Commit Graph

5480 Commits

Author SHA1 Message Date
Jorim Jaggi
6255421565 Merge "Exclude non-observable insets change" into rvc-dev am: 1f6b99d5fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11592755

Change-Id: I63a484ff464ee0d2ccf733a6512a901ade8fe3a0
2020-06-11 12:31:11 +00:00
Jorim Jaggi
1f6b99d5fa Merge "Exclude non-observable insets change" into rvc-dev 2020-06-11 12:15:49 +00:00
Antoan Angelov
fb12099ae4 Merge "Fix broken test" into rvc-dev am: 95e41f279d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11818179

Change-Id: Iccd0d2eddca9989f33630436da8254907ae88522
2020-06-11 11:03:54 +00:00
Antoan Angelov
95e41f279d Merge "Fix broken test" into rvc-dev 2020-06-11 10:56:55 +00:00
Matt Pietal
4ff6a77009 Merge "Sharesheet - Fix logic for a-z count" into rvc-dev am: c3e572fc74
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11820081

Change-Id: I5ca8993d647caf3f1affd3c0faf377d08993b1a6
2020-06-10 20:24:38 +00:00
arangelov
24156fa7b1 Fix broken test
Fixes: 158656507
Test: atest ChooserActivityTest#testWorkTab_selectingWorkTabWithPausedWorkProfile_directShareTargetsNotQueried
Change-Id: I875de96d4847575e6369724ca2c95b828befb5af
2020-06-10 19:21:32 +01:00
Matt Pietal
1245b38b60 Sharesheet - Fix logic for a-z count
Prior logic only counted the number of grouped items. This could
result in the a-z list not being shown even though there were
additional targets. For instance, if 1 group had 9 targets, a-z
would've been hidden even though only 4 targets were present in the
ranked app row, resulting in 5 targets being inaccessible.

Fixes: 158017940
Test: atest ChooserActivityTest#fourOptionsStackedIntoOneTarget
Change-Id: I58e262e40f3064ce8a091e44d6b00163c8f4e4f3
2020-06-10 11:16:55 -04:00
Jorim Jaggi
ed31259e01 Exclude non-observable insets change
When we notify insets changed, legacy behavior forces us to force
a new measure on the entire hierarchy. However, this can cause
jank in various scenarios.

Make sure that we don't report an insets change if non-observable
state changes.

Test: InsetsStateTest
Test: Swipe up to home while IME open
Bug: 157123435
Change-Id: I9c51066c6489888720b307240d03054cc18c4172
2020-06-10 14:24:03 +02:00
Adrian Roos
37afe34234 Merge "Insets: allow controlling insets as long as the window is covering in the relevant direction" into rvc-dev am: 5b12e07b9c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11632046

Change-Id: I7757a737ba43aa612b62e20dfcaddb4f3fcee9b4
2020-06-09 08:35:45 +00:00
Adrian Roos
5b12e07b9c Merge "Insets: allow controlling insets as long as the window is covering in the relevant direction" into rvc-dev 2020-06-09 08:24:57 +00:00
TreeHugger Robot
a50aa34d52 Merge "Insets: Fix stuck mPendingFrame" into rvc-dev am: 88e86e641a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11744899

Change-Id: Idc7381b5687e14ffed0668d9aeca516a91249afd
2020-06-08 15:42:01 +00:00
TreeHugger Robot
88e86e641a Merge "Insets: Fix stuck mPendingFrame" into rvc-dev 2020-06-08 15:41:26 +00:00
Adrian Roos
021f4a7140 Insets: Fix stuck mPendingFrame
Fixes an issue where the mPendingFrame was not properly cleared
if we re-applied the current frame.

Fixes: 156762386
Test: InsetsSourceConsumerTest
Change-Id: I9f0ebfafac44e1b4b87ea9d3408e64ba34bca2ec
2020-06-05 17:15:26 +02:00
Adrian Roos
8d04bcbc43 Insets: allow controlling insets as long as the window is covering in the relevant direction
Fixes: 154745615
Test: InsetsStateTest
Change-Id: I666a7eee82c15f0c5594c0acbd1a4f0186bcdc01
2020-06-05 14:46:14 +02:00
TreeHugger Robot
8159948707 Merge "Add test for tapping Work share tab when work profile is off" into rvc-dev am: 8f27cd8e55
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11734120

Change-Id: I1cc5c0029d53a7c1b7a6ef6e86d8c1b4d25ff4bf
2020-06-05 12:34:45 +00:00
TreeHugger Robot
8f27cd8e55 Merge "Add test for tapping Work share tab when work profile is off" into rvc-dev 2020-06-05 12:23:43 +00:00
Charles Chen
84bf8d437c Merge "Make InputMethodService be an UI context" into rvc-dev am: f3a7bc8e31
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11700778

Change-Id: I9950fd52ff633983e7b3325ba528fb35fc901968
2020-06-05 02:55:45 +00:00
Charles Chen
f3a7bc8e31 Merge "Make InputMethodService be an UI context" into rvc-dev 2020-06-05 02:40:17 +00:00
arangelov
f32a43868b Add test for tapping Work share tab when work profile is off
Also fix some work tab-related tests.

Fixes: 158166545
Fixes: 148156663
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: I5850bbc7d72d563f6e58dd19fafc56c0703ce669
2020-06-04 19:09:35 +01:00
Charles Chen
f1338b12a9 Make InputMethodService be an UI context
IMS handles configuration and display changes from the server side
and render views to inteact with users. Thus IMS should be marked as
an UI context

fixes: 157027563
Test: atest ContextTest
Change-Id: I0a2307c4764acf8b9fc0254a9ee2fc8a344bb7ef
2020-06-03 09:33:52 +08:00
TreeHugger Robot
b1fe173f1f Merge "Fix AugmentedAutofillService onFillRequest() wrong focused AutofillId for WebView" into rvc-dev am: cc4f13e0ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11700779

Change-Id: If21669fc2a76cfee6bbf7c875ad23a913328801e
2020-06-02 21:11:06 +00:00
Joanne Chung
fbc89efee3 Fix AugmentedAutofillService onFillRequest() wrong focused AutofillId for WebView
When AutofillManagerService try to trigger AugmentedAutofill, it uses
AutofillId.withoutSession() to get the AutollId without session. It
will return invalid "parentId:NO_ID" if the virtual AutofillId is
created with FLAG_IS_VIRTUAL_INT. The virtual AutofillId flag should
be FLAG_IS_VIRTUAL_INT or FLAG_IS_VIRTUAL_LONG, we should get
mVirtualIntId for FLAG_IS_VIRTUAL_INT or mVirtualLongId for
FLAG_IS_VIRTUAL_LONG.

Bug: 156408900
Test: atest android.autofillservice.cts.augmented
Test: atest android.view.autofill.AutofillIdTest#\
testVirtual_Long_withoutSession
Test: atest android.view.autofill.AutofillIdTest#\
testVirtual_Int_withoutSession
Test: Manual. Write a simple cts test for webview and check the
focused AutofillId is correct while switching between the field.

Change-Id: I7ebb4d7cfb6d6f383724b798dae69269ae3a27be
2020-06-03 01:06:24 +08:00
Charles Chen
c1ee356ca6 Merge "Fix get display from display context derived context not working" into rvc-dev am: 13e3568567
Change-Id: Ibdb1cea64d43db5b54b5905ee544b6e374fe60ff
2020-05-30 06:51:42 +00:00
Charles Chen
13e3568567 Merge "Fix get display from display context derived context not working" into rvc-dev 2020-05-30 06:35:35 +00:00
Charles Chen
e22c4cb3c6 Fix get display from display context derived context not working
In ContextImpl, we checked the flag "mIsAssociatedWithDisplay" to
identify if a context can access a display or not. The flag wasn't
passed from outer context, and it leads to an issue that context
which created from #createConfigurationContext from display context
failed to obtain display instance.

This CL passes mIsAssociatedWithDisplay from outer context and
also add test to verify the behavior.

fixes: 157719118
Test: atest ContextTest ContextAccessTest

Change-Id: Ibeb2a08c75f90304e12dcf99293c84409c5eea34
2020-05-30 12:46:59 +08:00
Narayan Kamath
cc9f819283 Merge "Revert ResolverActivity changes associated with browseables." into rvc-dev am: 101fcc5746
Change-Id: I3cd05030567145ae5528db56a3b4d73faa4fb814
2020-05-28 11:30:32 +00:00
Narayan Kamath
101fcc5746 Merge "Revert ResolverActivity changes associated with browseables." into rvc-dev 2020-05-28 10:35:09 +00:00
Heemin Seog
164713ecfe Merge "Add climate bar insets" into rvc-dev am: 58169786a6
Change-Id: Iea5d4299f49aa5d886c5482a5916d80ef8596eba
2020-05-27 15:49:24 +00:00
Heemin Seog
58169786a6 Merge "Add climate bar insets" into rvc-dev 2020-05-27 15:38:32 +00:00
Narayan Kamath
754186806d Revert ResolverActivity changes associated with browseables.
Reverts changes 69df963, 0c7c5d59, 6cbef19 and others. These changes
don't revert cleanly because of several refactorings layered on top
of the original changes.

The main objective of these change is to get rid of mUseLayoutForBrowseable
and associated codepaths as we treat choosing between browseables the
same as other choices.

Bug: 157460946
Test: manual
Test: atest ResolverActivityTest
Test: atest ChooserActivityTest

Change-Id: Ibe9f2289289f7f5da3986e6892a2ee4ff65765a0
2020-05-27 12:48:15 +01:00
Heemin Seog
d79e4f49d2 Add climate bar insets
This can be used to support a 3rd kind of system bar to inset the
applicaiton space.

Bug: 152763889
Test: manual
Change-Id: I3ba75886e94a9fe80a0d1a920749d152dda64031
2020-05-26 14:26:25 -07:00
Michael Groover
3cdc8fbdb2 Merge "Address edge cases for signing certificate lineages in sharedUids" into rvc-dev am: 2046776127
Change-Id: If65b24c62ca4ae868d15bbf30aff5f5bbc4b235f
2020-05-26 16:11:10 +00:00
Michael Groover
2046776127 Merge "Address edge cases for signing certificate lineages in sharedUids" into rvc-dev 2020-05-26 16:07:57 +00:00
Michael Groover
f1744af7ed Address edge cases for signing certificate lineages in sharedUids
Currently when a package is installed / updated in a sharedUid the
signatures for the sharedUid are not updated unless the new package
adds a new signer to the lineage; in this case the new lineage is
assigned to the sharedUid without consideration for the existing
lineage. This leads to the following problems:

1. If the current sharedUid lineage is A -> B and the new package has
lineage B -> C then this is used for the sharedUid and A is lost from
the lineage.
2. If the new lineage revokes one or more capabilities from a previous
signer in the lineage these updated capabilities are ignored unless the
lineage added a new signer as well.
3. If the new lineage revokes the sharedUid capability from a previous
signing key in the lineage and another app is installed as part of the
sharedUid and signed with that key the new app's installation is allowed
to proceed.
4. If only a single app is installed as part of a sharedUid, and that
app is updated with a rotated key and a lineage that revokes the
previous signing key's sharedUid capability the update is blocked.
5. If an app is installed as part of the sharedUid and has a diverged
signer in the lineage (ie sharedUid lineage is Y -> A -> B and new app
lineage is Z -> A -> B -> C) the installation is allowed and Y is lost
from the lineage.

Problems 1 and 2 are addressed with the new SigningDetails
mergeLineageWith method that merges common signers between two lineages
and also updates their capabilities to the most restrictive between
the two lineages (capabilities are anded together). Problems 3 is
addressed by checking the signatures of each of the packages in the
sharedUid for any signed with an ancestor for which the sharedUid
capability may have been revoked. Problem 4 is addressed by checking
if the package being updated is the only one in the sharedUid; if so
the update to the new lineage is allowed to proceed. Problem 5 is
addressed by verifying the new app's lineage is the same, a subset, or
a superset of the other.

Bug: 152046935
Test: atest PkgInstallSignatureVerificationTest
Test: atest SigningDetailsTest
Test: atest PackageManagerTests
Test: atest PackageManagerTest
Change-Id: I420c309f522bb47b65ca40ee848024c85cd5804d
2020-05-22 23:50:52 +00:00
Collin Fijalkovich
aa1c667e4f Merge changes from topic "dump-cacheinfo" into rvc-dev am: acb2bba925
Change-Id: Iec363450741936bc3d8ec0f99c597fb5373b5b9c
2020-05-18 23:56:28 +00:00
Darryl Johnson
f7f71df05c Merge "Make sure config change items are executed in the order dispatched." into rvc-dev am: 0d8822c94a
Change-Id: I2317fc9f603255b092f56253f7aaa3e277b69b14
2020-05-18 23:39:03 +00:00
Collin Fijalkovich
acb2bba925 Merge changes from topic "dump-cacheinfo" into rvc-dev
* changes:
  Add cache debugging information to bugreports.
  Maintain global list of caches; purge on low memory
2020-05-18 20:52:43 +00:00
Darryl Johnson
0d8822c94a Merge "Make sure config change items are executed in the order dispatched." into rvc-dev 2020-05-18 17:26:14 +00:00
TreeHugger Robot
37334ce7d4 Merge "De-duplicate with callerTargets(added by using Intent.EXTRA_INITIAL_INTENTS) when adding DisplayResolveInfo." into rvc-dev am: e79c1056b2
Change-Id: I65562306c089dfedc3d06ae147f4f619fdd69ab5
2020-05-15 23:26:16 +00:00
TreeHugger Robot
e79c1056b2 Merge "De-duplicate with callerTargets(added by using Intent.EXTRA_INITIAL_INTENTS) when adding DisplayResolveInfo." into rvc-dev 2020-05-15 23:10:41 +00:00
Joshua Duong
c28d70db77 Merge "Don't attach PendingIntent if settings app is hidden." into rvc-dev am: 8ba3431761
Change-Id: Ib618a2537340cd1e9683387ff6377c282b5ace7a
2020-05-15 21:15:21 +00:00
Joshua Duong
8ba3431761 Merge "Don't attach PendingIntent if settings app is hidden." into rvc-dev 2020-05-15 21:14:39 +00:00
TreeHugger Robot
b06daeb545 Merge "Sharesheet - Fix app stacking" into rvc-dev am: 8714e7d195
Change-Id: I459d1a499ed6301f727623addfc41eb6e9dc6d81
2020-05-15 20:15:23 +00:00
TreeHugger Robot
8714e7d195 Merge "Sharesheet - Fix app stacking" into rvc-dev 2020-05-15 20:13:47 +00:00
Joshua Duong
b381dfaf18 Don't attach PendingIntent if settings app is hidden.
The settings app may not be available. In that case, just show the adb
notification without a PendingIntent.

Bug: 156453114

Test: atest AdbNotificationsTest
Test: With USB debugging enabled, install TestDPC, and use it to hide settings app.
Unplug and replug USB. USB debugging notification shows up and clicking
it does nothing.
Change-Id: Ie29d2c425c05bce9371600d76e4eb2eaba692fd7

Change-Id: Ie5f746cbc7b8a32fc280177bf281a9e973c8df12
2020-05-15 18:58:33 +00:00
Song Hu
276e384e4c De-duplicate with callerTargets(added by using Intent.EXTRA_INITIAL_INTENTS) when adding DisplayResolveInfo.
Bug: 154611479
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Change-Id: I812c8275fc6f12ad52f56419eedd0c580530704a
2020-05-15 10:01:52 -07:00
Darryl L Johnson
2b9720c694 Make sure config change items are executed in the order dispatched.
In the previous implementation a batch of process/activity config
changes would effectively be executed out of order. When the server
would dispatch changes in config in quick succession the config change
items would update the pending configs first through the preexecute()
calls and then apply the activity config before the process config
is applied even though the process config was dispatched before the activity
config change item. See b/148639784 for more detail.

Fixes: 148639784

Test: ActivityThreadTest#testHandleActivityConfigurationChanged_EnsureUpdatesProcessedInOrder
Test: ActivityThreadTest#testHandleActivityConfigurationChanged_SkipWhenNewerConfigurationPending

Change-Id: I3c926076ac8dba73eb0471c7bc91313df519cf92
2020-05-15 09:40:30 -07:00
Tiger Huang
4f6a9e78cc Merge "Do not dispatch system UI visibility during traversal" into rvc-dev am: 8fd8a538b8
Change-Id: Ief24436d5c61577546d2b99341945d4bdd39ceb9
2020-05-14 17:27:13 +00:00
Tiger Huang
8fd8a538b8 Merge "Do not dispatch system UI visibility during traversal" into rvc-dev 2020-05-14 17:25:56 +00:00
Matt Pietal
c9544a7e92 Sharesheet - Fix app stacking
When there was greater than 2 candidates for app stacking, the prior
targets would get dropped.

Bug: 156220800
Test: atest ChooserActivityTest
Change-Id: Ia8494bb81e95c5415d080148a0c4f98bd243c142
2020-05-13 21:19:40 -04:00