Commit Graph

4321 Commits

Author SHA1 Message Date
TreeHugger Robot
3eb14956fd Merge "Adding executor with repeat functionality" into rvc-dev 2020-04-21 22:07:54 +00:00
Robert Snoeberger
05e51c1d5b Adding executor with repeat functionality
The use case I'm looking at is for the seek bar in media controls. While
playing, the elapsed time needs to be continuously checked with a fixed
delay (ie. polling the elapsed time).

Bug: 154352658
Test: Added RepeatableExecutorTest
Change-Id: I142545e9a405c38fda6002a85fa3c47343f2fce4
2020-04-21 16:13:41 -04:00
Winson Chung
648c4f96be Merge "Don't update nav bar tint when in gesture nav" into rvc-dev 2020-04-21 19:36:57 +00:00
TreeHugger Robot
9bc5f9efc2 Merge "Keeing the device in gesture nav while user setup is pending" into rvc-dev 2020-04-21 18:25:41 +00:00
Miranda Kephart
44cc1e274b Merge "Add screenshots logging" into rvc-dev 2020-04-21 16:58:54 +00:00
Fabian Kozynski
cc14ed08f5 Merge "Add content description for ScreenRecordTile" into rvc-dev 2020-04-21 14:12:23 +00:00
Fabian Kozynski
54ba50a500 Merge "Remove dependency on connectivity sticky broadcasts" into rvc-dev 2020-04-21 13:13:10 +00:00
Evan Laird
aeb6fd2c0a Merge "DO NOT MERGE: More tests for CurrentUserContextTracker" into rvc-dev 2020-04-20 23:12:42 +00:00
Evan Laird
03c444586e DO NOT MERGE: More tests for CurrentUserContextTracker
Reworks some of the CurrentUserContextTracker and test its
functionality, and consequently fixes some NotificationConversationInfo
tests

Test: atest CurrentUserContextTrackerTest NotificationConversationInfoTest
Bug: 151843296
Fixes: 154332812
Change-Id: I0e3d4b1c64cba2cab581abca4ce9377a7c4676de
2020-04-20 17:08:29 -04:00
TreeHugger Robot
4601299db7 Merge "Fix issue where keyboard would not be dismissed" into rvc-dev 2020-04-20 19:22:54 +00:00
Fabian Kozynski
0daa9708d0 Add content description for ScreenRecordTile
Adds description with name and state for QQS.

Test: manual
Test: atest
Fixes: 153518955
Change-Id: Idc599d891c769791ee4ed2aec9f30db758846897
2020-04-20 15:03:50 -04:00
Lucas Dupin
8d54074d26 Fix issue where keyboard would not be dismissed
When swiping down from the top of the screen to dismiss the bouncer,
the input field should hide the keyboard, otherwise it would get stuck
on the lock screen.

Test: manual
Test: atest KeyguardHostViewTest
Test: atest KeyguardBouncerTest
Fixes: 154245193
Fixes: 152882608
Change-Id: I99ee2cff85df1ab0b6544e9b5b472e105fca7b72
2020-04-20 10:46:46 -07:00
Winson Chung
68e33e033c Don't update nav bar tint when in gesture nav
- The region sampling listener is already constantly updating the tint
  based on the actual content beneath the bar

Change-Id: Ia521bd3c5c8507fd97e22dd12e8102dfc2368320
Bug: 154002408
Test: Open up the settings "opening links" activity and ensure it
      the tint doesn't get clobbered
2020-04-20 09:57:10 -07:00
TreeHugger Robot
b31a5f43d0 Merge "Add history onboarding" into rvc-dev 2020-04-17 20:48:26 +00:00
TreeHugger Robot
ed1adb192f Merge changes I60bc5899,I97696070 into rvc-dev
* changes:
  Bind children dynamically in new pipeline (2/2)
  Bind children dynamically in new pipeline (1/2)
2020-04-17 19:45:42 +00:00
Julia Reynolds
da7c24580e Add history onboarding
Test: atest
Fixes: 153150072
Change-Id: I0d90eaff168cc38ca0a1123bb65ed941c9e283f8
2020-04-17 15:10:10 -04:00
Sunny Goyal
38412951a9 Keeing the device in gesture nav while user setup is pending
> Sending different insets to the app during user setup
> Keeping the back butotn visible and not handling edge swipe
> Fixing bug where EdgeBackGestureHandler is not updated with correct
  edge scale when user switches

Bug: 150004073
Bug: 148492421
Test: Manual
Change-Id: I112465a634de2c85d613c071b66f8c099c2c78e3
2020-04-17 11:35:41 -07:00
Robert Snoeberger
59f73711b5 Merge "NotificationMediaManager is bad signal for resumption" into rvc-dev 2020-04-17 18:22:02 +00:00
Miranda Kephart
7b2c313da7 Add screenshots logging
Bug: 150710005
Test: manual
Change-Id: I54a37eb0a62234c6c53fc0f3c80e18e9ee269f12
2020-04-17 13:28:23 -04:00
Heemin Seog
a38de34373 Merge "Remove filter for automotive calsses in SysUI Tests" into rvc-dev 2020-04-17 15:18:08 +00:00
Heemin Seog
fce7edf87f Remove filter for automotive calsses in SysUI Tests
Bug: 112863499
Test: atest SystemUITests on sdk_gphone_x86
Change-Id: I4c07abb0a1306c704c7fdd62ecfc4efb7259ce73
2020-04-16 23:51:48 -07:00
TreeHugger Robot
ef84b9a1c5 Merge "Make alignment indication red again" into rvc-dev 2020-04-17 01:55:50 +00:00
TreeHugger Robot
b99ef1b146 Merge "Combine AlertingManager and HeadsUpBindController" into rvc-dev 2020-04-16 21:14:13 +00:00
Lucas Dupin
5567b8938b Make alignment indication red again
Test: atest KeyguardIndicationControllerTest
Fixes: 154258966
Change-Id: Ia94a31046cb64c1d93c70b53a9367f80ea689594
2020-04-16 14:05:35 -07:00
Fabian Kozynski
b00c70bc80 Remove dependency on connectivity sticky broadcasts
This removes the dependency on the following Sticky broadcasts:
* ConnectivityManager.CONNECTIVITY_ACTION
* ConnectivityManager.INET_CONDITION_ACTION
* TelephonyIntents.ACTION_SIM_STATE_CHANGED
* TelephonyIntents.ACTION_DEFAULT_VOICE_SUBSCRIPTION_CHANGED
* WifiManager.NETWORK_STATE_CHANGED_ACTION
* WifiManager.WIFI_STATE_CHANGED_ACTION

In general, we fetch the state to populate data.

Also, fixed some bubbles tests that were creating KeyguardUpdateMonitor
down the line.

Test: atest SystemUITests
Bug: 151641451

Change-Id: Ib4b1fba6a09766565cd21f96453bd2d056f74f70
2020-04-16 16:45:58 -04:00
Kevin Han
46f1013eb9 Combine AlertingManager and HeadsUpBindController
Previously, it was difficult to tell when a notification was inflated
before trying to show the heads up, and we got around it with a (now
flawed) heuristic based off if a notification was just inflated and
it has a heads up view.

This issue stems from having two control classes that are not really
communicating with each other. By combining these classes into one
heads up controller, the logic becomes more readable and we can directly
put a callback to show the HUN when the HUN content is inflated.

Bug: 149028421
Test: HUN smoke test
Change-Id: Ibb75597cfe26ccaf7e4d5247dc69d69bdf421ee6
2020-04-16 12:48:32 -07:00
Robert Snoeberger
445d441b44 NotificationMediaManager is bad signal for resumption
Entering resumption on STATE_NONE from NotificationMediaManager
causes flicker because it sends STATE_NONE to often. Instead, we can
listen for PlaybackState changes from the MediaController directly.

For cast, we need to enter the resumption state on STATE_CONNECTING,
because that is the resulting state after ending a cast session.

Fixes: 153937833
Test: manual - play music and toggle play / pause. Look for flicker
caused by action buttons rapidly switching in and out of the
resumption state.
Test: manual - cast from YT to TV. End cast session. Verify that player
is in the resumption state.

Change-Id: Ie7f577d1b06719a1ce2ae5927b2ee20745076303
2020-04-16 13:44:49 -04:00
TreeHugger Robot
c979a6eb22 Merge "DO NOT MERGE: Show an onboarding screen for priority conversations" into rvc-dev 2020-04-16 17:07:30 +00:00
TreeHugger Robot
31b94bfc1e Merge "Remove unnecessary transition logic from ImageWallpaper" into rvc-dev 2020-04-16 16:30:14 +00:00
Evan Laird
31ca547400 DO NOT MERGE: Show an onboarding screen for priority conversations
Test: atest SystemUITests
Bug: 151843296
Change-Id: I5280cff71591f8551016b6ba00d3a579507367cb
2020-04-16 11:59:43 -04:00
Kevin Han
43077f971b Bind children dynamically in new pipeline (2/2)
Support setting a logical child count on the notification group view.
Since we are filtering out the notifications and their views entirely in
the new pipeline, we can't just use the number of children views on the
notification group view to determine the "+X" value in the group view UX
for how many children are in the unexanded group. So instead we set this
value directly.

Bug: 145748993
Test: add notification group and see overflow values are accurate in
both old and new pipeline

Change-Id: I60bc58994a77bc3801f062dedc41faaee1d48494
2020-04-15 16:58:35 -07:00
Kevin Han
acaa911e6b Bind children dynamically in new pipeline (1/2)
Don't bother inflating group children that won't be visible and filter
it from the notification list we give to
NotificationViewHierarchyManager.

Bug: 145748993
Test: atest SystemUITests
Change-Id: I97696070aea93f5cf3c188a391db651ba802d080
2020-04-15 16:57:51 -07:00
TreeHugger Robot
c52300ea49 Merge "Show disabled seek bar when session is destroyed" into rvc-dev 2020-04-15 23:28:52 +00:00
Julia Reynolds
8d25709048 Update conversation inline controls text
- Support 'all conversations bubble'
- Only the selected button text should be colorful

Test: atest
Bug: 153471239
Fixes: 153885391
Change-Id: Ideb7cf6c853095cc6c55fa1b7f651aa7a0259f4e
2020-04-15 21:25:28 +00:00
Robert Snoeberger
fb8742d72a Show disabled seek bar when session is destroyed
Fixes: 153579050
Test: manual - play music, dismiss app, verify that seek bar is
disabled.

Change-Id: I2ac44eb18d57fb4ac8a67aebe042bdb8b1b7f9e9
2020-04-15 16:45:30 -04:00
Ahan Wu
4a29779808 Remove unnecessary transition logic from ImageWallpaper
Since we have blur and zoom effect, the desaturation transition of
ImageWallpaper is no longer necessary, so we remove related logic.

Bug: 153511553
Test: Manually test
Test: atest com.android.systemui
Change-Id: Id88fd5931f9168b7c4821dfdbb84165523c7dfa9
2020-04-16 03:32:00 +08:00
Joshua Tsuji
a3dfef42e5 Don't pull magnetized objects into the target unless they're dragged.
Test: manual
Bug: 153936889
Change-Id: I045cd8b937a706e4df25ad64ae12e6d292b9ff06
2020-04-15 14:55:02 -04:00
Aran Ink
0b5450ec37 Merge "Add overflow menu to GlobalActionsDialog." into rvc-dev 2020-04-14 16:12:30 +00:00
Josh Tsuji
a9dfeb264d Merge "Ignore flaky test." into rvc-dev 2020-04-14 14:06:03 +00:00
Julia Reynolds
c026d54cd7 Merge changes from topic "bubble_settings_wooo" into rvc-dev
* changes:
  Changes to enable bubble settings CTS
  Notification Bubble Button
  Make bubble settings a pref with an int rather than a bool
2020-04-14 11:22:14 +00:00
Aran Ink
cf03827a81 Add overflow menu to GlobalActionsDialog.
Test: atest GlobalActionsDialogTest
Test: Power menu items beyond the 3rd will appear in a dropdown menu instead of being truncated when controls are available. If controls are disabled (ex. 'adb shell settings put secure systemui.controls_available 0'), all items should still display in older versions of GlobalActions. Items in power overflow menu are both short- and long-pressable.

Fixes: 152625023

Change-Id: Icdbf8eb7e79a61d490d484f207eeedc47c4882c5
2020-04-13 17:14:02 -04:00
TreeHugger Robot
a13956797e Merge changes I001413f1,Id59a28c0 into rvc-dev
* changes:
  Remove setInflationCallback
  Clean up NotificationRowBinderImpl
2020-04-13 20:29:39 +00:00
Heemin Seog
14a64250e8 Merge "Remove phone specific shade controller from KeyguardViewMediator" into rvc-dev 2020-04-13 18:09:29 +00:00
Heemin Seog
a431d8ac9d Remove phone specific shade controller from KeyguardViewMediator
The relevant logic has been moved to KeyguardViewController instead so
that phone and car can define this separately.

Bug: 140423092
Bug: 147455109
Test: atest SystemUITests, manual for automotive
Change-Id: I9473c2ec6993808cd41c0c1021250dbf550f60c2
2020-04-13 09:36:22 -07:00
Joshua Tsuji
21c722b0f8 Ignore flaky test.
Test: hopefully passing more after this.
Fixes: 149193666
Change-Id: I53df87b98a4ffcc85c89805bb607c0ef15fe2d33
2020-04-13 11:20:20 -04:00
Fabian Kozynski
2dc9632eb5 Merge "Mock views in Keyguard view tests" into rvc-dev 2020-04-13 14:53:30 +00:00
Kevin Han
bd142939eb Remove setInflationCallback
The current use cases for NotificationRowBinderImpl and NotifInflater's
API don't really need a persistent inflation callback stored as opposed
to a one-shot callback. By explicitly putting the callback in the
inflate methods, it also makes it more clear which calls inflate and
expect a callback to be called.

Bug: 145749521
Test: atest SystemUITests
Test: smoke test (add, update, remove notification)
Change-Id: I001413f17b7472ea2ef637be21d9d454ee17015e
2020-04-10 20:34:15 -07:00
Youngjun Kwak
0abf11e202 Merge "Implement AAOS-specific KeyguardViewController and decouple keyguard from statusbar." into rvc-dev 2020-04-11 00:42:04 +00:00
Kevin Han
3742322d04 Clean up NotificationRowBinderImpl
Clean up a few things in NotificationRowBinderImpl

*Remove a bunch of dead parameters and methodsd
*Split logic into three main helper methods
   1) bindRow - called once when row is made
   2) updateRow - called to update row view state whenever the
   notification is updated
   3) inflateContentViews - called to initiate row content inflation
   whenever notification is updated
*Try to move other logic to appropriate places
  -Mainly move targetSdk resolution to be right after setting the sbn
  instead of after the row is inflated. This also makes icons neater to
  manage since we can immediately set the tag

Bug: 145749521
Test: atest SystemUITests
Change-Id: Id59a28c0fbbe1df5ffc4ec8eef58d760b8c6df05
2020-04-10 17:25:56 -07:00
TreeHugger Robot
c3721ac874 Merge "Deprecates the animatingBounds from WM to SysUI" into rvc-dev 2020-04-10 23:13:52 +00:00