Commit Graph

1755 Commits

Author SHA1 Message Date
Treehugger Robot
7815cd1c99 Merge "Enable DISALLOW_DUPLICATE_FIELD_IN_SKELETON since U" am: 643e586072 am: de4ea8f38b am: e47e8ec3f6 am: 15390ccf1d am: 913f632490
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2216581

Change-Id: I26336026ab0c7c92f4cbfe1c937be04fcf19d380
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-17 12:37:50 +00:00
Victor Chang
0d34d850fd Enable DISALLOW_DUPLICATE_FIELD_IN_SKELETON since U
It was supposed to be enabled in S, but we missed it due to
https://r.android.com/1490737

Test: android.text.format.DateFormatTest
Change-Id: I0f6495bf2e4434396606743da1e32a39a54a0b19
2022-09-13 15:49:09 +01:00
Seigo Nonaka
66260c6045 Implement Ctrl+B/I/U shorcut
These shortcut works as follows:

- If the selected region is empty, do nothing.
- If the selected region has at least one character that is not styled,
  e.g. bold, apply bold style.
- If the selected region is fully styled, e.g. bold, remove bold style
  from the region.

The default TextView/EditText supports styled editing, but it is used
commonly as plain text fields, e.g. email address in the form, etc.
So, not to style the text in such places, disable styled shortcut by
 default and let developers to enable it when necessary.

Bug: 240628246
Test: TextViewStyleShortcutTest
Change-Id: Id0f1cd85eb198553a852c5c2b628f5d03a2741e1
2022-09-08 13:41:42 +09:00
Justin Ghan
28b4da5b75 Merge changes from topics "insert-impl", "select-delete-impl"
* changes:
  TextView implementation of insert gesture
  TextView implementation of select and delete gestures
2022-08-29 20:11:17 +00:00
Justin Ghan
8b5d4bd91e TextView implementation of select and delete gestures
Bug: 240435922
Test: atest android.text.LayoutGetRangeForRectTest
Test: atest android.widget.cts.TextViewHandwritingGestureTest
Change-Id: I6ceaa4555b82f1c2650d2db3bf39674641d53b8f
2022-08-26 23:18:00 -07:00
Haoyu Zhang
852de827fc Optimize TextLine#measureAllOffset performance
Bug: 238954768
Bug: 235353864
Test: atest StaticLayoutGetOffsetForHorizontalPerfTest
Change-Id: Ic3a1a8fc5ef5d160401d390b920f3f2a409528f0
2022-08-26 00:23:07 -07:00
TreeHugger Robot
d9131a60b5 Merge "Implement paragraph cursor movement and selection extension" 2022-08-03 23:41:22 +00:00
Haoyu Zhang
e7422024fe Introduce Layout#fillCharacterBounds
Introduce Layout#fillCharacterBounds to compute character bounds faster.
This change makes TextView#populateCharacter 5 times faster.

After:
        populateCharacterBounds[mTextLength (100))]_min (ns): 52361
        populateCharacterBounds[mTextLength (300))]_min (ns): 148941
        populateCharacterBounds[mTextLength (1,000))]_min (ns): 463237
        populateCharacterBounds[mTextLength (3,000))]_min (ns): 1388081
        populateCharacterBounds[mTextLength (10,000))]_min (ns): 1165867

Before:
        populateCharacterBounds[mTextLength (100))]_min (ns): 204065
        populateCharacterBounds[mTextLength (300))]_min (ns): 653159
        populateCharacterBounds[mTextLength (1,000))]_min (ns): 2184327
        populateCharacterBounds[mTextLength (3,000))]_min (ns): 6770318
        populateCharacterBounds[mTextLength (10,000))]_min (ns): 22777530

Bug: 233922052
Test: atest android.text.TextViewPopulateCharacterBoundsTest
Test: atest android.text.TextViewCursorAnchorInfoPerfTest
Change-Id: I68a47cf3099b89e0a10604b7706fa7a3dea66d32
2022-08-02 09:39:12 -07:00
Seigo Nonaka
c7053c6587 Implement paragraph cursor movement and selection extension
Bug: 240624037
Test: atest BaseMovementMethodTest SelectionParagraphTest
Change-Id: I75161fc88975736fe26395959bafba661c590f66
2022-08-02 17:22:17 +09:00
Haoyu Zhang
c8abba4907 Introduce TextLine#measureAllbounds
This new method computes the horizontal character bounds by making
use of the character advances returned from native layer. It'll be
used in TextView to populate character bounds, and it's much efficent
compared to calling getPrimaryHorizontal for each character.

Bug: 233922052
Test: atest android.text.TextLineTest
Change-Id: Icdd53e61e2d1513b2231affb19bb00ea5d938d48
2022-07-08 12:50:32 -07:00
TreeHugger Robot
106145fc27 Merge "Add descriptive toString method and missing accessors" 2022-07-01 01:27:28 +00:00
Victor Chang
1accb533b3 Merge "Re-land "Switch file size formatters to use ICU's MeasureFormat"" am: b284c36224 am: 6d5f7f22c4 am: fe5155786f am: 6ea4660db1 am: d2a1e4bd0a
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2100171

Change-Id: I06a6648e1d6574199bbf8ccf69d62b0bbbee2418
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 11:43:19 +00:00
Victor Chang
fe5155786f Merge "Re-land "Switch file size formatters to use ICU's MeasureFormat"" am: b284c36224 am: 6d5f7f22c4
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2100171

Change-Id: I1dacfb85cbc5886c8fd8f917085a2ebd943170cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-05-24 11:20:54 +00:00
Seigo Nonaka
5f2c67b89c Remove hyphens at the ellipsized start/end position
Bug: 232438922
Test: atest CtsTextTestCases
Change-Id: I937732945a99d4b390d9d8986338b13d0c843353
2022-05-23 12:03:46 -07:00
Seigo Nonaka
0561027f9a Add descriptive toString method and missing accessors
Bug: N/A
Test: compile
Change-Id: I15411d8bf67dba9745f4f2e02114099612b9a844
2022-05-19 01:29:16 +00:00
Roozbeh Pournader
988cb5a32d Re-land "Switch file size formatters to use ICU's MeasureFormat"
Re-land http://ag/2443141 because the over-translation issue should be
resolved now.

Use ICU's MeasureFormat to the degree possible for formatting file
sizes.

Bug: 36994779
Bug: 71580745
Bug: 217592956
Test: atest FrameworksCoreTests:android.text
Test: atest CtsTextTestCases
Change-Id: If3416ec38cf18c0441576643bfab850148e18c8e
2022-05-17 17:05:48 +01:00
Ling Ma
e2496f8601 Merge changes from topic "truncate operator name" am: ffa0f982b6 am: 9cf73e369d am: eb897b1d85 am: 8827b92855 am: 8ec131c2a2
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2004810

Change-Id: Iba13c4d338b95ba2da57f60b79acd077979185ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-01 23:27:38 +00:00
Ling Ma
8827b92855 Merge changes from topic "truncate operator name" am: ffa0f982b6 am: 9cf73e369d am: eb897b1d85
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2004810

Change-Id: Ie1a67a1a9fae4dbbc321755f7ec9bde8bb84613f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-01 22:54:46 +00:00
Ling Ma
58d9786a64 Add truncateStringForUtf8Storage()
Test: manual
Bug: 210502588
Change-Id: I5d4ded0cb30151bc567cfedcdb1bbbdb9abdca9b
2022-03-31 18:57:05 -07:00
TreeHugger Robot
90b2bfd4bc Merge "Fix wrong Nullability of BoringLayout new API introduced in API33" into tm-dev 2022-03-22 17:00:27 +00:00
TreeHugger Robot
193ec53542 Merge "Set useFallbackLineSPacing into member value" into tm-dev am: ee06c56645
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17288890

Change-Id: I14aafca4d40f7035c14b015b55befcdc96b5ec6d
2022-03-22 06:04:26 +00:00
Allen Su
508818fc58 Merge "Text Wrapping automation" 2022-03-22 05:44:23 +00:00
allenwtsu
f70429088a Text Wrapping automation
Bug: 220836284
Test: atest StaticLayoutTest
Change-Id: I2aead872b0b472b3c625e075348e46da768ff3be
2022-03-22 11:16:57 +08:00
Seigo Nonaka
5cc42bcb59 Fix wrong Nullability of BoringLayout new API introduced in API33
Bug: 225695033
Test: N/A
Change-Id: I93d3fc3041e862ad5f6064ac517e9cdbd23f1599
(cherry picked from commit c93d6b49b5)
2022-03-21 23:28:01 +00:00
Seigo Nonaka
c93d6b49b5 Fix wrong Nullability of BoringLayout new API introduced in API33
Bug: 225695033
Test: N/A
Change-Id: I93d3fc3041e862ad5f6064ac517e9cdbd23f1599
2022-03-20 23:01:51 -07:00
Seigo Nonaka
418393399c Set useFallbackLineSPacing into member value
Bug: 225727260
Test: atest BoringLayoutTest
Change-Id: Ifc7b2e3920d770a6b59cc4ea191560db057d2363
2022-03-21 05:50:31 +00:00
josephpv
12781c1548 Fix typo in TextUtils and remove unused import
Bug: 222479601
Test: Manual

Change-Id: I7790d1e9b782743141bf1714a51763ff47ca8565
2022-03-14 20:08:47 +00:00
James.cf Lin
396c789426 Update the text wrapping API.
1) Update the LineBreakConfig class to be immutable.
2) Do not return null in the PrecomputedText.Params#getLineBreaiConfig API

Bug: 216638444
Test: atest TextViewTest; atest MeasuredTextTest; atest PrecomputedTextTest; atest TextViewPrecomputedTextTest; atest StaticLayoutLineBreakingVariantsTest
Merged-In: I93bcb6ebc35344e34e9bb8a24df375aa7b3a8d81
Merged-In: I07766137ff6639c7d4acaad07dbcf11a2841cdb0
Change-Id: I07766137ff6639c7d4acaad07dbcf11a2841cdb0
2022-03-10 09:58:40 +00:00
James.cf Lin
e5aad7a752 Fix performance regression create_PrecomputedText_NoStyled_Greedy_NoHyphenation_DirDifferent_min
The LineBreakConfig instance in the StaticLayout is null as default.

Because the LineBreakConfig in StaticLayout was not initialized, the null instance was brought to PrecomputedText and caused the function PrecomputedText.Builder#checkResultUsable to return UNUSABLE.

Bug: b/220992481
Test: atest StaticLayoutTest; atest StaticLayoutPerfTest
Change-Id: I93bcb6ebc35344e34e9bb8a24df375aa7b3a8d81
2022-03-09 03:25:06 +08:00
James Lin
2d26f03f3a Merge "Update the text wrapping API." 2022-02-19 01:31:52 +00:00
James.cf Lin
4ae65dff9f Update the text wrapping API.
1) Update the LineBreakConfig class to be immutable.
2) Do not return null in the PrecomputedText.Params#getLineBreaiConfig API

Bug: 216638444
Test: atest TextViewTest; atest MeasuredTextTest; atest PrecomputedTextTest; atest TextViewPrecomputedTextTest; atest StaticLayoutLineBreakingVariantsTest
Change-Id: I07766137ff6639c7d4acaad07dbcf11a2841cdb0
2022-02-18 11:45:15 +08:00
Seigo Nonaka
9babbc0c59 Merge "Improve BoringLayout#isBoring for PrecomputedText" 2022-02-16 01:20:03 +00:00
Xin Li
5ad6db7742 Merge sc-v2-dev-plus-aosp-without-vendor@8084891
Bug: 214455710
Merged-In: I8cfa435bb6233818adb9cc99dadeeb06a03443d5
Change-Id: Ib93992d88fd1704179009a3872798b9e7b83a6d1
2022-02-11 07:25:43 +00:00
TreeHugger Robot
1a2dee2c84 Merge "Recycle obtained TypedArrays" 2022-02-10 22:11:25 +00:00
Nikolas Havrikov
4407d1f383 Recycle obtained TypedArrays
Bug: 218835043
Test: make
Change-Id: I27c679c164920dc4b1096a316432f64501a85ae5
2022-02-10 15:04:20 +01:00
Alan Viverette
406e0f6553 Migrate frameworks/base javadocs references to androidx
Does not remove Support Library artifacts from docs classpath (ApiDocs.bp)
because they are still used in development/samples, which is not as easy
to migrate as javadoc.

Bug: 158779503
Test: make docs
Exempt-From-Owner-Approval: Mass find/replace for androidx migration
Change-Id: Icf7f53ec36a0e970413352e2ebf40ce9d60ed17e
2022-02-09 22:25:14 +00:00
Seigo Nonaka
6b9b5167e1 Improve BoringLayout#isBoring for PrecomputedText
Bug: 216736786
Test: atest PrecomputedTextTest
Test: perf score becomes 758,071 -> 110,755
Change-Id: I57d3eb9d1e896ed1c847733c4e96ac52dd97d2c4
2022-02-03 15:25:59 +09:00
Calvin Pan
2801e6de4f Merge changes Ib484fc0c,I2b9ff69c,I0a31b117,I888c65c8,I03723cfe, ...
* changes:
  Clean <plurals> in DateTimeView
  Clean <plurals> in CertificateMonitor
  Clean <plurals> in FillUi
  Clean <plurals> in BugreportProgressService
  Clean <plurals> in keyguard
  Clean <plurals> in ChooserActivity
  Clear <plurals> in TextUtils
  Clean <plurals> in FindActionModeCallback
  Clean <plurals> in ZenModeConfig
  Add util class for plurals
2022-01-27 06:31:58 +00:00
Hans Boehm
1350cb73d7 Merge "Prefer WeakReference.refersTo() to get()" am: 63e3c2c709 am: aca7bb4b9f am: a2e1dc8b9a am: db7bb39fb9
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1956816

Change-Id: I8f190ce1b3c9fc97a4efd8f3d90178db6ab362da
2022-01-27 01:18:15 +00:00
Hans Boehm
db7bb39fb9 Merge "Prefer WeakReference.refersTo() to get()" am: 63e3c2c709 am: aca7bb4b9f am: a2e1dc8b9a
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1956816

Change-Id: I449eec7c2bc21bfa5c7909a4508fbf899a59040d
2022-01-27 01:01:31 +00:00
Calvin Pan
436659396c Clear <plurals> in TextUtils
Bug: 199230228
Test: make
Change-Id: I3c0422b588a954a9e32fdcc94ea3946dbccddcd0
2022-01-26 11:55:03 +08:00
James Lin
b0429656ad Merge "Add line break word style parameter in the LineBreakConfig" 2022-01-24 17:27:12 +00:00
James.cf Lin
664a75b407 Add line break word style parameter in the LineBreakConfig
The line break word style(lw) provides the phrase-based breaking opportunities. When the line break word style is set, it will be brought to ICU for calculation.

Bug: 183780874
Test: atest minikin_tests; atest TextViewTest; atest MeasuredTextTest; atest PrecomputedTextTest
Change-Id: Idd851497e46c1fca87ff590230d93f8bb5c9afae
2022-01-22 12:27:51 +08:00
Hans Boehm
3492061b6d Prefer WeakReference.refersTo() to get()
This is an initial pass over frameworks/core to avoid WeakReference
get(), since that can cause the referent to be unnecessarily retained.
Most of these were found by searching for "get() == null".

Bug: 215259836
Test: Treehugger
Change-Id: I5227b05ca22e83b886ccf6713989961076df3f8c
2022-01-20 17:57:02 -08:00
Bernardo Rufino
1a5cb387d6 Revert "Revert "Migrate unsafe parcel APIs in framework-minus-apex""
This reverts commit 331be9a643.

Reintroducing ag/16366278 since it seems unrelated to b/214053959 (more details on b/214053959#comment55).

Original commit message:

Migrate unsafe parcel APIs in framework-minus-apex

Migrate the following unsafe parcel APIs in framework-minus-apex:
* Parcel.readSerializable()
* Parcel.readArrayList()
* Parcel.readList()
* Parcel.readParcelable()
* Parcel.readParcelableList()
* Parcel.readSparseArray()

This CL was generated by applying lint fixes that infer the expected
type from the caller code and provide that as the type parameter
(ag/16365240).

A few observations:
* In some classes we couldn't migrate because the class also belonged to
another build module whose min SDK wasn't current (as is the case for
framework-minus-apex), hence I suppressed the lint check
(since I'll eventually submit the lint check to the tree).
* In some cases, I needed to do the cast in
https://stackoverflow.com/a/1080525/5765705 to make the compiler happy
since there isn't another way of providing a class of type
Class<MyClassWithGenerics<T>>.
* In the readSerializable() case, the new API also requires the class
loader, that was inferred to by InferredClass.class.getClassLoader().
* Note that automatic formatting and import rely on running hooked up
to the IDE, which wasn't the case here.

Bug: 195622897
Change-Id: I272432e6e082a973f7a50492ec35d79c2b577c93
Test: TH passes
2022-01-19 11:13:18 +00:00
Seigo Nonaka
94904647a4 Add setLineBreakConfig API
Add new API to allow applications to specify the line break word style. The line break style is one of the locale extension. When the line break style is set, it will be brought to ICU for calculation.

Bug: 183780874
Test: atest minikin_tests; atest TextViewTest; atest MeasuredTextTest; atest PrecomputedTextTest
Change-Id: Ia9cdb5b83e346f96ae22abbb1bcce05c43207bba
2022-01-15 14:28:40 +08:00
TreeHugger Robot
7f635e3d3b Merge "Implement fallback line spacing for BoringLayout" 2022-01-12 23:14:26 +00:00
Ashwini Oruganti
776b439703 Merge "Revert "Migrate unsafe parcel APIs in framework-minus-apex"" 2022-01-12 23:07:08 +00:00
Bernardo Rufino
331be9a643 Revert "Migrate unsafe parcel APIs in framework-minus-apex"
This reverts commit 90bb3709dc.

Reason for revert: b/214053959

Change-Id: Ic271bab1d3eaf677a5989dda9deb944ee2ad6850
2022-01-12 17:44:44 +00:00
Seigo Nonaka
78c774defb Implement fallback line spacing for BoringLayout
The fallback line spacing is a feature of extending the line height
when the fallback font has taller glyph. This was implemented to
StaticLayout in Android P but not yet implemented in BoringLayout.

This CL enables this feature to the BoringLayout as well.

Not to break existing apps, change this behavior only if the
targetSdk version is T or later.

This is a 2nd attempt of Ia6d6f9f44e73ddaf5e8fe9a8aead7a53efbddd44
The root cause of SystemUI crash was wrong API usage. (start, end) was
passed instead of (start, count).

Bug: 210923482
Test: atest FallbackLineSpacingTest BoringLayoutFallbackLineSpacingTest
Test: atest CtsGraphicsTestCases
Test: atest CtsTextTestCases
Test: atest SystemUITests
Change-Id: I9137607b0120934f7ad2a12c0f0b8aaa52915831
2022-01-12 00:00:53 -08:00