Commit Graph

614 Commits

Author SHA1 Message Date
TreeHugger Robot
bb3826cb3f Merge "Disable failing pip assertion" 2021-07-20 22:41:24 +00:00
Nataniel Borges
b8b08a5884 Disable failing pip assertion
Test is very flaky in presubmit. Disable it until we can identify what is causing the failure. Currently sponge cannot fetch tests results and, thus, cannot be debugged.

Bug: 193436187

Test: atest WMShellFlickerTests
Change-Id: Ieb7a80d0675aefe1a80d10a0f8b512506d063bba
2021-07-20 19:46:08 +02:00
TreeHugger Robot
fbcadb0708 Merge "Disable SetRequestedOrientationWhilePinned test" 2021-07-20 15:16:58 +00:00
Nataniel Borges
f99a1edbfd Disable SetRequestedOrientationWhilePinned test
Test is very flaky in presubmit. Disable it until we can identify what is causing the failure

Test: atest WMShellFlickerTests
Change-Id: Ieb7a80d0675aefe1a80d10a0f8b512506d063bb3
2021-07-19 21:18:41 +02:00
TreeHugger Robot
ec7536f73e Merge "Fix One-handed tutorial looks janky on entering transition" into sc-dev am: ed889bb867 am: 39e2268eae
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15283490

Change-Id: Ibf28b07c6bba54ef0dfbf29f54aeb54863e13225
2021-07-18 17:58:12 +00:00
Bill Lin
500e2b146d Fix One-handed tutorial looks janky on entering transition
According to systrace, one-handed-tutorial-overlay got
jank problem(SurfaceFlinger GPU Deadline Missed,
App Deadline Missed, Buffer stuffing).

1.setLayerType(LAYER_TYPE_HARDWARE) when create targetViewContainer
  setLayerType(LAYER_TYPE_NONE) when removeTutorialFromWindowManager
2.Rename isShowing() to isAttached()
3.Remove redundant float casting
4.Remove redundant increment param

Test: manual trigger OHM
Test: atest WMShellUnitTests
Bug: 193589897
Change-Id: Ieec397795b46dee9ca04375bfc26b09441688d08
2021-07-16 19:21:15 +08:00
TreeHugger Robot
28ff4daf01 Merge "Add adb command to toggle side stage outline border" into sc-v2-dev am: 2bd69d1eda am: ea254c0383
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15258462

Change-Id: Idd027a5801aa1bfdfd07510556d3bb303a273c1c
2021-07-14 04:32:23 +00:00
TreeHugger Robot
2bd69d1eda Merge "Add adb command to toggle side stage outline border" into sc-v2-dev 2021-07-14 04:03:59 +00:00
Wei Sheng Shih
f3ae09f3e2 Merge "Get starting window background color directly." into sc-dev am: a9a861134d am: 47dc082e47
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15020163

Change-Id: Iba15949bfa4e0bcd75d17a0957006f17dea6f29f
2021-07-14 02:20:18 +00:00
Wei Sheng Shih
76d20eedf6 Merge "Get starting window background color directly." into sc-dev am: a9a861134d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15020163

Change-Id: I46ebb85f40dab8cd27f520fbdac81656fea52d51
2021-07-14 01:50:27 +00:00
Jerry Chang
0b106a923d Add adb command to toggle side stage outline border
Make the outline boarder of the side stage default off. Add an adb
command to toggle on/off the boarder.

$adb shell dumpsys activity service SystemUIService WMShell
setSideStateOutline <true/false>

Bug: 189839391
Test: verified the adb command could toggle on/off side stage outline
border.

Change-Id: I4c09b072b384badd206f0e81eca6daa033ac8565
2021-07-14 01:09:22 +00:00
wilsonshih
3be521ad48 Get starting window background color directly.
SystemUI does not need to re-calculate background color of starting
window because Shell library is bound to SystemUI, so status bar can
get background color directly, also this can support to get the
background color from snapshot starting window.

Also fix the starting window listener did not receiveing background
color successful because makeSplashScreenContentView is execute on
another background thread, so there should block the splash screen
thread until the background color is estimated.

Bug: 192213918
Bug: 192659309
Test: manual launch apps from Notification and Launcher, ensure the
color is correctly send to SystemUI or Launcher.

Change-Id: I626cb23d7aebfe4e032fad285bfad374c0e11cea
2021-07-13 18:53:19 +08:00
Tony Huang
43dd5ffe88 Merge "Set stage outline layer to top" into sc-v2-dev am: 152f01c18f am: f7429af9ba
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15209100

Change-Id: Ia542a986689948c7567831a6fbbbcfe1f32fb7be
2021-07-12 23:56:31 +00:00
Chris Li
7358b07b8c Merge "Skip AppPairs and LegacySplit flicker tests when Shell transition is on" into sc-v2-dev am: 4c296db79b am: 8e868b57ae
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15133311

Change-Id: I6ec6132c19fd2105930b49c9dcca7cfff84322a6
2021-07-12 23:54:35 +00:00
Tony Huang
152f01c18f Merge "Set stage outline layer to top" into sc-v2-dev 2021-07-12 10:17:33 +00:00
Tony Huang
efbc8c1028 Set stage outline layer to top
Outline do not set layer before so it will show behind tasks layer
then it will be invisible. Set its layer to top to ensure it's
visible.

Also fix context error message bug by replacing display context to
window context.

Fix: 192902371
Fix: 192527238
Test: Enable spilt and disable it many times and check outline display
Test: Check ContextImpl log
Change-Id: Ic1796965d7254d2276d4c05c662e940820c8d995
2021-07-12 16:44:23 +08:00
Chris Li
56f9dc1299 Skip AppPairs and LegacySplit flicker tests when Shell transition is on
AppPairs: no plan to update to Shell transition soon
LegacySplit: will be replaced by StageSplit in sc-v2

Bug: 183993924
Test: pass existing
Change-Id: I1cd485126356ae5d628b13cc33f883d61430285d
2021-07-11 13:02:01 -07:00
TreeHugger Robot
1149bd1b36 Merge "Promote or demote stable and flaky flicker tests" 2021-07-11 15:35:00 +00:00
Nataniel Borges
477500adf3 Promote or demote stable and flaky flicker tests
Weekly CL updating the status of flicker tests.

Promote:
- stable postsubmit to presubmit
- stable flaky to postsubmit

Demote:
- unstable presubmit to flaky
- unstable postsubmit to flaky

Test: atest FlickerLibTest FlickerTests WMShellFlickerTests
Bug: 190189685
Bug: 141361128
Change-Id: I8988b9f9e6d92d26b169da91ce98b359bf05336f
2021-07-10 14:40:04 +02:00
Bill Lin
b077e9e468 Merge "Redesign One-haned tutorial UX behavior" into sc-dev am: 5ad4a8093c am: b174f409cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15187818

Change-Id: I45b6b04566ed1e50b8e069338b00149556295862
2021-07-10 01:26:31 +00:00
Bill Lin
2d05491113 Merge "Improve SystemUIBootiming_StartServices_avg" into sc-dev am: 1334cfb90d am: 9e70c42838
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15243692

Change-Id: Ifc7ae635aa61d0c9c150eea261b9b2e279c2f14b
2021-07-10 01:26:12 +00:00
Bill Lin
6412447d27 Merge "Redesign One-haned tutorial UX behavior" into sc-dev am: 5ad4a8093c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15187818

Change-Id: Iaaa00752187baa50b75e14aedd25c08cfbc31e98
2021-07-10 01:10:53 +00:00
Bill Lin
1e1856fc4d Merge "Improve SystemUIBootiming_StartServices_avg" into sc-dev am: 1334cfb90d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15243692

Change-Id: Ibcef8192752d2a20bf9b047e2d02f925a23346d9
2021-07-10 01:10:49 +00:00
Bill Lin
5ad4a8093c Merge "Redesign One-haned tutorial UX behavior" into sc-dev 2021-07-10 01:05:11 +00:00
Bill Lin
80b340a9aa Improve SystemUIBootiming_StartServices_avg
Previously, we tried to tuning boottime of SysUI
See go/systemuiboottiming_ohm
- Reduce access setting provide at SysUI start-up
- Remove unused obervers
  1. Timeout
  2. TapAppExit
- Update mShortcutEnabled state at ctor

Test: manual enable OHM shortcut, rebot
      make sure shortcut function works
Test: atest WMShellUnitTests
Test: asit/perf/boottime_test
Bug: 193225130
Change-Id: I2753f8b1e47622c00b9c6d2f4cd319c6e43634ea
2021-07-09 21:31:05 +08:00
Bill Lin
477c88a7d5 Redesign One-haned tutorial UX behavior
- Always show tutorial for user to know device state
  is in One-handed mode.
- Clean the redundant params from ctor

Test: manual trigger OHM
Test: atest WMShellUnitTests
Bug: 192648901
Change-Id: I10c3f3f29190b672fb88471df3cf374a994cdaa7
2021-07-09 19:05:05 +08:00
Bill Lin
d4dfcceb7f Merge "Improve SystemUIBootTiming performance in OneHandedController" into sc-dev am: 7f162ddaf0 am: bf112d0345
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15175505

Change-Id: I55d8862af766662b7b31a917c3689517d04f9bc3
2021-07-09 02:16:36 +00:00
Bill Lin
8db534922d Merge "Improve SystemUIBootTiming performance in OneHandedController" into sc-dev am: 7f162ddaf0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15175505

Change-Id: I678c86456cea4da5cee5be133fde3bba4881da10
2021-07-09 02:02:24 +00:00
Bill Lin
7f162ddaf0 Merge "Improve SystemUIBootTiming performance in OneHandedController" into sc-dev 2021-07-09 02:00:33 +00:00
Chris Li
9faa470aec Merge "Revert "Revert "Not show size compat UI when task is not visible""" into sc-dev am: 50c03ea7ed am: 886a6697a8
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15237129

Change-Id: I724309d4ee1d3bce6830951ff7d5cfe1692af51d
2021-07-08 22:15:06 +00:00
Chris Li
c769062301 Merge "Revert "Revert "Not show size compat UI when task is not visible""" into sc-dev am: 50c03ea7ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15237129

Change-Id: I8c2e257e5a2b7d89814288d5d8cd2e24af76c722
2021-07-08 22:03:19 +00:00
Chris Li
171f08c8b5 Merge "Skip stage-split stateChange tests when using shell transit" into sc-v2-dev am: 64c167d613 am: 642a68d7a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15018051

Change-Id: I28031198619eeb3d415e360dc787f39fa988afe8
2021-07-08 20:45:37 +00:00
Chris Li
64c167d613 Merge "Skip stage-split stateChange tests when using shell transit" into sc-v2-dev 2021-07-08 20:12:32 +00:00
Chris Li
a23a2bb5db Revert "Revert "Not show size compat UI when task is not visible""
This reverts commit 76370b6fe6.

Reason for revert: Fix the merge break in ShellTaskOrganizerTests.java

Fix: 193069342
Test: atest WMShellUnitTests:ShellTaskOrganizerTests
Change-Id: I02c4bddc407eaac0ebb7cd5abb0b394f242d4d6e
2021-07-08 12:09:40 -07:00
Chris Li
e7ed99bfc2 Merge "Remove TaskInfo#topActivityToken usage in size compat for security" into sc-dev 2021-07-08 18:05:40 +00:00
Leon Jeng
3378200e36 Revert "Not show size compat UI when task is not visible" am: 76370b6fe6 am: 4e86d92f71
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15232572

Change-Id: Ifc3812e3ce2a0f10c235ab679dcdd21391c90711
2021-07-08 10:11:31 +00:00
Leon Jeng
979db138fe Revert "Not show size compat UI when task is not visible" am: 76370b6fe6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15232572

Change-Id: Ib61cabd6c4d77d4fa5cd3f64b2272fcd684db153
2021-07-08 10:01:44 +00:00
Leon Jeng
76370b6fe6 Revert "Not show size compat UI when task is not visible"
This reverts commit adb92508c0.

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?branch=git_master&target=coral-userdebug&lkgb=7530814&lkbb=7530923&fkbb=7530923, bug b/193105445

Bug: 193105445
Change-Id: I697229da6986d6466d7f13872e9ae7a727b80838
2021-07-08 09:48:10 +00:00
Chris Li
4693896d4a Merge "Not show size compat UI when task is not visible" into sc-dev am: 927c644bfa am: 1402f79d1b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15225378

Change-Id: Id2d1a91f49855fc92be3f3eba3b782f3ea3fe4ee
2021-07-08 07:14:11 +00:00
Nataniel Borges
9271b1a31a Merge "Simplify flicker assertions" 2021-07-08 07:07:13 +00:00
Chris Li
2d8b03190d Merge "Not show size compat UI when task is not visible" into sc-dev am: 927c644bfa
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15225378

Change-Id: Ic80035d84e4e2f2a5471bd4f85cc90ff61cda49f
2021-07-08 07:01:54 +00:00
Bill Lin
3aafe19994 Improve SystemUIBootTiming performance in OneHandedController
Fix race condition in SystemUIBootTiming issue.

1. Avoid updateOneHandedEnabled() called twice during init
   a. [O] come from setOneHandedEnabled()
   b. [X] come from setSwipeToNotificationEnabled()
2. Passively waiting shortcut enabled changed callback, and then
         query setting ACCESSIBILITY_BUTTON_TARGETS status.
3. Add a new flag isShortcutEnabled to cache shortcut enabled
   state.
4. By new OHM Settings UX design setSwipeToNotificationEnabled()
   should NOT setEnabledGesturalOverlay().
5. Remove redundant auto enabled Toast and print in log instead.
   (In general case, user is not able to see the Toast)

Test: atest google/perf/boottime/boottime-test
Test: atest SystemUITests
Test: atest WMShellTests
Test: manual factory reboot, OHM should disabled by default
Bug: 192612924
Change-Id: I8b24c99bc8bd5bfb17c73a6bb8494109d9a8170d
2021-07-08 14:14:25 +08:00
Chris Li
927c644bfa Merge "Not show size compat UI when task is not visible" into sc-dev 2021-07-08 05:53:15 +00:00
Chris Li
fc422208b1 Merge "Remove TaskInfo#topActivityToken usage in size compat for security" into sc-v2-dev am: 9d86a7b10f am: 7ee5c0b861
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15140327

Change-Id: I2ebd8ee5a949740f7faa6aae66f12e43d9b9cae5
2021-07-08 04:25:13 +00:00
Chris Li
1245aefa49 Remove TaskInfo#topActivityToken usage in size compat for security
Security report shows that this can cause leak token of different app.

Replace the functionality with a callback to the TaskOrganizerController
to restart activity when size compat restart button is clicked.

Bug: 186776724
Test: manually verify the restart button still works
Change-Id: I097b9f02e8435e6765695b9d5a531a4e165bac66
Merged-In: I097b9f02e8435e6765695b9d5a531a4e165bac66
2021-07-07 21:09:24 -07:00
Chris Li
adb92508c0 Not show size compat UI when task is not visible
Before, when a size compat task was hidden, the size compat UI might
still be showing. Now, remove the UI when the task is no longer visible.

Bug: 193069342
Test: manually verify the size compat button is not showing in recents
Change-Id: Ia17a97f5e7a9af497d8da16b31bb5169dd502d53
2021-07-07 17:46:08 -07:00
Chris Li
ae54032e9a Remove TaskInfo#topActivityToken usage in size compat for security
Security report shows that this can cause leak token of different app.

Replace the functionality with a callback to the TaskOrganizerController
to restart activity when size compat restart button is clicked.

Bug: 186776724
Test: manually verify the restart button still works
Change-Id: I097b9f02e8435e6765695b9d5a531a4e165bac66
2021-07-07 12:50:53 -07:00
Evan Rosky
12056ba8f2 Skip stage-split stateChange tests when using shell transit
with shell transitions, the transition itself manages stage-split
state.

Bug: 183993924
Test: atest StageTaskListenerTests
Change-Id: Ic742d3a23c080d68812a5795ab490b56eea7e4a4
2021-07-06 03:42:31 +00:00
Vadim Caen
f863855683 Merge "Implement the legacy splash screen behavior" into sc-dev am: 2be72d030b am: fa0a9d0bfd
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14920934

Change-Id: I9f4a3c7c55c9ee03a6e8255e433189133c110b14
2021-07-05 15:59:18 +00:00
Vadim Caen
c56fa470bd Merge "Implement the legacy splash screen behavior" into sc-dev am: 2be72d030b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14920934

Change-Id: If3cb25fa466589eed613c1b122e638533631a549
2021-07-05 15:46:35 +00:00