Commit Graph

11127 Commits

Author SHA1 Message Date
Adrian Roos
a38538d2d6 Merge "DisplayCutout: Add clarifying images to LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES" into pi-dev am: 95712fe0cb
am: b038415e98

Change-Id: If06875a89cdf08eb04aeaeada403e5de8551e326
2018-03-28 15:21:53 +00:00
Adrian Roos
95712fe0cb Merge "DisplayCutout: Add clarifying images to LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES" into pi-dev 2018-03-28 14:56:19 +00:00
Adrian Roos
1a2ee998b7 Merge "DisplayCutout: Fix attrs.xml javadoc" into pi-dev am: 813a4bee76
am: f71a29c976

Change-Id: I9cc8503daa68cbc45f288bf61afa54d3ad4045f2
2018-03-28 14:54:06 +00:00
Adrian Roos
813a4bee76 Merge "DisplayCutout: Fix attrs.xml javadoc" into pi-dev 2018-03-28 14:29:08 +00:00
Adrian Roos
ad1da31764 DisplayCutout: Add clarifying images to LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
Fixes: 76462084
Test: make doc-comment-check-docs, open $ANDROID_BUILD_TOP/out/target/common/docs/doc-comment-check/reference/android/view/WindowManager.LayoutParams.html, navigate to LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
Change-Id: I8a9df979cbb062896fa874a163414a4f8a095b21
2018-03-28 15:00:45 +02:00
Lucas Dupin
c8c6f79581 Merge "Unload wallpaper bitmap and release HwuiContext" into pi-dev am: 3844e1d83c
am: a68e764dad

Change-Id: I8a268f6a1d21785eee32deaefd478faf3424764c
2018-03-28 04:01:40 +00:00
Lucas Dupin
41c25cee06 Unload wallpaper bitmap and release HwuiContext
To decrease sysui memory usage

Test: adb dumpsys meminfo
Fixes: 74534423
Change-Id: I3cb4a5927e8d6b20a7aeba3fda253f0ba4cc18f6
2018-03-27 16:30:07 -07:00
Felipe Leme
51c2131306 Merge "Recover dataset picker when view fail to autofill." into pi-dev am: 828ffa45a1
am: f10983fbe7

Change-Id: I8cbae3ab05a79fc9358a787af32887d9968370b6
2018-03-27 22:01:48 +00:00
TreeHugger Robot
828ffa45a1 Merge "Recover dataset picker when view fail to autofill." into pi-dev 2018-03-27 19:48:44 +00:00
Derek Sollenberger
93e2e97d1b Merge "Remove deprecated android.graphics.Canvas APIs" into pi-dev am: 812e87ecba
am: d32b6e012a

Change-Id: I596d43c935516141b9c834c0af7441606d41a33a
2018-03-27 19:36:37 +00:00
Felipe Leme
49f08edf7d Recover dataset picker when view fail to autofill.
When a dataset is selected, the framework tries to autofill all views belonging
to it. But if one (or more view) failed to autofill, we should let the user
recover by tapping the view again.

This scenario typically happens when views are recycled.

Test: atest MutableAutofillIdTest#testViewGoneDuringAutofillCanStillBeFilled
Test: atest CtsAutoFillServiceTestCases # manually retrying flaky failures

Fixes: 76149637

Change-Id: I7a6352c68b4a7d5e4cb80a7346c66efd831f21c8
2018-03-27 10:50:36 -07:00
Adrian Roos
87526af33c DisplayCutout: Fix attrs.xml javadoc
Fixes an issue with the javadoc for windowLayoutInDisplayCutoutMode.
Removes @tags from enum javadocs, because they get merged into a table,
which does not support inner @tags. Instead, use <code> tags which work
in that context.

Also replaces @see tags with {@link} tags in the attr javadoc, because
the enum value table gets appended, but it is invalid to have text after
an @see tag.

Change-Id: Ib97e9aa82e173d99a467132a0d403793d7297e61
Fixes: 76448223
Test: make doc-comment-check-docs, verify output at $ANDROID_BUILD_TOP/out/target/common/docs/doc-comment-check/reference/android/R.attr.html#windowLayoutInDisplayCutoutMode
2018-03-27 17:44:19 +02:00
Derek Sollenberger
7b837616ae Remove deprecated android.graphics.Canvas APIs
Bug: 73777445
Test: compile
Change-Id: Ie68f2fbe3c3be82f3c20529d535875d4cc204b7c
2018-03-27 14:36:50 +00:00
Felipe Leme
82eca0fb60 Merge "Integrate autofill session lifecycle with URL bar changes when on compat mode." into pi-dev am: 992d078542
am: 85584bcb20

Change-Id: Iaa4e79b744c71b7e666ac026e108128eb96255c1
2018-03-27 05:42:41 +00:00
TreeHugger Robot
992d078542 Merge "Integrate autofill session lifecycle with URL bar changes when on compat mode." into pi-dev 2018-03-27 05:15:20 +00:00
Felipe Leme
0c8ce322a3 Integrate autofill session lifecycle with URL bar changes when on compat mode.
The contents of a browser URL bar is typically changed for 2 reasons:

1.User entered a new URL.
2.Form was submitted and the URL changed.

On scenario #1, the current session should be canceled, while on #2 it should be
committed. Scenario #2 is already handled when the service sets a SaveInfo, so
this CL handles the other cases:

1.Focus on URL bar is ignored so it does not trigger a new partition.
2.If URL bar changed and service didn't set a SaveInfo, the session is canceled.

Fixes: 76027553

Test: manual test with Chrome
Test: new tests on VirtualContainerActivityCompatModeTest:
      testFocusOnUrlBarIsIgnored()
      testUrlBarChangeIgnoredWhenServiceCanSave()
      testUrlBarChangeCancelsSessionWhenServiceCannotSave
      testUrlBarChangeCancelsSessionWhenServiceReturnsNullResponse
Test: atest CtsAutoFillServiceTestCases

Change-Id: I19d2aa4c8b25def0d5eca1c59cfdc2ffe33dd388
2018-03-26 11:55:31 -07:00
Robert Carr
cfc0ddf1df Merge "Fix SurfaceView Background" into pi-dev am: e3d2c41344
am: beb2540414

Change-Id: I1e6bc640843038f41a0b444dd507d884d472a117
2018-03-24 04:00:58 +00:00
Felipe Leme
d6878276d9 Merge "Properly set input type on autofill compat mode." into pi-dev am: 352da45bbb
am: be541db705

Change-Id: I8975c3604122935f84347606a3a21517a7ee05e3
2018-03-24 02:06:48 +00:00
Todd Kopriva
56a99d5ff6 Merge "Merge "docs: fixing bug 36982027 and 30636712, typos" into oc-mr1-dev am: 5b0a4eea8d" into pi-dev am: ba22b7f4fd
am: 1e72ce692a

Change-Id: I9741c3ba70d229e389fb2c4e068a576a9b6007a6
2018-03-24 01:44:05 +00:00
Evan Rosky
1069c90060 Merge "Added TestApi for default focus highlight" into pi-dev am: 87f9818319
am: a6afc381c9

Change-Id: I034e076aa41e3866b84e19261132450991d9488d
2018-03-24 00:54:19 +00:00
TreeHugger Robot
e3d2c41344 Merge "Fix SurfaceView Background" into pi-dev 2018-03-23 23:21:04 +00:00
TreeHugger Robot
352da45bbb Merge "Properly set input type on autofill compat mode." into pi-dev 2018-03-23 22:49:25 +00:00
John Reck
477ea0674c Merge "Add isPivotSet/resetPivot" into pi-dev am: 6045d66aa2
am: 530d626b81

Change-Id: I592dd6459b9526393602d9845d0191c291f56cb6
2018-03-23 22:14:45 +00:00
Todd Kopriva
1057fc37f5 Merge "docs: fixing bug 36982027 and 30636712, typos" into oc-mr1-dev
am: 5b0a4eea8d

Change-Id: Iff4044c52e7ccdf6f7f879b9d5457ce1458b21bd
2018-03-23 22:11:38 +00:00
TreeHugger Robot
87f9818319 Merge "Added TestApi for default focus highlight" into pi-dev 2018-03-23 22:04:04 +00:00
Felipe Leme
c380e18e31 Properly set input type on autofill compat mode.
Test: atest CtsAutoFillServiceTestCases:android.autofillservice.cts.VirtualContainerActivityTest#testAutofillSync\
CtsAutoFillServiceTestCases:android.autofillservice.cts.VirtualContainerActivityCompatModeTest#testAutofillSync

Fixes: 76173462

Change-Id: Ie400ed5d4426febc34b02f68d6be4d86bc11034f
2018-03-23 14:04:23 -07:00
Robert Carr
386fd70434 Fix SurfaceView Background
When refactoring to not use global transaction when setting
position  I failed to account for the forwarding done by the
background wrapper.

Bug: 76099976
Bug: 76110573
Test: Manual. go/wm-smoke
Change-Id: I2cff8e571f12e69cefbd1ea35538fd71beaf1ec4
2018-03-23 13:48:48 -07:00
John Reck
6045d66aa2 Merge "Add isPivotSet/resetPivot" into pi-dev 2018-03-23 19:26:50 +00:00
Felipe Leme
5b5e50d987 Merge "Improved autofill logging and dumping." into pi-dev am: 63df4e248a
am: c39b648a80

Change-Id: Ifc409bae7d1e8b1c6d2f84be9c1ca7bef308966f
2018-03-23 07:28:21 +00:00
Felipe Leme
63df4e248a Merge "Improved autofill logging and dumping." into pi-dev 2018-03-23 05:48:26 +00:00
Evan Rosky
e1a0b347a0 Added TestApi for default focus highlight
Bug: 62864111
Test: View_DefaultFocusHighlightTest
Change-Id: I2a74de3274351f0a7662715e723c25f4d7f8f6ed
2018-03-22 19:37:50 -07:00
Abodunrinwa Toki
80f5725d1e Merge "Fix smart_linkify_enabled flag." into pi-dev am: e9a7cb8158
am: 27d8cf774a

Change-Id: I4d0c13b480cdd0f2fa134716575e86630a7e90d4
2018-03-23 02:31:56 +00:00
Rose Liu
8bc23adc0d Merge "Assign -1 as default value of window type and owner uid." into pi-dev am: a194d92495
am: 0da0266bdf

Change-Id: I7e52c530a059592fefb14503b09cd0f416584e67
2018-03-23 01:55:59 +00:00
Felipe Leme
da9ea34c02 Improved autofill logging and dumping.
Bug: 76027553
Test: adb shell dumpsys autofill

Change-Id: I19ef88c71334c62292ed982e43d7a7e89b35f10e
2018-03-22 16:43:28 -07:00
TreeHugger Robot
e9a7cb8158 Merge "Fix smart_linkify_enabled flag." into pi-dev 2018-03-22 22:56:58 +00:00
rongliu
3dac23bd4d Assign -1 as default value of window type and owner uid.
Bug: 74622357
Test: Test with ag/3738015 together. Layers without buffers have window
type -1 and owner uid -1.

Change-Id: I6f010bf1327671a06874b75bc0a63a3fb010ced7
2018-03-22 13:44:29 -07:00
Abodunrinwa Toki
6563833cf3 Fix smart_linkify_enabled flag.
The flag should only ensure that smart linkify calls behave in the
legacy way instead of totally disabling linkify.
Also, to keep the flag consistent with smart_selection_enabled and
smart_text_share_enabled flags, the flag should only disable the
SmartLinkify (i.e. Linkify.addLinksAsync) feature not TextClassifier
APIs (i.e. TextClassifier.generateLinks).

Also fixes issue with non-focusable TextViews by firing the primary
action instead of showing the floating toolbar. (b/73156794)

Bug: 75967597
Bug: 73156794
Test: bit FrameworksCoreTests:android.text.util.LinkifyTest
Test: bit CtsTextTestCases:android.text.util.cts.LinkifyTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: manual - checked behaviour turning flag on/off
Test: manual - checked behaviour with TextView.setFocusableInTouchMode(true/false)
Change-Id: I541f60161b9cd63ce7e57235607500f2fb0841e7
2018-03-22 19:25:14 +00:00
Lukas Zilka
f7b2a69bbc Merge "Adds support for a fall-back model when the language-specific model is not found." into pi-dev am: f9593d62b3
am: a30195420a

Change-Id: I7b2f81fd136b56e05857c06c07be3af89eed2d1a
2018-03-22 11:12:24 +00:00
TreeHugger Robot
f9593d62b3 Merge "Adds support for a fall-back model when the language-specific model is not found." into pi-dev 2018-03-22 10:50:47 +00:00
John Reck
8686e1f157 Add isPivotSet/resetPivot
Bug: 74825533
Test: CTS view tests in topic
Change-Id: Ib918bc5830d53ee0a83b13ab53ac6e8dd86c869f
2018-03-21 16:42:59 -07:00
Lukas Zilka
0fcacdddf4 Adds support for a fall-back model when the language-specific model is not found.
Bug: 74720318

Test: Builds and fall-back works.
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
Change-Id: I5491af628c8406e42ca2cc971ad3a8b708ceb315
2018-03-21 12:25:41 +01:00
Yohei Yukawa
957d06bf11 Merge "Fix confusing Log.e message in SpellCheckerSession" into pi-dev am: efcd6e1ceb
am: 32355d12be

Change-Id: I49383474cc086de13352df36ea3bf8855acf7ff6
2018-03-21 09:06:14 +00:00
Robert Carr
b731d9d560 Merge "Distinguish between createSurface error codes." into pi-dev am: d0661a081d
am: 367eeed46a

Change-Id: I0c992c81c3d53ee764b02b95563275ead7c8ea29
2018-03-21 06:10:54 +00:00
TreeHugger Robot
efcd6e1ceb Merge "Fix confusing Log.e message in SpellCheckerSession" into pi-dev 2018-03-21 03:25:49 +00:00
Andrii Kulian
aa48cf9c52 Merge "Don't set override display info for ActivityView" into pi-dev am: 982973934d
am: 8ef2b626c8

Change-Id: I1cd3d6bf253b77316f8194292f619928c9e95530
2018-03-21 03:14:18 +00:00
Yohei Yukawa
0cf7b31012 Fix confusing Log.e message in SpellCheckerSession
With this CL, calling SpellCheckerSession#close() multiple times will
no longer show the following error message in logcat, which was quite
confusing.

  E SpellCheckerSession: ignoring processOrEnqueueTask due to
    unexpected mState=TASK_CLOSE scp.mWhat=TASK_CLOSE

Note that with a recent CL [1], we now more often see the above
message.  A typical scenario is:

  1. App creates SpellCheckerSession x.
  2. App calls x.close().
  3. x is garbage-collected. ART calls x.finalize(), which internally
     calls x.close() again.

 [1]: I4e00c3a2cec93d1dacff20546e481fe757279661
      9b64367193

Bug: 72974646
Fix: 72974646
Test: Made sure that no error message in question with a test app
      that calls SpellCheckerSession#close() multiple times then
      trigger SpellCheckerSession#finalize().
Change-Id: Ie9690860e6d0406dc6746cd03c28f693e65c1dde
2018-03-21 01:15:02 +00:00
kopriva
6a7f167f67 docs: fixing bug 36982027 and 30636712, typos
Test: make ds-docs

Bug: 36982027
Bug: 30636712

Change-Id: I70d6d216c714a31b7e762a203a27f6124642131e
2018-03-20 17:59:48 -07:00
TreeHugger Robot
d0661a081d Merge "Distinguish between createSurface error codes." into pi-dev 2018-03-21 00:40:19 +00:00
Andrii Kulian
982973934d Merge "Don't set override display info for ActivityView" into pi-dev 2018-03-20 22:01:27 +00:00
Andrii Kulian
f0379de259 Don't set override display info for ActivityView
ActivityView content should never be letter- or pillar-boxed
and it doesn't have overscan areas, so we can skip setting
display override info for a virtual display that backs it.

Bug: 72220802
Test: Manually resize with ActivityView demo app
Change-Id: I211449eaea50ec5d3214d63e7eb93a1d2ed2c0fd
2018-03-20 19:43:34 +00:00