Commit Graph

9138 Commits

Author SHA1 Message Date
James.cf Lin
8fb76731ee Fix Telephony crash in the method ImsCallProfile#toString
According to the crash stack, the Telephony crash in the method ImsCallProfile#toString. Add the null check before assessing the class instance.

Bug: 148746493
Test: manual
Change-Id: I156c8ac9f8cd05e678cc38397e84e10f14ce7403
2020-03-30 13:59:17 +08:00
Hall Liu
952697b886 Merge changes from topic "phonestatelistener-limit-rvc-dev" into rvc-dev
* changes:
  Add gating, logging for PhoneStateListener's limit
  Institute limit on PhoneStateListener
2020-03-28 06:48:56 +00:00
Hall Liu
ed6d6e69a8 Add gating, logging for PhoneStateListener's limit
Add gating via PlatformCompat and DeviceConfig and logging via
PlatformCompat to the limit instituted on per-process listeners

Fixes: 152074216
Test: atest CtsTelephonyHostCases
Change-Id: I4d6681d90705b68c3349f4124e434a29b50fd3a2
2020-03-27 19:21:51 -07:00
TreeHugger Robot
ddcf560b4e Merge "Remove "@Deprecated" from supplyPinReportResult + supplyPukReportResult" into rvc-dev 2020-03-28 00:03:49 +00:00
Rambo Wang
2939486f37 Merge "NR is lower priority than all other signal strengths" into rvc-dev 2020-03-27 23:38:16 +00:00
Daniel Bright
ef5836157f Remove "@Deprecated" from supplyPinReportResult + supplyPukReportResult
Fully rolled back comments and signature to original state before change

Test: bootup phone
Bug: 147854704
Change-Id: I5fcd71e1569e6b0e16cff5392239b89259ee1790
2020-03-27 15:01:16 -07:00
Shuo Qian
8d1791efc7 Add a hidden API for EXTRA_LAST_KNOWN_NETWORK_COUNTRY
Test: Treehugger; atest
Bug: 152246523
Change-Id: Id77b81e18b293d8d8c8e7b3127826fbd577d6117
2020-03-27 02:45:47 +00:00
Sarah Chin
5b2f94a0aa Merge "Update Bands API" into rvc-dev 2020-03-27 00:33:05 +00:00
Sarah Chin
854fc2ca64 Update Bands API
Test: build
Bug: 151842542
Change-Id: Ib033758d469b9b485eb7cce6c026b5a649e6a6fa
2020-03-26 15:02:29 -07:00
Sarah Chin
85e3140365 Merge "Un-deprecate SmsManager APIs" into rvc-dev 2020-03-26 21:53:51 +00:00
Rambo Wang
8e56e11eab NR is lower priority than all other signal strengths
aosp/891956 introduced signal strengths support for NR. In the
method SignalStrength.getPrimary, NR is the lowest priority.
This is against the policy which is in the comment, saying
"prioritizing newer faster RATs".

Bug: 148634820
Test: atest com.android.internal.telephony.SignalStrengthTest
Change-Id: Ia9055c9e8cd8d09cdd3f101750c9f9cea983a9f8
2020-03-26 12:35:38 -07:00
Tyler Gunn
f0d5687181 Merge "Fix potential issue where sub info change listener is not registered." into rvc-dev 2020-03-26 15:02:15 +00:00
Sarah Chin
ac3eb46325 Un-deprecate SmsManager APIs
MmsManager methods were removed for mainline, so unexposing these

Test: build
Bug: 144004293
Change-Id: I9714719f2d922cb027fa42a1aa535006dce7342c
2020-03-25 23:33:15 -07:00
Tyler Gunn
cf2cd8dcd8 Fix potential issue where sub info change listener is not registered.
SubscriptionManager#addOnSubscriptionsChangedListener can fail to
register a listener if the TELEPHONY_REGISTRY system service is not up.
Currently this is just silently ignored.

Adding a callback method on the listener to notify the registrant that the
listener failed to be registered, and adding exponential backoff code in
TelecomAccountRegistry to retry registration.

Test: Manual; edited code in Subscriptionmanager to fail the first attempts
to add a listener for TelecomAccountRegistry.  Verified the backoff took
place and registration still occurred for the listener.
Test: Tried to write a mockito test but gave up because this code has
far too many intertwined dependencies and is not inherently testable
Fixes: 152217039

Change-Id: Icf3133cdeca526979cb621f29659b880127b680a
2020-03-25 18:11:56 -07:00
Mingming Cai
fa9bd571b9 Merge "Add comments to GSM and CDMA getDbm()" into rvc-dev 2020-03-26 01:05:36 +00:00
Mingming Cai
e5befcbd28 Add comments to GSM and CDMA getDbm()
Bug: 148912739
Test: make
Change-Id: I9be4caeda8f50645bc742e95bfd7ba067a02883f
Merged-In: I9be4caeda8f50645bc742e95bfd7ba067a02883f
(cherry picked from commit b78e84c522)
2020-03-25 16:08:18 -07:00
Michael Groover
c55df5a4df Merge "Update SubInfo#getNumber docs to reflect permission requirement" into rvc-dev 2020-03-24 16:26:34 +00:00
TreeHugger Robot
4f53d72e52 Merge "Add unit test for ClosedSubscriberGroupInfo" into rvc-dev 2020-03-23 21:50:07 +00:00
Michael Groover
6d4c98513b Merge "Add method to clear out SubscriptionInfo#getCardString" into rvc-dev 2020-03-23 21:31:42 +00:00
TreeHugger Robot
9a58d5747a Merge "Un-expose APIs added for telephony mainline." into rvc-dev 2020-03-21 21:17:33 +00:00
TreeHugger Robot
4e4fa985c1 Merge "[Telephony Mainline] Hide TelephonyServiceManager and TelephonyFrameworkInitializer" into rvc-dev 2020-03-21 05:05:27 +00:00
Michael Groover
77d7d6f76d Update SubInfo#getNumber docs to reflect permission requirement
getLine1Number has been moved out of the READ_PHONE_STATE permission,
but callers with READ_PHONE_STATE can still query SubscriptionInfo
which contains the number for the subscription. The number will be
sanitized from the resulting SubscriptionInfo object(s); this change
updates the docs to reflect the new READ_PHONE_NUMBERS permission
requirement.

Bug: 152063877
Test: atest SubscriptionControllerTest
Change-Id: If4834ad0f648556207ad9b848fc4db332993a6d6
2020-03-20 21:16:12 -07:00
TreeHugger Robot
7840df3d27 Merge "Exposing TelephonyManager.isIccLockEnabled as a system API." into rvc-dev 2020-03-21 02:47:36 +00:00
Philip P. Moltmann
18122752c0 Merge "Pipe through attributeTag for one SMS permission check" into rvc-dev 2020-03-21 01:48:48 +00:00
Peter Wang
23cf98eaa8 [Telephony Mainline] Hide TelephonyServiceManager and TelephonyFrameworkInitializer
Bug: 151455139
Fix: 151455139
Test: Build
Change-Id: I067c821239585d3d4e8dcf39798b1d0014ba077b
2020-03-20 17:34:49 -07:00
Amit Mahajan
4009110b3b Un-expose APIs added for telephony mainline.
Will be reworked on in R.

Test: basic sanity
Bug: 140908357
Change-Id: Ib18b66c9351b0434d7c46e004cd162928d7133f7
2020-03-21 00:21:48 +00:00
TreeHugger Robot
98f6a63baa Merge "Hide APIs exposed for Telephony mainline which is no longer needed in R." into rvc-dev 2020-03-20 23:19:53 +00:00
Amit Mahajan
1c6679a3ad Exposing TelephonyManager.isIccLockEnabled as a system API.
This was recently removed as part of un-exposing telephony
mainline related APIs (b/146983487), but being added back in R as GMSCore
already uses it (b/151742706).

Test: TH
Bug: 151742706
Bug: 146983487
Change-Id: If4e8e87c7dfbb261ee3abfec2a4774980c24d0c2
2020-03-20 14:39:06 -07:00
Sarah Chin
7bc7f92228 Merge "Fix NPE in updateNrState" into rvc-dev 2020-03-20 20:50:36 +00:00
Michael Groover
a953322575 Add method to clear out SubscriptionInfo#getCardString
In Androird 10 access to device identifiers was limited to apps with
the READ_PRIVILEGED_PHONE_STATE permission, carrier privileges, the
READ_DEVICE_IDENTIFIERS appop set to allow, or those that pass a
device / profile owner check. TelephonyManager#getSimSerialNumber
was guarded behind these new access requirements, but the same value
is still accessible as the cardString from the SubscriptionInfo.
While getCardString is a hidden API SubscriptionInfo#toString can
be used to obtain this value.

Bug: 152057778
Test: atest SubscriptionControllerTest
Change-Id: I9b8786a321b1ba79d81b74c3041589f30df8e9c8
2020-03-20 13:13:36 -07:00
Sarah Chin
19dc0a5d62 Merge "Update watchdog value" into rvc-dev 2020-03-20 19:40:21 +00:00
Sarah Chin
491ad0510f Fix NPE in updateNrState
Test: build
Bug: 151837748
Change-Id: Ia05cb6b43a79524501821467c510f595f7a64ebe
2020-03-20 11:16:55 -07:00
Philip P. Moltmann
830833053d Pipe through attributeTag for one SMS permission check
Bug: 136595429
Test: TH
Change-Id: I346ac2d3acad0e0d18b298f89f0b96324fc52333
2020-03-20 10:46:07 -07:00
Betty Chang
52a836d49c Merge "Revert "Revert "[Telephony Mainline] To mark @hide for mainline ..."" into rvc-dev 2020-03-20 15:46:42 +00:00
Rambo Wang
e0c4e40512 Add unit test for ClosedSubscriberGroupInfo
Compare homeNodebName based on values instead of references.

Bug: 151976726
Test: atest ClosedSubscriberGroupInfoTest
Change-Id: I15557e673c8b6842a6fc28b6ea814323652a00b8
2020-03-20 06:40:04 -07:00
Xiangyu/Malcolm Chen
b7efa56055 Merge "Fix bug that getBaseBandVersion() may write the value incorrectly." into rvc-dev 2020-03-20 06:12:43 +00:00
Sarah Chin
e2642adac5 Update watchdog value
Test: build
Bug: 149759312
Change-Id: I9e4bdb3a5dd9c6b476540f3c90304657986e17c3
2020-03-19 21:13:31 -07:00
Betty Chang
4ce79c63de Merge "[Telephony Mainline] To mark @hide for mainline module reverting" into rvc-dev 2020-03-20 02:30:50 +00:00
Betty Chang
e40c8c3b29 Revert "Revert "[Telephony Mainline] To mark @hide for mainline ..."
Revert "Revert "[Telephony Mainline] To mark @hide for mainline ..."

Revert submission 10702401-revert-10665971-TML_revertSystemApi-ZNISIHWMFP

Reason for revert: Fixing build by make framework-telephony-stubs-srcs-update-current-api (new txt file has been added for telephony)
Reverted Changes:
I5a320c062:Revert "[Telephony Mainline] To mark @hide for mai...
I0e762e0dd:Revert "[Telephony Mainline] To mark @hide for mai...

Test: make
Bug:151896160

Change-Id: I6f22488aca8f2059d9fb4be48116edc52856a393
2020-03-20 10:13:35 +08:00
TreeHugger Robot
0b6c81800f Merge changes from topic "sms-attributeTag-rvc-dev" into rvc-dev
* changes:
  Set attribution tag in TelephonyManager#sendVisualVoicemailSmsForSubscriber
  Merge "Pipe through attributeTag for one self-permission check" am: 9ed7e7f1b1 am: 1bf1d39fa4 am: 6094f4258e am: 7fd121e139 am: b54512bca9
2020-03-20 02:09:28 +00:00
Sarah Chin
11001c05ce Merge "Add response and indication for CellInfo" into rvc-dev 2020-03-20 01:27:45 +00:00
Malcolm Chen
629f9111f7 Hide APIs exposed for Telephony mainline which is no longer needed in R.
The APIs were added in b/144351078, b/148097978 and b/148116922.
b/151665796 is used to revert them.

Bug: 151665796
Bug: 144351078
Bug: 148097978
Bug: 148116922
Test: build
Change-Id: I08db8c5c0161747a7e775a8de0daa7077b513f10
2020-03-20 01:25:45 +00:00
Philip P. Moltmann
d04383e033 Set attribution tag in TelephonyManager#sendVisualVoicemailSmsForSubscriber
Bug: 136595429
Test: TH
Change-Id: Ifceab355a24d67daa17d3d97a6abd9bb71569a0f
2020-03-19 16:21:26 -07:00
Philip P. Moltmann
f35af1fc36 Merge "Pipe through attributeTag for one self-permission check" am: 9ed7e7f1b1 am: 1bf1d39fa4 am: 6094f4258e am: 7fd121e139 am: b54512bca9
Bug: 136595429
Change-Id: I60bc87fac0070e6d3a749ae5fc8346d9f4f55da8
(cherry picked from commit 24b15eef74)
2020-03-19 16:19:49 -07:00
Malcolm Chen
2bdc9c1fc9 Fix bug that getBaseBandVersion() may write the value incorrectly.
getBaseBandVersion tries to get value from a legacy API and rewrites it
back. However the read value is the full list but the write is to a
specific phone, causing the list to grow unexpectedly.

Bug: 149342541
Test: manual - using test app, call API and check result.
Change-Id: I78b0443c5e38a30010796fcb69f01a8c7ebaf160
2020-03-19 15:50:44 -07:00
TreeHugger Robot
65b857a25c Merge "Fixed the doc" into rvc-dev 2020-03-19 22:48:12 +00:00
Nathan Harold
055ebf2d33 Merge "Remove FIXME that getApnSetting should be NonNull" into rvc-dev 2020-03-19 22:19:45 +00:00
Hall Liu
41d248b927 Merge "Ims: Add <RETRY_CALL_FAIL_REASON> and <RETRY_CALL_FAIL_NETWORK> extras" into rvc-dev 2020-03-19 22:18:11 +00:00
Radhika Agrawal
66a3e59965 Merge "API review comments Test: make Bug: b/150126235" into rvc-dev 2020-03-19 22:09:23 +00:00
Sarah Chin
41b0dcc47c Add response and indication for CellInfo
cellInfoList_1_5
getCellInfoListResponse_1_5
networkScanResult_1_5

Test: atest RILTest
Bug: 151774189
Change-Id: I1ba01eb97f13f843fd27b65d4a2b1049e97ead71
2020-03-19 13:49:02 -07:00