This is done by disabling all the trigger points (the 4 corners). Will
hold off on removing the entire code until later in case needed.
Bug: 179299163
Test: Manual. Dragging from the corner no longer works
Change-Id: I4ed931245cbb49647feeff8b37174f6502fe9c5e
This resulted in a full opacity SurfaceView hanging out behind the bubble scrim. This was not visible when we had an opaque scrim but now that it's transparent again we can see it.
Bug: 184198137
Test: manual
Change-Id: If768ccc9f6dab56764227cffdbbda4f8738d56cc
Bug: 184196634
Test: Enable cutout, move pip and ensure the dismiss scrim ends under
the cutout in landscape
Change-Id: I43003e6acf6b100597080898b162018823b203c5
PipMovesInAllApps was intended to test the PiP window movement when the
shelf height of Launcher changes and breaks with the recent `Device
search` feature that opening all-apps in Launcher triggers both IME and
shelf height change.
Since PipKeyboardTest has covered PiP movement with IME, reimplement
this by launching a new app instead of going to all-apps and also rename
this test for its intention.
Bug: 184050344
Test: atest WMShellFlickerTests:PipShelfHeightTest
Change-Id: I102ea95e6e91c9707b73587282702b868eb705fb
- Don't wait for double tap timeout when clicking to unstash (you can't
double tap while stashed to expand)
- Hide the menu when stashing so that it doesn't show again when
unstashed
- Only log unstash if previously stashed
Bug: 183756396
Test: Tap to show unstashed pip/stash with menu showing
Change-Id: I693b67d38f32d28636ff6b5d0aaf096af78b825b
Menu actions were not clickable because the drag corner resize
handler did not take into account the OHM offset when comparing
the touch location to the PIP bounds, wrongly causing the menu
to be hidden on ACTION_DOWN and thus the menu actions never got
their click listeners fired on ACTION_UP.
Bug: 172839150
Test: Enter PIP with YT, enter OHM, play/pause/expand work fine
Change-Id: I8d1539cef46a5d7c0afe88e80638175cb3994db3
Only the thread which created the menu view (shell main thread) can
update its view layout, so ensuring that it is executed in that sense.
Also moved setup work in PipController to Shell Main thread. Ideally
they should be in ShellInit, but that will need to wait until
tv.PipController can unify with PipController.
Bug: 182418859
Test: Enter PIP
Change-Id: Ib88fefb9320ab441715c6ef3d5cf4f80dc9f022f
Race condition caused pip animation end transition later than
split screen appear transition. Fix it by set to right surface
postiion on on pip side too.
Bug: 172381920
Test: Enter pip and split screen then expand pip
Change-Id: If5470a99385b389af87db1129994610002c035fd
- Tweak calculation of resize bounds, calculate the scale from the change
in distance between the pointers, and scale about the centroid of the
pip
- Fix issue with rotation not being about the center of the pip
- Fix issue with jumping rotation on start of gesture
- Fix issue with animating to top when max bounds are used
- Fix issue with resizing while the menu is open not actually resizing
for a brief period (the menu fading was triggering another pip
animation)
http://recall/-/g6hkB0pXjyQSvfA8STqRAT/cW6W0tdqDzisBndgU2JnM7
Bug: 178881304
Test: Pinch to resize in the cases above
Change-Id: I3bdf535cda64b9ce1926c7081f6cc40d4d79ab69
Previously the assertions were part of WMShell, however it is easier to keep them in the library as they can be used in other projects
Test: atest FlickerTests WMShellFlickerTests
Bug: 162925924
Change-Id: Ia6ca7cce1da81be2b73166acce40218bc304a77a
Ensures no other tasks are executing (cleanup) when a flicker test states to mitigate flakiness
Test: atest FlickerTests WMShellFlickerTests
Bug: 162925924
Change-Id: I84f712c8aba13ac845b9467f6c9753bc91e21a27
Test's currently failing due to the new `device search`, disable for
now to unblock presubmit and re-enable once we have a working solution.
Bug: 184050344
Test: atest WMShellFlickerTests:com.android.wm.shell.flicker.pip
Change-Id: I6b75ea213b442400090ee0a3f2b7e46ee5ecd395
As PiP gets bigger, it should be that user doesn't have to put their
fingers as close as before to the dismiss bubble before it magnetizes
and pulls in PiP.
Bug: 164947242
Test: Manual. Resize PiP to larger and try to drag to dismiss bubble.
Change-Id: I2ec0fbfd87bc010d9ca551df0eeb77a22c02c6dc
Previously OHM did not support for multile user switch
Now we hook SysUI onUserSwitch callback to update
latest one handed mode functionality by currentUserId
Test: atest SystemUITests
Test: atest WMShellUnitTests
Test: manually switch user and observe verify different OHM config
for different users
Bug: 182278800
Change-Id: I8ae7d0aedcafc8f477f41d2703df2df53839a89f
Empty DisplayLayout do not contain navigation bar height
Bug : Cold boot and set 3 Button NavBar Mode, observe
one handed mode can not trigger
Recovery step : Rotate once and the gesture become activate
Fixes: 183951120
Test: create forest and flash ROM, set NavBar 3 Button Mode.
Test: atest WMShellUnitTests
Change-Id: I930216719f77d0e15d46790e02b788ce9cd80e98
