Commit Graph

1129 Commits

Author SHA1 Message Date
Ben Lin
1d57a3b9aa Merge "PiP: Ensure PiP menu layout updates are on Shell main thread." into sc-dev am: 085035f9cc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13933477

Change-Id: I4a45559f031872abe44dac4832273e4477176e59
2021-04-01 18:06:39 +00:00
Ben Lin
085035f9cc Merge "PiP: Ensure PiP menu layout updates are on Shell main thread." into sc-dev 2021-04-01 17:44:52 +00:00
Hongwei Wang
23135f4758 Merge "Flicker test for PiP and launcher shelf height" into sc-dev am: 313a5ed5fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14055865

Change-Id: Id5c061e3f2202dc1c11c991e4bdc280ee32d8e08
2021-04-01 16:42:53 +00:00
Hongwei Wang
313a5ed5fa Merge "Flicker test for PiP and launcher shelf height" into sc-dev 2021-04-01 16:26:44 +00:00
TreeHugger Robot
852f4bf24c Merge "Don't reset Z order if the expanded view is temporarily animated out." into sc-dev am: 3c942191cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14057889

Change-Id: I8a3d95b2077d9575b3113de27b2c6e0ba2978a46
2021-04-01 15:44:58 +00:00
TreeHugger Robot
3c942191cb Merge "Don't reset Z order if the expanded view is temporarily animated out." into sc-dev 2021-04-01 15:35:55 +00:00
Tony Huang
2d28bdf1c0 Merge "Fix black screen while pip to split screen" into sc-dev am: c8b7266594
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13982586

Change-Id: Ie4445e21e0ecd928fda0a2efc40ac4934fd81f81
2021-04-01 06:52:34 +00:00
Tony Huang
c8b7266594 Merge "Fix black screen while pip to split screen" into sc-dev 2021-04-01 06:35:50 +00:00
Winson Chung
9bd83ee894 Merge "More minor menu changes" into sc-dev am: 0aa964394e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14054656

Change-Id: Ief93af1f03c312049e9f436e4f613c7d406fcaad
2021-04-01 06:24:37 +00:00
Winson Chung
0aa964394e Merge "More minor menu changes" into sc-dev 2021-04-01 06:22:11 +00:00
Winson Chung
915cba9381 Merge "Extend pip dismiss overlay to under cutout" into sc-dev am: 5cd74d3d26
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14056110

Change-Id: I35c2ab8dddd040a643e1ba9a2c62054ca11af042
2021-04-01 06:06:55 +00:00
Winson Chung
5cd74d3d26 Merge "Extend pip dismiss overlay to under cutout" into sc-dev 2021-04-01 05:42:48 +00:00
Bill Lin
aa83cc4fe8 Merge "1/ Make One handed mode support multiple user switch" into sc-dev am: f9d740b0dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13851605

Change-Id: I855e7ece30235a85b82a5903bee6d2f9d0ebac02
2021-04-01 02:37:25 +00:00
Bill Lin
f9d740b0dc Merge "1/ Make One handed mode support multiple user switch" into sc-dev 2021-04-01 02:02:39 +00:00
Bill Lin
cb3ed65258 Merge "DisplayLayout set() include copy new mNavBarFrameHeight" into sc-dev am: 9ad3b820be
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14024689

Change-Id: I2ddaa076142c8d27d3c92070fdb4ec177e7730d6
2021-04-01 00:50:14 +00:00
Bill Lin
9ad3b820be Merge "DisplayLayout set() include copy new mNavBarFrameHeight" into sc-dev 2021-04-01 00:31:22 +00:00
Josh Tsuji
47709b1d3a Don't reset Z order if the expanded view is temporarily animated out.
This resulted in a full opacity SurfaceView hanging out behind the bubble scrim. This was not visible when we had an opaque scrim but now that it's transparent again we can see it.

Bug: 184198137
Test: manual
Change-Id: If768ccc9f6dab56764227cffdbbda4f8738d56cc
2021-03-31 23:24:01 +00:00
Jorge Gil
4664af1be0 Merge "Account for OHM offset before possibly hiding the PIP menu" into sc-dev am: 5d2a09adf0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14054950

Change-Id: I75a49dbaf3f60b1c864d7283aa245b149df5ef4a
2021-03-31 22:42:50 +00:00
Winson Chung
4bd615ffa0 Extend pip dismiss overlay to under cutout
Bug: 184196634
Test: Enable cutout, move pip and ensure the dismiss scrim ends under
      the cutout in landscape
Change-Id: I43003e6acf6b100597080898b162018823b203c5
2021-03-31 15:19:20 -07:00
Hongwei Wang
c5d831fea1 Flicker test for PiP and launcher shelf height
PipMovesInAllApps was intended to test the PiP window movement when the
shelf height of Launcher changes and breaks with the recent `Device
search` feature that opening all-apps in Launcher triggers both IME and
shelf height change.

Since PipKeyboardTest has covered PiP movement with IME, reimplement
this by launching a new app instead of going to all-apps and also rename
this test for its intention.

Bug: 184050344
Test: atest WMShellFlickerTests:PipShelfHeightTest
Change-Id: I102ea95e6e91c9707b73587282702b868eb705fb
2021-03-31 13:38:10 -07:00
Winson Chung
3e99b90ab1 More minor menu changes
- Don't wait for double tap timeout when clicking to unstash (you can't
  double tap while stashed to expand)
- Hide the menu when stashing so that it doesn't show again when
  unstashed
- Only log unstash if previously stashed

Bug: 183756396
Test: Tap to show unstashed pip/stash with menu showing
Change-Id: I693b67d38f32d28636ff6b5d0aaf096af78b825b
2021-03-31 13:21:01 -07:00
jorgegil@google.com
1965456d5b Account for OHM offset before possibly hiding the PIP menu
Menu actions were not clickable because the drag corner resize
handler did not take into account the OHM offset when comparing
the touch location to the PIP bounds, wrongly causing the menu
to be hidden on ACTION_DOWN and thus the menu actions never got
their click listeners fired on ACTION_UP.

Bug: 172839150
Test: Enter PIP with YT, enter OHM, play/pause/expand work fine
Change-Id: I8d1539cef46a5d7c0afe88e80638175cb3994db3
2021-03-31 11:43:34 -07:00
Ben Lin
8b70910beb PiP: Ensure PiP menu layout updates are on Shell main thread.
Only the thread which created the menu view (shell main thread) can
update its view layout, so ensuring that it is executed in that sense.

Also moved setup work in PipController to Shell Main thread. Ideally
they should be in ShellInit, but that will need to wait until
tv.PipController can unify with PipController.

Bug: 182418859
Test: Enter PIP
Change-Id: Ib88fefb9320ab441715c6ef3d5cf4f80dc9f022f
2021-03-31 11:02:01 -07:00
Nataniel Borges
eb5c46a23f Merge changes from topic "remove-all-tasks" into sc-dev am: 400197ade7
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13898767

Change-Id: Ie5deb6c271b3f5e5457b3c0a88d9ee32a1a84173
2021-03-31 17:10:23 +00:00
Nataniel Borges
400197ade7 Merge changes from topic "remove-all-tasks" into sc-dev
* changes:
  Ensure apps not running on cold launch test
  Remove all tasks before flicker tests
2021-03-31 16:54:05 +00:00
Ben Lin
b036ac21b2 Merge "PiP: update magnetic field radius for dismissmal as PiP resizes." into sc-dev am: beb4f03369
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13976320

Change-Id: Ic7b4a272a51a2de71d94300cf9692c50fd1deb43
2021-03-31 16:44:16 +00:00
Ben Lin
beb4f03369 Merge "PiP: update magnetic field radius for dismissmal as PiP resizes." into sc-dev 2021-03-31 16:29:22 +00:00
Winson Chung
1d2b2c69dd Merge "Fix some issues with pinch to resize" into sc-dev am: 87a79200bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13993363

Change-Id: I3ad5cd7d6211b46ac6ef067703cf09a9276dd5ed
2021-03-31 16:21:27 +00:00
Winson Chung
87a79200bd Merge "Fix some issues with pinch to resize" into sc-dev 2021-03-31 16:03:23 +00:00
Wei Sheng Shih
22b7e19bac Merge "Prevent the decor view to be visible again after exit animation finish." into sc-dev am: ef355db3ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13929088

Change-Id: I3a7899a1b484b1c072f040d253aa030d198524df
2021-03-31 13:21:15 +00:00
Wei Sheng Shih
ef355db3ec Merge "Prevent the decor view to be visible again after exit animation finish." into sc-dev 2021-03-31 12:56:38 +00:00
Jason Chang
e237d2b224 Merge "Apply "Dominant Palette A - 800" color to the background of One-Handed mode" into sc-dev am: dfe477f26d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14011906

Change-Id: I9e1c5362cc3333d1ca2bfa3fd2cea5cd0606d315
2021-03-31 11:41:02 +00:00
Jason Chang
dfe477f26d Merge "Apply "Dominant Palette A - 800" color to the background of One-Handed mode" into sc-dev 2021-03-31 11:29:11 +00:00
Nataniel Borges
f95a380711 Merge "Move Pip assertions to flickerlib" into sc-dev am: 2935ef01dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13976026

Change-Id: Ia7d8c9f28bcffcfe01ab89f9ca2899fbb8a8959d
2021-03-31 08:14:07 +00:00
Nataniel Borges
2935ef01dc Merge "Move Pip assertions to flickerlib" into sc-dev 2021-03-31 07:54:24 +00:00
Jason Chang
c15df4e3ac Apply "Dominant Palette A - 800" color to the background of
One-Handed mode

Change the One-Handed mode background color to
Dominant Palette A - 800. (#3C4043)

Bug: 177314967

Test: manual
Test: atest WMShellUnitTests
Change-Id: I68852d362f6f425832d36f3e60c2a41b9e505216
2021-03-31 15:11:16 +08:00
Tony Huang
71784f2ad4 Fix black screen while pip to split screen
Race condition caused pip animation end transition later than
split screen appear transition. Fix it by set to right surface
postiion on on pip side too.

Bug: 172381920
Test: Enter pip and split screen then expand pip
Change-Id: If5470a99385b389af87db1129994610002c035fd
2021-03-31 14:56:23 +08:00
Bill Lin
e12d300118 Merge "Dispatch newDisplayLayout in updateDisplayLayout() directly" into sc-dev am: eb4158fbb0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14018009

Change-Id: Ibe5ae681acef7047d33eddf8b4ca137cfd9d615c
2021-03-31 06:54:35 +00:00
Bill Lin
eb4158fbb0 Merge "Dispatch newDisplayLayout in updateDisplayLayout() directly" into sc-dev 2021-03-31 06:53:40 +00:00
Winson Chung
59415ea448 Fix some issues with pinch to resize
- Tweak calculation of resize bounds, calculate the scale from the change
  in distance between the pointers, and scale about the centroid of the
  pip
- Fix issue with rotation not being about the center of the pip
- Fix issue with jumping rotation on start of gesture
- Fix issue with animating to top when max bounds are used
- Fix issue with resizing while the menu is open not actually resizing
  for a brief period (the menu fading was triggering another pip
  animation)

http://recall/-/g6hkB0pXjyQSvfA8STqRAT/cW6W0tdqDzisBndgU2JnM7

Bug: 178881304
Test: Pinch to resize in the cases above
Change-Id: I3bdf535cda64b9ce1926c7081f6cc40d4d79ab69
2021-03-30 21:55:25 -07:00
wilsonshih
e697b8176c Prevent the decor view to be visible again after exit animation finish.
Fix the flicker when WindowState#removeIfPossible apply exit animation.

Test: atest SplashscreenTests SplashscreenTests
Bug: 183004107
Bug: 182815506
Change-Id: I3ac4ad98ab9e9c295f78ba6f86e1e02f2067163b
2021-03-31 11:30:55 +08:00
Jorge Gil
041b6c7658 Merge "Check that the PiPParams are not null before getting seamless flag" into sc-dev am: 68a6b1a97b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14022621

Change-Id: I39d6e7e9c10672bafc67ba1db263bc33c30d6a89
2021-03-31 00:55:49 +00:00
Jorge Gil
68a6b1a97b Merge "Check that the PiPParams are not null before getting seamless flag" into sc-dev 2021-03-31 00:22:54 +00:00
Winson Chung
3509b2e4b7 Merge "Separate BubblesController construction from initialization" into sc-dev am: 48a183c5bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13979040

Change-Id: I8babcbed8c3c4ad062d0cc1aeb9c717bde2dd1d0
2021-03-30 23:50:47 +00:00
Winson Chung
48a183c5bd Merge "Separate BubblesController construction from initialization" into sc-dev 2021-03-30 23:45:11 +00:00
Jorge Gil
7ccc027761 Merge "Account for OHM offset during PIP drag corner resize" into sc-dev am: 5ec8620a0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13974202

Change-Id: Ib2546b64b21800df1ca2c568fc8f474c32c0d4f6
2021-03-30 23:16:32 +00:00
Evan Rosky
bdf238eb78 Merge "Add one-shot remote handler and remote runner interface" into sc-dev am: 0bdcf9b9c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13991315

Change-Id: Ib5a5895afcee7723c9cf534246d043b5dccb0e6b
2021-03-30 23:16:17 +00:00
Winson Chung
2497545cc0 Merge "Only unlink death recipient if binder was previously added" into sc-dev am: b2724e8cb9
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13976247

Change-Id: I90730608e15e09696960a3585cb5337cfa95fe21
2021-03-30 23:15:21 +00:00
Winson Chung
f0dc69a111 Merge "Minor pip menu changes" into sc-dev am: e7802702ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13999967

Change-Id: I43e3d16f11fdbde33539fb78900e1c3225d146c4
2021-03-30 23:14:59 +00:00
Jorge Gil
ee34715824 Merge "Don't skip cleaning up PIP state in onTaskVanished even if EXITING_PIP" into sc-dev am: af38d60afe
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14021515

Change-Id: Ie351c1b13632afae6caa5b5793a195ee489973ae
2021-03-30 23:11:31 +00:00