Commit Graph

1243 Commits

Author SHA1 Message Date
Ching-Sung Li
f8d48b0316 DO NOT MERGE Add feature flag for PixelLiveWallpaper dogfood in Settings
Add feature flag (settings_pixel_wallpaper_category_switch) in developer
option for PixelLiveWallpaper's dogfood user to turn downloadable Live
wallpaper's category on or off. Expected expiration on: 2019/07/31.

Bug: 128962566
Test: Manual check this feature flag in developer option
Change-Id: Ie9d9180605cf92cf5618999d5a76f4fd87875859
2019-04-09 01:14:47 +00:00
Howard Ro
2470fdb507 Merge "More description on logBinaryPushStateChanged" into qt-dev 2019-04-08 21:19:35 +00:00
Svet Ganov
d8eb8b2690 Restricted permission mechanism - framework
This change adds a mechanism for restricting permissions (only runtime
for now), so that an app cannot hold the permission if it is not white
listed. The whitelisting can happen at install or at any later point.

There are three whitelists: system: OS managed with default grants
and role holders being on it; upgrade: only OS puts on this list
apps when upgrading from a pre to post restriction permission database
version and OS and installer on record can remove; installer: only
the installer on record can add and remove (and the system of course).

Added a permission policy service that sits on top of permissions
and app ops and is responsible to sync between permissions and app
ops when there is an interdependecy in any direction.

Added versioning to the runtime permissions database to allow operations
that need to be done once on upgrade such as adding all permissions held
by apps pre upgrade to the upgrade whitelist if the new permisison version
inctroduces a new restricted permission. The upgrade logic is in the
permission controller and we will eventually put the default grants there.

NOTE: This change is reacting to a VP feedback for how we would handle
SMS/CallLog restriction as we pivoted from role based approach to roles
for things the user would understand plus whitelist for everything else.
This would also help us roll out softly the storage permisison as there
is too much churm coming from developer feedback.

Exempt-From-Owner-Approval: trivial change due to APi adjustment

Test: atest CtsAppSecurityHostTestCases:android.appsecurity.cts.PermissionsHostTest
Test: atest CtsPermissionTestCases
Test: atest CtsPermission2TestCases
Test: atest RoleManagerTestCases

bug:124769181

Change-Id: Ic48e3c728387ecf02f89d517ba1fe785ab9c75fd
2019-04-07 22:39:54 -07:00
Howard Ro
74ac91a932 More description on logBinaryPushStateChanged
Provides more descriptive documentation for 'options' and 'state'
parameters when calling StatsLog#logBinaryPushStateChanged

Bug: 129768469
Fix: 129768469
Test: n/a
Change-Id: I4b06cc2618258e8e24a26c4616658ce8f146e133
2019-04-07 18:34:37 -07:00
TreeHugger Robot
1ccf640d56 Merge "Remove mainline settings feature flag." into qt-dev 2019-04-05 23:33:16 +00:00
Fan Zhang
9d9369543b Remove mainline settings feature flag.
Fixes: 123648279
Test: rebuild
Change-Id: Iec229482cc249b9fcf1b3e7ec4a3d3c6f7fa8e2c
2019-04-05 14:30:31 -07:00
Susi Kharraz-Post
a7f614519e Fast follow-on unit tests for HashedStringCache
Unit tests for HashedStringCache that was commited in earlier CL
ag/6867725 . This is testing the various inputs and expected outputs.
Testing also revealed some vulnerability for invalid input so added
validation in the code under test.

Bug: b/129870147
Test: This is the test file
Change-Id: I7387f808df87a869f81339cd4aea99b23dfc06bd
2019-04-04 15:15:33 -04:00
Susi Kharraz-Post
0c70be6738 Merge "Add logging for direct share target" 2019-04-04 00:03:56 +00:00
TreeHugger Robot
2ae133285b Merge "Fix Global Actions animations, and use old power menu when panel is disabled. Also tweak feature flags setup to use old flag as a force option for debugging." 2019-04-03 22:36:29 +00:00
Susi Kharraz-Post
14cbfcdbd0 Add logging for direct share target
To answer the question if users share mainly with 1 or 2 direct targets
or with a multitude of contacts, we need to log the direct target +
package name. For privacy, this gets hashed with a salt that expires by
default every 7 days. The PH flag will allow us to change the expiration
time if we obtain PWG permission for that.

Bug: 126365511
Test: New test in ChooserActivityTest + manual testing of consistency
and flag rollout using adb shell device_config put systemui
hash_salt_max_days with multiple values

Change-Id: Ib4255b3eb39ca91ccb5803dc036ffe0ea83a27c9
2019-04-03 17:54:25 -04:00
Aaron Heuckroth
c792661840 Fix Global Actions animations, and use old power menu when panel is disabled.
Also tweak feature flags setup to use old flag as a force option for debugging.

Test: Automated tests pass. Long-press power menu without plugin installed from different device orientations -- menu should animate in from the closest screen edge in all orientations and rotate correctly when device is rotated. Repeat after enabling the settings_global_actions_force_grid_enabled option in Feature Flags to ensure the correct behavior persists when using the new grid layout.

Fixes: 126444760
Fixes: 129698948

Change-Id: I9ac387244a5904f832c5d8b6c40362c00c6a22a2
2019-04-03 16:33:55 -04:00
Po-Chien Hsueh
2d204b3985 Merge changes from topic "dyn_system_ff"
* changes:
  Use setEnable() when there is an installed image
  Use gsid.isGsiEnabled to refine DynamicSystemService
  Use FeatureFlagPersistent to guard DynamicSystem
  Make feature flag settings_dynamic_system persistent
2019-04-03 07:55:55 +00:00
Po-Chien Hsueh
c5b6931f27 Make feature flag settings_dynamic_system persistent
Bug: 119647479
Test: turn on/off feature flag and use DynamicSystem
Change-Id: I2b2591f7a937cbe74d67cbfb95b778d2cfa32abb
2019-04-03 10:29:31 +08:00
Andrew Sapperstein
4e4768b989 Merge "Default enable feature flag for Safety Hub" 2019-04-02 17:32:25 +00:00
TreeHugger Robot
8ad3e75bb1 Merge "Revert "Revert "Checkng upper bound in *Array classes.""" 2019-04-01 21:31:15 +00:00
yuanjiahsu
bc63cbda00 Default enable feature flag for Safety Hub
Default enable feature flag for Safety Hub Droidfood.

Test: Manually
Bug: 118809382
Bug: 129240579
Change-Id: Ibd38c0354d3b3dd0041b3d22d5b3f04277f54009
2019-04-01 08:54:27 +00:00
Kweku Adams
025a1664ab Revert "Revert "Checkng upper bound in *Array classes.""
This reverts commit 91ec970564.

Reason for revert: b/128433495

Change-Id: I4aac43f6aacd594f9c2bf58db9fbc4a1395d8888
2019-03-30 00:03:17 +00:00
Tej Singh
e5f5a10478 Merge "Public StatsLog API for generic mainline logging." 2019-03-23 05:00:52 +00:00
TreeHugger Robot
8620836456 Merge "[Passpointv2] Enable saved network showing detailed page" 2019-03-22 22:46:15 +00:00
TreeHugger Robot
c396d6738c Merge "API review followup: DynamicAndroidClient" 2019-03-22 17:21:39 +00:00
Andrei-Valentin Onea
bb5089fbd9 Merge "Add @UnsupportedAppUsage annotations" 2019-03-21 19:11:51 +00:00
Andrei Onea
e30e3928f9 Add @UnsupportedAppUsage annotations
For packages:
  android.companion
  android.filterfw
  android.hardware.camera2.utils
  android.inputmethodservice
  android.net.nsd
  android.os
  android.preference
  android.security.keymaster
  android.service.dreams
  android.telecom
  android.telephony.ims.compat.feature
  android.telephony
  android.util
  android.view.accessibility
  android.media.effect

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: I9c2f8347952f3cc65759472b0e1a2717b285e44e
2019-03-21 14:04:57 +00:00
Po-Chien Hsueh
4e908c24ca API review followup: DynamicAndroidClient
Some API changes per API reivew:
- Move DynamicAndroidClient and ~Manager to android.os.image.
- Rename them to DynamicSystemClient and ~Manager.
- Rename permission MANAGE_DYNAMIC_ANDROID to MANAGE_DYNAMIC_SYSTEM
- Corresponding changes in the installation service.
- Corresponding changes in privapp-permissions-platform.xml.
- Add missing annotations.
- Change setOnStatusChangedListener's parameters order.
- Improve documentations.
- Re-generate api/system-current.txt.

Bug: 126613281
Test: adb shell am
Change-Id: Ia920e9ccf6de1dbbd38c52910cb72cb81b9b5b32
2019-03-21 17:25:59 +08:00
cosmohsieh
9ca5102ce8 [Passpointv2] Enable saved network showing detailed page
Enable this feature as default. Shows detail wifi page when clicking
saved network.

Bug: 116362877
Test: manual
Change-Id: I4f8f469967e6f45b20941fbff5f4590a2ccc4063
2019-03-21 05:14:24 +00:00
Tej Singh
be0482b421 Public StatsLog API for generic mainline logging.
Sets up a public api for logging atoms to statsd. The API excepts a
buffer which is already encoded in the proper format for the socket, as
well as the number of bytes of the buffer to write. It performs a JNI
call to perform the socket write. Autogenerated app code will be built
for each mainline module that needs to use this API to log.

Test: builds
Test: existing logs flow properly
Bug: 126134616
Change-Id: I8a9a91e638d730e3ff69cb9345692e49e0db3c96
2019-03-20 17:44:53 -07:00
Fan Zhang
a70a59b945 Revert "Revert "Enable mainline module feature.""
This reverts commit 52e966e996.

Reason for revert: b/123648279
Test: TH

Change-Id: I0a79535be95a92555c32d94219f3b98a9579815f
2019-03-20 13:19:22 -07:00
Fan Zhang
0afbc9f0a3 Merge "Update feature flag mapping owners" am: 16eab7c16d am: 6d52af0b55
am: 1e932cf89c

Change-Id: I12118dae5a391e762176b5b09c590d30786bec3b
2019-03-15 12:41:20 -07:00
Fan Zhang
bfa1f876e8 Update feature flag mapping owners
Test: rebuild

Change-Id: I288e039ffaf88ce271ba17bcc26f0e038314b354
2019-03-14 16:26:05 -07:00
cosmohsieh
205e5b990d [PasspointV2] Add feature flag for showing data usage chart on detail fragment
Add flag for showing data usage chart on detail fragment

Bug: 128569047
Bug: 124700353
Test: manual
Change-Id: Ib150c4d72224b5707c16916d4e134aa5221a481f
2019-03-14 05:54:04 +00:00
TreeHugger Robot
5d682a61ae Merge "Revert "Checkng upper bound in *Array classes."" 2019-03-12 21:54:07 +00:00
TreeHugger Robot
83234be184 Merge "[MAC Randomization] Removed feature flag to align framework global flag" 2019-03-12 19:17:50 +00:00
Paul Scovanner
91ec970564 Revert "Checkng upper bound in *Array classes."
This reverts commit 17d453ea85.

Reason for revert: b/127750694

Change-Id: I0ffbf0e64109b3ec724e0687a27b231e335f76b4
2019-03-12 18:03:48 +00:00
cosmohsieh
b46623a3ea [Passpointv2] Add feature flag for saved network show details fragment
Add feature flag for saved network show details fragment

Bug: 128369527
Test: Manual
Change-Id: I661a923b4866c4595a5ad5d5fe2964a72def3952
2019-03-12 14:46:41 +08:00
cosmohsieh
59ea1f7ca1 [MAC Randomization] Removed feature flag to align framework global flag
Removed feature flag and change to check global flag as framework MAC
randomization api does.

Bug: 127817791
Bug: 120743100
Test: atest WifiPrivacyPreferenceControllerTest
Change-Id: Iefe0d442326ca6a9461af8724a1632fd238d8d2b
2019-03-12 03:54:49 +00:00
TreeHugger Robot
fcba01e838 Merge "Revert "Revert "Set the "settings_network_and_internet_v2" flag to on by default""" 2019-03-09 02:54:51 +00:00
Antony Sargent
45c44fc882 Revert "Revert "Set the "settings_network_and_internet_v2" flag to on by default""
This reverts commit c9a5c72ab8.

Reason for revert: The underlying problem for the *original* revert is fixed in ag/6671099, so now we can revert the revert (after ag/6671099 lands). 

Change-Id: I01e5ebac8140b253bee9d19981eff53365d3bccd
2019-03-08 23:20:58 +00:00
Chiachang Wang
9afd64ede8 Merge "Support DATA_STALL_EVENT in StatsLog.write" 2019-03-07 05:37:23 +00:00
TreeHugger Robot
9bef843cef Merge "Checkng upper bound in *Array classes." 2019-03-06 22:08:20 +00:00
TreeHugger Robot
56ff8c44a5 Merge ""Global Actions Panel" plugin" 2019-03-06 18:34:35 +00:00
Fan Zhang
516218f9b2 Merge "Revert "Set the "settings_network_and_internet_v2" flag to on by default"" 2019-03-06 18:03:59 +00:00
Antony Sargent
c9a5c72ab8 Revert "Set the "settings_network_and_internet_v2" flag to on by default"
This reverts commit 1b386491c5.

Reason for revert: Reverting temporarily because of a few bugs that were uncovered: b/127524919 and b/127394263

Change-Id: I47de22c89b680d08c62fb008f97953d0586ab0a3
2019-03-06 18:02:48 +00:00
Steve Elliott
9b87a44b79 "Global Actions Panel" plugin
This change adds a new plugin API surface inside of Global Actions,
where a plugin can provide a View to be rendered alongside the Global
Actions menu.

When the GlobalActionsDialog.ActionDialog is created, the plugin can
produce a GlobalActionsPanelPlugin.PanelViewController instance, which
is used to provide the View to be rendered, and respond to Global
Actions events (right now, only dismissal). At this time, the plugin
is given an instance of GlobalActionsPanelPlugin.Callbacks, allowing
the plugin to interact with the GlobalActionsDialog (right now, only
to request dismissal).

When there is a Panel present, a darker scrim is used that is *not*
based on the colors underneath.

In order to provide maximum flexibility, the View comprising the Panel
is rendered above (z-ordering) the existing Global Actions menu, and
can take up the entire screen if desired. In practice, plugins should
take care to not block access to the GlobalActions menu.

Change-Id: I9d6eea80f7eb49e9adbc1a634f7d9c1ab720cddb
Test: manual
2019-03-06 11:30:58 -05:00
Satoshi Sanno
83950247d0 Merge "Fix that the update to v1 signed version fails if apk verity is enabled" am: 0b3fe647ef am: b6fd88c4fc
am: 6f113ecebe

Change-Id: Iaf80875375068f17fe12f8846fae8c5afc2cbc2f
2019-03-05 18:21:49 -08:00
Kweku Adams
17d453ea85 Checkng upper bound in *Array classes.
*Array classes will now throw an IndexOutOfBoundsException if a caller
tries to get or set a value for an index that's invalid based on the
current size.

Bug: 118339123
Test: atest CtsUtilTestCases
Change-Id: Iddc9a0c7c89e0ac743b0380049527a1b2dfb434f
2019-03-05 15:40:12 -08:00
Treehugger Robot
0b3fe647ef Merge "Fix that the update to v1 signed version fails if apk verity is enabled" 2019-03-05 21:33:25 +00:00
Antony Sargent
1b386491c5 Set the "settings_network_and_internet_v2" flag to on by default
Bug: 116349402
Test: (should be covered by existing tests)
Change-Id: I942a11bb20aea3179c414012ff7c39a1cffbc07f
2019-03-04 16:27:06 -08:00
Jeff Sharkey
ac4eafc9cf Merge "Mark @Nullable annotation to String parameter" 2019-03-04 17:33:32 +00:00
Svetoslav Ganov
2a980300bc Merge "Slice and dice app ops - framework" 2019-03-04 17:22:20 +00:00
shawnlin
e40033eb24 Mark @Nullable annotation to String parameter
Test: make, make system-api-stubs-docs-update-current-api
Bug: 126700130
Change-Id: I89b9bf726bda3241cf8bfb4737d2c25cb65b8369
2019-03-04 17:01:34 +08:00
Hugo Benichi
df44944fe6 Merge "LocalLog: add overloaded dump and reverseDump methods." am: 7c447498c3 am: 0357a9ca4c
am: 5121df9b61

Change-Id: I89cb6300ae6c86e790df702fbdf3416b2f242cd9
2019-03-03 18:19:39 -08:00