Commit Graph

14520 Commits

Author SHA1 Message Date
TreeHugger Robot
046f2c80ae Merge "Keep RemoteInputView visible when focused" into nyc-dev 2016-05-10 17:41:59 +00:00
Jason Monk
c62cf80faa Fix accessibility order in nav bar
Change-Id: I2e90dee8e50b0642f39258fe3d04ded2f0bb8961
Fixes: 28281859
2016-05-10 11:19:48 -04:00
Selim Cinek
9688c2edc9 Merge "Fixed a memory leak with notification children" into nyc-dev 2016-05-10 03:03:09 +00:00
Selim Cinek
7103fd44a8 Fixed a memory leak with notification children
Children where not removed from the stackscrollstate as
their removal was blocked when removing a group.

Change-Id: I0a3bbb91d0df2693e1ec7e89276c8714636a34ad
Fixes: 28670320
2016-05-09 22:22:33 -04:00
Selim Cinek
b745a89c1f Merge "Fixed an issue where clearing transient views could ANR" into nyc-dev 2016-05-09 23:33:15 +00:00
Adrian Roos
181385ce33 Keep RemoteInputView visible when focused
Scrolls the NotificationStackScrollLayout in response to movement
to ensure that the focused view stays visible. Also makes sure that
the action list is always aligned at the bottom of the notification
to avoid jank during this scrolling when the height changes.

Fixes: 28193862
Fixes: 26919632
Change-Id: I911a873367fe26eafd9fae4bca4e693d0827eba7
2016-05-09 23:30:26 +00:00
Selim Cinek
3e04c56432 Merge "Fixed a crash with min-priority notifications in a group" into nyc-dev 2016-05-09 23:19:28 +00:00
Selim Cinek
81f26d332c Fixed an issue where clearing transient views could ANR
It could lead to an infinite loop because it was called on
the wrong view.

Change-Id: Ie8008114474eccf2c0a4b930a5299eb6be1247c1
Fixes: 28634521
2016-05-09 18:54:10 -04:00
Selim Cinek
06416b9e57 Fixed a crash with min-priority notifications in a group
Those notifications could get into a group with higher priority
because they were autobundled or if the app said so.
This could lead to invisible views on the lockscreen and a crash
when this happened in an animated fashion.
The bug was triggering old code that wasn't needed anymore that
removed the viewstate.

Change-Id: Ic86c2f03d55f2e98e352cdbfbb3ca80d8e676765
Fixes: 28611831
2016-05-09 16:43:37 -04:00
Selim Cinek
f9f48ecd4c Merge "Fixed a concurrent modification crash" into nyc-dev 2016-05-09 20:42:53 +00:00
TreeHugger Robot
ed47cf23e8 Merge "Fixed a bug where notifications could become orphaned" into nyc-dev 2016-05-09 20:33:14 +00:00
Selim Cinek
319eecff96 Merge "Fixed a bug where the statusbar could become empty" into nyc-dev 2016-05-09 19:02:56 +00:00
Selim Cinek
fa2dc63505 Merge "Fixed a bug where Notifications could overlap" into nyc-dev 2016-05-09 19:02:31 +00:00
TreeHugger Robot
8a111f5f20 Merge "Change ForcedResizableInfoActivity to handle config. changes" into nyc-dev 2016-05-09 18:22:15 +00:00
Selim Cinek
c0b14b0e89 Fixed a concurrent modification crash
Because notifications could become isolated when
the group is suppressed it could lead to concurrent
modifications while looping.

Change-Id: Ifd4fe0cc24110455de0d3edf2da0be0773eb8c67
Fixes: 28652038
2016-05-09 13:13:58 -04:00
Selim Cinek
52941c5618 Fixed a bug where notifications could become orphaned
When a child got set not be a heads up after it was already
removed (When for example it was clicked on shortly after
it got posted) then it got orphaned leading to bad bugs
like the next notification not being visible. This
could happen often with WhatsApp who set the head up flags
on the summary instead of the children.

Change-Id: I52c8f5d9bc50080e4ece530255236d36f998372e
Fixes: 28565942
2016-05-09 13:13:56 -04:00
Jaewan Kim
ccb85eb411 Merge "Fix recents row blinking when PIP is focused" into nyc-dev 2016-05-09 17:05:54 +00:00
Jason Monk
d4bdf9ca7c Merge "QQS: Fix ripple clipping" into nyc-dev 2016-05-09 13:20:20 +00:00
Wale Ogunwale
3840c88938 Change ForcedResizableInfoActivity to handle config. changes
This created extra churn in the system during resize due to
the activity relaunching.

Bug: 28614747
Change-Id: I148b6fca3dad7e10c90085a04bccb99587397912
2016-05-07 14:13:52 -07:00
Felipe Leme
d31a97fd83 Fixed connectivity state in some restricted network scenarios.
NetworkPolicyManagerService (NMPS) keeps an internal list of uid
rules (mUidRules) for network restrictions, and when these rules
changes it needs to notify external listeners (such as
ConnectivityService / CS).

Prior to Android N, both Data Saver mode (the feature previously known
as "Restrict Baground Data") and Battery Save mode used the same set of
firewall rules to implement their restrictions: when Battery Saver mode
NPMS would mark all networks as metered and set the proper firewall
rules externally.

Recently, these 2 modes were split in 2 distinct firewall rules and
NMPS.updateRuleForRestrictBackgroundLocked() was changed to update
the mUidRules logic based on the Data Saver firewall (since the Battery
Saver firewall changes are handled externally, on
updateRuleForRestrictPowerLocked()). As such, CS was not notified when
the power-related changes were made, which would cause apps to get a
state of CONNECTED / CONNECTED when querying its active connection.

Another scenario that is not properly handled is when a UID whitelisted
for Data Saver is brought back to foreground: although the proper
firewall rules are set, CS is not notified, and the apps state would be
DISCONNECTED / BLOCKED.

This CL introduces many changes that fix this issue:

- Fixed updateRuleForRestrictBackgroundLocked() to invoke
  onUidRulesChanged() when the Battery Saver status changed.
- Fixed updateRuleForRestrictBackgroundLocked() to invoke
  onUidRulesChanged() when an app whitelisted for Data Saver is brought
  back to the foreground.
- Added a new API (onRestrictPowerChanged() and getRestrictPower())
  to notify external services about Battery Saver mode changes.
- Fixed CS logic to properly handle the Battery Saver changes.

Externally to this change, the CTS tests were also improved to verify
the apps get the proper connection state; they can be verified running:

cts-tradefed run commandAndExit cts -m CtsHostsideNetworkTests \
    -t com.android.cts.net.HostsideRestrictBackgroundNetworkTests

BUG: 28521946

Change-Id: I8eaccd39968eb4b8c6b34f462fbc541e5daf55f1
2016-05-06 14:53:50 -07:00
Sid Soundararajan
4fd98d1f09 Merge "Reset Cards as they come into view" into nyc-dev 2016-05-06 21:16:56 +00:00
Winson
27c28f8da2 Fix exception when docking task.
- If a task fails to dock, animate the stack back to original state so 
  that the layout is not stuck in a "docked" state.

Bug: 28577229
Change-Id: If927b898a48cd5949764cb3b0c0798d22efd850a
2016-05-06 20:51:55 +00:00
Winson Chung
7e2d589ce0 Merge "Disabling movement of entire affiliated task set." into nyc-dev 2016-05-06 20:50:13 +00:00
Keisuke Kuroyanagi
a423e2535b Merge "Fix: Cannot control ime_switcher and menu after resetting." into nyc-dev 2016-05-06 19:52:48 +00:00
Sid Soundararajan
061f81e7b0 Reset Cards as they come into view
This will ensure that they are in the correct configuration. Needed since
recycler view will be re-using views.

BUG:28632740
Change-Id: Icdaa48696e198cfeb8c37718fec05f7f9b195842
2016-05-06 11:55:25 -07:00
Winson
6976f7bae9 Disabling movement of entire affiliated task set.
- This CL removes the dependency on the last-active-time of the task
  record, since that is dependent on the current system time (which can
  be changed by the user).  Instead of working around the previous
  behavior in ActivityManager which moves all affiliated tasks to the
  top when one task is launched, we change the behavior in the AM
  directly, and prevent re-sorting the list of recent tasks improperly
  (aside from the stable sort which puts the freeform tasks first).

Bug: 27398177

Change-Id: I9fa9b3497d08082fe00aa724538255de87e746d6
2016-05-06 18:53:05 +00:00
Jason Monk
4987524b27 QQS: Fix ripple clipping
Change-Id: Ib29265ca582e8563277466edefb32b0a5c852b2f
Fixes: 28175282
2016-05-06 14:44:25 -04:00
Jason Monk
5df0ee53ac Merge "QS Header: remove collapsed alarm ripple" into nyc-dev 2016-05-06 18:36:00 +00:00
TreeHugger Robot
5d6a218d9e Merge "Dismiss docked stack if an activity is shown on top of the lock screen" into nyc-dev 2016-05-06 18:30:23 +00:00
Keisuke Kuroyanagi
47bd7333e1 Fix: Cannot control ime_switcher and menu after resetting.
mButtonDispatchers contains ButtonDispatcher for ime_switcher and menu;
however, in #inflateButton, we tried to find ButtonDispatcher for
menu_ime, which is a FrameLayout containing ime_switcher and menu.
Therefore, after #clearViews and #inflateLayout, ime_switcher and menu
KeyButtonView are not in the corresponding ButtonDispatchers.
It means NavigationBarView#getImeSwitchButton and
NavigationBarView#getMenuButton returns empty ButtonDispatcher.
As a result, we can't control ime switch button and menu button via
NavigationBarView after then.  e.g. We can't control ime switch button
visibility.

This CL fixes that issue by calling #addToDispatchers recursively for
ViewGroup children if corresponding ButtonDispatcher is not found.  This
behavior is aligned with #addAll.

Bug: 28580774

Change-Id: Ibe724753390b7bbb395a6d53d00bc6d06d00aa9a
2016-05-06 10:49:54 -07:00
Jorim Jaggi
3273f31c40 Also notify divider when getting DockedTopTaskEvent
Under some circumstances we never go through the activity lifecycle
if we call startActivity before it gets stopped, so we never notified
the divider about that we have drawn.

Bug: 28531536
Change-Id: I6a13527d52bf40a87f89de4b2799bd0833c6612a
2016-05-06 17:20:59 +00:00
Wale Ogunwale
9973294080 Dismiss docked stack if an activity is shown on top of the lock screen
It is risky/complicated to try to put the activity showing on-top of
the lock screen in the right fullscreen configuration with the current
architecture. So, we just dismiss for now.

Bug: 28195260
Change-Id: I29a0350993ce8fe548d4a465b06d877cde151c78
2016-05-06 10:13:14 -07:00
Julia Reynolds
20aef8a291 Quicksettings accessibility.
Bug: 15696340
Change-Id: I6887e2dad4822911d3a1642aaec5703174b57330
2016-05-06 10:24:38 -04:00
Winson
f9e79e0499 Fix edge case crash with invalid bitmap dimensions.
- In these cases, skip returning an animation spec for that task

Bug: 28235453
Change-Id: I611dc4390c0cbd2ca5f16112e4784848b2d6896f
2016-05-06 00:35:10 +00:00
Selim Cinek
50e7467eb6 Fixed a bug where the statusbar could become empty
Because fullscreen intent notifications could suddenly
become children.

Change-Id: I2eb8f2bf671b5d039ac3493f281debbe730dc828
Fixes: 28166429
2016-05-05 15:58:10 -04:00
Jason Monk
8e788d015c Merge "QS Edit: fix some move logic" into nyc-dev 2016-05-05 19:51:55 +00:00
Jason Monk
b8ae788f07 QS Header: remove collapsed alarm ripple
Its no longer a button, so it shouldn't act like one.

Change-Id: Iac78f80bb0e99fd4d6135f6c1ceac9bc96c7cc8e
Fixes: 28611090
2016-05-05 14:36:57 -04:00
Jason Monk
a8f07d916d QS Edit: fix some move logic
Make sure its possible to add tiles when none are there and remove
tiles when all are added.

Bug: 28067638
Change-Id: Ia5a145f095cd33cf8d4a85a0a8aabb2344e3dec6
2016-05-05 13:11:36 -04:00
Selim Cinek
cfcd23e61b Fixed a bug where Notifications could overlap
Change-Id: Ic7f9599cee95411e1207b609e584038ad8cb4d99
Fixes: 28550654
2016-05-05 12:31:42 -04:00
Jason Monk
4a19a2043c Merge "Fix QS crash with RTL rotate" into nyc-dev 2016-05-05 15:42:43 +00:00
Jason Monk
c665a3d4e9 Merge "Fix QS edit accessibility" into nyc-dev 2016-05-05 15:41:34 +00:00
Jason Monk
d27ed8b336 Merge "QS Edit: announce exit/entrance" into nyc-dev 2016-05-05 15:41:07 +00:00
Jason Monk
f3bd7a300f Fix QS header settings + user visibilities
Change-Id: If2b5fb2ab47254bb0e44685a0fcd5d92d5d347fb
Fixes: 28235542
2016-05-05 10:15:25 -04:00
Jaewan Kim
92e5a0dfa6 Merge "Fix thumbnail transition animation when Recents is shown with PIP" into nyc-dev 2016-05-05 04:57:35 +00:00
TreeHugger Robot
4e0114742a Merge "Don't resize task when dismissing docked stack" into nyc-dev 2016-05-05 02:07:28 +00:00
Jorim Jaggi
069dfe67a2 Don't resize task when dismissing docked stack
Make sure to "freeze" bounds while dismissing the docked stack by
either maximizing or minimizing it.

Bug: 28196862
Change-Id: Ifcd9deda340de8bc46df949df2fa1049e2f45f92
2016-05-04 17:24:47 -07:00
Jorim Jaggi
f28b23416e Merge "Add dump information for divider" into nyc-dev 2016-05-05 00:00:03 +00:00
Winson
ae165154a2 Fixing issue with passing arguments to toggle recents.
Bug: 28598762
Change-Id: I38edd34ae158abd97b28c82e700f3e020e81af75
2016-05-04 23:58:48 +00:00
Winson
d7cb517b4c Fixing regression in enter-recents state.
- We should always start the activity when docking to ensure that the
  launch state is set up correctly.

Bug: 28470261
Change-Id: I4aae0dedb95a1c796c72b487b6700da0754e66f3
2016-05-04 23:58:06 +00:00
Jorim Jaggi
31f71705df Add dump information for divider
Bug: 28575870
Bug: 28445644
Change-Id: Ib2137c49f1672ed2a9e7e31a5b68c22e0bb166b1
2016-05-04 16:43:04 -07:00