Commit Graph

2232 Commits

Author SHA1 Message Date
satok
594cb47654 Merge "Use user's settings for the spell check language instead of the system locale" 2011-09-30 01:52:40 -07:00
satok
70deff4c10 Use user's settings for the spell check language instead of the system locale
Bug: 5390462
Change-Id: Ia2a3981cb93f451646debe5ee6b037313825cf9f
2011-09-30 17:49:40 +09:00
Luca Zanolin
af43add388 Merge "The x and y position of the pop-up where not calculated correctly when the text view had internal scrolling." 2011-09-30 01:01:35 -07:00
Svetoslav Ganov
2783b4fa43 Merge "ActivityChooserView shows "see all" improperly." 2011-09-29 17:54:22 -07:00
Fabrice Di Meglio
46c78b4de1 Merge "Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)" 2011-09-29 17:53:09 -07:00
Svetoslav Ganov
1c07e22c36 ActivityChooserView shows "see all" improperly.
1. The cooser was presenting the "Show all" option if the number
   of available activities was more than the initial max count of activities
   to be shown. Since the show all option is added to the drop down
   the latter becomes effectively one longer than the initial max activity
   count which may make the drop down taller than client expectats. Also
   this leads to the case where if the activities are one more than the
   initial activity count pressing the show all button will just replace
   the show all item with the activity that did not fit - this is somehow
   annoying to the user.

bug:5379282

Change-Id: I2693214cb0b66edb2a3bdffc01ed29139341111c
2011-09-29 16:51:04 -07:00
Philip Milne
a15cb2cda7 Merge "Fix for 5393156" 2011-09-29 15:01:27 -07:00
Philip Milne
4a145d7262 Fix for 5393156
. Fix for the above.
. Make instances of Space invisible by default.
. Correctly accomodate parental constraints when row/col order is undefined.

This fix allows GridLayout to accomodate simple dependencies between
its axes. In the example given in bug 5393156, the presence of a
multi-line TextView means that GridLayout can only compute its height
after it has computed its width. This fix adds a second measurement pass
to GridLayout that passes infomation betwen the axes, using the GridLayout's
orientation property to indicate which axis should be examined first.

Change-Id: I90761c6fcfe8edc7ef6d9a89076fd5cda3adc0a4
2011-09-29 14:48:44 -07:00
Fabrice Di Meglio
a130e5f59d Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)
- make DynamicLayout honor max lines
- make StaticLayout.generate() take maxLines as a parameter instead of using the field mMaximumVisibleLineCount

Change-Id: I9eafb1be4b8bb2aa881514955a6903f559cb6a1e
2011-09-29 12:44:16 -07:00
Gilles Debunne
404c8e5764 Merge "Bug 5278473 & 5278471: delete option in suggestion popup menu" 2011-09-29 10:21:18 -07:00
Gilles Debunne
f4314dffbd Merge "Too many SpellCheckSpans are created." 2011-09-29 10:20:46 -07:00
Chet Haase
253f694981 Merge "Fixed ProgressBar logic for AnimationDrawables" 2011-09-29 07:47:16 -07:00
Luca Zanolin
83e8ced91a Merge "Change the width of the suggestion item to match the one of the suggestion pop-up" 2011-09-29 01:09:47 -07:00
Adam Powell
636da63854 Merge "Fix bug 5385274 - tabs in browser can't be scrolled" 2011-09-28 23:51:50 -07:00
Adam Powell
f6a6c97062 Fix bug 5385274 - tabs in browser can't be scrolled
Fix a regression related to optimizing invalidation in scrolling
views.

Change-Id: I6a39075dc830d78436a274935a904a32084defac
2011-09-28 23:48:10 -07:00
Adam Powell
8f84765385 Merge "Fix bug 5386915 - Action mode is intercepting touches it shouldn't be" 2011-09-28 22:47:08 -07:00
Adam Powell
e0b6cd14ac Fix bug 5386915 - Action mode is intercepting touches it shouldn't be
Standalone action mode windows should not be touch modal.

Change-Id: Ia3bab69b3ac344837093a17c4b58451bcc3471bf
2011-09-28 22:06:39 -07:00
Chih-Chung Chang
02dd17da36 Fix 5389072: NPE in MediaController.updateFloatingWindowLayout().
There was another constructor which we didn't add the call to
initialize the layout.

Change-Id: I1519c9afd7d6333736fe19d256f55a2f4cdc60c3
2011-09-29 12:49:04 +08:00
Svetoslav Ganov
a53d19dc6d Merge "Revamping of the NumberPicker widget for improved usablility." 2011-09-28 19:43:55 -07:00
Chet Haase
a79803c092 Fixed ProgressBar logic for AnimationDrawables
There are problems in ICS using custom ProgressBar indeterminate drawables when
those drawables are AnimationDrawables. Code that determines appropriate aspect-ratio
sizing should not kick in for this case; the animation drawables know what size
they should be.

Change-Id: I7c35e0dc0f2719f698551f197c688e6156a3f5bd
2011-09-28 17:51:53 -07:00
Svetoslav Ganov
b80a3fcad1 Revamping of the NumberPicker widget for improved usablility.
1. Now if the widget is not interacted with shows a smaller selector
   wheel with the increment and decrement arrows at the top and bottom
   respectively.

2. Tapping an arrow button now animates the widget to the new value. i.e.
   rotates the selector whell to the next value.

3. Fixed a bug that double tapping on the input shows the IME but then
   after pressing an arrow button the IME is not hidden.

4. Fixed a bug that was exposed via late changes in the framework or the
   graphics and was manifested of the selector wheel not having fading
   edges.

bug:5251980
bug:5383502

Change-Id: I4a089dc69b07a3b28a514017cddf786cb9f4af16
2011-09-28 16:58:05 -07:00
Luca Zanolin
a403cb7e72 The x and y position of the pop-up where not calculated correctly when the text view had internal scrolling.
This method is invoked only when the pop-up is currently displayed and the text scrolles.

This is scenario is reproducible only with Voice IME (I think), as the text is inserted without
touching the screen.

Bug: 5290463

Change-Id: I0b842732cc1f115de06e992fbe28cb64eac49b22
2011-09-28 11:43:22 +01:00
Chih-Chung Chang
85d4ea6fe4 Fix 5158468: Update floating window size when the anchor view size changes.
Originally when surfaceChanged() happens, we remove the old window and
create a new window. This causes flickering. Now we just update the window
layout according to the size of the anchor view.

Change-Id: Id741dac07872e473f2c9829b626c5c9568e7e22d
2011-09-28 18:00:29 +08:00
Luca Zanolin
58707d6212 Change the width of the suggestion item to match the one of the suggestion pop-up
Bug: 5267313
Change-Id: Ic7151398872459459f2537322961092d3ccffd1c
2011-09-28 09:27:49 +01:00
Gilles Debunne
a6c673bd6f Bug 5278473 & 5278471: delete option in suggestion popup menu
Also added + and x icons on that line.

Change-Id: I508ae48f83eb7a831f24bb4f81933d9e698abde6
2011-09-27 18:24:17 -07:00
Gilles Debunne
b062e81e3a Too many SpellCheckSpans are created.
Removed the Runnable in SpellChecker, spell check is triggered at the end
of updateSpellCheckSpans instead of when a new SpellCheckSpan is created.

Cache the spans in updateSpellCheckSpans to limit the calls to getSpans.

When typing, every new letter in a word will create a SpellCheckSpan
(this is needed in case the user taps somewhere else on the screen)
The SpellCheckSpans are pooled in SpellChecker to limit unnecessary new
SpellCheckSpan creation.

Minor optimization on test order in getSpans to avoid some calculation.

Spell check is not started everytime the selection is changed (would be
triggered when the insertion handle is moved). Explicitely do that only
on tap.

Change-Id: Ibacf80dd4ba098494e0b5ba0e58a362782fc8f71
2011-09-27 15:06:52 -07:00
Adam Powell
f5d412a0c7 Improve docs in BaseAdapter.
Change-Id: Idbe19f9b01132c28b4960515c23bd28e3729fd5d
2011-09-27 11:32:59 -07:00
Fabrice Di Meglio
3a6c2e9855 am a200a23a: Merge "Bug 5332065: IOOB in case the suggestionSpan has been removed" into ics-factoryrom
* commit 'a200a23af10dfcbbe46d10e868c2eae9f2c794a4':
  Bug 5332065: IOOB in case the suggestionSpan has been removed
2011-09-26 20:40:54 -07:00
Gilles Debunne
14ed50a9a3 Bug 5332065: IOOB in case the suggestionSpan has been removed
I don't understand how the SuggSpan that has been tapped to display
the popup can have disappeared when an item is clicked.

This problem seems specific to monkey test with a race condition somewhere.

Change-Id: I447b6563a1b959dc3c1ead31cde2d9bcad369765
2011-09-26 15:59:24 -07:00
Fabrice Di Meglio
8013290dd0 Merge "Fix bug #5366547 TruncateAt.MARQUEE should be replaces with "two dot" ellipsis on hardware that dont support MARQUEE" 2011-09-26 12:16:41 -07:00
Gilles Debunne
ea1c7f3c51 Merge "Bug 5248215: Even though I turned off the Spelling correction, it still shows up" 2011-09-26 10:38:58 -07:00
Fabrice Di Meglio
cb332649e4 Fix bug #5366547 TruncateAt.MARQUEE should be replaces with "two dot" ellipsis on hardware that dont support MARQUEE
- introduce TruncateAt.END_SMALL
- code refactoring for suppressing use of hardcoded constants

Change-Id: I70e24857cd5d6bd012a743cbc0ba46fbd06d5457
2011-09-25 14:39:27 -07:00
Adam Powell
53f56c4f51 Fix bug 5358705 - Request no full-screen mode of the IME when a
SearchView is expanded in an action bar

This is a case where we always know there will be room on screen for
the user to meaningfully use the UI in the absence of full-screen
extract mode. Save the old state and restore it when we go in and out
of expanded action bar mode.

Change-Id: I4ae2c5df4f581c6824e6a1f7ff8d97fd86d8e260
2011-09-25 13:50:57 -07:00
Svetoslav Ganov
83a559e78f Merge "Scroll accessibility events should not populate text." 2011-09-23 13:26:18 -07:00
Gilles Debunne
186aaf9735 Bug 5248215: Even though I turned off the Spelling correction, it still shows up
Bug 5313754: SpellCheckSession is released when the window loses focus.

When an EditText is initialized with text, a new spell check is initiated
and previous spell check spans are removed.
Requires a new flag to prevent this from happening when the window focus
change comes from the suggestion popup window being shown.

Also fixes bug 5329588: handle spell check language change.

This change has been reverted. This amended change defers the creation
of the SpellChecker, so that it is only created for editable TextView.

Patch 3: Bug 5332065, the spell check session is closed in onDetachedFromWindow, which is
called when the window is destroyed (like on rotation), which was not the case with
onWindowFocusChanged.

Patch 5: Fixed life cycle. A view can be created and never attached to the hierarchy. As
a result, the spellCheck session would not be closed. Moved spell check to onAttach and
perform a spell check when text is changed by setText only if the view has previously
been attached (and the spellChecker has been created).

Change-Id: Ic2cfbfc0d3f23c589dd9e37f02e4afc1d625615d
2011-09-23 10:16:01 -07:00
Svetoslav Ganov
b84b94e1a0 Scroll accessibility events should not populate text.
Scroll events are used to report position change and should not
contain the text content of the view that fires them because it
is usiually a containter for many other views and the text will
be long and not informative for accessibility purposes. Also
such evens are fired relatively frequently. If a client wants
to fetch some textual content for a scroll event he can use
the interrogation APIs.

bug:5352059

Change-Id: I43e02aca895c8ab16ba82ebe1cee3aea8ce7711a
2011-09-22 19:55:47 -07:00
Svetoslav Ganov
1ac6b1e221 Merge "ActivityChooserView not showing "Show all" properly if the default target button not shown." 2011-09-22 19:08:26 -07:00
Svetoslav Ganov
f632eaa9d6 ActivityChooserView not showing "Show all" properly if the default target button not shown.
If the default target button is hidden all activities are shown in the list from
which to choose. In this case due to off by one error the list was not showing the
option to expand it if the activities are one more than the initially shown.

bug:5358475

Change-Id: I8c3db37dab008637d78330f8de830cec92720264
2011-09-22 16:09:46 -07:00
Adam Powell
823f074a73 Fix bug 5300621 - Share menu disappears in gallery
ActionProviders (or action views) unfortunately had no way to report
that they had opened a sub-UI that would affect menu visibility
listeners used to hide action bars when not in use. This caused the
Gallery UI to hide its action bar when the share popup was open.

Add hidden API (to be made public later) to ActionProvider that can be
used to inform the menu system that a sub UI has opened or
closed. Account for this in menu visibility callbacks. Fix
ShareActionProvider to use this when its popup windows open and close.

Fix a regression where submenus were not properly reporting visibility
changes.

Change-Id: Ia6f45fb463ad106105c40d01f141c2e5c8b96f78
2011-09-21 17:21:47 -07:00
Gilles Debunne
a80599f5be Revert "Bug 5248215: Even though I turned off the Spelling correction, it still shows up"
This reverts commit 6e405f84b8.

Change-Id: I9593273d414aee1f9817f84b462cf45360ff19e3
2011-09-21 10:58:03 -07:00
Chih-Chung Chang
d1396fbc64 Fix 5229466: don't consume pointer events outside the window
Change-Id: Ifa3d1d5edd81346e6ca80e113f80914ee2c47055
2011-09-21 15:56:26 +08:00
Gilles Debunne
576b6bb2f9 Merge "Bug 5248215: Even though I turned off the Spelling correction, it still shows up" 2011-09-20 18:02:45 -07:00
Svetoslav Ganov
4877b85aea Merge "ActivityChooserView not showing highest ranked target if default action not shown." 2011-09-20 17:41:59 -07:00
Svetoslav Ganov
efab4e7f59 ActivityChooserView not showing highest ranked target if default action not shown.
The view was not showing the highest ranked activity if the default action
button was not shown (happens if no history is present).

bug:5224159

Change-Id: I66536513e14496568ea2034467bd29ea4bc93cdb
2011-09-20 15:13:35 -07:00
Svetoslav Ganov
d37848af08 TextView not adding text to accessibility events.
Reversed conditional.

bug:5342756

Change-Id: Ia2a523af6f7b12e27275e6095ea1b137768ea14c
2011-09-20 14:03:59 -07:00
Justin Ho
f2ff20e05b Merge "Tuning Overscroller's scroll curve Softer end + rounder curve with less contrast Bug: 5200575" 2011-09-19 18:06:13 -07:00
Justin Ho
a181bb4b8c Tuning Overscroller's scroll curve
Softer end + rounder curve with less contrast
Bug: 5200575

Change-Id: Icff6ba3cf7ae052c80b2e80e2d2b07085fcb40ce
2011-09-19 17:52:06 -07:00
Dianne Hackborn
2c2ab5864f Fix issue #5260129: Suggestion strip in Talk app not showing all the time 2011-09-19 13:59:39 -07:00
Gilles Debunne
6e405f84b8 Bug 5248215: Even though I turned off the Spelling correction, it still shows up
Bug 5313754: SpellCheckSession is released when the window loses focus.

When an EditText is initialized with text, a new spell check is initiated
and previous spell check spans are removed.
Requires a new flag to prevent this from happening when the window focus
change comes from the suggestion popup window being shown.

Also fixes bug 5329588: handle spell check language change.

Change-Id: I113229dbe06863d34c1369d05d067292894f73f1
2011-09-19 10:57:22 -07:00
Dianne Hackborn
bc82385706 Fix issue #5260129: Suggestion strip in Talk app not showing all the time
Change-Id: Ibac6138f3b3b0c3850a30d2c432495aa57b7f3f1
2011-09-19 10:41:43 -07:00