Commit Graph

13359 Commits

Author SHA1 Message Date
Antoan Angelov
b98da91c63 Merge "Initialize workProfileUserHandle before initial check for work tabs" into rvc-dev 2020-05-13 18:06:06 +00:00
Miranda Kephart
a4b9474647 Merge "Fix NPE in ScreenshotHelper" into rvc-dev 2020-05-13 16:20:14 +00:00
arangelov
8519218a73 Initialize workProfileUserHandle before initial check for work tabs
The shouldShowTabs() call checks for the existence of the work
profile user, which is actually initialized after that call.

Fixes: 156462936
Test: manual
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: Iff840826f7b008420f1a254c1044c05c27764d0c
2020-05-13 13:59:22 +00:00
TreeHugger Robot
f4fa3eb9fa Merge "Hide the top intent resolver divider when there are tabs" into rvc-dev 2020-05-13 12:41:43 +00:00
TreeHugger Robot
58c274fdcb Merge "When android:ui process receives callback result of AppPredictionService sortTargets, directly handles result instead of sending to Handler which takes extra time to dispatch messages." into rvc-dev 2020-05-13 00:57:28 +00:00
Beverly Tai
3fb4151b06 Merge "Inject LockPatternUtils into KeyguardUpdateMonitor" into rvc-dev 2020-05-12 22:40:44 +00:00
TreeHugger Robot
f30c225fcb Merge "Add OWNERS for display, haptics, input and power" into rvc-dev 2020-05-12 20:17:39 +00:00
Michael Wright
2e7e81c950 Add OWNERS for display, haptics, input and power
Bug: 156349083
Test: N/A
Change-Id: Ia8afccfc2e470095ae3d52c827c0ac78b7c120ae
2020-05-12 19:11:13 +01:00
Miranda Kephart
cc92b9c370 Fix NPE in ScreenshotHelper
Check for null before unbinding the screenshot process.

Test: manual
Bug: 155726862
Change-Id: Ica1cc521b6a510b5e15e42e1e2a87ebf613a53aa
2020-05-12 13:47:33 -04:00
Beverly
f882ee2164 Inject LockPatternUtils into KeyguardUpdateMonitor
For better testability of KeyguardUpdateMonitor. We don't actually want
to register callbacks to the real lock settings. But if we ever do in
tests, we make sure to cleanup the callbacks in
KeyguardUpdateMonitor.destroy().

Test: atest SystemUITests
Fixes: 156230507
Change-Id: I2548c15da29ef5a15f6d3b512fbfd344ca2bd355
2020-05-12 12:59:13 -04:00
Menghan Li
084b2de544 Merge "Refines volume key shortcut confirm dialog strings" into rvc-dev 2020-05-12 16:10:51 +00:00
menghanli
3cba1dc1c5 Refines volume key shortcut confirm dialog strings
- Provide more clear content for single and multiple services are
enabled.
- Avoid non-a11y users accidentally turning shortcut on without
reading this carefully. Hence we put "don't turn on" as the
primary action.

Bug: 155249323
Bug: 138582063
Test: atest AccessibilityShortcutControllerTest
Change-Id: I1c391bb0516bcebfbf6161b94cc0c0b80e0bb72f
2020-05-12 16:05:50 +00:00
Abhijeet Kaur
e0ae189f8a Merge "Add manage mode workflow for ExternalStorageProvider" into rvc-dev 2020-05-12 14:39:19 +00:00
Alex Kershaw
760754ec61 Hide the top intent resolver divider when there are tabs
Fixes: 155174577
Test: manual
Change-Id: If35f4902e793767cbd38e1f5770d55c4e7b22872
2020-05-12 12:02:42 +01:00
Antoan Angelov
ff779f6d8e Merge "Don't show layout with default if in tabbed view" into rvc-dev 2020-05-11 14:49:18 +00:00
Abhijeet Kaur
553625de0a Add manage mode workflow for ExternalStorageProvider
In Scoped Storage world, access to "Android/data" style directories are
hidden for privacy reasons. Allow ExternalStorageProvider to show these
hidden files when in manage mode.

Bug: 150366834
Test: Android/data and Android/obb is visible from Files App, but are
hidden in Picker view from StorageTestApp and Gmail (GMAIL > Compose >
Attach > Go to Pixel > Android)

Change-Id: I58b4fc23d9b479df4fc0480ae55f1f2070d0cb7c
2020-05-11 11:39:40 +01:00
Jason Hsu
5c8f27a56e Merge "Logs accessibility shortcut behavior." into rvc-dev 2020-05-10 03:06:30 +00:00
jasonwshsu
d9aa03245c Logs accessibility shortcut behavior.
* Uses the atom AccessibilityShortcutReported in westworld.

Bug: 151285965
Test: make statsd_testdrive && ./out/host/linux-x86/bin/statsd_testdrive 266
Change-Id: Iba9d829ae35c7a336c38007101bdddfcd3dc2ddb
2020-05-09 22:31:05 +08:00
Song Hu
0debe440bd When android:ui process receives callback result of AppPredictionService sortTargets, directly handles result instead of sending to Handler which takes extra time to dispatch messages.
Bug: 155551642
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Test: manually test on the device
Change-Id: I7a28dbebfb4bf9cdf1fe27dd224c72ef9b44f2fe
2020-05-08 10:24:51 -07:00
Kevin Chyn
f67a780c33 Merge "[DO NOT MERGE] Add sysUiSessionId between BiometricService and AuthController" into rvc-dev 2020-05-07 23:22:02 +00:00
Kevin Chyn
fa7069d83c [DO NOT MERGE] Add sysUiSessionId between BiometricService and AuthController
Bug: 155420058

Test: BiometricPromptDemo, inspect logs

Change-Id: I47cffa4e8acb1e5f098572d26e47882ff5e9be26
2020-05-07 14:06:57 -07:00
arangelov
aa307e28ca Don't show layout with default if in tabbed view
Fixes: 155890640
Fixes: 150939321
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Test: manually verified default layout is not shown

Change-Id: I11c543331b44039a7a2ae85a1b2a67b8525739a4
2020-05-07 16:16:45 +01:00
Matt Pietal
2f16758a0a Merge "Sharesheet/Resolver a11y adjustments" into rvc-dev 2020-05-07 11:38:59 +00:00
Antoan Angelov
afbd12c4ed Merge "Fix sharesheet scroll jankiness." into rvc-dev 2020-05-07 10:56:05 +00:00
Feng Cao
254545cae5 Merge "Support re-attaching the inline suggestion view to window" into rvc-dev 2020-05-07 05:23:15 +00:00
Feng Cao
b46851c964 Support re-attaching the inline suggestion view to window
* Before this change, when the inline suggestion view is detached from
  the IME window (e.g. due to layout change), the remote view content
  will not show again even after the view is reattached to the window
  on the IME side. This patch fixes it by requesting the remote view
  owner (the ext services) for a new SurfacePackage when the view is
  re-attached to the window (see javadoc of SurfaceControlViewHost for
  why this works).
* This patch also fixes the issue where the SurfaceControlViewHost was
  never released in the ext services. This is done by notifying the
  ext services (through system server) when the view is detached from
  the IME window, and then the system server will release the
  SurfaceControlViewHost if after N(=500) ms the view is not re-attached
  to a window.
* After the SurfaceControlViewHost is released, if the view is
  re-attached to the window later, a new SurfaceControlViewHost will be
  created to back the same InlineContentView.
* The current code structure also lays a foundation for a subsequent
  change to allow reusing the same remote view for inline suggestions
  during filtering.

Test: atest CtsAutofillServiceTestCases (sanity test)

Bug: 153615023
Bug: 154683107

Change-Id: Idc587e1e82a96b792c351796464821b7aad7cd89
2020-05-06 19:30:39 -07:00
Ben Lin
c43997ba15 Merge "Enforce max size for resizing operations." into rvc-dev 2020-05-06 21:17:02 +00:00
Matt Pietal
877b5ec262 Sharesheet/Resolver a11y adjustments
1. Announce app name with direct share targets
2. Don't speak 'heading' in direct share rows
3. Don't close resolver/sharesheet when swiping left
4. Talkback will announce # of rows and columns for sharesheet

Fixes: 141908464
Fixes: 155153657
Fixes: 151897812
Fixes: 149437892
Fixes: 80319063
Test: talkback
Change-Id: I16586208407ba56814d3cf69648e660bded72ccf
2020-05-06 15:27:54 -04:00
Song Hu
f52438f9a2 Merge "Send onCreatePredictionSession, sortAppTargets, requestPredictionUpdate immediately instead of sending them to main thread Looper queue of ChooserActivity." into rvc-dev 2020-05-06 19:03:46 +00:00
Song Hu
d52863d12b Send onCreatePredictionSession, sortAppTargets, requestPredictionUpdate
immediately instead of sending them to main thread Looper queue of
ChooserActivity.

These methods are relatively latency-sensitive. When main thread Looper queue has many backlogs, it takes long time
to dispatch requests.

Bug: 155551642
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Test: manually test on the device
Change-Id: I7d00e49c6a30fec478e620bc98180d379f801fc8
2020-05-06 10:17:29 -07:00
arangelov
706316db0f Fix sharesheet scroll jankiness.
This CL makes the following changes:
1. Cache the itemViewType in the ViewHolder, so that we don't
have to call it again from onBindViewHolder
2. Cache the result of shouldDisplayLandscape to reduce the
number of IPC calls while scrolling the list, as this is called
indirectly by the ChooserGridAdapter's getRowCount and
getItemCount. It calls Activity#isInMultiWindowMode which makes
an IPC call to the ActivityTaskManager.
3. Cache the work profile user handle to reduce the number of
IPC calls while scrolling the list, as this is called
indirectly by ChooserGridAdapter's getRowCount and getItemCount.

Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Test: manually verify there is no jankiness when scrolling
Test: manually change orientation between portrait and
landscape to make sure screen orientation cache gets invalidated
Test: launched share sheet in multi-window mode and then removed
one window - sharesheet properly updated its views
Fixes: 151117747
Fixes: 154766645

Change-Id: Ib8e329b534f3de1d4906f6a07908cc7879dcaa47
2020-05-06 16:35:16 +01:00
Antoan Angelov
950aca5795 Merge "Use intent resolver strings for sharesheet when picking intent" into rvc-dev 2020-05-06 14:23:13 +00:00
Song Hu
efa0eab058 Merge "Enable ChooserTarget ranking of the same app." into rvc-dev 2020-05-06 00:02:06 +00:00
Song Hu
60c131e869 Enable ChooserTarget ranking of the same app.
Bug: 151112858
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Change-Id: If5a4edfec7116cd54ed0ae6543cab0beb011f987
2020-05-05 10:27:52 -07:00
Collin Fijalkovich
a131a0c64f Merge changes from topic "rvc-telephony-caching" into rvc-dev
* changes:
  Cache getPhoneId and getSlotIndex binder calls.
  Refactor SubscriptionManager caching code
  Cache getDefaultSmsSubscriptionId Binder calls
  Cache getActiveDataSubscriptionId Binder calls
2020-05-05 16:30:39 +00:00
Kholoud Mohamed
d4d2427c01 Merge "Fix bug in IntentForwarderActivity" into rvc-dev 2020-05-05 13:37:54 +00:00
kholoud mohamed
06335279aa Fix bug in IntentForwarderActivity
Bug: 155096621
Test: atest com.android.cts.devicepolicy.ManagedProfileCrossProfileTest#testCrossProfileIntentFilters
Test: atest IntentForwarderActivityTest
Test: atest ResolverActivityTest
Test: atest ChooserActivityTest
Change-Id: Ieb99f566fa9cfc14254fecfa5897d421fd39482f
2020-05-05 09:56:07 +00:00
Jing Ji
e9fbacf6c5 Merge "Support to pull aggregated procstats associations" into rvc-dev 2020-05-05 01:05:47 +00:00
Adam Bookatz
316bc6ff66 Merge "Listener to watch op starts" into rvc-dev 2020-05-05 00:52:12 +00:00
Yuncheol Heo
8f4363a226 Merge changes from topic "immersive" into rvc-dev
* changes:
  Add test api getStatus/NavigationBarBackgroundView.
  Notify the visibility change to update color views without control.
2020-05-05 00:14:09 +00:00
Adam Bookatz
182862e595 Listener to watch op starts
Currently, there is
onOpNoted - tells listeners that noteOp has occurred
onOpActiveChanged - tells listeners that an op's 'active' state has
changed, i.e. that a successfull startOp or stopOp has happened

There was, however, no way of telling a listener that a startOp has
happened (regardless of whether it was successful). This cl introduces
it, via a OnOpStartedListener.

This is required by the ForegroundServiceAppOpSessionEnded atom,
which counts the number of accepted vs. rejected attempts, and
therefore also needs to know when a rejected start happened.

This cl also contains some cosmetic moving of code so that
startOperation() and noteOperationImpl() are almost
exactly parallel.

* Also *
This cl fixes a bug I discovered in stopWatchingNoted, in which
the callback wasn't fully removed. Consequently, if a callback
was unregistered and then re-registered, the re-registration would
mistakingly be ignored (in direct contradiction to the javadoc).

Test: atest UidAtomTests#testForegroundServiceAccessAppOp
Test: atest AppOpsStartedWatcherTest AppOpsActiveWatcherTest AppOpsNotedWatcherTest
Test: manually monitor: adb shell cmd stats print-logs && adb logcat -v uid -s statsd | grep "statsd  : {" | egrep '\(256\)'
Bug: 152800926
Change-Id: Icdb9edf6b2b7c5807b339c1aabb32e882190b071
2020-05-04 21:59:29 +00:00
Yuncheol Heo
70c4bb9007 Add test api getStatus/NavigationBarBackgroundView.
Introduces new test api to access the background view of status bar and
navigation bar.

Bug: 154720832
Test: atest WindowInsetsPolicyTest

Change-Id: If38d3f57edfbb2631d4c1e47ed5347a332edacfb
2020-05-04 14:36:43 -07:00
Jing Ji
060d68630d Support to pull aggregated procstats associations
Bug: 145203981
Test: b/152397079#comment12
Test: atest CtsStatsdHostTestCases
Change-Id: If5b9723a41a9d2eefc2cb132b3a3bf16f57872e9
2020-05-04 14:33:06 -07:00
Song Hu
4a9bd0da70 Merge "Pass ChooserTarget sharing and impression info to AppPredictor. Rank ChooserTargets of the same component as per available scores returned by AppPredictor. These two features are guarded by flag "mChooserTargetRankingEnabled" Add relevant logging to make it easy to figure out root cause from bug report." into rvc-dev 2020-05-04 16:39:00 +00:00
Song Hu
5aab2d3fbe Pass ChooserTarget sharing and impression info to AppPredictor.
Rank ChooserTargets of the same component as per available scores returned by AppPredictor.
These two features are guarded by flag "mChooserTargetRankingEnabled"
Add relevant logging to make it easy to figure out root cause from bug report.

Bug: 151112858
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Change-Id: Id8c4b373ba9e2e1ae29281791e49dde8722ba9d1
2020-05-03 15:17:54 -07:00
Winson Chung
4ef84183e7 Account for getDimension() also doing a pixel conversion
Change-Id: Ie35eb98d6063a0747851e06f6da17b86ede19b41
Bug: 148104018
Test: Ensure edge swipe thresholds match resources
2020-05-01 15:24:49 -07:00
arangelov
993d63b339 Use intent resolver strings for sharesheet when picking intent
Fixes: 154290625
Test: manual
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: Ibf28daaf42859df2d9093e871c102d0a327231f2
2020-05-01 15:32:57 +01:00
Rubin Xu
bc7d9bdd5a Merge "Refresh strong auth alarm when admin changes policy" into rvc-dev 2020-05-01 10:14:28 +00:00
Ben Lin
d14589e051 Enforce max size for resizing operations.
Previously, maxVisibleSize is only enforced when we want to preserve
orientation. However, we should enforce it when in complete freeform
also.

Even for preserve orientation case, since it calculates two possible
rectangles and grab the bigger one if it's a grow operation, it's
possible the bigger rectangle is beyond the max possible size. By
setting the limitations early, this will no longer happen.

Bug: 154936459
Bug: 155433395
Test: Drag-resize a window that has a max size set (PIP window), and now
it is properly constrained.
Test: atest TaskPositionerTests

Change-Id: I3e9bc615554561e035a5c7110d0400687c6ba365
2020-04-30 16:32:24 -07:00
Maryam
a142e5210b Add Flags to be able to run experiments for the Back Gesture Problem.
Test: manual atest, adb shell device_config put systemui back_gesture_bottom_height 1000
Bug: 148104018
Change-Id: I5b0e696ca2e015d2d9a1718785f4a140cfff083f
2020-04-30 16:23:43 +00:00