This reverts commit d31d096720.
Reason for revert: Although this change fixed the behavior change for for creation of
GradientDrawables defined in xml, the default value for GradientDrawables defined
programmatically is different. The default orientation for GradientDrawables defined
in xml is LEFT_RIGHT, however, the default orientation for GradientDrawables defined
programmatically is TOP_BOTTOM. Since a fix for AAPT has been made to automatically
insert an angle measurement of 0 if one is not defined, we can revert this CL and target
a proper fix in master.
Change-Id: Ib8983386832fb25f53b5e68e76e9d41d9d26fec9
Merged-In: Ib8983386832fb25f53b5e68e76e9d41d9d26fec9
And also pre-grant it to all apps that currently get any storage
permission pre-granted
Test: atest SplitPermissionTest
m -j gts && gts-tradefed run commandAndExit gts-dev -m GtsPermissionTestCases --test=com.google.android.permission.gts.DefaultPermissionGrantPolicyTest#testDefaultGrantsWithRemoteExceptions
Manual testing:
All combinations of
- App targetSdk = 28 and 29 (and 22 for extra credit)
- App having the <uses-permission> tag for
ACCESS_MEDIA_LOCATION or not
- Upgrade from P->Q-QPR and from vanilla Q->Q-QPR
Further upgrade of targetSdk from 28->29 while on Q-QPR
==> All permission behavior should make sense. Sometimes there
are weird, but expected behaviors. Hence we need to
collect the results and then look at the unexpected ones.
See SplitPermissionTest for some tests I added for the
location-background permission which was split from
the fine/coarse-location permissions
Fixes: 141048840,140961754
Change-Id: Ib9f50d25c002036f13cf2d42fc4d1b214f20920c
In master, we retrieve the KeyguardUpdateMonitor through Dependency.get().
This change has not landed in qpr1 and should use a different method of
access.
Bug: 140270231
Test: atest SystemUITests
Change-Id: Icbba30e52d4d011fc01cba13262b18a3a235316c
The transition to Doze is asynchronous from the release of the display
suspend blocker. This created a race condition where we could
potentially suspend before Doze service had a chance to transition to
Doze. This change holds the Display Suspend blocker until Doze service
acquires the DOZE lock.
Bug: 138828701
Test: atest PowerManagerService
Test: Manual, verify no repro of the bug. Additional verify the device
does release the Display suspend blocker once we are in DOZE.
Change-Id: I777bc7963b1ab445378164b0f4d3f79113510b81
This CL changes the policy for showing the 'x' on the mobile signal
indicator such that we do not show an 'x' when a subscription has an
icon group of NOT_DEFAULT_DATA, except in the case where mobile data is
turned off on the default subscription
Test: atest SystemUITests; manual
Fixes: 135457552
Change-Id: Ie21462be12a9920d9b2830039f4095c5bd82bd2c
1. If a previous version of an app doesn't declare internet permission;
2. The User upgraded it to a new version and the new one does declare the
internet permission;
3. The new app are not allowed to access the internet until next boot
Bug: 137864893
Test: Manual, just make sure the onPackageChanged would be executed on package changes
Change-Id: I69cdbb16a027a9c4e974b32371b1f64a23a51a23
Signed-off-by: wangmingming1 <wangmingming1@xiaomi.com>
Because we were cancelling an animation but never reseting the translation
we could be stuck in weird transition states.
Fixes: 136117476
Test: lock and unlock quickly with overlapping animations, observe no overlap
Change-Id: Iee389fa77588289417d0e3e5bdc31aeda1aac58a
- Make flags is the last parameters in access decipher methods.
All calling code assumes this.
- Get proxyUid info from the appropriate field
- Don't create proxy entries if uid is invalid
- Fixed some incorrect docs
Test: adb shell dumpsys appops now shows proxy information
Fixes: 141328071
Change-Id: I2f94e9b171133141643e628c9224d8d74ec5ad87
Staged sessions currently send a SESSION_COMMITTED broadcast
when they are created, but not upon activation. Since there
is nobody active at activation to listen to the broadcast,
it should not be sent. This also prevents app shortcuts being
added to the launcher before a new version has been activated.
Bug: 139663018
Test: atest StagedInstallTest
Change-Id: Icf51b5611a1903eee58c3310bfb875eaf737c26f
This reverts commit 09843a687b.
Reason for revert: There is possible reentrant behavior when posting the safeToRemove callback after a FGS has been canceled/reposted
Bug: 140948482
Change-Id: I2c5b9135e57a87f412dce8c167147dcb38f6bbae
To fix b/130645908, tasks with top activities in INITIALIZING state were
considered visible. This allowed apps to circumvent background activity
launch restriction by starting 2 activities when in a background stack.
The first activity will remain in INITIALIZING state (since it's in the
bg), so the second launch is permitted since top activity is
INITIALIZING.
Removing '|| topActivity.isState(INITIALIZING)' removes the
vulnerability and curiously still allow the legitimate use case of the
bug linked above to work, i.e. the test in ag/7088262 still passes. This
is because of 2 reasons:
1) Grace period introduced in ag/7638265.
2) Allow bg activity starts to put activity on top of bg task (instead of
fg’ing it) in ag/7190176.
I verified (2) by removing the grace period check, reverting the linked
CL and verifying that the test failed.
This essentially reverts ag/7090415.
Test: atest BackgroundActivityLaunchTest \
RootWindowContainerTests \
WmTests:ActivityStarterTests \
CtsWindowManagerDeviceTestCases:ActivityStarterTests
Bug: 138583650
Bug: 130645908
Change-Id: Iee4ba841c6c83888b55c5cb55fffc949048d2030
Data stall event can be triggered if the tx/rx tput is consecutively below a threshold over multiple RSSI polls. Changing the unit of the threshold from Mbps to Kbps allows us to configure a value below 1Mbps, e.g., 400Kbps.
Bug: 141027476
Test: frameworks/base/wifi/tests/runtests.sh
Signed-off-by: Mingguang Xu <mingguangxu@google.com>
Change-Id: Ib7b398fb6975c0d03b09550db9bf68a2bb8bddfb
Merged-In: I76d6338cd2d482d198fde1e5a2d1a0540c087ca6