Commit Graph

1770 Commits

Author SHA1 Message Date
Xiangyu/Malcolm Chen
d706a9df5e Merge "Don't show signal bar of hidden Cellular subscription." 2019-01-16 01:42:10 +00:00
Dave Mankoff
785d3d27f4 Merge "Fix the library paths of plugins to allow loading native libraries." 2019-01-15 23:06:05 +00:00
Mady Mellor
7c73162d40 Merge "Create BubbleMetadata use it instead of app overlay intent" 2019-01-15 22:24:45 +00:00
TreeHugger Robot
a9f50e954d Merge "Add custom bubble clock face." 2019-01-15 21:51:35 +00:00
Malcolm Chen
d2d400cb4c Don't show signal bar of hidden Cellular subscription.
Bug: 121396526
Test: manual
Change-Id: I646278c9ab4dd2f37083658a25ad38ad4f65d42f
2019-01-15 13:25:42 -08:00
Mady Mellor
c39b4aedb0 Create BubbleMetadata use it instead of app overlay intent
* BubbleMetadata encapsulates necessary info to display a bubble
* Replaces app overlay intent usages with BubbleMetadata
* Renames existing bubble APIs to use 'bubble' rather than 'app overlay'

Bug: 111236845
Test: existing tests pass
Change-Id: I6a85d3c41dda47139fb8d960cadf1c8e109cf29b
2019-01-15 10:28:31 -08:00
Robert Snoeberger
046ee9ceca Add custom bubble clock face.
Bug: 122301289
Test: Using adb to set the settings value switches to bubble clock.
Change-Id: I9b5ab62796204cfdce7b9beb147f34f80b0db167
2019-01-15 13:03:26 -05:00
Dave Mankoff
b938def5e9 Fix the library paths of plugins to allow loading native libraries.
Test: atest
Bug: 111394067
Change-Id: I05db6db5e735f7532f772a59ff57b8ad0595c1a2
2019-01-15 10:45:37 -05:00
Mady Mellor
344731a8aa Merge "Closer to notification model & updates on bubbles" 2019-01-14 17:28:31 +00:00
Mady Mellor
c8238f4ccf Merge "Enable 'real bubbles' and fix our tests" 2019-01-14 17:28:11 +00:00
TreeHugger Robot
cf136dd1ff Merge "Add experiment flag for smart suggestions in heads-up notifications." 2019-01-14 11:42:49 +00:00
Eyal Posener
a9cf9c723f Add blocking helper logging
The added logging events are: blocking helper view displayed or
dismissed, any button click within the view, undo clicks and
system suggests of blocking helper.

* Move some of the getLogMaker logic of server's NotificationRecord
  class to the common StatusBarNotification class.
* Use the StatusBarNotification.getLogMaker to produce blocking helper
  logging.
* Add logging in the NotificationInfo for interaction and display of
  the blocking helper view.
* Add logging in the NotificationBlockingHelperManager for system
  suggests of blocking helper.

Bug: 112482290
Test: unittests and manual - viewed produced logs.
Change-Id: I3a5267d55faba21f6668d35ff8aa12deb0dc5921
2019-01-14 10:58:29 +02:00
Lucas Dupin
7fc9dc16c2 AOD notification icons placement
Whenever there's a custom clock, notification icons should be on the top
left. The default clock will just show the dark shelf.

Test: atest NotificationStackScrollLayoutTest
Test: atest CollapsedStatusBarFragmentTest
Test: visual - with and w/o clock plugin
Test: visual - with and w/o RTL layout
Bug: 122301289
Bug: 111405682
Fixes: 120563185
Change-Id: I4c513d347f656262ee6f91bd208ab9f219e4419c
2019-01-12 04:57:20 +00:00
TreeHugger Robot
f36aa2d7df Merge "Added assistant as an action for possible gestures" 2019-01-12 02:35:16 +00:00
Matthew Ng
0548fbc287 Added assistant as an action for possible gestures
Also matched launcher with the stabilization flag only used for the new
quick step swiped right to left and vice versa.

Bug: 112934365
Test: atest QuickStepControllerTest
Change-Id: Ia6801f96e60c8764448bca6667b93846ef637318
2019-01-11 16:44:49 -08:00
Mady Mellor
3f2efdbf5d Closer to notification model & updates on bubbles
* Introduces BadgedImageView / BadgeRenderer for icon & badging
  -> These are both semi-temporary until I move things over to using
     icon library

* Introduces "shouldShowInShade" bit on NotificationData, this is used
  to indicate whether a bubble's notification should display in the
  shade or not
* BubbleController uses NotificationEntryListener to annotate notifs
  bubble state & add / update / remove bubbles
* Cleans up expansion / dismissing / visibility in BubbleController

General notif / dot / bubble behaviour:
* When a bubble is posted, the notification is also in the shade and
  the bubble displays a 'dot' a la notification dots on the launcher
* When the bubble is opened the dot goes away and the notif goes away
* When the notif is dismissed the dot will also go away
* If the bubble is dismissed with unseen notif, we keep the notif in shade

go/bubbles-notifs-manual has more detailed behavior / my manual tests

Bug: 111236845
Test: manual (go/bubbles-notifs-manual) and atest BubbleControllerTests
Change-Id: Ie30f1666f2fc1d094772b0dc352b798279ea72de
2019-01-11 12:53:32 -08:00
Mady Mellor
b4991e60db Enable 'real bubbles' and fix our tests
Previously the test was marking entries as 'isBubble' automatically which
isn't quite correct.

This CL fixes that and has the side effect that enables bubbles for real.
This doesn't auto-bubble any notification, however, if the notification
is on an appropriately noisy channel & has an app overlay intent we will
bubble it.

Bug: 111236845
Test: atest BubbleControllerTest
Change-Id: I26c67ce002eec808591d7864b2366bb4140be386
2019-01-11 12:53:26 -08:00
TreeHugger Robot
529938db4f Merge "remove status bar icon logs" 2019-01-11 19:19:26 +00:00
TreeHugger Robot
791158382b Merge "Initialize dark amount when a new plugin is connected." 2019-01-11 16:26:13 +00:00
Chris Wren
1acdb5e6bb remove status bar icon logs
partial revert of Ife5ce988

Bug: 122451213
Test: runtest systemui
Change-Id: I026217ea8e95ba0805b05e62a5d527c8c3a1d9ce
2019-01-11 10:53:51 -05:00
Gustav Sennton
3f3eaff7c0 Add experiment flag for smart suggestions in heads-up notifications.
With this CL we add a new key-value pair to
smart_replies_in_notifications_flags to control whether smart
suggestions should be turned on for heads-up notifications. By default
the suggestions are turned ON.

Bug: 122351821
Test: atest SmartReplyConstantsTest
Test: Run "adb shell settings put global
smart_replies_in_notifications_flags show_in_heads_up=false" and ensure
heads-up notifications do not contain smart suggestions.
Change-Id: I84292c10a4545112b0e993af33bb01a8cc18ce23
2019-01-11 12:20:41 +00:00
Wu Ahan
1153b78033 Merge "Enable AOD image wallpaper and apply aod mask view." 2019-01-11 08:21:59 +00:00
TreeHugger Robot
c9c0912313 Merge "Fade away wallpapers when long pulse" 2019-01-11 05:25:44 +00:00
TYM Tsai
a71c8929ec Fade away wallpapers when long pulse
Docking pulses may take a long time and the wallpaper should fade away
to avoid aging.

Bug: 120464108
Test: atest SystemUITests
Change-Id: I8fac3a81b4b6b93089b58fbd30b67d8c6dae7139
2019-01-11 10:46:22 +08:00
TreeHugger Robot
44b93686b9 Merge "Move to Extension for handling plugins plus default." 2019-01-10 20:52:03 +00:00
Robert Snoeberger
58f2315865 Initialize dark amount when a new plugin is connected.
Bug: 119756967
Test: Added test to KeyguardClockSwitchTest.
Change-Id: I716a92f72afcfb51bea80757eedc8797364b95c7
2019-01-10 15:51:32 -05:00
TreeHugger Robot
dcc45dcbbc Merge "Swipe up to unlock when pulsing" 2019-01-10 18:48:30 +00:00
Robert Snoeberger
8bf1a3c125 Move to Extension for handling plugins plus default.
Bug: 118761043
Test: KeyguardClockSwitchTest adapted and passes.
Change-Id: I747274af894845a867b0d1ca38b2fd3338798e01
2019-01-10 13:44:00 -05:00
Milo Sredkov
41dc4ba3c6 Make the tap-to-edit behaviour configurable
Add a new key-value pair to smart_replies_in_notifications_flags that
controls the default tap-to-edit behaviour.

Bug: 111437455
Test: atest SmartReplyConstantsTest
Test: Try "adb shell settings put global smart_replies_in_notifications_flags edit_choices_before_sending=true" and observe
Change-Id: Ida90b98c28f4183697e84a6722768d41c72dd9cf
2019-01-10 10:44:26 +00:00
Lucas Dupin
1c32743a11 Swipe up to unlock when pulsing
Bug: 111405682
Test: adb shell am broadcast -a com.android.systemui.doze.pulse com.android.systemui
Change-Id: Ida5adb6a18f3ee992b1d154e10b35ba244f5b712
2019-01-09 16:39:36 -08:00
Mady Mellor
1fba2a6213 Merge "NotificationEntryListener: pre & post onEntryUpdated" 2019-01-09 19:52:26 +00:00
TreeHugger Robot
e714a7eaa9 Merge "Don't stop adding smart suggestions just because one doesn't fit." 2019-01-09 11:44:44 +00:00
Mady Mellor
0ad5b9defd NotificationEntryListener: pre & post onEntryUpdated
Some of the listeners care about doing things to notifications prior
to the entries being filtered and some of them care about it after the
entries are filtered.

This CL introduces new method onPreEntryUpdated and alters the existing
method to be onPostEntryUpdated so that listeners can know about both
events.

Test: atest NotificationEntryManagerTest#estUpdateNotification_prePostEntryOrder
Change-Id: Ifa56fbf27cbc8f58c8eda9c95c79a57f1a52c9ac
2019-01-08 15:21:02 -08:00
Ahan Wu
723a80e4fd Enable AOD image wallpaper and apply aod mask view.
1. Enables image wallpaper in AOD.
2. Enables a mask with 70% black scrim and vignette effects.
3. Add feature flag in developer options which is default disabled.

Bug: 111861907
Bug: 118470430
Test: Manually test the flow
Test: runtest systemui
Test: atest ImageWallpaperTransformerTest
Test: atest AodMaskViewTest

Change-Id: Iff2642d52264e88012f4759842a59aaf5bc45b38
2019-01-08 15:17:53 +08:00
TreeHugger Robot
1cac57911e Merge "Hide media details on lock screen" 2019-01-08 03:21:31 +00:00
Lucas Dupin
3d560e430c Hide media details on lock screen
Media data will only be available when dozing to avoid duplication
on the notification shade.

Test: manual
Test: atest KeyguardSliceProviderTest
Bug: 111405682
Change-Id: I5e057496aa36c912293be54a4abfa62667b96db3
2019-01-07 17:15:00 -08:00
Ned Burns
f81c4c405f Extract NotificationData.Entry to top-level
NotificationData.Entry -> NotificationEntry

Both NotificationData and NotificationEntry moved
`notification.collection` package.

Test: atest
Change-Id: Ia7158eb732711ddb324e514edb9884d518edab87
2019-01-07 16:31:21 -05:00
TreeHugger Robot
8b9351ba04 Merge "Fix custom clock face showing up outside of lock screen." 2019-01-07 20:29:18 +00:00
TreeHugger Robot
2729b24c53 Merge "Moves snapViewIfNeeded() call to listener on NSSL." 2019-01-07 17:27:37 +00:00
Gustav Sennton
3515675803 Don't stop adding smart suggestions just because one doesn't fit.
Up until now we've added smart suggestions to a notification from a
certain list (in order). When we've reached a suggestion that doesn't
fit in the notification we've simply skipped the rest of the
suggestions. With this CL we only skip the suggestion that's too long,
and instead try adding the less-prioritized suggestions.

Example:
Assume the notification can fit suggestions 1, 2, and 4 (suggestion 3 is
too long to fit):
"Action1", "Action2", "LongestActionEvererererrer", "Action4"

Behaviour before this CL: only the first two suggestions are shown:
"Action1", "Action2"
Behaviour after this CL: actions 1, 2, and 4 are shown:
"Action1", "Action2", "Action4"

Bug: 121250868
Test: atest SystemUITests
Change-Id: Icd90eebe1514e88a9dd0d48db050325764830155
2019-01-07 17:27:14 +00:00
TreeHugger Robot
42d3cf3647 Merge "Change the API for setting Notification Actions to be contextual." 2019-01-07 15:30:46 +00:00
Gus Prevas
5ecd2b8e14 Moves snapViewIfNeeded() call to listener on NSSL.
This change removes the logic from NotificationEntryManager which snaps
an updated notification's view back into place and replaces it with a
NotificationEntryListener defined by the NotificationStackScrollLayout.
This allows us to remove a method from the NotificationListContainer
interface and gets us halfway to breaking the dependency from
NotificationEntryManager on NotificationListContainer.

Test: atest SystemUITests, manual
Change-Id: I744ece3fa660454d9725aa553ffebcfe8846a303
2019-01-07 09:41:11 -05:00
Gustav Sennton
005d7a0d07 Change the API for setting Notification Actions to be contextual.
According to Android API council we shouldn't add a new semantic-action
flag to mark an action as contextual. Instead we should use a boolean
flag.
This CL adds that boolean flag.

Bug: 120842160
Test: build and run Notify app (in
vendor/google_experimental/users/cinek/), and ensure smart actions are
showing when the 'No Smart Actions' chooser is changed to
'Short Smart Actions'.
Change-Id: I5fc6dfa37ab28e3f29529cb6fda99c049783eb80
2019-01-07 10:59:45 +00:00
Ned Burns
01e3821aa3 Invert BubbleController <-> NEM dependency
Test: atest
Change-Id: I35b9dfbead7c623a6d0321943570c6115cf7eb5e
2019-01-04 20:09:28 -05:00
Ned Burns
ef2ef6c909 Change onRemoteEntry() to only fire when entries are removed
Conceptually, this should be a paired match with
onNotificationAdded(). Previously we were firing this method even
if the notification was no longer present (already removed) or
if it hadn't been added yet (was in pending).

Test: atest

Change-Id: I613f60aa8cf4e1aeb7bb13ff5883a221c9b623c6
2019-01-04 20:06:07 -05:00
TreeHugger Robot
441f143110 Merge "Removes unused fields from NotificationEntryManager." 2019-01-04 23:19:55 +00:00
TreeHugger Robot
bf435d53ac Merge changes from topic "foreground-service-controller-2"
* changes:
  Factors out notification listening from ForegroundServiceController.
  Collapses ForegroundServiceControllerImpl into interface.
2019-01-04 22:20:45 +00:00
Gus Prevas
9258646f98 Removes unused fields from NotificationEntryManager.
Test: atest SystemUITests
Change-Id: Ia2b361fbfa9d3aa3c18a9a4577eda28bdc22b080
2019-01-04 16:06:12 -05:00
Gus Prevas
eb4e2e1139 Factors out notification listening from ForegroundServiceController.
This change introduces the ForegroundServiceNotificationListener
component, which contains the logic formerly in
ForegroundServiceController for updating its state in response to
notification events.  ForegroundServiceNotificationListener adds a
standard NotificationEntryListener to the NotificationEntryManager,
allowing us to remove the explicit calls from NotificationEntryManager;
splitting this out to its own class prevents us from introducing a
circular dependency since NotificationEntryManager still needs to use
the query methods on ForegroundServiceController.

Test: atest SystemUITests, manual
Change-Id: Iec72aa3a9fd90e3f0079db3b2a3c4f1882e59731
2019-01-04 14:05:43 -05:00
Robert Snoeberger
60854080d3 Fix custom clock face showing up outside of lock screen.
Bug: 122349591
Test: Added tests to KeyguardClockSwitchTest
Change-Id: Ie5f39ab598e993759ec628a071af81a52629a574
2019-01-04 13:19:53 -05:00