Commit Graph

13031 Commits

Author SHA1 Message Date
Automerger Merge Worker
06cd567e82 Merge "Merge "Delete size limitation for ContrastColorUtil.isGrayScale() method. loss of performance is tiny because, image will be resized at ImageUtil.isGrayscale() method." am: 8157fac634 am: 55e52fcf66 am: 7686146070 am: baade55697" into rvc-qpr-dev-plus-aosp am: 8b3b050b2c
Change-Id: Ia5ee63d4eaf1107c3f1886b9f34afdeda2f256a0
2020-03-02 20:16:20 +00:00
Automerger Merge Worker
ab33375932 Merge "Revert "Notification statsd logs: Notification panel."" into rvc-dev am: f5324f74f5 am: 0f8aa5ec82 am: cc733b7df1 am: 2297346d31
Change-Id: Iede7798c70b4db145c60a67d93df78b7d17e4081
2020-03-02 20:15:23 +00:00
Automerger Merge Worker
2703eed3d6 Merge "Fix intent resolver height calculation" into rvc-dev am: 48eec146dc am: 034b630f05 am: ace731fe9a am: 5562ed4440
Change-Id: I1447d4612e94ce1ea80c0a14dfdc106b36dab6e1
2020-03-02 20:12:14 +00:00
Automerger Merge Worker
5563a204b3 Merge "Delete size limitation for ContrastColorUtil.isGrayScale() method. loss of performance is tiny because, image will be resized at ImageUtil.isGrayscale() method." am: 8157fac634 am: 55e52fcf66 am: 7686146070 am: baade55697
Change-Id: Ic8eba126bad92fb1b4a8a440d1b6c94a29f63125
2020-03-02 19:54:30 +00:00
TreeHugger Robot
f5324f74f5 Merge "Revert "Notification statsd logs: Notification panel."" into rvc-dev 2020-03-02 19:39:25 +00:00
Automerger Merge Worker
7686146070 Merge "Delete size limitation for ContrastColorUtil.isGrayScale() method. loss of performance is tiny because, image will be resized at ImageUtil.isGrayscale() method." am: 8157fac634 am: 55e52fcf66
Change-Id: Idf7bb89b2cf2f43f6d7c464d46f3743653155a7f
2020-03-02 19:12:44 +00:00
TreeHugger Robot
48eec146dc Merge "Fix intent resolver height calculation" into rvc-dev 2020-03-02 19:06:26 +00:00
Automerger Merge Worker
55e52fcf66 Merge "Delete size limitation for ContrastColorUtil.isGrayScale() method. loss of performance is tiny because, image will be resized at ImageUtil.isGrayscale() method." am: 8157fac634
Change-Id: I3abd10637d164a5501d380af70ae2a98afbc84bb
2020-03-02 18:55:28 +00:00
Will Brockman
3cc20a4ed8 Revert "Notification statsd logs: Notification panel."
This reverts commit 626f043a30.

Reason for revert: Frequent sysui crashes - https://buganizer.corp.google.com/issues/150566246

Bug: 150566246
Bug: 146488473
Change-Id: I124127553d8b69201d990c12da1e49218292b5ff
2020-03-02 14:17:45 +00:00
Yogisha Dixit
3222ef87b1 Merge "Store ambient display suppression state in memory." 2020-03-02 10:45:51 +00:00
SongFerngWang
53515a0ea6 CellularBatteryStats: Address API council feedback
Bug: 144925883
Test: Build pass, device boots up
atest TelephonyMetricsTest

Change-Id: Iac5904a3397a42aa5f015cb53bb63318f5c377a4
Merged-In: Iac5904a3397a42aa5f015cb53bb63318f5c377a4
(cherry picked from commit 84dc30fede)
2020-03-02 05:15:08 +00:00
Automerger Merge Worker
ea424f2599 Merge "Notification statsd logs: Notification panel." into rvc-dev am: 9eda5f5e32 am: 08ce857707 am: cda0187a20 am: 33e033d321
Change-Id: I05655a91e1db046699653f04acc93e47a21912cf
2020-03-01 18:38:06 +00:00
Will Brockman
9eda5f5e32 Merge "Notification statsd logs: Notification panel." into rvc-dev 2020-03-01 17:51:04 +00:00
SongFerng Wang
0de10d2c69 Merge "CellularBatteryStats: Address API council feedback" 2020-02-29 14:07:19 +00:00
Automerger Merge Worker
1531f2053f Merge "Several improvements and bug fixes to the inline autofill flow" into rvc-dev am: 0fe12dad61 am: be2c24d473 am: 594397cf37 am: 4c7ac86a34
Change-Id: Ic387434d27b9a9fc1818eacff0e30911584ac9db
2020-02-29 02:30:58 +00:00
TreeHugger Robot
0fe12dad61 Merge "Several improvements and bug fixes to the inline autofill flow" into rvc-dev 2020-02-29 01:35:19 +00:00
Feng Cao
ec496000ec Several improvements and bug fixes to the inline autofill flow
* Pipe the augmented autofill's inline actions through to the
  InlineSuggestionsResponse
* Do not send the inline action if the number of inline suggestions is
  zero
* Refactor autofill inline suggstion session so that all the calls to
  the IME has happens within the class
* Send an empty response to IME to hide the inline suggestion UI  when
  view exits and the previous response wasn't empty

Test: manual verification, atest InlineLoginActivityTest
Bug: 149522488
Bug: 150312201

Change-Id: I7a0dbf44e9fad6e7da857448c0f2b186e1681d17
2020-02-28 17:25:30 -08:00
arangelov
3d57e8a8ce Fix intent resolver height calculation
This CL makes the following changes:
- We update ResolverViewPager to wrap around
the tallest of its children. We can do that now
thanks to recent changes that load the inactive
tab.
- Place empty state screens at the top of the
tab content and update padding and text sizes
- Use layout_alwaysShow=true instead of trying
to calculate the proper height for the different
layout cases (with/without tabs, with/without
default app layout).

Test: manual
Bug: 149823158
Bug: 149822719
Bug: 149823253
Bug: 149817311
Bug: 148156663
Bug: 149824092
Change-Id: I81f9e8600e59b74c64584723054d309becf34f12
2020-02-28 16:40:06 +00:00
Automerger Merge Worker
097b548c24 Merge "PhoneWindow: Fix potential memory leak" into rvc-dev am: ee540c3245 am: 8d0a2cfa51 am: 6df8137b23 am: 452c6b1b22
Change-Id: I40f583452f5c40ef411b252768ae10e51791c343
2020-02-28 15:00:25 +00:00
Will Brockman
626f043a30 Notification statsd logs: Notification panel.
Experimenting with moving this logging to the SysUI side to be able to
log the complete panel, including any lifetime-extended items.

Test: atest NotificiationLoggerTest SystemUITests
Test: statsd_testdrive 245
Test: adb shell cmd stats print-logs && adb logcat -s statsd:I | grep ' (245)'

Bug: 146488473
Change-Id: I0a1a1ddd8838c002807e7137477175f0acceba98
2020-02-28 09:56:42 -05:00
Adrian Roos
ee540c3245 Merge "PhoneWindow: Fix potential memory leak" into rvc-dev 2020-02-28 13:58:48 +00:00
Automerger Merge Worker
9cb0920938 Merge "Zygote: migrate zygote start time metrics to StatsLog" into rvc-dev am: 720830ee90 am: 421713ccea am: 35887d7217 am: c840ab6b9c
Change-Id: I2fb4a01ac9c5ca55eaafc1118a13184e727d2aae
2020-02-28 00:54:28 +00:00
Keun young Park
ebac6a0d9b Zygote: migrate zygote start time metrics to StatsLog
- Also log second zygote start time as well.

Bug: 132691841
Test: check statsd dump
Change-Id: If749707dc5bcfefaeac1a476add076d2925af46d
2020-02-27 18:55:54 +00:00
Automerger Merge Worker
5caf1948e8 Merge "Include pending media as well when deleting mediastore entries." into rvc-dev am: 442399b1c1 am: 377d13b37e am: 49cf50aef9 am: f5f2b98b63
Change-Id: I504020913aca72138b00dd2e04553e974e007adf
2020-02-27 18:33:29 +00:00
Nicholas Ambur
626b24958f Merge "remove client token passing active VI service" into rvc-dev 2020-02-27 18:01:24 +00:00
Sudheer Shanka
442399b1c1 Merge "Include pending media as well when deleting mediastore entries." into rvc-dev 2020-02-27 17:49:53 +00:00
Adrian Roos
cd9cf09965 PhoneWindow: Fix potential memory leak
Fixes an issue where PhoneWindow and thus Activity can be leaked through AttachInfo through
the OnContentApplyWindowInsetsListener.

Fixes: 148799801
Test: make droid; atest WindowTest
Change-Id: I1de5518c84fd7e6d1aa1542a9252b1c600f5712d
2020-02-27 17:01:09 +00:00
SongFerngWang
84dc30fede CellularBatteryStats: Address API council feedback
Bug: 144925883
Test: Build pass, device boots up
atest TelephonyMetricsTest

Change-Id: Iac5904a3397a42aa5f015cb53bb63318f5c377a4
2020-02-27 15:59:31 +00:00
Automerger Merge Worker
c650f81ce8 Merge "Pipe windowToken for hideSoftInput" into rvc-dev am: 73b1d16d28 am: cec5307235 am: ef8ebae6e5 am: 9048c195bd
Change-Id: I8c57e69f16efa58d320c44caf5da795743137c3c
2020-02-27 08:08:22 +00:00
Taran Singh
73b1d16d28 Merge "Pipe windowToken for hideSoftInput" into rvc-dev 2020-02-27 07:14:04 +00:00
Tarandeep Singh
4fe5b654a1 Pipe windowToken for hideSoftInput
Pipe the windowToken of the window requesting hideSoftInput just like we
did it for showSoftInput [1].
This calls hideInsets on the correct display when control target is
different from IME target e.g. ActivityView.
Also hideInsets should be called on InsetsControlTarget instead which was
originally attempted in [2]

[1]: Ia49e23dd077d264a58d28a7b8acffde54b7db187
[2]: I7133e151a1037c42b275b97857936437a7a6725f

Bug: 149870112
Bug: 133381284
Test: Manually using steps mentioned in bug.

Change-Id: Ia596a392eb73ae46debd097151c8c9a7edd59833
2020-02-27 04:13:25 +00:00
Automerger Merge Worker
7d2e051d92 Merge "Add API constraints to ScheduledJobStateChanged atom" into rvc-dev am: 13ecf63ba4 am: 2477a07249 am: 8900c9a867 am: c60fc6dd96
Change-Id: I12ea889ce87d61ddaa6e84ed23da6e7595ae33f4
2020-02-27 03:48:05 +00:00
TreeHugger Robot
13ecf63ba4 Merge "Add API constraints to ScheduledJobStateChanged atom" into rvc-dev 2020-02-27 02:57:01 +00:00
Automerger Merge Worker
5c14fe0612 Merge "Move libstatssocket to shared." into rvc-dev am: cb50e94e7a am: 92851d4d55 am: 2198604a5c am: 4cc58dd008
Change-Id: I1b06900ea5f2298df552925b17068256a0a71e3d
2020-02-27 01:44:55 +00:00
Automerger Merge Worker
9eb82b7af2 Merge "Remove IME surface when hidden" into rvc-dev am: 05b07c2657 am: 6b925b391b am: 9dbb1c7868 am: 66a16fbb54
Change-Id: I66fc20443e4c42f67561898c63b19669c37a562c
2020-02-27 01:44:22 +00:00
Christian Wailes
f10e42e2ae Merge "Cleanup of Zygote files" 2020-02-27 01:14:29 +00:00
Jeffrey Huang
cb50e94e7a Merge "Move libstatssocket to shared." into rvc-dev 2020-02-27 01:00:01 +00:00
Taran Singh
05b07c2657 Merge "Remove IME surface when hidden" into rvc-dev 2020-02-27 00:53:09 +00:00
Automerger Merge Worker
bad916c8a8 Merge "Start InstanceIDs at 1." into rvc-dev am: e1e7c02af4 am: 04d3a37b74 am: 764d127601 am: 59152ba9fc
Change-Id: Ieff2e27823a9b977292a89355b1ad9795430de62
2020-02-26 21:26:23 +00:00
Jeffrey Huang
21f7e6a3f6 Move libstatssocket to shared.
This fixes the boot loop when zygote tries
to log to statsd during boot time.

Linking libstatssocket statically from two different places
causes translation errors resulting in multiple instances of the
same struct being created. This meant that the struct is no longer
shared across the same process for opening/closing of the socket.

Bug: 149889582
Test: Phone boots
Change-Id: Ibfa25c0fe7874ba08157a5ec43601c5cf8305723
2020-02-26 11:51:26 -08:00
Tarandeep Singh
94c9a8328e Remove IME surface when hidden
When IME is no longer shown, notify IMS to hide the window surface.
This reclaims the memory allocated to IME window surface.

Fix: 150163310
Test: atest CtsInputMethodTests
      Manually:
      1. Open any app that has editor  and run
         adb shell  dumpsys SurfaceFlinger | grep Total
      2. Note down total memory
      3. Tap on editor and IME shows. Note down memory
         using command in #1. It should go up by ~27MB
      4. Hide IME and note down memory again.
         It should revert to original value in #1.

Change-Id: I6c2a13dd40b22d3fd62b4763ba369992e5ff1138
2020-02-26 18:58:33 +00:00
Eugene Susla
ab14c55c1f Generate @NonNull setter args and @MaySetToNull to opt out
Bug: 143653080
Test: source /usr/local/google/home/eugenesusla/android2/master/frameworks/base/tests/Codegen/runTest.sh
Change-Id: Iba8da34c91fd09e266429ab131add1d53449506b
2020-02-25 19:04:47 -08:00
Chris Wailes
94b45280d4 Cleanup of Zygote files
This CL cleans up some warnings in the ZygoteInit.java and
ZygoteServer.java files.  These warnings were mostly about unused
variables, protection class changes, and dead code.  Some changes
to code in Zygote.java and ZygoteConnection.java were needed due to
function signature changes.

Test: Built and booted image
Change-Id: I6ba33cfcb4729a75dbbd4f908f4b46110d3bb991
2020-02-25 15:55:31 -08:00
Will Brockman
4f0f9d2d85 Start InstanceIDs at 1.
Protobufs make it easy to confuse default and unset values.

Test: atest NotificationManagerServiceTest
Fixes: 149760215
Change-Id: Ia27f33cb8331960369f86e75ac3cfa148dad887a
2020-02-25 18:57:32 +00:00
TreeHugger Robot
20ea7f5258 Merge "Introduce SoftInputShowHideHistory" into rvc-dev 2020-02-25 05:35:25 +00:00
e.min
3daed10832 Delete size limitation for ContrastColorUtil.isGrayScale() method.
loss of performance is tiny because, image will be resized at ImageUtil.isGrayscale() method.

Test: situation that one notification is sended to other resoltion devices, ex) using DEX mode,
Test: notification can be inflated at different resolution context.
Test: and app can have notification icon that is made dynamically.
Test: (it doesn't have resource for each resolution. ex: calendar notice icon with number)
Test: at this moment, judgement for grayscale can be differed from each device.
Change-Id: I2755c56869aba58287137f683a81ec4ddfd3d7c1
2020-02-25 10:53:09 +09:00
Nicholas Ambur
1ec50c8f2f remove client token passing active VI service
Previous implementation relied on client to pass a token which the
service used to verify if it was the active service. This is seen to be
a security concern as there is no way to verify how the client obtained
the token. Instead, a check is done to confirm the caller's UID matches
the UID of the active service.

In the case of voice model enrollment, KeyphraseEnrollmentInfo class is
leveraged. A client is allowed to enroll if it is the active voice
interaction service or if it is a voice model enrollment application
bundled with the system image.

All previous manifest permision checks still apply.

Bug: 148159858
Test: gts-tradefed run gts-dev -m GtsAssistIntentTestCases -t \
com.google.android.assist.gts.KeyphraseModelManagerTest \
\#testShouldEnrollOnlyWhenActiveService

Merged-In: Ie2c4653d365770a9123a22bc69822518b4ccc568
Change-Id: Ie2c4653d365770a9123a22bc69822518b4ccc568
(cherry picked from commit c6f4118f9e)
2020-02-25 01:20:05 +00:00
Nicholas Ambur
d291d14a39 Merge changes from topic "voiceinteraction-access-control"
* changes:
  remove client token passing active VI service
  add enrollment application UID tracking
2020-02-24 23:13:11 +00:00
Suprabh Shukla
1b5778d119 Add API constraints to ScheduledJobStateChanged atom
This helps us know if jobs with a particular constraint are being
starved or otherwise dysfunctional due to a bug.

Test: make statsd_testdrive &&
./out/host/linux-x86/bin/statsd_testdrive 8

Sample output:
    atom {
      scheduled_job_state_changed {
        attribution_node {
          uid: 10224
          tag: ""
        }
        job_name: "android.jobscheduler.cts.jobtestapp/.TestJobService"
        state: SCHEDULED
        stop_reason: STOP_REASON_CANCELLED
        standby_bucket: RESTRICTED
        job_id: 691
        has_charging_constraint: true
        has_battery_not_low_constraint: true
        has_storage_not_low_constraint: false
        has_timing_delay_constraint: false
        has_deadline_constraint: true
        has_idle_constraint: true
        has_connectivity_constraint: true
        has_content_trigger_constraint: false
      }

Bug: 138239687
Change-Id: I175e5a0f5cc2cb3be447ccb58142006946092e75
2020-02-24 19:09:46 +00:00
Dieter Hsu
0dbbb422e2 Retry TTS speaking for a11y shortcut warning dialog
TTS engine might fetch data over the network or prepare data when
binding tts service at first time after boot that may take a few
seconds. Because the dialog is shown only once and on-demand for
enableing accessibility shortcut, it's unable to speak successfully
unless others have bound tts ahead of time.

Bug: 139887992
Test: 1. adb shell settings delete secure accessibility_shortcut_dialog_shown
      2. manual reboot, long press both vol keys and tts speaks
Test: Add 2nd user and long press both vol keys and tts speaks
Test: atest AccessibilityShortcutControllerTest

Change-Id: I6290f0a64d1a51aa46f13e7d88a15a096ddb0fdc
Merged-In: I6290f0a64d1a51aa46f13e7d88a15a096ddb0fdc
2020-02-24 08:14:12 +00:00