Commit Graph

12908 Commits

Author SHA1 Message Date
Winson Chung
687bcb7f33 Skip updating exclusion rects unless one is set
Bug: 140775753
Bug: 140701977
Bug: 140758369
Test: atest google/perf/jank/SystemUI/UbSystemUIJankTests:android.platform.systemui.tests.jank.SystemUiJankTests#testQuickSettingsPull -v
Change-Id: I824ca918d141eb88aa99b1e90adafe64ca3eb672
2019-09-16 22:41:45 +00:00
Mady Mellor
fd48588768 Merge "qt-r1-bubbles-dev @ build 5835883" into qt-qpr1-dev 2019-09-16 21:55:51 +00:00
Priyank Singh
3228b57d8e Status bar background color should not be transparent.
Bug: 130431689
Test: Manual
Change-Id: Ida8788f2d758eedaf5db0139f81a65402ba0b88b
2019-09-11 23:46:26 +00:00
Mady Mellor
a5813e0e3d qt-r1-bubbles-dev @ build 5835883
Test: presubmit setup on source branch

Bug: 126945401
Bug: 128932906
Bug: 129158983
Bug: 130237686
Bug: 130250809
Bug: 130442248
Bug: 131267438
Bug: 131609280
Bug: 131692350
Bug: 131849856
Bug: 133444037
Bug: 134064116
Bug: 134064858
Bug: 134070807
Bug: 134077101
Bug: 134090085
Bug: 134155107
Bug: 134423445
Bug: 134512898
Bug: 134514210
Bug: 134514227
Bug: 134734945
Bug: 134960381
Bug: 134989736
Bug: 135214687
Bug: 135280077
Bug: 135472021
Bug: 135475155
Bug: 135487618
Bug: 135488406
Bug: 135518045
Bug: 135633218
Bug: 136034310
Bug: 136150954
Bug: 136199542
Bug: 136538998
Bug: 137201711
Bug: 137213469
Bug: 137214359
Bug: 137214536
Bug: 137233453
Bug: 137876221
Bug: 138301618
Bug: 138445026
Bug: 138659213
Bug: 138749133
Bug: 138799651
Bug: 138801505
Bug: 138941969
Bug: 139002444
Bug: 139025304
Bug: 139816141
Change-Id: Ia7364529ea58070c8d45ecd726ab6ac7d34f2abe
Merged-In: Ic271a6a0f0803941dd5a84124dabf4d8c5fcc755
Merged-In: Ic3a4ba793db7f1361678ef51c411d9eab85d9b85
2019-09-11 22:42:54 +00:00
TreeHugger Robot
b85d750900 Merge "Fix regression in updating gesture exclusion rects" into qt-qpr1-dev 2019-09-04 07:17:54 +00:00
TreeHugger Robot
79243ed6c6 Merge "Skip updateCursorAnchorInfo when matrix is null" into qt-qpr1-dev 2019-09-04 01:01:31 +00:00
Winson Chung
05a36465b4 Fix regression in updating gesture exclusion rects
- Use the precalculated aggregate visibility instead of traversing
  hierarchy again in isShown()

Bug: 140157754
Test: atest SystemGestureExclusionRectsTest
Change-Id: Ica58de4ff43da75cfcdac3f359fc915f65608e78
2019-09-03 12:15:08 -07:00
Winson Chung
61cfd71d39 Ignore hidden views when computing exclusion rects
Bug: 138806473
Test: atest SystemGestureExclusionRectsTest
Change-Id: I43629546af641d2b6347889e3ea10bd2cbbe9070
2019-08-22 16:36:18 -07:00
Tarandeep Singh
561a199ac7 Skip updateCursorAnchorInfo when matrix is null
Sometimes, the activityViewToScreenMatrix is null, we should skip
updateing cusor anchor info in such cases.
Fix: 139135335
Test: Manually using the steps in bug.

Change-Id: Ie58ad9a311a8f630b0a6d27d60ca017abc95ef45
2019-08-22 01:24:04 +00:00
Mihir Patel
245fc50ce7 Merge "Fixing a bug where content capture sessions with child sessions could get stuck in a state where no event flushing other than forced flushes would occur" into qt-r1-dev
am: 4aa0aeadff

Change-Id: Iadf1c43fc5b38ab432e4bc2f47d50dd911f725ed
2019-08-19 13:34:24 -07:00
Mihir Patel
f70d85032d Merge "Fixing a bug where content capture sessions with child sessions could get stuck in a state where no event flushing other than forced flushes would occur" into qt-r1-dev
am: 4aa0aeadff

Change-Id: Ie885e7fd929e54f62ae920ec8840d8abb0c5075f
2019-08-19 13:33:33 -07:00
Mihir Patel
52ed9ee038 Fixing a bug where content capture sessions with child sessions could get stuck in a state where no event flushing other than forced flushes would occur
Fixes: 139202268
Test: atest CtsContentCaptureServiceTestCases
Change-Id: I21e9d4db2402fe5210b7d938dac2f12e7557c146
2019-08-09 14:10:30 -07:00
Issei Suzuki
94e8d116ab DO NOT MERGE: Support alpha value in SurfaceView.
For backward compatibility, SurfaceView ignores alpha value by
default. In order to reflect alpha value set on the SurfaceView
to its underlying surface, setUseAlpha() needs to be called.

Translucent alpha only works when the surface is placed z-above.
Otherwise only fully opaque and transparent status are supported.

Bug: 137937105
(Orignal bug from b/130442248)
Test: Manual, use BubblesTest app and checks if alpha is set.
Change-Id: I86847de59109b2adf12a2c7c50c988c2cbcf0450
2019-08-09 14:08:03 +00:00
Adrian Roos
15195e080b GestureNav: Log exclusion rect heights
am: 5f2c9a14f5

Change-Id: I1486dc89e9502351961156b0f1094ef7ad77c45c
2019-08-05 14:19:15 -07:00
Adrian Roos
5f2c9a14f5 GestureNav: Log exclusion rect heights
Logs the rejected and requested exclusion rect heights.

Test: adb shell device_config put android:window_manager key_system_gesture_exclusion_log_debounce_millis 1000
Bug: 135152789
Change-Id: Ie12640f4bf0a8b40b666e604188a0bedd85e8981
Exempt-From-Owner-Approval: DeviceConfig.java: Adding constant to WindowManager namespace.
2019-08-05 21:19:40 +02:00
Jorim Jaggi
a830816c8f Merge "Fix overlapping remote and recents animations" into qt-r1-dev
am: b248a0343f

Change-Id: I13810205eddf4531786ef93c1568ed28d4004cf2
2019-08-05 11:40:07 -07:00
Jorim Jaggi
b248a0343f Merge "Fix overlapping remote and recents animations" into qt-r1-dev 2019-08-05 18:12:56 +00:00
Jorim Jaggi
589c5ba0fa Fix overlapping remote and recents animations
Test: Open app and immediately swipe up while opening. Verify
Thread prioties in systrace

Test: WindowProcessControllerTests
Fixes: 137881181
Change-Id: Ic1d7403d2a648e6f1d1b6a3d55b56bf37bc57a2c
2019-08-05 17:10:18 +02:00
Adrian Roos
1bb6408678 Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev am: c9f4bcae57
am: 91ce40fa1a

Change-Id: I08769de094ffddb0f0d1a30ac8b9cd28cfe19ed8
2019-08-02 13:29:55 -07:00
Adrian Roos
91ce40fa1a Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev
am: c9f4bcae57

Change-Id: I0581305f01ebdaa121ce0e70ab9d44f142c9f99f
2019-08-02 05:42:10 -07:00
Adrian Roos
c9f4bcae57 Merge "GestureNav: Clarify javadoc in regards to exclusion limits" into qt-dev 2019-08-02 12:17:11 +00:00
Adrian Roos
e6feb7d198 GestureNav: Clarify javadoc in regards to exclusion limits
Bug: 124518180
Test: m checkapi
Change-Id: I43b0b890a763e339deb246cabf9adbf011eae088
2019-07-26 14:50:03 +02:00
Vadim Caen
ed1f376605 DO NOT MERGE Do not call drawableChanged pre Q am: 843f9dee8b
am: 605e74c930

Change-Id: I48a298c8d8bb55b2b04c5a4ab1ad234922166ca3
2019-07-24 16:50:41 -07:00
Vadim Caen
605e74c930 DO NOT MERGE Do not call drawableChanged pre Q
am: 843f9dee8b

Change-Id: I813f41905386da06e6eaebd6b7f85c17a6051456
2019-07-24 16:19:39 -07:00
Vadim Caen
843f9dee8b DO NOT MERGE Do not call drawableChanged pre Q
Some apps rely on not updating the window format when changing the
background of the DecorView. To keep the compatibilty with these app we
add only call DecoreView.drawableChanged() when the window background is
changed on app targetting Q and above.

Test: Manually test by lunching Instagram TV and pressing return twice.
The window should aninate with no flickering.
Bug: 136987724

Change-Id: I3593d30dc6f10519008151974e475f0dad86fc64
2019-07-24 21:29:12 +00:00
Winson Chung
7ff14a69cf Merge "Modify deferred recents animation cancel to work without screenshot" into qt-r1-dev
am: 48e3cfc06a

Change-Id: If607c33898a4a4ed75a3768ae1027507edfc0437
2019-07-23 22:25:45 -07:00
Winson Chung
7a545ae9cc Modify deferred recents animation cancel to work without screenshot
- Allow the recents animation runner to request deferring a cancel from
  stack order change until the next app transition start without using
  a screenshot. This allows launcher to set this state, then start an
  activity without a flash due to the animation not finishing immediately
- Always prepare a transition when using the deferred cancel to ensure
  an app transition callback
- Handle app transition canceled as well (if canceled, we continue to
  cancel recents the animation with/without the screenshot as requested)
- Remove internal lock and use the global WM lock when setting the defer
  cancel state
- Renamed a few methods to clarify the deferred cancel flow

Bug: 137196872
Test: atest FrameworksServicesTests:RecentsAnimationControllerTest
Test: atest WmTests:RecentsAnimationTest
Change-Id: Ie8f6f60b6bf6777e36f24749b30f90c8c26ee848
2019-07-23 15:50:33 -07:00
Adrian Roos
0752f6d036 Merge "GestureNav: make reportSystemGestureExclusionChanged oneway" into qt-dev am: d4a50e6e72
am: 7c77af6371

Change-Id: I69d6088d4c4354a97048aed171060c79993fedbd
2019-07-16 15:20:23 -07:00
Adrian Roos
7c77af6371 Merge "GestureNav: make reportSystemGestureExclusionChanged oneway" into qt-dev
am: d4a50e6e72

Change-Id: I9f837989727c263517aa0d2f3dfd47a830f6170c
2019-07-16 15:00:35 -07:00
Adrian Roos
e6911497de GestureNav: make reportSystemGestureExclusionChanged oneway
When the WindowManager lock is contended, reportSystemGestureExclusionChanged can cause
jank. Making it oneway avoids this.

Fixes: 137650591
Test: make droid
Change-Id: I5d96b7e2225745b146014ad11cafaf0ad9a1b734
Merged-In: I5d96b7e2225745b146014ad11cafaf0ad9a1b734
2019-07-16 20:29:03 +00:00
Issei Suzuki
927fe872b2 DO NOT MERGE: Support alpha value in SurfaceView.
For backward compatibility, SurfaceView ignores alpha value by
default. In order to reflect alpha value set on the SurfaceView
to its underlying surface, setUseAlpha() needs to be called.

Translucent alpha only works when the surface is placed z-above.
Otherwise only fully opaque and transparent status are supported.

Bug: 130442248
Test: Manual, use BubblesTest app and checks if alpha is set.
Change-Id: I86847de59109b2adf12a2c7c50c988c2cbcf0450
2019-07-10 17:17:36 +02:00
Issei Suzuki
03c2c10230 DO NOT MERGE: Clean up SurfaceView.
Bug: 136538998
Test: no-op refactoring CL. Existing unit tests still pass.
Change-Id: Idd6c5871ed34880a053f3a43ab4f7aa3a466b548
2019-07-10 17:17:36 +02:00
Issei Suzuki
33727a0e81 DO NOT MERGE: Clean up SurfaceView
Bug: 136538998
Test: no-op refactoring CL. Existing unit tests still pass.
Change-Id: Ibd0310a87ed38aa48215be9cba54f1c7a2a8a9fa
2019-07-10 17:17:36 +02:00
chaviw
dd5bde0a3c DO NOT MERGE: Deleted SurfaceControl.remove method
Updated all callers of SC.remove to use Transaction.remove(sc) and apply
immediately since that's the equivalent. Eventually, the transactions
that contain remove could combine with other transactions if it makes
sense to avoid duplicate applies.

Test: SurfaceControlTest
Change-Id: I13c6ec86de6a6d60f142c2269337557510dd006d
Exempt-From-Owner-Approval: Already approved and merged in master.
2019-07-10 10:02:08 +00:00
Issei Suzuki
9127d3cf43 DO NOT MERGE: Extend ViewRootImpl to support multiple FrameDrawingCallback
Bug: 136150954
Bug: 130442248
Test: Manual, Bubble test app to check if the callback is triggered.
Change-Id: I690005fece924c38a5269cb35309061d0ccb6f1e
(cherry picked from commit 935935660c)
2019-07-01 14:05:49 +00:00
Mathew Inwood
f405e83cdc Merge "Restore some greylist entries." into qt-dev
am: f4535c8d51

Change-Id: I9349026a5f99cb2ebac1d9fadd3c716e8a06aaa3
2019-06-28 13:18:28 -07:00
Mathew Inwood
a5531fa161 Restore some greylist entries.
In Q, these APIs were either:
- removed from the greylist entirely without good reason
- Moved to the restricted greylist without any public alternative
  information added

So they are being moved back to the greylist for Q.

Test: Treehugger
Bug: 136102585
Change-Id: Ie3dd15c8e17d530d853473a013717e6175383080
2019-06-28 09:23:06 +00:00
Peiyong Lin
964fcdbebd Merge "Attach color space information when attach and queue buffer." into qt-r1-dev 2019-06-27 16:14:02 +00:00
Peiyong Lin
ccc06b6f51 Attach color space information when attach and queue buffer.
Currently when calling attachAndQueueBuffer, the color space information is
lost. This results in color shift if the color space doesn't match the color
space of the surface.

BUG: b/135002842, b/131928312
Test: boot. Manually verified on P19
Change-Id: I95ec73c24942f79197d25ee85f139b2aaf805677
2019-06-26 11:40:08 -07:00
Winson Chung
abe1a94072 Merge "Catch all exceptions in onFrameDraw" into qt-dev
am: cff24b878d

Change-Id: If3aef1ccbba89a4b0964749ee3184a83f88185be
2019-06-25 15:43:48 -07:00
Winson Chung
cff24b878d Merge "Catch all exceptions in onFrameDraw" into qt-dev 2019-06-25 22:07:44 +00:00
Jorim Jaggi
b0bb2f778f Catch all exceptions in onFrameDraw
... as throwing an exception in there somehow will mess up the
hwui task queue.

Test: Have a crashy app, swipe up while the app is crashing
Fixes: 134583193
Change-Id: Ie3ba5f991759f807b154f55f9fc816e7efe2fdfe
2019-06-25 15:37:53 +02:00
Issei Suzuki
0ca1dbcb25 Merge "Added subtle animation for unlocking screen." into qt-r1-dev 2019-06-25 11:22:26 +00:00
TreeHugger Robot
e6930c4aa1 Merge "Fixed event flushing to handle when mDirectServiceInterface is not ready yet." into qt-r1-dev 2019-06-24 18:42:45 +00:00
Issei Suzuki
5609ccbf95 Added subtle animation for unlocking screen.
Change-Id: Id691fec4f2e492682a53d6855090524f000ddc6c
Bug: 134965724
Bug: 134952761
Test: N/A
2019-06-24 14:25:04 +00:00
Robert Carr
9e4b7a3f8d Merge "ViewRootImpl: Ensure layout when configuration changes." into qt-dev
am: 6397ab05f9

Change-Id: I17feac89670b328f88878ce57636cf4954e0c6f3
2019-06-21 17:30:57 -07:00
John Reck
5866a0c6ab Revert SurfaceView back to Q's version
Revert API behavior changes to SurfaceView, snapping
back to Q's version.

Bug: 133378280
Test: none
Change-Id: I3a47f9bfdfab2d16707f952a9af672551736e681
2019-06-19 11:39:20 -07:00
Adam He
d93ed17d5e Fixed event flushing to handle when mDirectServiceInterface is not ready
yet.

Fixes: 135474027
Test: atest CtsContentCaptureServiceTestCases
Change-Id: I5bc12cd5f48138650c82b052c785a505fc8f4773
2019-06-18 16:51:57 -07:00
Robert Carr
437c0e4c15 ViewRootImpl: Ensure layout when configuration changes.
When the configuration changes between landscape and reverse
landscape, the app will not receive onConfigurationChanged as
orientation is not part of the public portion of the configuration.
However, when the ViewRootImpl receives such a configuration back from
relayout, it will force a layout of the client views
(see updatedConfiguration in performTraversals), this is because
Configuration#equals compares the non public part of the configuration
as well. This CL changes MSG_REPORT_RESIZED to handle the configuration
changing the same way performTraversals does, so that the app consistently
receives a configuration change.

Bug: 134643273
Test: Manual
Change-Id: If016bcd9a5b8d2a7efc5e1ab3c82a88a608caf8b
2019-06-18 16:12:29 -07:00
lumark
c0ecccca16 Merge "Make InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED testable." into qt-dev
am: b7abebde5b

Change-Id: I7459ec72287ffa36bcc11e9cce87d9a4258705d5
2019-06-18 05:32:28 -07:00