Commit Graph

13520 Commits

Author SHA1 Message Date
Stanislav Zholnin
54762b293e Prevent developer provided strings from being uploaded through statsd.
- in situation when developer provides message when op is noted, do not
report it through stack trace collection infrastructure
 - collect only statcktraces for OP_FLAG_SELF and OP_FLAG_TRUSTED_PROXIED to
match collection of appops counts

Test: atest  android.app.appops.cts.RuntimeMessageCollectionTest
Fixes: 159433071
Change-Id: I1ab56a530832873a1f1f68aba5ab6eabc9e8a17a
2020-06-19 19:43:03 +01:00
Evan Rosky
a9233b0aab Merge "Fix support for split-screen w/ non-resizable home" into rvc-dev 2020-06-19 02:06:38 +00:00
Evan Rosky
89c285ebde Fix support for split-screen w/ non-resizable home
First, this treats non-resizable minimized the same as
resizable minimized except with a status-bar height primary.
This differs from before in that the dividerbar remains
visible/usable -- this makes it more obvious to the user that
they are in split-screen mode.

Second, this actually places the home stack into the split
secondary root and overrides its windowing-mode to fullscreen.
This is needed because otherwise it can't properly interleave
with the other secondary tasks -- which would cause backing-out
of the secondary task to return to recents instead of home.

Both of these combined also allows us to clean up some
special-case code.

Bug: 159247878
Test: Use split-screen with non-resizable 3p home.
Change-Id: Idc2050703d972a4b2fa8f74f5827bcc126dce832
2020-06-18 14:25:27 -07:00
TreeHugger Robot
ab3811efea Merge "Resolver/Chooser - Fix reuse of textview" into rvc-dev 2020-06-18 17:56:30 +00:00
Hunter Knepshield
9568960297 Merge changes from topic "bugreport-stub" into rvc-dev
* changes:
  Reevaluate some carrier-associated apps' status on SDK changes.
  Add new "addedInSdk" attribute to carrier-associated apps.
2020-06-18 17:01:01 +00:00
Matt Pietal
2d0c7b02bc Resolver/Chooser - Fix reuse of textview
Upon reuse of a view by the recyclerview, it was possible to show a
reused view's sublabel, as it was doing incorrect comparisons. Make
sure to always reset the textviews, and hide it if necessary.

Fixes: 150813955
Test: manual, but helpful to have many apps installed and launch the sharesheet
Change-Id: Idb0c03c0b0917104bd9f26cdd9ed33a0055fa6f2
2020-06-18 12:16:56 -04:00
TreeHugger Robot
ae64ae50de Merge "Resolver - Center text with no sublabel" into rvc-dev 2020-06-18 13:16:56 +00:00
Sudheer Shanka
b52a288e0c Merge "Maintain the fuse buffer pool keyed by inode instead of threadId." into rvc-dev 2020-06-18 09:46:29 +00:00
Luke Huang
7144459282 Merge "Disable sockets and DNS if process lacks INTERNET permission." into rvc-dev 2020-06-18 03:03:06 +00:00
Luke Huang
6f214e8ebe Disable sockets and DNS if process lacks INTERNET permission.
This is a Client-only solution.
  - Add to NetdClient a per-process std::atomic_boolean
    similar to netIdForProcess and netIdForResolv.
  - The boolean says whether the process should be
    allowed Internet connectivity.
  - Add an @hide method to NetUtils.java to set the boolean;
    call it from the initialization code of the new
    process just after forking from zygote.
  - Make netdClientSocket and dnsOpenProxy check the
    boolean. If the boolean is false, return EPERM from
    socket calls.

Bug: 150028556
Test: atest NetworkUtilsTest
Test: atest CtsAppSecurityHostTestCases:UseProcessTest
Change-Id: If002280fbad493dfc2db3d9d505c0257d49a9056
Exempt-From-Owner-Approval: OWNERS already approved identical patchset 5
2020-06-18 03:02:06 +00:00
TreeHugger Robot
b0c2439535 Merge "Include orignal componentName of ChooserTargets, when pass ChooserTargets sharing and impression events to AppPredictionService." into rvc-dev 2020-06-17 21:45:44 +00:00
Matt Pietal
a4d5e8c9b7 Merge "Sharesheet - Don't update list on bg thread" into rvc-dev 2020-06-17 19:49:41 +00:00
TreeHugger Robot
728da7002e Merge "Fix collapsed group message text alignment" into rvc-dev 2020-06-17 19:16:49 +00:00
TreeHugger Robot
8525b71e2a Merge "Rename "Westworld" to "Statsd"" into rvc-dev 2020-06-17 18:50:27 +00:00
Matt Pietal
dd6ed8ecbb Resolver - Center text with no sublabel
Also avoid breaking sharesheet, as the sublabel was intentionally
being marked visible with no text for better alignment.

Fixes: 149622636
Test: manual + atest ResolverActivityTest
Change-Id: Id65058de70cf70c4cb18940e75f4c5051f1da25c
2020-06-17 13:54:57 -04:00
Steve Elliott
70f970f80b Merge changes If8d5b906,I861d6ef7 into rvc-dev
* changes:
  Fix alignment of expanded bundled group convo avatar
  Truncate sender name in collapsed group message.
2020-06-17 17:47:02 +00:00
Winson Chung
a1423286b2 Merge "Use new insets apis for determining the stable/system insets" into rvc-dev 2020-06-17 17:26:49 +00:00
Antoan Angelov
3258a3e170 Merge "Also check inactive profile targets in onHandlePackagesChanged" into rvc-dev 2020-06-17 16:05:07 +00:00
Winson Chung
05b5f976d7 Use new insets apis for determining the stable/system insets
- The old calls appear to account for the display cutout now which causes
  the landscape/seascape comparison to fail

Bug: 157878422
Test: atest TaskSnapshotControllerTest
Test: TaskSnapshotSurfaceTest
Test: DecorViewTest
Test: Open an app with displaycutout layout shortEdge or always, and
      rotate to landscape in non-gestural mode, and ensure that the
      divider and background are drawn in the right place
Change-Id: Ib51964a76e25f902858aad4e8aeb810dfca2edc0
Merged-In: Ib51964a76e25f902858aad4e8aeb810dfca2edc0
2020-06-17 16:01:46 +00:00
Steve Elliott
3e8e61df11 Fix collapsed group message text alignment
Fixes: 155499457
Test: manual
Change-Id: Ib98ac5204f5518368b76df852241f33d39a05490
2020-06-17 11:58:00 -04:00
Antoan Angelov
acfac74964 Merge "Re-setup viewpager on configuration change for RTL languages" into rvc-dev 2020-06-17 15:00:51 +00:00
arangelov
581a3c5800 Also check inactive profile targets in onHandlePackagesChanged
Before we would only check the active tab for available
targets and finish the activity if there are none.
However, with the work tab, there can be cases where
the active tab has no targets, but the inactive tab does.

Fixes: 159202588
Test: manual
Change-Id: Ie03ebd1b022362681df432ec29299df86dceb490
2020-06-17 12:57:57 +00:00
arangelov
5f416b9452 Re-setup viewpager on configuration change for RTL languages
Otherwise rotating the device while showing a tab with RTL
shows blank tab content. This could be due to ViewPager
bugs when handling RTL.

Fixes: 158862939
Test: manually rotating the device with RTL layout
Test: manually rotating the device with LTR layout
Change-Id: Iba4c71cf88747d6fbbc36d19b5102460e8aa7cec
2020-06-17 12:57:47 +00:00
arangelov
9a960b740e Disable side swiping on RTL languages
The internal ViewPager seems to not handle RTL well. This CL
disables side swiping in that case.

Fixes: 159110029
Test: manually confirmed side swiping does not happen on RTL
languages
Test: manually side swiped on non-RTL languages

Change-Id: I30272426d1d1ef4f17ec656630cee01505f66c59
2020-06-17 10:15:38 +00:00
Muhammad Qureshi
4f4910ab73 Rename "Westworld" to "Statsd"
Bug: 158725651
Test: N/A; trivial name change
Change-Id: I1bac4ad010ff7fea62a9d9564ba981d74b206aff
2020-06-16 18:45:22 -07:00
Steve Elliott
4594603f1e Fix alignment of expanded bundled group convo avatar
Fixes: 159043203
Test: manual
Change-Id: If8d5b906d79c9dfcc5e99d8162f73d0f7d09e6e1
2020-06-16 20:58:52 -04:00
Steve Elliott
7da4bccd8a Truncate sender name in collapsed group message.
Fixes: 158769554
Test: manual, visual
Change-Id: I861d6ef755eac2c41e3ae2e2ca01d4a2dfeeecc8
2020-06-16 20:58:52 -04:00
Hunter Knepshield
1172ffa7c2 Add new "addedInSdk" attribute to carrier-associated apps.
Previously, the sysconfig wasn't capable of understanding
carrier-associated apps that were added after a device's initial launch
(i.e. via OTA) because the logic in CarrierAppUtils explicitly avoids
disabling such apps a second time.

Most of this change is just plumbing everything through. For now, it's
all @hide due to R API deadlines. It will be made public in S.

Bug: 154872019
Test: manual, QA, atest FrameworksTelephonyTests:CarrierAppUtilsTest
Change-Id: I530a4f73146b09879547ca2e0c26428957fef37a
2020-06-16 16:48:38 -07:00
TreeHugger Robot
892d269b65 Merge "Guard against NPE in ServiceConnector" into rvc-dev 2020-06-16 23:11:11 +00:00
Eugene Susla
2ae38f3856 Guard against NPE in ServiceConnector
Fixes: 157759109
Test: presubmit
Change-Id: Ic1f594e667af50c0df8e566be4efdbaab6dccb26
2020-06-16 13:38:48 -07:00
Sudheer Shanka
c608143486 Maintain the fuse buffer pool keyed by inode instead of threadId.
In order to save memory, FuseAppLoop maintains a buffer pool to use
when dispatching the read/write requests. Currently, it uses
the threadId of the ProxyFileDescriptorCallback as the key for this
buffer pool and this can result in an issue when a caller creates
multiple ProxyFileDescriptors with ProxyFileDescriptorCallbacks
running on the same thread. When this happens, it is possible that
a buffer is reused before a read/write request which was using it
earlier has been handled and would result in data from read/write
requests on different fds getting mixed up.

Bug: 158568683
Test: atest --test-mapping apex/blobstore
Change-Id: Iaffd54f4430ecb3778f01c80f5a1684ac448f8dc
2020-06-16 13:07:42 -07:00
Matt Pietal
0aefc0cefc Sharesheet - Don't update list on bg thread
Found a potential issue where the adapter list was being updated on
the bg thread, and could cause conflicts while the recyclerview is
loading.

Fixes: 159028662
Test: atest ChooserActivityTest
Change-Id: I60abd9a8325964ed2ca1218e8846f816b02da431
2020-06-16 14:04:52 -04:00
TreeHugger Robot
26dfdc587f Merge "Implementation of sharding for procstats atoms" into rvc-dev 2020-06-16 17:12:16 +00:00
Song Hu
c6297c89f9 Include orignal componentName of ChooserTargets, when pass ChooserTargets sharing and impression events to AppPredictionService.
Bug: 159121173
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Change-Id: Ifd4bfbdaec55ed16c4fcb3f835f8bc4569b87a40
2020-06-16 09:28:55 -07:00
Jorim Jaggi
8ec4d3a33f Merge "Revert "Revert "Remove IME surface when occured in multi-window mode""" into rvc-dev 2020-06-16 12:56:20 +00:00
Yunfan Chen
c02a5ac5bb Revert "Revert "Remove IME surface when occured in multi-window mode""
This reverts commit 2a38a35622.

Reason for revert: The original CL was reverted for b/158836294 and it turned out to be innocent. Re-land the CL.

Bug: b/155660756

Change-Id: Iada83e80059e7cb9566bb7ad4e4c9909b4ed794a
2020-06-16 01:54:41 +00:00
Richard Gaywood
52a2edf548 Implementation of sharding for procstats atoms
Oftentimes, the ProcStats protobuf is larger than StatsEvent can handle.
With this CL, we detect that state before it happens, and attempt to
shard the ProcStats data over multiple protobufs, each with its own
StatsEvent.

Test: see b/158294266
Bug: 158294266
Change-Id: I1787d0ddeb6825a55adb8e0e1ec55c89af6990c5
2020-06-15 16:08:35 +00:00
TreeHugger Robot
3fb94d8e9d Merge "Add logging on sharesheet displayList to help investigate issue that icons launch different apps unexpectedly." into rvc-dev 2020-06-15 12:12:07 +00:00
Lorenzo Colitti
242087ad3e Merge "Automatically add FEATURE_IPSEC_TUNNELS for Q+ devices." into rvc-dev 2020-06-15 09:06:29 +00:00
Song Hu
f473e42f96 Add logging on sharesheet displayList to help investigate issue that icons launch
different apps unexpectedly.

Bug: 158172791
Test: manual test on the phone
Change-Id: I003b83f6a76dca2f97cfd43b2f265ad572f0e5c5
2020-06-14 14:50:54 -07:00
TreeHugger Robot
a840c1f3ea Merge "Revert "Remove IME surface when occured in multi-window mode"" into rvc-dev 2020-06-12 23:08:13 +00:00
Jerome Gaillard
2a38a35622 Revert "Remove IME surface when occured in multi-window mode"
This reverts commit 460dabda46.

Reason for revert: Droidcop-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?testMethod=testTopPositionSwitchOnTapTimeoutDifferentProcess&testClass=android.server.wm.lifecycle.ActivityLifecycleTopResumedStateTests&atpConfigName=cts%2Fframework%2Fgce-presubmit-wm-cloud-tf-3&testModule=CtsWindowManagerDeviceTestCases&fkbb=6585261&lkbb=6585728&lkgb=6581565&testResults=true&badBuildCount=13&branch=git_rvc-qpr-dev-plus-aosp&target=aosp_cf_x86_phone-userdebug, bug b/158836294

Bug: 158836294
Change-Id: Iec015564030658845a5b1262c23c5b72570af9cf
2020-06-12 22:45:20 +00:00
Miranda Kephart
33aff26285 Check for null service in ScreenshotHelper
We were testing whether mScreenshotConnection was null as a proxy
for whether we had a running screenshot service. In principle
mScreenshotService should never be null if mScreenshotConnection
is not null, but it's safer to check. This may fix the crash noticed in
early May (attached bug), and either way is better for the stability
of the process.

Bug: 156366251
Fix: 156366251
Test: manual
Change-Id: Iea669a5a2ca2334760141ec6fec8ec7ffb01f25c
2020-06-12 13:04:18 -04:00
Yunfan Chen
b55bc82d13 Merge "Remove IME surface when occured in multi-window mode" into rvc-dev 2020-06-12 03:05:54 +00:00
Daniel Sandler
5c71678253 Merge "As foretold, this release goes to eleven." into rvc-dev 2020-06-11 22:55:23 +00:00
TreeHugger Robot
b367074347 Merge "Fix restoring vertical scroll after horizontal." into rvc-dev 2020-06-11 19:18:16 +00:00
TreeHugger Robot
0561690cac Merge "Apply theme shape clipping to group convo avatars" into rvc-dev 2020-06-11 18:22:46 +00:00
TreeHugger Robot
954574cfaa Merge "Strip formatting from convo senders and title" into rvc-dev 2020-06-11 16:14:44 +00:00
arangelov
0e383d7872 Fix restoring vertical scroll after horizontal.
Fixes: 158622814
Test: manual
Change-Id: I310566d57f83b3aba5e015873ec4c48a9243fbf0
2020-06-11 15:52:13 +01:00
TreeHugger Robot
998df4f345 Merge "Kill off callback reference as soon as credential is verified" into rvc-dev 2020-06-11 11:39:57 +00:00