Commit Graph

563 Commits

Author SHA1 Message Date
Ben Lin
6d00ea7a4a Merge "PiP: Double-tap to maximum, again to go back to last resized size." into sc-dev 2021-02-01 22:35:13 +00:00
Nataniel Borges
283866d88d Merge "Reduce flicker memory consumption (Pt 4)" into sc-dev 2021-02-01 12:22:01 +00:00
Nataniel Borges
1ee38b1c18 Reduce flicker memory consumption (Pt 4)
Improve flicker memory consumption with the following:
- Use a static factory for better compatibility with JUnit4 ParameterizedRunner
- Ensure `cleanUp` is always called, even when an exception occurs

Bug: 178572522
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Id9e539c0e8bce350f94811cab58a726e47aac525
2021-02-01 09:38:12 +01:00
Ben Lin
f426138ac8 PiP: Double-tap to maximum, again to go back to last resized size.
When double tapping, it now maximizes PiP to the biggest size possible,
but doesn't save the maximized bounds as a user resize. Instead, save
the current bounds before maximizing, and then restore that if user
double taps again.

Bug: 178881304
Test: Double-tap on PiP
Change-Id: Ib1dfb07e1ee1134759309213089504bb1eb97279
2021-01-29 18:55:31 -08:00
Winson Chung
26c4ade4d5 8/ Updating bubbles to run on shell thread
- Refactor some code to prevent blocked calls when calling to
  and from the Bubbles code when it runs on another thread
- Ensure that ScrimView can be run in separate windows running
  on separate threads

Bug: 161979899
Test: atest WMShellUnitTests
Test: atest SystemUITests
Change-Id: I8eca9e9f644486f73a39f21dc37852be51d94539
2021-01-29 22:07:33 +00:00
Hongwei Wang
34b2197e34 Merge "New tap on PiP window behavior" into sc-dev 2021-01-29 21:49:29 +00:00
Nataniel Borges
3a544c9da5 Merge "Reduce flicker memory consumption (Pt 3)" into sc-dev 2021-01-29 19:46:12 +00:00
Nataniel Borges
63d515d10e Merge "Disable tests flaky on flame" into sc-dev 2021-01-29 18:18:15 +00:00
Winson Chung
a7e151f01a Merge "7/ Clean up some usage of getLooper" into sc-dev 2021-01-29 17:14:59 +00:00
Yuncheol Heo
52d3773622 Merge "Fix NPE in TaskView." into sc-dev 2021-01-29 15:21:30 +00:00
Nataniel Borges
442ffb6671 Disable tests flaky on flame
EnterLegacySplitScreenTest#testNonResizeableNotDocked fails with visibleWindowsShownMoreThanOneConsecutiveEntry(Splash Screen)

RotateTwoLaunchedAppTest#testRotateAndEnterSplitScreenMode fails with "java.lang.AssertionError: Unable to find app icon in Overview"

Bug: 173875043
Test: atest WMShellFlickerTests
Change-Id: Iaa0a159e5240bd2c129ada844661caac3c64142f
2021-01-29 15:47:33 +01:00
Shawn Lin
7ee87037f5 Merge "Create an API to get a cutout path" into sc-dev 2021-01-29 12:42:48 +00:00
Nataniel Borges
0f3645b868 Reduce flicker memory consumption (Pt 3)
Improve flicker memory consumption with the following:
- Ensure each assertion has a name for use with parameterized runner

Bug: 178572522
Test: atest FickerTests WMShellFlickerTests
Change-Id: I84af8ccccbbe42533013be664c91521fe49f7021
2021-01-29 11:55:29 +01:00
TreeHugger Robot
9cc46e4fe3 Merge "Re-map DisplayAreaAppearedInfo to token-leash map" into sc-dev 2021-01-29 05:06:51 +00:00
Hongwei Wang
352f35ddaf New tap on PiP window behavior
PiP window stays same on tap if it's large enough to hold all the
actions within it. Ignore the artifacts in demo video such as the shift
of settings button and menu resize out of sync, they are tracked in
separate bugs.

Video: http://rcll/aaaaaabFQoRHlzixHdtY/hkQgdmbuBhNT0WdKW8aegL
Bug: 175055101
Test: See video
Change-Id: Ie19b30dd1e8ba716095b76a3f341b5ab2a51399b
2021-01-28 17:42:53 -08:00
TreeHugger Robot
5722117dcb Merge "Apply window crop on entering PiP transition" into sc-dev 2021-01-28 21:40:15 +00:00
Yuncheol Heo
86df2c5757 Fix NPE in TaskView.
- TaskInfo can be null before Listener is executed.

Bug: 178710250
Test: atest CarDevicePolicyManagerTest
Change-Id: I90cd57dbd01692b86924ec1b762e31f91a6cd6e0
2021-01-28 13:34:04 -08:00
Winson Chung
9211706490 7/ Clean up some usage of getLooper
- Don't expose the looper from the executor for now since
  we don't want people to build around it

Bug: 161979899
Test: atest WMShellUnitTests
Change-Id: Ia8e29c100eeef639a60ea0b5a87ea4ae551867c2
2021-01-28 10:47:39 -08:00
Winson Chung
c1b8011f54 Merge "Migrate to using DisplayLayout instead of DisplayInfo" into sc-dev 2021-01-28 18:03:44 +00:00
shawnlin
f7ff55217c Create an API to get a cutout path
- Added a new API to get the cutout paths.
- Create a @hide class CutoutPathParserInfo
  - Used to store the needed info to create the cutout paths.
  - Will be used when DisplayCutout.getCutoutPath() is called to
    create the cutout paths.

Bug: 172646505
Test: atest DisplayCutoutTest DisplayContentTests WmDisplayCutoutTest
Change-Id: Ief92ce4466f6bffb2a9375388b71de43049b4eef
2021-01-28 19:12:54 +08:00
Nataniel Borges
82dd3e14f8 Merge "Disable flaky pip test" into sc-dev 2021-01-28 09:30:08 +00:00
TreeHugger Robot
3faaf538e9 Merge "Remove double-posting in DisplayImeController" into sc-dev 2021-01-28 08:48:30 +00:00
Bill Lin
1fd078151b Re-map DisplayAreaAppearedInfo to token-leash map
Clean-up DA callback APIs of OneHandedDisplayAreaOrganizer
  onDisplayAreaAppeared()
  onDisplayAreaVanished()

Note:
  When super.unregisterOrganizer() is called, all DAs should be
  removed from the map in the callback of onDisplayAreaVanished().
  It was not working correctly because the map is using DisplayAreaInfo
  as the key, which will be different because of the different
  configuration object. We should use the DA token as the key.

Bug: b/172298357
Test: atest WMShellUnitTests:OneHandedDisplayAreaOrganizerTest
Test: atest SystemUITests
Test: Trigger OHM, rotate screen
Test: Trigger OHM, disabled through settings
Change-Id: I4560df1ab36ec33292fa4ec08cab28644b0fabe2
2021-01-28 15:00:02 +08:00
TreeHugger Robot
f6e8b35b63 Merge "Temperory ignore flaky visibleLayersShownMoreThanOneConsecutiveEntry" into sc-dev 2021-01-28 05:09:51 +00:00
Wilson Wu
299897e9ba Merge "Make IInputMethodManager to oneway (10/N)" into sc-dev 2021-01-28 01:46:32 +00:00
Winson Chung
4dc41ab58b Migrate to using DisplayLayout instead of DisplayInfo
- No need to keep two sources of truth, can just use display
  layout to  store/calcualte all the info we need
- Update the display layout on display configuration changed
  as well
- KI: When changing displays, the min size of the pip also
  changes so we will need to calculate that based on the
  smallest display size

Bug: 175644531
Test: atest PinnedStacktests
Test: atest WMShellUnitTests
Change-Id: I34614a8f739311c7b382b6848e4752fa68c91cfb
2021-01-27 22:01:21 +00:00
Hongwei Wang
1c2ffc5410 Apply window crop on entering PiP transition
For entering PiP transition in button navigation mode, there seems to be
regression causing the black background when there is no source rect
hint being set.

Work around this by explicitly applying window crop on the start of transition.

Video: http://rcll/aaaaaabFQoRHlzixHdtY/e9o986ZD7jO0rI14rrwoRZ
Bug: 178242567
Test: See video
Change-Id: I89ba5a41f0d6fc7ad9873455348b22db3f364615
2021-01-27 13:17:54 -08:00
Nataniel Borges
59a995a7b1 Disable flaky pip test
Bug: 171049720
Test: atest FlickerTest
Change-Id: I21bbbc7dcb98c4cc039b4621f807386093d8deb2
2021-01-27 16:54:07 +01:00
Adrian Roos
a30d9a0d74 Remove double-posting in DisplayImeController
Now that the PerDisplay methods already run on the mMainExecutor,
we no longer need to post to that executor from PerDisplay's methods.

Fixes: 175954493
Test: atest DisplayImeController
Change-Id: Ib528b899b7f47f5c4afe3e31925bfb8d8abb8aef
2021-01-27 14:31:08 +01:00
Wilson Wu
c4663ba6a9 Make IInputMethodManager to oneway (10/N)
1. Comply following methods to IVoidResultCallback to
emulate current behavior.

-. setAdditionalInputMethodSubtypes
-. removeImeSurface
-. removeImeSurfaceFromWindow

2. Add "oneway" to all methods which we already apply them
to result-callback model.

Bug: 163453493
Test: Manual test with keyboard
Test: atest CtsInputMethodTestCases
Test: atest DisplayImeControllerTest
Change-Id: Icb396ae5d74060af69c4ecb16723b2e37b9f2067
2021-01-27 09:12:47 +00:00
Bill Lin
d7ee2ede94 Temperory ignore flaky visibleLayersShownMoreThanOneConsecutiveEntry
Splash screen sometimes cause the assertion fail
Ignore the assertion until good approach available

Test: atest WMShellFlickerTests
Bug: 178447631
Change-Id: Id2dce31e409d22fceeacb67828631b81d7a50a09
2021-01-27 16:44:15 +08:00
Winson Chung
d19e69d0bc 6/ Update pip to use shell main thread
- Remove some currently unused pip interface methods
- Remove some usages of handler
- Remove update thread (will eventually run on shell main thread)

Bug: 161979899
Test: atest WMShellUnitTests
Change-Id: If97e5182e396029120f0d0fb9e730ece93cddcc8
Signed-off-by: Winson Chung <winsonc@google.com>
2021-01-27 05:39:01 +00:00
Jorge Gil
0d98528ce2 Merge "Add crossfade animation on finish resize" 2021-01-26 17:37:12 +00:00
Nataniel Borges
732cde8f57 Merge "Enable RotateAppPairs tests" 2021-01-26 16:21:32 +00:00
TreeHugger Robot
c64d83723f Merge "Disable visibleLayersShowInConsecutiveEntries assertion" 2021-01-26 14:31:26 +00:00
TreeHugger Robot
c79f0ed9d5 Merge "Enable Pip tests" 2021-01-26 09:28:36 +00:00
Nataniel Borges
5de871ffd2 Enable RotateAppPairs tests
The tests are stable in postsubmit, so they can be moved to presubmit

Bug: 162923992
Test: atest FlickerTests
Change-Id: Ie691d8ae11672337e46529b26cc358f99e5a0bf4
2021-01-26 08:48:29 +01:00
Nataniel Borges
beaddd2cde Disable visibleLayersShowInConsecutiveEntries assertion
This assertion is ~30% flaky at the moment

Bug: 162923992
Test: atest FlickerTests
Change-Id: I288b5f19ee45bd708a4c47b161f6b7f5405968b5
2021-01-26 08:45:06 +01:00
Lucas Dupin
e6fee6030a Merge "Make bubble scrim respect opacity flag" 2021-01-26 05:29:20 +00:00
jorgegil@google.com
fe0ab24277 Add crossfade animation on finish resize
If seamless resize is enabled and the pip param for it is set to false,
the finish resize transaction will do a crossfade animation between the
two states.

Bug: 152554547
Test: corner/drag resize or tap to expand, stretch resize crossfade when let go
Change-Id: I8b2b27335ab8150a84914fc29615dd6625b1af35
2021-01-25 17:20:58 -08:00
Evan Rosky
27923b5a68 Merge "Add support/adapter for recents animation via shell transition" 2021-01-26 00:29:40 +00:00
Lucas Dupin
2107c5815f Make bubble scrim respect opacity flag
Test: atest ScrimControllerTes
Fixes: 173562716
Change-Id: If815eb75f63078741f2b1104938b223e0a99df31
2021-01-25 16:27:14 -08:00
Wale Ogunwale
2a9e1e73ac Merge "Fixed some bugs with main/side stage splits" 2021-01-25 23:46:26 +00:00
Yuncheol Heo
857ebd3ccd Merge "Move setTaskAlwaysOnTop from TaskView to BubbleExpandedView." 2021-01-25 19:39:13 +00:00
Wale Ogunwale
f84a471b02 Fixed some bugs with main/side stage splits
- Dragging to right to dismiss no working.
- Dragging to left to dismiss closes all apps
- Not able to put app in split after left drag to dismiss
- Pressing back on last activity in one split dismisses both.
- Don't move home task forward when startActivityFromRecents with launch
root set.

Fixes: 176061049
Test: they pass!
Change-Id: Ic1219b747e995ee8833b31433356bd44435118da
2021-01-25 10:51:58 -08:00
Nataniel Borges
82d51f03ab Enable Pip tests
The tests are stable in postsubmit, so they can be moved to presubmit

Bug: 171049720
Test: atest FlickerTests
Change-Id: I116157823f192ce31473d2d7d33ae7b8bf4e7a43
2021-01-25 18:34:56 +01:00
Nataniel Borges
1257711e65 Merge changes from topics "media-projection", "merge-specs", "single-assertion"
* changes:
  Use MediaProjection for screen recording
  Split app pair tests into individual assertions
  Compatibilize tests with new runner
2021-01-25 14:06:18 +00:00
Sergey Nikolaienkov
322819916e Merge "Filter out WmShellFlickerTests that are not supported on TV" 2021-01-25 10:12:46 +00:00
Nataniel Borges
9d110213e9 Use MediaProjection for screen recording
Use media projection instead of the shell command for screen recording.

Test: atest FlickerTests
Bug: 177077842
Change-Id: I9ac7351bf04004b5512316232637fd5cc2dd5fcc
2021-01-25 08:58:32 +01:00
Nataniel Borges
d04791d65c Split app pair tests into individual assertions
After this CL each assertion in the AppPairs test will appear as independent tests

Bug: 162923992
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Id704301b3396c4330001ef639faed6e978237f10
2021-01-25 08:58:27 +01:00