Commit Graph

8686 Commits

Author SHA1 Message Date
Treehugger Robot
e78ac20b5d Merge "Update language to comply with Android’s inclusive language guidance" am: dce2f1c04b am: c686b1f21c am: 50015ad612 am: 7ee1dc7321 am: 0ead0fc382
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1371481

Change-Id: Ib0e78ce48eaa0be5cc8dc69d3e5674ac8722a287
2020-07-23 21:14:35 +00:00
Treehugger Robot
0ead0fc382 Merge "Update language to comply with Android’s inclusive language guidance" am: dce2f1c04b am: c686b1f21c am: 50015ad612 am: 7ee1dc7321
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1371481

Change-Id: Ib309e244728db2b4182040d55286aab74ee446e7
2020-07-23 20:54:51 +00:00
Treehugger Robot
50015ad612 Merge "Update language to comply with Android’s inclusive language guidance" am: dce2f1c04b am: c686b1f21c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1371481

Change-Id: I05712223149c676ae849114562ef6969fbe8ab18
2020-07-23 20:29:38 +00:00
Seigo Nonaka
f47561320f Update language to comply with Android’s inclusive language guidance
See https://source.android.com/setup/contribute/respectful-code for reference

Bug: 161896447
Test: atest TextViewTest
Change-Id: I83f253f6edfb2724972793b3495835540b7b52e4
2020-07-22 22:54:14 -07:00
vichang
2b05393251 Merge "Remove @CorePlatformApi LocaleData usage in frameworks" am: 3f89b904a8 am: 226e3d7641 am: 9ee26b06fb am: f82c013ec3 am: 6e4f9e9e06
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1367376

Change-Id: I7f0c730abced6a03fb8952d602a398a724667569
2020-07-22 20:28:18 +00:00
vichang
6e4f9e9e06 Merge "Remove @CorePlatformApi LocaleData usage in frameworks" am: 3f89b904a8 am: 226e3d7641 am: 9ee26b06fb am: f82c013ec3
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1367376

Change-Id: Ib6bae04011ee7f40a42f0f44cb76f3053cf2648d
2020-07-22 20:09:57 +00:00
vichang
9ee26b06fb Merge "Remove @CorePlatformApi LocaleData usage in frameworks" am: 3f89b904a8 am: 226e3d7641
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1367376

Change-Id: Ib23a5ff1491c89d5cd0f962b1f609c988111c18b
2020-07-22 19:48:40 +00:00
TreeHugger Robot
172b4510d1 Merge "Ensures the slop value is fixed cross lines." 2020-07-22 03:22:44 +00:00
vichang
3f9e52d88b Merge "Use DateFormatSymbols directly instead of using LocaleData" am: 3bd9f08ae5 am: da5838aa43 am: 36a3657be8 am: afbfec08c7 am: eb59659998
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1364767

Change-Id: I4dd7683e1473cde7ea560d43de38ad640fe752f6
2020-07-21 17:53:25 +00:00
vichang
eb59659998 Merge "Use DateFormatSymbols directly instead of using LocaleData" am: 3bd9f08ae5 am: da5838aa43 am: 36a3657be8 am: afbfec08c7
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1364767

Change-Id: I1e4cd3206d9de0498b6886d2ebd193573b4d2a6d
2020-07-21 17:35:31 +00:00
vichang
36a3657be8 Merge "Use DateFormatSymbols directly instead of using LocaleData" am: 3bd9f08ae5 am: da5838aa43
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1364767

Change-Id: I8fbfc4e551396b32c1aafab4aa750af1baa7c827
2020-07-21 16:56:31 +00:00
Victor Chang
55a6efbfd9 Remove @CorePlatformApi LocaleData usage in frameworks
They can be replaced by the public API provided by ICU4J instead.
No extra layer of caching equivalent to the LocaleData cache is
added because ICU4J has caches instances, e.g. DateFormatSymbols,
etc.

Bug: 160606356
Test: atest FrameworksCoreTests:android.text.format
Change-Id: I07048e0e1a4835d2744b7fce6a5ed79a112e456b
2020-07-20 21:09:40 +01:00
Victor Chang
c744bd5f64 Use DateFormatSymbols directly instead of using LocaleData
Bug: 160606356
Test: atest FrameworksCoreTests:android.text.format
Change-Id: Id5d70328ab146d439ed45135e0fa9d1b9cc95257
2020-07-20 21:09:40 +01:00
TreeHugger Robot
d5e6e62dc8 Merge "Fixes the issue multi-touch causing launcher icons to be not clickable." into rvc-dev am: 94df031718 am: b2f5bfcfc2 am: 61dda21b2b am: 68ea95a8a5
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12163209

Change-Id: I25e4901e09f93949d9e245430f1e7d83fde5fd87
2020-07-17 17:45:21 +00:00
TreeHugger Robot
68ea95a8a5 Merge "Fixes the issue multi-touch causing launcher icons to be not clickable." into rvc-dev am: 94df031718 am: b2f5bfcfc2 am: 61dda21b2b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12163209

Change-Id: I22ca7c23aee67275b3fab108a01b33aa4dfdc6da
2020-07-17 17:39:30 +00:00
TreeHugger Robot
b2f5bfcfc2 Merge "Fixes the issue multi-touch causing launcher icons to be not clickable." into rvc-dev am: 94df031718
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12163209

Change-Id: Icae3589b44c4a98f67afc659f62346db8a6ddd65
2020-07-17 17:24:24 +00:00
Shu Chen
38dfd19611 Ensures the slop value is fixed cross lines.
In Q, the slop is a fixed value calculated based on
TextView.getLineHeight().
In R+ (before this cl), the slop is a dynamic value based on the height
of the current line.

It's been confirmed as the root cause of the regression bug b/159528374.

This cl changes the slop value back to the fixed value.

Bug: 159528374
Test: Verified locally.
Change-Id: I182d22779f1c1155ae2e0b0deb0455bd270b2fd9
2020-07-17 13:40:58 +00:00
Pinyao Ting
b4444ff0a1 Fixes the issue multi-touch causing launcher icons to be not clickable.
The issue occurs because TextView#isFromPrimePointer assumes multi-touch
events are happening on the same TextView and relies on
ACTION_UP/ACTION_CANCEL to reset the Prime pointer id.

consider following scenario:
1. ACTION_DOWN (pointer 0) landed on ViewA,
   ACTION_DOWN (pointer 1) landed on ViewB.
2. ACTION_MOVE landed on both ViewA and ViewB, triggering a drag.
3. When all fingers are released, ACTION_CANCEL (pointer 0) will be
   landed on both ViewA and ViewB, so the prime pointer in ViewB is not
   reset due to pointer index mismatch.

This CL always reset prime pointer id whenever ACTION_UP/ACTION_CANCEL
is triggered.

Bug: 157399040
Test: manual
Change-Id: Id35d9eac939378482fa50e85bb5cda58469240ad
2020-07-16 20:59:10 -07:00
TreeHugger Robot
3a3aac9b50 Merge "Apply max char length when setSingleLine is called." into rvc-qpr-dev am: 23d7aab779
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12122217

Change-Id: I5071b9c8a03eb90e59e15c313c50c08560858cfb
2020-07-16 20:24:44 +00:00
TreeHugger Robot
675aa8d1e7 Merge "Set upper-limit for the single line edit text." into rvc-qpr-dev am: 00440b4af0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12122216

Change-Id: Ic16b4cd03eeb7e476c5dff095fd837570d7842e7
2020-07-16 20:23:53 +00:00
Christopher Tate
acd4d23f1e Avoid churning NumberFormat instances in ProgressBar
Don't construct a new locale-specific NumberFormat every time a progress
bar's state is refreshed or updated.  We now do this only when necessary
due to a locale change.

Bug: 161264248
Test: atest ProgressBarTest
Change-Id: I349ec28268a3471184e5746b164f81428ad80cc8
2020-07-16 11:31:54 -07:00
Yinglei Wang
fba2b3264f Merge "Delay sending accessibility events a little for temporarily detached view" 2020-07-15 17:34:45 +00:00
yingleiw
e34bc33af3 Delay sending accessibility events a little for temporarily detached view
In RV, a view could be temporarily detached in one draw cycle.
Accessibility events sent during this time will be lost. To prevent the
events from being lost, we will set a flag when a view is detached by
parent. And when sending accessibility events for detached view, we will
delay it a little by
ViewConfiguration.getSendRecurringAccessibilityEventsInterval. This way,
if the view is attached in one draw cycle, the events will be sent out.

Also add more setStateDescription() in CompoundButton to for safer code.
(this is not the cause of this bug though).

Fix: 151125936

Test: tested that the bug is fixed.

Change-Id: Iffca8c87bad4fa2f66862b966e351562d77d6d76
2020-07-14 17:12:07 -07:00
vichang
534ea43ebd Merge "Remove libcore.icu.ICU usage in android.text.format.DateFormat" am: ec71624f22 am: 3b25f55042 am: 8a202538bc am: 13121a763b am: 8ec9138f79
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1355737

Change-Id: Ia20f6f9fcc64711e79a9afdd38895ab600b8c691
2020-07-13 02:56:29 +00:00
vichang
8a202538bc Merge "Remove libcore.icu.ICU usage in android.text.format.DateFormat" am: ec71624f22 am: 3b25f55042
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1355737

Change-Id: Ibc2b1561f316afe2371d9549190a0c328a180141
2020-07-13 02:31:18 +00:00
vichang
ec71624f22 Merge "Remove libcore.icu.ICU usage in android.text.format.DateFormat" 2020-07-10 10:47:38 +00:00
Seigo Nonaka
223c8e0118 Apply max char length when setSingleLine is called.
Bug: 145128646
Test: atest android.widget.cts.EditTextTest
Change-Id: I1f2fd6c97c5cdeb7be5017d4c6aeb19fd269e939
Merged-In: I1f2fd6c97c5cdeb7be5017d4c6aeb19fd269e939
2020-07-09 22:57:52 +00:00
Seigo Nonaka
a0c653945b Set upper-limit for the single line edit text.
Bug: 145128646
Test: atest EditTextTest#testSingleLineMaxLength
Change-Id: I32b28dcc8c18386839b5adea5b73c77896036567
Merged-In: I32b28dcc8c18386839b5adea5b73c77896036567
2020-07-09 15:42:28 -07:00
Nikita Dubrovsky
68bdd1abae Merge "Change cursor drag threshold from 30 to 45 degrees from vertical" into rvc-dev am: f44a60bd69 am: cf4e0dc46b am: c84cbdb149 am: 1bf451125b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12052997

Change-Id: Ia7fbe25cc8074d6d33480737b8762522a9958939
2020-07-08 17:28:08 +00:00
Nikita Dubrovsky
cf4e0dc46b Merge "Change cursor drag threshold from 30 to 45 degrees from vertical" into rvc-dev am: f44a60bd69
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/12052997

Change-Id: Ie8a3eee8e2030bb429531d0f13df4302d4908072
2020-07-08 16:46:34 +00:00
Treehugger Robot
3bf7edf711 Merge "Fix typos related to sortSelectionIndices" am: 5247f04147 am: 7a42f1c980 am: 1376456548 am: 63c26b2080 am: c5e61b5f28
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1355842

Change-Id: I966f008fa4c2677bc2ef8d4e2535402cf7d84304
2020-07-08 03:05:56 +00:00
Treehugger Robot
1376456548 Merge "Fix typos related to sortSelectionIndices" am: 5247f04147 am: 7a42f1c980
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1355842

Change-Id: Iec31622cc351a635b8d590b2509523167141d32c
2020-07-08 02:16:23 +00:00
Victor Chang
a0d05f4fdc Remove libcore.icu.ICU usage in android.text.format.DateFormat
The methods can be implemented with ICU4J directly.

Bug: 160606356
Test: atest android.text.format.DateFormatTest
Test: atest CtsTextTestCases:android.text.format.cts.DateFormatTest
Change-Id: I3d5f639a94026c599b487563c95bf9d165adfeec
2020-07-06 21:30:24 +01:00
Wang Han
11bd793f2c Fix typos related to sortSelectionIndices
Bug: 160555160

Change-Id: I2710e10776a4f6f633abc14d6898c186b5a01124
2020-07-06 13:21:57 +00:00
Joanne Chung
611f0c8ab7 Fix AutofillValueTest#autofillEmptyTextValue.
The new added API for rich content(ag/9884022) denies to autofill
empty text. However, Autofill allows us to fill an empty text. We
should not cause a compatibility issue.

Bug: 159035197
Test: atest android.autofillservice.cts.AutofillValueTest#\
autofillEmptyTextValue
Test: atest FrameworksCoreTests:AutofillValueTest

Change-Id: Ieb5b82bfe4bf77abd151c61ea4cf9125b8fe61f5
2020-07-06 20:50:10 +08:00
Joanne Chung
6dfbe8316c Fix app crash if the selection is from reverse direction.
When user types some text and then long presses on end of empty area
to open context menu, if user opens Gboard and selects text from the
reverse direction, SelectionEnd will be less than SelectionStart. The
IllegalArgumentException occurred because TextClassification does not
allow SelectionEnd is less than SelectionStart. We swap the start and
end index if end index is less than start index.

Bug: 150916165
Bug: 157452302
Test: Manual. No crash occurs.
Test: atest FrameworksCoreTests:android.widget.TextViewActivityTest
(cherry picked from commit cb3c97db0c)

Merged-In: I8dbc92f0f31e64b7e3a45ae91762e1b741629a8e
Change-Id: Ie0e2b5840e147f98174cae4521eb777e1a080706
2020-07-06 17:41:55 +08:00
Nikita Dubrovsky
b1ad3b6800 Change cursor drag threshold from 30 to 45 degrees from vertical
Bug: 158948887
Test: Manual and unit tests
  atest FrameworksCoreTests:EditorTouchStateTest
  atest FrameworksCoreTests:EditorCursorDragTest
Change-Id: I6b30c0d6ef9c93fd4fd6aae3004cd6965e9d7be4
2020-07-01 13:14:19 -07:00
Jorim Jaggi
41bd44e606 Merge "Pass in callsite of SurfaceControl constructor explicitly (1/3)" into rvc-dev am: 37cf2279c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11920862

Change-Id: I19b6f83b3777bfeccbe90f1c531efcc59e41f54e
2020-06-27 00:14:24 +00:00
Jorim Jaggi
37cf2279c9 Merge "Pass in callsite of SurfaceControl constructor explicitly (1/3)" into rvc-dev 2020-06-26 23:58:17 +00:00
Jorim Jaggi
543db32125 Pass in callsite of SurfaceControl constructor explicitly (1/3)
Creating a new Throwable (and filling in the stack trace) can take
up to 150us. Since we do this on the critical path when sending
over SurfaceControl via binder multiple times, this is too much.
Instead, add an option to pass in callsite manually.

Bug: 159056748
Change-Id: I46c339c15a07192d61c4c546e46f260684a47120
Exempt-From-Owner-Approval: Large scale refactor
2020-06-26 13:40:07 +00:00
Jorim Jaggi
d42ab1b938 Pass in callsite of SurfaceControl constructor explicitly (1/3)
Creating a new Throwable (and filling in the stack trace) can take
up to 150us. Since we do this on the critical path when sending
over SurfaceControl via binder multiple times, this is too much.
Instead, add an option to pass in callsite manually.

Bug: 159056748
Change-Id: I46c339c15a07192d61c4c546e46f260684a47120
Merged-In: I46c339c15a07192d61c4c546e46f260684a47120
Exempt-From-Owner-Approval: Large scale refactor
2020-06-26 15:35:23 +02:00
TreeHugger Robot
5c941c3057 Merge "Fix the visibility of SurfaceView in InlineContentView." into rvc-dev am: 9c71148852 am: ebcad32029 am: 48f87547dc am: a4393d82ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11988456

Change-Id: Ie27a287b15090a09b14d1b7743ef76592cab711a
2020-06-25 05:59:16 +00:00
TreeHugger Robot
ebcad32029 Merge "Fix the visibility of SurfaceView in InlineContentView." into rvc-dev am: 9c71148852
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11988456

Change-Id: Ibd355dd33759f9a6d930fffaae7fa2d2a26140df
2020-06-25 05:29:59 +00:00
Qi (wangqi) Wang
db0dbea190 Fix the visibility of SurfaceView in InlineContentView.
SurfaceView doesn't respect the visibility of its ancestor so we need to
update it accordingly inside InlineContentView.

Test: manually
Bug: 158714351

Change-Id: If482747d6ae5d7628b46de837c11b6232406120c
2020-06-24 19:45:46 -07:00
Automerger Merge Worker
67a228259c Merge "Merge "Address missed comments from previous CL" into rvc-dev am: dab5588e84 am: d00340e1a5 am: 439359869f" into rvc-qpr-dev-plus-aosp am: 23c9cc0cb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11978216

Change-Id: I6fca331224199adce27ff8b835d4c54c74a112b6
2020-06-24 17:44:39 +00:00
Svetoslav Ganov
842f9e3b31 Merge "Address missed comments from previous CL" into rvc-dev am: dab5588e84 am: d00340e1a5 am: 439359869f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11978216

Change-Id: Ice21ea4808754a69d0c233d2c85669ff2460d2a0
2020-06-24 17:29:30 +00:00
Svetoslav Ganov
9529f00aa7 Merge "Address missed comments from previous CL" into rvc-dev am: dab5588e84
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11978216

Change-Id: I2637826dde356b7604dffa907f4385c7b83a3780
2020-06-24 17:01:41 +00:00
Svetoslav Ganov
3e38462491 Merge "Handle reperenting of InlineContentView" into rvc-dev am: f8b9ddea71 am: a962563758 am: bf50afcb4e am: e6e30d2948
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11907687

Change-Id: Id8c4a07af383ef3f58bad760b28fdb5a69dc3e03
2020-06-24 07:22:38 +00:00
Svetoslav Ganov
bf50afcb4e Merge "Handle reperenting of InlineContentView" into rvc-dev am: f8b9ddea71 am: a962563758
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11907687

Change-Id: Ia18fc12a4015296d59985b376b159a1560717d90
2020-06-24 06:56:18 +00:00
Svetoslav Ganov
0de1884aef Merge "Handle reperenting of InlineContentView" into rvc-dev am: f8b9ddea71
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11907687

Change-Id: I9b0919075bc6e29cf4beb6d2e92097d74ac4d99b
2020-06-24 06:44:18 +00:00