Commit Graph

1180 Commits

Author SHA1 Message Date
TreeHugger Robot
258c743697 Merge "Shelf alignment and animation fixes" into pi-dev 2018-04-11 02:01:27 +00:00
Lucas Dupin
b561eda050 Shelf alignment and animation fixes
- Translate shelf after collapsing notification panel
- Fix issue where icon y translation would be off in AOD

Change-Id: Ibae5e7cd4cb989514a96d5edfd761b0c0201de03
Fixes: 77540062
Fixes: 77541059
Test: visual
2018-04-10 16:01:42 -07:00
TreeHugger Robot
a4dab5d1ea Merge "[Notif] Show block message for notif with multiple channels" into pi-dev 2018-04-10 19:06:42 +00:00
TreeHugger Robot
7cf18d5ec4 Merge "Hiding clear all when replying now" into pi-dev 2018-04-10 18:33:29 +00:00
Selim Cinek
7c6fe5b71f Hiding clear all when replying now
Change-Id: Id08084776967f85101b07d3a56b5dffe80af6dbc
Fixes: 75984847
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarTest.java
2018-04-10 10:20:45 -07:00
Rohan Shah
ca0447e3f6 [Notif] Show block message for notif with multiple channels
Showing blocking message on notifications with multiple channels. Also,
the blocking helper was never committing the saveImportance logic...
Updated so it does that again.

Moved binder calls over to bg (for committing block/minimize rules).

Change-Id: I5042cf51a4700958c3cedbf5619fd1cbcb944a03
Fixes: 77320402
Test: Visually, atest {ENR|NotifInfo}Test
2018-04-10 13:20:16 -04:00
TreeHugger Robot
0e675bd901 Merge "Exempt tests for hidden APIs." into pi-dev 2018-04-10 16:34:05 +00:00
Sanry Huang
816d46f7d0 Merge "Fix the wrong tint state of Nav buttons" into pi-dev 2018-04-10 13:39:04 +00:00
shawnlin
317db378f6 Fix the wrong tint state of Nav buttons
Update the aphla value of scrimBehind in setPanelExpansion to display
the correct tint state of Nav buttons.

Test: runtest systemui
Change-Id: Ia17bbe71106900b764ec2f5ac4729b9770eac4bc
Fixes: 74578143
2018-04-10 10:38:17 +08:00
TreeHugger Robot
13276e7ebd Merge "[Notif] Disable "Customize" for blocking helper" into pi-dev 2018-04-10 01:25:40 +00:00
Lucas Dupin
373356b9bd Remove focus highlight from scrims
Change-Id: Ib51d8b1c6964716ac120f3567a8919decc513fbe
Fixes: 77591096
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
2018-04-07 19:31:39 -07:00
TreeHugger Robot
ee7bc05a03 Merge "Do not animate scrim when ColorFade" into pi-dev 2018-04-06 23:18:27 +00:00
Nicolas Geoffray
b0284fb5de Exempt tests for hidden APIs.
Bug: 64382372
Bug: 74963051
Test: m
Change-Id: I5234dd6230f2bdd6ffccbf12b25a02d929d20161
2018-04-06 14:54:39 +01:00
Lucas Dupin
7362e18a7b Merge "Misc bouncer fixes" into pi-dev 2018-04-05 17:21:26 +00:00
Lucas Dupin
ea0116eac2 Do not animate scrim when ColorFade
AOD scrims should only animate when sysui will control the screen-off
transition.

Test: manual
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Bug: 77539750
Change-Id: Iba79ea09c149068e75163fabddd3608254dd83f3
2018-04-05 10:16:44 -07:00
Milo Sredkov
b0f55e993e Require screen to be unlocked for smart replies
Currently tapping on a smart reply works even when the screen is
locked. To make it consistent with inline replies, require the screen
to be unlocked before sending the reply.

Bug: 76217177
Test: atest SmartReplyViewTest
Change-Id: I3af8a0411537503650fb9f83cd99f65900e700e0
2018-04-05 13:41:48 +01:00
Lucas Dupin
d2ce46d5a7 Misc bouncer fixes
- IME flickers after dismissing a call
- IME not being triggered after rebooting
- Bouncer being shown during shade expansion animation

Test: go/sysui-bouncer-tests
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/KeyguardBouncerTest.java
Fixes: 74523176
Fixes: 75001274
Change-Id: Iae2aa1534c34a4191311b85e81e80cea89711bf4
2018-04-04 17:32:02 -07:00
TreeHugger Robot
71c632367a Merge "WM Tests: Use a separate WindowManager instance per test" into pi-dev 2018-04-05 00:25:34 +00:00
TreeHugger Robot
f6f68802c9 Merge "Allow double tap when pulsing" into pi-dev 2018-04-04 22:48:22 +00:00
TreeHugger Robot
71436c639a Merge "Update for sdk drop" into pi-dev 2018-04-04 22:40:27 +00:00
TreeHugger Robot
a60cb52487 Merge "[DO NOT MERGE] Fix a11y action "expand notifications" when QS is open" into pi-dev 2018-04-04 20:26:23 +00:00
Jeff Gaston
c2100af2f6 Update for sdk drop
Bug: 77554455
Test: m -j checkbuild
Change-Id: Ia9255ae441d490276c7a9c498b75708f90bf84a1
2018-04-04 15:56:53 -04:00
TreeHugger Robot
ae26aa74a3 Merge "[Notif] Cache bool instead of manager/info" into pi-dev 2018-04-04 18:00:31 +00:00
Lucas Dupin
78949b8480 Allow double tap when pulsing
Change-Id: Ifd8d5a274981940c6dca21193dc26f9a74e0cfaa
Fixes: 75722320
Test: manual
Test: atest tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
2018-04-04 01:58:53 +00:00
Julia Reynolds
9159006d08 Only tag foreground notifications
With active permission icons

Test: atest SystemUITests
Change-Id: I31828f6239b1253794f9569d29dccdac5c10b0da
Fixes: 75276447
2018-04-03 20:00:24 +00:00
Evan Laird
4b68e2f785 Add DISABLE_CLOCK flags to status bar, fix transitions
- CollapsedStatusBarFragment now listens to DISABLE_CLOCK so that it can
be requested to hide with disable flags (fixes SUW)
- PhoneStatusBarTransitions cares about the entire left side as a unit
instead of just notifications.

Test: atest frameworks/base/packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/CollapsedStatusBarFragmentTest.java
Test: go through SUW, also change users from guest -> owner from lock
screen.

Change-Id: Ia693386b9ef0438a4fe341d056731e2ba6e973a0
Fixes: 71512617
Fixes: 71360226
2018-04-03 14:00:23 -04:00
Rohan Shah
4ed1b2ad49 [Notif] Cache bool instead of manager/info
Follow up to ag/3815403

Updated to cache bool instead of manager/info in order to reduce IPC
calls made thru packagemanager.

Also collapsed test setup for shade.

Change-Id: I8fa116b3f24eaa887d2139c0aab1996e3c95fbdc
Fixes: 74115090
Test: Visually & atest for ExpandableNR
2018-04-03 10:14:16 -07:00
Rohan Shah
7c6b37a73e [Notif] Disable "Customize" for blocking helper
Rolling forward ag/3824685.

Update UI to hide customize when blocking helper is showing. Fixed a
small problem with context.getString too where it was unnecessarily
passing in a format string argument.

Change-Id: I07feba206051f6804d2a537c468fcde8d85f0940
Test: Visually
Test: Ran atest NotifInfoTest with new test case (rebased this time)
Fixes: 77321231
2018-03-30 14:20:08 -07:00
Rohan Shah
13c78d15d8 Merge "Revert "[Notif] Disable "Customize" for blocking helper"" into pi-dev 2018-03-30 21:05:07 +00:00
Rohan Shah
35fe985a95 Revert "[Notif] Disable "Customize" for blocking helper"
This reverts commit 3cfc950708.

Reason for revert:
Apparently a breakage got through treehugger - I hadn't synced my changes and one of the params was incorrect. Reverting for now and rebasing before resubmit...

Bug: 77321231
Change-Id: Ib306759d6344a69f17331a6c3c9cc78d1345508b
2018-03-30 21:04:36 +00:00
TreeHugger Robot
eff51d566a Merge "Remove SignalClusterView in favor of IconManager" into pi-dev 2018-03-30 20:22:16 +00:00
TreeHugger Robot
21ba6eff91 Merge "[Notif] Disable "Customize" for blocking helper" into pi-dev 2018-03-30 20:03:11 +00:00
Evan Laird
e1d13c9884 Remove SignalClusterView in favor of IconManager
Refactors SignalClusterView into StatusBarSignalPolicy so that it can be
used in a StatusBarIconContainer and solve all of our status bar
problems.

- Remove all uses of SignalClusterView and references to
  R.id.signal_cluster. The class still exists it's just unused now

- Add StatusBarIconHolder, which can point to StatusBarIcon,
  WifiIconState, or PhoneIconState

- StatusBarIconList.Slot. Allows for easier indexing of icons now that
  there can be multiple icons per slot

- Add StatusBarWifiView to be inflated inside of the
  StatusBarIconController when needed

- StatusBarMobile view. similar to above

- Upgrade StatusBarIconControllerImpl and StatusBarIconList to
  understand the holders and added 2 new methods to specifically handle
  wifi / phone state changes

- Create IStatusBarIconView (todo: rename). Abstracts the properties we
  want away from StatusBarIconView so that we can use an arbitrary view
  type

- NeutralGoodDrawable. Draws a light and a dark icon when needed.

- Fixes a few demo mode bugs: multi sim was broken and also turning off
  demo mode was a little broken

TODO: More tests are needed for StatusBarSignalPolicy and maybe the
IconManagers

Test: runtest systemui; visual
Bug: 63772836
Bug: 73778753
Bug: 74985733
Fixes: 74427768
Fixes: 74338687
Fixes: 74388467

Change-Id: I5621b3013cdc9638b61552bd4d7211f211eddf1b
2018-03-30 14:49:08 -04:00
Rohan Shah
3cfc950708 [Notif] Disable "Customize" for blocking helper
Update UI to hide customize when blocking helper is showing. Fixed a
small problem with context.getString too where it was unnecessarily
passing in a format string argument.

Test: Visually
Test: Ran atest NotifInfoTest with new test case
Fixes: 77321231
Change-Id: Ia03ea7badc7aa7ccd7b3a0e235cce2363ace9953
2018-03-30 10:48:17 -07:00
TreeHugger Robot
160261a553 Merge "[Notif] Dont show blocking helper for non-blockable notifs" into pi-dev 2018-03-30 17:43:33 +00:00
Salvador Martinez
6abf6254d2 Merge "Update triggering logic for hybrid notification" into pi-dev 2018-03-30 17:25:00 +00:00
Rohan Shah
63411fc9f3 [Notif] Dont show blocking helper for non-blockable notifs
If the notification is considered non-blockable, we don't want to show
it. Moved necessary logic around into the appropriate classes (minor
refactor).

Cached system info (IPC) in ExpandableNotifRow instead of calling so
late in the game.

Updated tests & added nonblocking checks.

Change-Id: Ic010a0b32cf6df42e9d0d2c600cbbe95a68ffde2
Bug: 74115090
Test: atest {notif tests}
Test: Visually via debug flag on sys notif
2018-03-30 08:38:32 -07:00
Adrian Roos
3150dbf7a5 WM Tests: Use a separate WindowManager instance per test
Fixes a bunch of flakes, where the WindowManagerService instance
was reused between tests, which caused delayed callbacks from a
previous test affecting state of a future test.

Also introduces a DexmakerShareClassLoaderRule to manage
the 'dexmaker.share_classloader' property instead of sprinkling
error prone System.setProperty() invocations all over the tests.

Change-Id: Ic9445d1b2cef594e79365c425632aabced6343a9
Fixes: 76111404
Fixes: 75991352
Fixes: 75991878
Fixes: 75992153
Test: atest services/tests/servicestests DexmakerShareClassLoaderRuleTest packages/SystemUI/tests packages/SystemUI/shared/tests
2018-03-29 21:27:47 +00:00
Salvador Martinez
fd38aa5114 Update triggering logic for hybrid notification
Currently in the worst case a user can receive 4 battery
notifications if the time estimates and percentages line up right.
This CL makes it so a user can at MOST receive one "low" battery
warning and one "critical" battery warning per charge cycle. A
charge cycle is restarted when a user charges to at least 45%
battery AND has 6 hours remaining. This does not affect the
behavior of the non-hybrid notification.

Test: robotests
Bug: 76203825
Change-Id: Ib3c7fe589f1ce4c0cdb821e1f21d1139a56fad62
2018-03-29 14:11:32 -07:00
TreeHugger Robot
9ed9aa932e Merge "Bouncer should not show over the full screen user switcher on boot." into pi-dev 2018-03-29 18:28:12 +00:00
TreeHugger Robot
a000724a83 Merge "Exempt some notis from DND visual suppression" into pi-dev 2018-03-29 12:25:02 +00:00
Julia Reynolds
5bbb6dac0a Exempt some notis from DND visual suppression
Specifically, foreground service notifications
and media notifications.

Fixes: 75261156
Test: atest SystemUITests
Change-Id: I2f1fddbf748a274177d2c8dddb1b72fce82c8c4c
2018-03-29 10:50:44 +00:00
TreeHugger Robot
cfa0f19fa1 Merge "Properly filter alert window notifications" into pi-dev 2018-03-29 03:50:31 +00:00
TreeHugger Robot
f07d10e36b Merge "[Notif] Write AppUid earlier in NotificationInfo" into pi-dev 2018-03-29 02:43:23 +00:00
Rohan Shah
dbd64e7b46 [Notif] Write AppUid earlier in NotificationInfo
Noticed that appuid was being used but it wasn't set until later in the
lifecycle of the notificationinfo (rendering the channel logic moot).

If the notif is now posting notificiations to the default channel while
having multiple channels, it'll now show "Uncategorized" in the blocking
helper/notification info screens.

Fixes: 77240828
Test: Ran NotifInfoTest (added one new test case)
Test: Visually, artificially sent default ch notif with app having 9 ch
Change-Id: I45f2c35fb6dae610e511b2d316b3c184b84f2d09
2018-03-28 17:51:04 -07:00
Brad Stenning
38b46f82f7 Add an option to display HVAC temp values in sysui
Bug: 77148007
Test: on device that has a real HVAC unit
Change-Id: I97b303dd947858157ede72c5d537ae6a1e40cc67
2018-03-28 15:49:56 -07:00
jovanak
5f6dc61c10 Bouncer should not show over the full screen user switcher on boot.
Full screen switcher is only used in auto.

Fixes: 77142022
Test: Some unit tests + Refreshing sys ui and making sure full screen switcher shows first.

Change-Id: I726a79af274c2443fca0ece007ecac0f3c42a439
2018-03-28 14:39:21 -07:00
Julia Reynolds
3c7de110cc Properly filter alert window notifications
Test: atest SystemUITests
Change-Id: Ie07ffeb7a96469d985261c9a1edb1d7ce82af5c5
Fixes: 77162311
2018-03-28 16:41:01 -04:00
TreeHugger Robot
4f4d78b877 Merge "Fix scrim animation when unlocking with fp" into pi-dev 2018-03-28 06:23:20 +00:00
Lucas Dupin
067136c616 Fix scrim animation when unlocking with fp
Notification panel expansion was overriding the animation.
The expansion needs to be ignored during "wake and unlock"
states.

Test: visual
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Change-Id: I781aece52c845f3fee9149c109ad598c7b555751
Fixes: 76018235
2018-03-27 21:45:34 -07:00