Commit Graph

3989 Commits

Author SHA1 Message Date
TreeHugger Robot
adb59a0126 Merge "Remove duplicate code from InputMethodUtils" 2018-04-10 23:13:36 +00:00
Yohei Yukawa
08a3ecea32 Remove duplicate code from InputMethodUtils
This is a follow up CL to my CL [1], which originally aimed to revert
the CL [2] that added several methods into InputMethodUtils but could
not because those methods were already used in other places.

Interestingly we already have almost the same code in
InputMethodAndSubtypeUtil in SettingsLib package on which those other
projects can depend on. Hence this CL removes InputMethodUtils' ones
to avoid code duplication.

Although in future we may move the logic back to framework internal,
at the moment it is more important to reduce code duplication.

Note that this CL also ports existing test cases for those two
functions from FrameworksCoreTests to RunSettingsLibRoboTests in
GoogleTruth style.

 [1]: I122a8f69b2f75a9af85e14b66db764c5d153040e
      ca7809507c
 [2]: I01f5fafbbcfe3e3f5313829162ec011eaf2ad991
      2028ddaa50

Fixes: 73056657
Test: atest InputMethodUtilsTest
Test: make RunSettingsLibRoboTests -j
Test: prebuilts/checkstyle/checkstyle.py -f frameworks/base/packages/SettingsLib/tests/robotests/src/com/android/settingslib/inputmethod/InputMethodAndSubtypeUtilTest.java
Change-Id: Iad926ffd9806482a5aef0d8c20d2049be40d03c9
2018-04-10 14:50:53 -07:00
Seigo Nonaka
c623c25722 Merge "Fix {Spanned|Spannable}StringNoCopyTest test cases" into pi-dev am: 55ae317213
am: e310042df2

Change-Id: Iafdffc033f6198feb545538466b92a820fbc3b5c
2018-04-10 14:04:14 -07:00
TreeHugger Robot
8c12f27bc4 Merge "Updated DrawableWrapper implementation to support the hidden setXfermode method to delete the corresponding Xfermode to the wrapped drawable" 2018-04-10 21:00:21 +00:00
Seigo Nonaka
e310042df2 Merge "Fix {Spanned|Spannable}StringNoCopyTest test cases" into pi-dev
am: 55ae317213

Change-Id: I9e49ba0af1772980a5a8fadd5f6b9d27efad5c8d
2018-04-10 13:51:12 -07:00
TreeHugger Robot
55ae317213 Merge "Fix {Spanned|Spannable}StringNoCopyTest test cases" into pi-dev 2018-04-10 20:32:20 +00:00
Nader Jawad
94f25a6515 Updated DrawableWrapper implementation to support the hidden setXfermode
method to delete the corresponding Xfermode to the wrapped drawable

Added coretest to verify the hidden API properly propagates the Xfermode
to the wrapped drawable

Change-Id: I1f14105b7019b57bfcdd7182bb50ea2465c91ffe
Fixes: 30840201
Test: Ran atest on coretests
2018-04-10 12:32:00 -07:00
Nicolas Geoffray
b19c2e7451 Merge "Exempt tests for hidden APIs." into pi-dev am: 0e675bd901
am: 03ba2d9241

Change-Id: I0e4517312cac9b37537eee55eafd811aff531ea8
2018-04-10 10:11:10 -07:00
Nicolas Geoffray
03ba2d9241 Merge "Exempt tests for hidden APIs." into pi-dev
am: 0e675bd901

Change-Id: I012a1ce8483f5fdddf60cfd33ea4303d72455fca
2018-04-10 09:56:52 -07:00
TreeHugger Robot
0e675bd901 Merge "Exempt tests for hidden APIs." into pi-dev 2018-04-10 16:34:05 +00:00
Jeff Sharkey
7fa50c393d Merge "Offer to format data sizes in either IEC or SI." into pi-dev am: 52b4692192
am: da28d3d2e5

Change-Id: Id49d518271783b1622e89bcefd55b58c40b5b1a3
2018-04-10 08:27:39 -07:00
Jeff Sharkey
da28d3d2e5 Merge "Offer to format data sizes in either IEC or SI." into pi-dev
am: 52b4692192

Change-Id: Ia1ce1829a330105796ad954afca1ed61df87dd02
2018-04-10 08:17:57 -07:00
Jeff Sharkey
52b4692192 Merge "Offer to format data sizes in either IEC or SI." into pi-dev 2018-04-10 15:02:23 +00:00
Mathew Inwood
8e913755d5 Merge "Different hidden API enforcement policy for P & pre-P." into pi-dev am: 9139bbfa9b
am: 9c5d1784b9

Change-Id: I13ee422263c141cf3c18b46da59acf26d24e6042
2018-04-10 06:33:23 -07:00
Mathew Inwood
9c5d1784b9 Merge "Different hidden API enforcement policy for P & pre-P." into pi-dev
am: 9139bbfa9b

Change-Id: Ie7883c0ff862d26f5639176ff004726ba8d3f972
2018-04-10 06:24:17 -07:00
TreeHugger Robot
9139bbfa9b Merge "Different hidden API enforcement policy for P & pre-P." into pi-dev 2018-04-10 13:07:41 +00:00
Dan Gittik
8e7231bccf Merge "Added system-wide minimum brightness curve." into pi-dev am: 082147cfe1
am: 746256b546

Change-Id: I457cfa2b9c4eec3606e2520446644a07ec2a8397
2018-04-10 04:52:34 -07:00
Dan Gittik
746256b546 Merge "Added system-wide minimum brightness curve." into pi-dev
am: 082147cfe1

Change-Id: Ia74815253c61e3054cdac5becb5aae0350d6336c
2018-04-10 04:43:09 -07:00
TreeHugger Robot
082147cfe1 Merge "Added system-wide minimum brightness curve." into pi-dev 2018-04-10 11:28:44 +00:00
Mathew Inwood
1ab3025cc7 Different hidden API enforcement policy for P & pre-P.
Also make these configurable so we have the flexibility to change it if
necessary.

Setting the policy inside ActivityManagerService is not ideal, as that
means that AMS is the only place where the policy in ApplicationInfo is
correct. It should really be set inside PackageManagerService. However,
if it's set there, it would get out of date when the settings change, and
we'd have to update inside AMS anyway. So putting it only here seems ok
for now.

Test: $ adb shell settings put global hidden_api_policy_pre_p_apps 2
Test: $ adb shell settings put global hidden_api_policy_p_apps 2
Bug: 64382372
Change-Id: Ic4cbbb1e6464623e90c17ae08c0b6cbbe0dfa125
2018-04-10 10:13:07 +01:00
Dianne Hackborn
bce7549727 Merge "Fix issue #77721907: Add global setting to hide all error dialogs" into pi-dev am: 1f596e0c2e
am: d260ab199f

Change-Id: If18ad593ad81c918116407e78f6e462886e5b892
2018-04-09 23:48:11 -07:00
Dianne Hackborn
d260ab199f Merge "Fix issue #77721907: Add global setting to hide all error dialogs" into pi-dev
am: 1f596e0c2e

Change-Id: I64a8fceb305856c12645cb4c9ba7cf691cf23976
2018-04-09 23:39:36 -07:00
Dianne Hackborn
1f596e0c2e Merge "Fix issue #77721907: Add global setting to hide all error dialogs" into pi-dev 2018-04-10 06:24:50 +00:00
Christine Franks
dc00e645bc Merge "Whitelist DISPLAY_COLOR_MODE setting for B&R" into pi-dev am: a1b3aa27dd
am: 2b6ef340c4

Change-Id: I3ba177d5b95fd2bbb7f1b43cd55094150fe9fd3e
2018-04-09 19:35:58 -07:00
Jeff Sharkey
415716915e Offer to format data sizes in either IEC or SI.
Add flags to let callers specify if they want IEC (power-of-two) or
SI (power-of-ten) units when formatting bytes.

Continue using SI units by default, since certain folks seem to have
strong opinions about that.

Bug: 76159924
Test: atest android.text.format.FormatterTest
Exempt-From-Owner-Approval: previous PS approved
Change-Id: I0074bb2578c2230e938b3f39c2564b1083feb825
2018-04-09 20:23:54 -06:00
Christine Franks
2b6ef340c4 Merge "Whitelist DISPLAY_COLOR_MODE setting for B&R" into pi-dev
am: a1b3aa27dd

Change-Id: I9f6cca01f68eafc4cfd249d46d8f9d5bfd7ce680
2018-04-09 18:31:44 -07:00
Jeff Sharkey
f35b79c609 Merge "API council requested tweaks to SubscriptionPlan." into pi-dev am: 5e0d360411
am: 4cd485f8e5

Change-Id: I5f3f1b04573a8a2286cf4d6456d7196fc5ed417d
2018-04-09 18:09:12 -07:00
Christine Franks
a1b3aa27dd Merge "Whitelist DISPLAY_COLOR_MODE setting for B&R" into pi-dev 2018-04-10 00:16:02 +00:00
Jeff Sharkey
4cd485f8e5 Merge "API council requested tweaks to SubscriptionPlan." into pi-dev
am: 5e0d360411

Change-Id: I447d4041d1dd0751147d13792b07d6617b27978a
2018-04-09 17:09:34 -07:00
Jeff Sharkey
5e0d360411 Merge "API council requested tweaks to SubscriptionPlan." into pi-dev 2018-04-09 23:20:43 +00:00
Christine Franks
1269960d99 Whitelist DISPLAY_COLOR_MODE setting for B&R
Bug: 68664032
Test: make -j100 && atest SettingsBackupTest && atest
SettingsValidatorsTest
Change-Id: I1d38acfcd3e6a0c228ae6891581b3218d4a67e6b
2018-04-09 14:41:59 -07:00
Jeff Sharkey
d2120e09a0 Merge "More knobs for connectivity experiments." into pi-dev am: 70df722321
am: 4f431f42cd

Change-Id: Ib5c3d10b1480220738c0972edcca65d8fdd62cba
2018-04-09 11:01:37 -07:00
Jeff Sharkey
4f431f42cd Merge "More knobs for connectivity experiments." into pi-dev
am: 70df722321

Change-Id: I4957ea5904101d781820f2dbbc5199a3139e2a54
2018-04-09 10:48:52 -07:00
Dianne Hackborn
82b17ca340 Fix issue #77721907: Add global setting to hide all error dialogs
adb shell settings put global hide_error_dialogs 1

This forces the same behavior as other devices that hide all
dialogs.

Bug: 77721907
Test: manual
Change-Id: I93e03d55f885f1874c33f46cad8cede0c759063b
2018-04-09 10:35:37 -07:00
TreeHugger Robot
70df722321 Merge "More knobs for connectivity experiments." into pi-dev 2018-04-09 17:33:15 +00:00
Jan Althaus
5c181fb2ec Merge "Fixing broken logging of OTHER events" into pi-dev am: 706edbd776
am: 1a1ff74bb6

Change-Id: Id275954847b2ed6d2389f1aad7b5c210971410b4
2018-04-09 06:29:19 -07:00
Jan Althaus
1a1ff74bb6 Merge "Fixing broken logging of OTHER events" into pi-dev
am: 706edbd776

Change-Id: Id4a2866e93e1c03c1e7a6b236175f2faae4cd6f6
2018-04-09 06:21:08 -07:00
Jan Althaus
706edbd776 Merge "Fixing broken logging of OTHER events" into pi-dev 2018-04-09 13:09:55 +00:00
Annie Meng
32e7e082f7 Merge "Don't backup/restore screen brightness" into pi-dev
am: 3a7e021169

Change-Id: Id27f2a0631fde41e2b247ec3eb48419bb48bc84d
2018-04-09 03:01:14 -07:00
Annie Meng
3a7e021169 Merge "Don't backup/restore screen brightness" into pi-dev 2018-04-09 09:53:48 +00:00
Clara Bayarri
536720ab31 Merge "Fix crash when modifying Selection" into pi-dev am: 1f2c6dea41
am: 82b8682922

Change-Id: I092f67aa3422b9a09ab969c3a2a794e62222dcc8
2018-04-09 02:48:41 -07:00
Clara Bayarri
82b8682922 Merge "Fix crash when modifying Selection" into pi-dev
am: 1f2c6dea41

Change-Id: Ic2bdd0642c4b94dc22d93dd19dade56e69e3e04e
2018-04-09 02:37:55 -07:00
TreeHugger Robot
1f2c6dea41 Merge "Fix crash when modifying Selection" into pi-dev 2018-04-09 09:26:42 +00:00
Robin Bennett
f6962c871d Merge "Add setting/experiment to send keycode sleep for ungaze when Home is the foreground activity." into pi-dev am: 219e139651
am: b1b9aa2ea0

Change-Id: I46ed3f1d59513bba6342f0ee29ba94de8b7f5c2b
2018-04-09 01:06:14 -07:00
Robin Bennett
b1b9aa2ea0 Merge "Add setting/experiment to send keycode sleep for ungaze when Home is the foreground activity." into pi-dev
am: 219e139651

Change-Id: I55b953d0f060f38251c6504470d4b13a38b50f25
2018-04-09 00:57:40 -07:00
Robin Bennett
219e139651 Merge "Add setting/experiment to send keycode sleep for ungaze when Home is the foreground activity." into pi-dev 2018-04-09 07:41:20 +00:00
Jan Althaus
042228d588 Merge "Remove legacy logger" into pi-dev am: 4f9d750e91
am: 47e3eb3090

Change-Id: Ie67b636931fbf718d35e013631884546e7069960
2018-04-07 05:34:00 -07:00
Jan Althaus
47e3eb3090 Merge "Remove legacy logger" into pi-dev
am: 4f9d750e91

Change-Id: I3ecf08e3608ca0ee79c11f4eae9356f6412f29ab
2018-04-07 05:21:22 -07:00
Jan Althaus
4f9d750e91 Merge "Remove legacy logger" into pi-dev 2018-04-07 12:06:12 +00:00
Jan Althaus
5a03094ebc Remove legacy logger
Migrate DefaultLogger implementation to SelectionSessionLogger.
This cleans up after the API refactor and fixes two bugs:
- All events are currently logged twice.
- Interfaces accept a null signature, but it currently crashes the legacy logger.

Bug: 73392698
Bug: 77659305
Test: atest FrameworksCoreTests:TextClassificationManagerTest
Test: atest FrameworksCoreTests:TextClassificationTest
Test: atest CtsViewTestCases:TextClassificationManagerTest
Test: atest CtsViewTestCases:TextClassifierValueObjectsTest
Test: atest CtsWidgetTestCases:TextViewTest
Test: atest CtsWidgetTestCases:EditTextTest
Test: Manually examined logs
Change-Id: I0d2b925abf5cab12d71fc2cc0fa527530c86ab10
2018-04-07 12:04:49 +00:00