The drag down animation didn't do the transition
to the full shade visually, so things would look
out of place.
Fixes: 191282610
Test: drag down while bypassing
Change-Id: Icdd62155f3762621c1046ed5271476ec0b4e2635
Merged-In: Icdd62155f3762621c1046ed5271476ec0b4e2635
- Whenever we defer the cleanup of the back gesture, schedule a failsafe
to clean up the window if it's not handled properly. We'll enable
this failsafe for sc-dev and disable it for further investigations
post sc-dev
- Dump additional info for the nav bar window so we can narrow down
the issue post sc-dev
Bug: 190778197
Test: Can't repro the initial issue, so artificially trigger it to verify failsafe
Test: adb shell dumpsys activity service SystemUIService
Change-Id: I0a8f25babe750e6e5ba4c933ab5271a82ef63646
Fixes visibility issue where keyguard could enter a bad state where QS
remains visible even though it should be hidden.
Previously, keyguard could enter a bad state if QS was closed while it
had a detail panel open that had animations disabled.
To fix issue, run animations when closing detail panels, even if they
requested not to be animated on close.
Test: Turn off all animations (i.e. adb shell 'settings put global
animator_duration_scale 0.0 && settings put global
transition_animation_scale 0.0 && settings put global
window_animation_scale 0.0'), open QS, tap user icon, tap close,
ensure you are taken back to the lock screen and that the UI looks
normal
Test: Rapidly tap the user icon and bottom of keyguard in quick
succession, ensure that keyguard UI never enters a bad state
Fixes: 193549640
Fixes: 193545214
Change-Id: Ie092f83031edaff0240194832b5499df3b4eab12
If the user starts to scroll while the panel is not fully expanded,
expand it fully.
Test: manual: expand and collapse QS while trying to scroll it
Fixes: 189915859
Change-Id: I15d46e3ff4c67754aa8063ffa55e5c62cad7dc89
Previously the bounds animation was on the background which doesn't
exist anymore.
Fixes: 192059748
Test: add media, dismiss, observe normal animation
Change-Id: I0f90b3ca5224b538c62adf30081ad30ed906b3b1
This CL ensures that we don't show the keyguard early when unlocking the
phone from the bouncer after swiping up on the lockscreen.
Bug: 191031464
Test: Manual, swipe up on lockscreen with PIN
Change-Id: Id7269189c857e1108a8e33074bb5abfd40437deb
When FalsingManager#cleanupInternal is called, it no longer produces
valid results. With this change, we check that the FalsingManager
is not used after being destroyed, and also avoid destroying it in
WalletScreenController.
Fixes: 188174214
Test: manual
Change-Id: I0ce67de5a326b56dee11c1d63c1d592640c0713d
Add media back into smartspace content when the new plugin is
enabled. Only show media on AOD when no other content is displayed,
other than the default weather/date card.
Fixes: 185373132
Test: atest KeyguardMediaViewControllerTest
Change-Id: I9a1ff4eaeb4e13ed30c7796c1e9d2d5d46916737
For stock tiles state (filled in subtitle when there is not one set by
the tiles), we specify values for each of the tiles states. That way,
they can be translated with that specific tile name in mind for
grammatical matching.
Custom tiles will use the default.
New stock tiles must add a new array to pass tests.
Test: QSTileViewImplTest TilesStatesTextTest
Fixes: 188163204
Change-Id: Idd4da01994e37cb4778dcdd3080711179cb884c7
When dragging down on the lockscreen, we now pull down the quick
settings while dragging instead of wating for the release
Bug: 184946919
Test: atest SystemUITests
Change-Id: Ib233282dd7ce4ba63ceab3e1b788aa164e88c8c0
Support next alarm appearing next to DnD. If weather is showing, show
inline, otherwise below the smartspace content. Next alarm will not
fade out but DnD will.
Fixes: 185678563
Test: atest KeyguardZenAlarmViewControllerTest
Change-Id: I21e95470d0013bfb6900c1c228dda69f5707c9e6
Logic for side view:
* If the tile has a sideViewCustomDrawable, show that regardless of
State
* Else, if the tile is not Boolean or the state has forceExpandView, it
shows a chevron.
* Else, show nothing.
Test: atest com.android.systemui.qs
Test: manual
Fixes: 187057842
Change-Id: Ib9407914f4fbe5ac833b06008fc405435d0c45b0
Add support for systemui to inform smartspace about do not disturb
settings. Address some minor spacing issues. Fix how smartspace loads
through dagger.
Fixes: 185970916
Test: atest KeyguardClockSwitchControllerTest
Change-Id: Id19244ceb45fb70a28d780fa5edefab35a5e42c4
Breaks the dependency of SystemUIPlugins on ThresholdSensor
by introducing an intermediate interface.
Fixes: 186781915
Test: manual
Change-Id: Ib2633f8f2acaa1d21f1e8968317b4a4e63d3af32
Also integrate the FalsingManager, which is important for determining
user intent while on the lockscreen.
Fixes: 186219857
Test: atest KeyguardClockSwitchControllerTest
Change-Id: I22108ec2335bd350fbcaf5d5b90dd3b351011767
Pass dozeAmount values to the smartspace library to allow the lib to
make decisions regarding content on both AOD and Lockscreen
Fixes: 185598979
Test: manual, multiple smartspace cards
Change-Id: Ic7bc2ba238b22794a33e6db18c1aae0fa7c96e0b
This is largely for both AOD and lockscreen, while may have different
colors than launcher. Particularly for AOD, we need to transition to a
WHITE color. Set a primary text color, with expectations that a
secondary color will later be set in order to support cards with
various background colors.
Fixes: 185211979
Test: manual, change to AOD <-> LS
Change-Id: I36fb8e5cfcbac1ec999b2b9df08f42d47507990f
Method no longer takes `robustCheck` parameter. Instead,
FalsingManager#isSimpleTap is added for basic checking, and
FalsingManager#isTap does robust checking by default.
FalsingManager#isTap takes an enum value for penalty instead of
a double, making the value more understandable.
Bug: 172655679
Test: atest SystemUITests && manual
Change-Id: Ib4a99f87bcd6acee67a98420f460c98d44fa6360
This CL adds a generic way in GhostViewLaunchAnimationController to
change the corner radius of the expanding background. It does so by
supporting Gradient- and LayerDrawable (and therefore RippleDrawable).
This will be first used to animate the launch of the settings after long
clicking a QS tile (see ag/13988954), but this implementation will
hopefully work with other views as well.
This CL also adds the wiring in ActivityStarter that will be needed by
the QuickSettings.
Bug: 184121838
Test: Manual
Change-Id: I40f7048edd682d5d68c32b4439368d19009a8df1
This CL removes all logic specific to notifications in
ActivityLaunchAnimator, so that it can be reused for other launch
animations.
I would suggest to look at ag/14057092 in parallel to make more sense of
the abstractions added in this CL.
For the sake of not making this CL even bigger than it already is, a few
things still need to be done in follow-up CLs:
- Show the status bar icons at the right time, instead of at the end of
the animation, when using the StatusBarLaunchAnimatorController.
- Move the animation/ package outside of the SystemUIPluginLib library
and instead have it in its own reusable library.
- Replace the animation durations and interpolator to the latest
designs.
- Improve split screen by retrieving the final window bounds and
prevent the clipping of the window during the animation.
- Handle animations in the lock screen.
For review, I would recommend to review in order:
1. ActivityLaunchAnimator.kt
2. StatusBarLaunchAnimatorController.kt
3. NotificationLaunchAnimatorController.kt
4. GhostedViewLaunchAnimatorController.kt
5. Everything else.
Bug: 184121838
Bug: 181654098
Test: Tap a notification when the shade is open and unlocked.
Change-Id: If4c3c64fcd153bb8e89111f56332013ca6dff156
We fetch the wallet cards on handleUpdateState() of the Tile, if the
card image exists, it will be stored in the QS State and then pass to
the QSTileViewHorizontal so the card image will be presented on the
tile.
The car image won't show on the tile when the user is edittng the tiles.
Test: manually tested on device
locked - https://hsv.googleplex.com/5756150307880960
unlocked - https://hsv.googleplex.com/5767433589620736
Test: atest
Bug: b/182963608
Change-Id: I45bab06528a7154419ae73f9e576cf385bf0f7c1
User detail panel settings button will now say "Close" instead
of "Done"
Bug: 169783558
Test: atest SystemUITests
Change-Id: Ibafe212dce8a8b8654e877418200e1dc2c5dec8b
User detail panel settings button will now say "User settings" instead
of "More settings"
Bug: 169783558
Test: atest SystemUITests
Change-Id: I1a7a6963f15dbbf6ed8086113fa47f4662d8373c
