Commit Graph

5552 Commits

Author SHA1 Message Date
Clara Bayarri
3d5a78aa40 am acc6fc50: am fee163c5: am de5cdeba: Merge "Fix Toolbar is not refreshed after Select All" into mnc-dev
* commit 'acc6fc509e2f45bfbb2a9d148a7e61a378f18b3e':
  Fix Toolbar is not refreshed after Select All
2015-06-05 02:43:30 +00:00
Clara Bayarri
01243ac57e Fix Toolbar is not refreshed after Select All
Bug: 21361248
Change-Id: Iab913bd610c208e5881d3d0eb5574efdf9eb5d92
2015-06-05 03:03:31 +01:00
Doris Liu
3dd9a25e61 am d8fa6c3a: am 6e941351: am 5de55868: Merge "Make ListView\'s EdgeEffect respect the clipToPadding flag" into mnc-dev
* commit 'd8fa6c3aeccf8be0f54ab2a8b4778c896cbc0546':
  Make ListView's EdgeEffect respect the clipToPadding flag
2015-06-05 01:27:32 +00:00
Clara Bayarri
b1d4d77d6a am 612e1da8: am f407aa30: am c1f28bc9: Merge "Separate the SelectionActionMode into Insertion and Selection." into mnc-dev
* commit '612e1da808b327aba06be883a54dc08f9afd6dd2':
  Separate the SelectionActionMode into Insertion and Selection.
2015-06-05 01:18:32 +00:00
Doris Liu
5de55868a9 Merge "Make ListView's EdgeEffect respect the clipToPadding flag" into mnc-dev 2015-06-05 00:57:32 +00:00
Doris Liu
f36c061909 Make ListView's EdgeEffect respect the clipToPadding flag
This CL sets the position of EdgeEffect based on whether
clipToPadding is enabled. When enabled, the EdgeEffect will be
bounded to the padding. Otherwise, it will be drawn at the view's
bounds.

Bug: 21595866
Change-Id: I3968e5b8d3a75ce2d7607e2037bc372024694d5b
2015-06-04 17:50:47 -07:00
Clara Bayarri
c1f28bc97d Merge "Separate the SelectionActionMode into Insertion and Selection." into mnc-dev 2015-06-05 00:40:43 +00:00
Clara Bayarri
7938cdbf98 Separate the SelectionActionMode into Insertion and Selection.
When we got rid of the paste popup, we merged it into the Selection
ActionMode and moved all its invocations to the ActionMode. Some apps
actually want the paste popup without the Selection ActionMode, hence
separating them again allows them to cancel the one they want.

Bug: 21571422
Change-Id: I91bcd0d9c3e68d9c736698fe0bec010b4c9f5cf3
2015-06-04 20:46:19 +01:00
Alan Viverette
6004b663ed am 59e81d32: am e6206fb8: am 2e4e5d74: Merge "Revert "Synchronize selected item data on-demand after data set invalidation"" into mnc-dev
* commit '59e81d32efd406c1112c474ac7f8dfadf22b371e':
  Revert "Synchronize selected item data on-demand after data set invalidation"
2015-06-04 19:33:16 +00:00
Alan Viverette
2e4e5d745f Merge "Revert "Synchronize selected item data on-demand after data set invalidation"" into mnc-dev 2015-06-04 17:19:27 +00:00
Alan Viverette
31ff78b146 Revert "Synchronize selected item data on-demand after data set invalidation"
This CL was a can of worms. More extensive changes are
needed to decouple AdapterView state from measure/layout
passes.

This reverts commit abed07f6c0.

Change-Id: I4e4e01692a1f660a04e9dfd16db882f13c3d0b94
2015-06-04 17:18:34 +00:00
Keisuke Kuroyanagi
88cf0a9335 am 48c21f47: am cf528d4b: am 4186b1d4: Merge "Stop offering "Replace..." when there are no suggestions." into mnc-dev
* commit '48c21f472b68b3312c73428ed3cbcd274ec50405':
  Stop offering "Replace..." when there are no suggestions.
2015-06-04 06:42:20 +00:00
Keisuke Kuroyanagi
4186b1d4d8 Merge "Stop offering "Replace..." when there are no suggestions." into mnc-dev 2015-06-04 06:06:52 +00:00
Alan Viverette
147ec13c20 am 424c08d5: am 3b2e25a4: am 8d6a9363: Merge "Fix drop down layout inflation in ThemedSpinnerAdapter classes" into mnc-dev
* commit '424c08d5a3b1b1f2040b7bea89f822c5bc5541ec':
  Fix drop down layout inflation in ThemedSpinnerAdapter classes
2015-06-04 00:25:35 +00:00
Alan Viverette
ea95b729e7 am bc0631b0: am ccb342c4: am d3c9df1a: Merge "Update number picker styling for Material" into mnc-dev
* commit 'bc0631b04b32fc547b8a9cc7a916380549013c84':
  Update number picker styling for Material
2015-06-04 00:11:32 +00:00
Alan Viverette
a40a7b1354 am f8e556e7: am 891a7ee6: am e9bb596c: Merge "Synchronize selected item data on-demand after data set invalidation" into mnc-dev
* commit 'f8e556e7eb58d1bccfea52effd9faa3bf5caf80f':
  Synchronize selected item data on-demand after data set invalidation
2015-06-03 23:57:11 +00:00
Alan Viverette
1c1b18abfb am b4133483: am bdb1127a: am b8da5340: Merge "Pass setEnabled() value in calendar-mode DatePicker delegate" into mnc-dev
* commit 'b4133483bd4e5127e4bd7c129ea9b5f129609f06':
  Pass setEnabled() value in calendar-mode DatePicker delegate
2015-06-03 23:57:06 +00:00
Alan Viverette
8d6a9363a1 Merge "Fix drop down layout inflation in ThemedSpinnerAdapter classes" into mnc-dev 2015-06-03 23:48:41 +00:00
Raph Levien
8746623e3c am 7f374287: am 85e9092d: am 88ac4e04: Merge "Rename setTextDir to setTextDirection" into mnc-dev
* commit '7f374287c418fd66299be4db36db21e5ab04740a':
  Rename setTextDir to setTextDirection
2015-06-03 23:46:42 +00:00
Alan Viverette
d3c9df1a34 Merge "Update number picker styling for Material" into mnc-dev 2015-06-03 23:35:02 +00:00
Alan Viverette
e9bb596cc8 Merge "Synchronize selected item data on-demand after data set invalidation" into mnc-dev 2015-06-03 23:29:10 +00:00
Alan Viverette
7d5967e55e Fix drop down layout inflation in ThemedSpinnerAdapter classes
Bug: 21209640
Change-Id: I32aed1b70977fae25f43714eb3ef6edca53e51e9
2015-06-03 16:27:36 -07:00
Alan Viverette
b8da5340f2 Merge "Pass setEnabled() value in calendar-mode DatePicker delegate" into mnc-dev 2015-06-03 23:20:36 +00:00
Clara Bayarri
3cd93a7055 am 3341fa53: am 79c389de: am eb665337: Merge "Fix Floating tool bar covers text during long press + drag" into mnc-dev
* commit '3341fa534985b55086099931ab079404fc0c12dd':
  Fix Floating tool bar covers text during long press + drag
2015-06-03 23:11:50 +00:00
Raph Levien
88ac4e04a5 Merge "Rename setTextDir to setTextDirection" into mnc-dev 2015-06-03 23:09:49 +00:00
Clara Bayarri
eb66533716 Merge "Fix Floating tool bar covers text during long press + drag" into mnc-dev 2015-06-03 22:33:59 +00:00
Mady Mellor
f9ccf37ec1 am a28b6021: am a80a8025: am 95753e2f: Merge "Ensure to reset state of selecting by word/char for new selections" into mnc-dev
* commit 'a28b60217affc8e0cef6e06e3901347c9011692b':
  Ensure to reset state of selecting by word/char for new selections
2015-06-03 22:26:50 +00:00
James Cook
d6a9223aa3 am 72921131: am 9a0f4bd4: am 8fd48ca3: Merge "Fix TabHost stealing focus on hardware keyboard keypress" into mnc-dev
* commit '72921131d967b560158c2891a8bf570bff106f33':
  Fix TabHost stealing focus on hardware keyboard keypress
2015-06-03 22:26:16 +00:00
Adam Powell
18033be14b am 93925483: am cb3b67f4: am c52e0d90: Merge "Properly restore RTL state in HorizontalScrollView" into mnc-dev
* commit '93925483f38e19d9e5b4e3fb95ec4d103b975cfc':
  Properly restore RTL state in HorizontalScrollView
2015-06-03 22:24:52 +00:00
Alan Viverette
b79ac367ad am 88bba269: am d425e2d7: am 4a7bb462: Merge "Call dispatchFinishTemporaryDetach before returning a transient view" into mnc-dev
* commit '88bba269c64b1bfc2ea2ce38bf6cdd9fcd4deccb':
  Call dispatchFinishTemporaryDetach before returning a transient view
2015-06-03 22:23:58 +00:00
Alan Viverette
abed07f6c0 Synchronize selected item data on-demand after data set invalidation
Previously, the selected item data could become inconsistent between a
call to Adapter.notifyDataSetChanged()/Invalidated() and the subsequent
layout pass.

Bug: 21614294
Change-Id: I45c9c98b2f6a8d8b8fb17de2065efa505cbf3c92
2015-06-03 15:19:13 -07:00
Mady Mellor
95753e2f4b Merge "Ensure to reset state of selecting by word/char for new selections" into mnc-dev 2015-06-03 21:15:19 +00:00
Alan Viverette
f7aa9251d0 Pass setEnabled() value in calendar-mode DatePicker delegate
Fixes mContainer referencing wrong view. Also cleans up getCalendarView()
exception message.

Bug: 21211308
Change-Id: I4ad18206a8071b2c9b75d488e14fd53da6f5fa5b
2015-06-03 14:07:26 -07:00
Clara Bayarri
dfac443516 Fix Floating tool bar covers text during long press + drag
The existing implementation started the ActionMode even when knowing
a drag would start. Moved this logic to once the drag is complete,
to avoid the toolbar popping up while the user is still dragging.

Since the existing method selected the initial word when no other
selection existed, refactored that logic so it is also performed at
the start of the drag. Otherwise, the user sees no selection until
he drags over 2 or more words.

Bug: 21144634

Change-Id: I97cf89b1c4c3ebdbbd1af50bd1ce5aa4af72164b
2015-06-03 22:06:55 +01:00
James Cook
8fd48ca377 Merge "Fix TabHost stealing focus on hardware keyboard keypress" into mnc-dev 2015-06-03 20:58:52 +00:00
Raph Levien
a6a082862b Rename setTextDir to setTextDirection
StaticLayout.Builder used "setTextDir" as a shorthand, but it's not
as clear as spelling it out. So, setTextDirection.

Bug: 21572282
Change-Id: Ia94476562d70678f963196b87bb63511d30836b6
2015-06-03 13:20:45 -07:00
Mady Mellor
36d5a7b225 Ensure to reset state of selecting by word/char for new selections
Previously this value was only updated when interacting with the
selection handles, so if you started a selection, entered by-char mode,
and then started another selection you would still be in by-char mode.
This resulted in incorrect behavior.

This CL alters the logic to update the handle state whenever the cursor
is placed which will included the initial long press to select a word.

Bug: 21301589
Change-Id: I15dbe6f2b76c7edd8ea4b3ba53e7107c47bc48fa
2015-06-03 19:53:52 +00:00
Adam Powell
c52e0d900c Merge "Properly restore RTL state in HorizontalScrollView" into mnc-dev 2015-06-03 19:52:26 +00:00
Alan Viverette
4a7bb4624f Merge "Call dispatchFinishTemporaryDetach before returning a transient view" into mnc-dev 2015-06-03 18:28:50 +00:00
Adam Powell
a3aa6d8278 Properly restore RTL state in HorizontalScrollView
Fix an incorrect unparceling of the previous saved state in
HorizontalScrollView. Remove an unneeded field in the saved state by
storing scroll offset from start instead of scrollX + isRtl.

Bug 20666194

Change-Id: I1ec45b3e3bd0846b5f659356df7ff94f42e61055
2015-06-03 10:56:45 -07:00
Alan Viverette
6c413ce638 Call dispatchFinishTemporaryDetach before returning a transient view
ListView caches transient state views for reuse during layout, which calls
dispatchStartTemporaryDetach() before caching the view. This should always
be followed by a corresponding dispatchFinishTemporaryDetach() before
removing the view from the cache and returning it for reuse. While this
was the case for other types of cached views, we missed this call for
views placed in one of the two transient view caches.

Bug: 17387206
Change-Id: I360945006558b2783c098183a7cc9bc28d05d9ab
2015-06-03 10:35:44 -07:00
Alan Viverette
d03a54140d am 14d8afc6: am 4156c870: am e25f6587: Merge "API review feedback for ThemedSpinnerAdapter, Spinner" into mnc-dev
* commit '14d8afc62f8665def5daec10b6abdf8dc7d52d76':
  API review feedback for ThemedSpinnerAdapter, Spinner
2015-06-03 02:36:04 +00:00
James Cook
d8b7d2ce2d Fix TabHost stealing focus on hardware keyboard keypress
Don't try to change focus at all on exit from touch mode. The old
behavior might have been useful for very old apps with a TabHost as
their primary UI, but that's not a modern app structure.

Bug: 21417491
Change-Id: I3db2ab42c90b6c82f23216244a8183c4290eb7d7
2015-06-02 16:02:12 -07:00
Alan Viverette
d281428abd Update number picker styling for Material
Implements several missing drawable maintenance methods (state, etc.)
for NumberPicker's divider.

Bug: 21588885
Change-Id: Ibe37884354864c43fbf84d9eb79d7183af46fcad
2015-06-02 15:47:37 -07:00
Alan Viverette
2add9bcf8c API review feedback for ThemedSpinnerAdapter, Spinner
Moves themed interface out of Spinner and extends SpinnerAdapter, updates
Spinner constructor to take a Theme rather than a Context.

Does NOT change BaseAdapter to implement ThemedSpinnerAdapter, because
the BaseAdapter class does not have any notion of layout inflation and
that would break the contract implied by ThemedSpinnerAdapter.

Bug: 21571899
Change-Id: Id7e8d630458857ce6c93a6a8b8f920e169ee1152
2015-06-02 14:54:40 -07:00
Clara Bayarri
be850e8362 am 9ebf7522: am 8ed46d3f: am a0b77dd5: Merge "Fix TextView ActionMode overflow finishes the ActionMode" into mnc-dev
* commit '9ebf7522895589d7bc9d6508c100ef8a26d42c9f':
  Fix TextView ActionMode overflow finishes the ActionMode
2015-06-02 19:22:40 +00:00
Clara Bayarri
6ed5549cf1 am dc1630e4: am 4ebfd76a: am d63a1776: Merge "Make Text Selection Action Mode secondary items IF_ROOM" into mnc-dev
* commit 'dc1630e45334b72a337e4dcb31fce453aa0fd3e1':
  Make Text Selection Action Mode secondary items IF_ROOM
2015-06-02 19:22:34 +00:00
Jorim Jaggi
54e12e8cc0 am b17e96de: am a60e4b08: am 03a7c4c6: Fix shared drawable state
* commit 'b17e96de98f16d9322ccca7457ee9c8197b416c9':
  Fix shared drawable state
2015-06-02 19:22:15 +00:00
Alan Viverette
d584b26ae6 am 1a92fc59: am bbc27621: am b0f94ae5: Merge "Always send VIEW_CLICKED event from AdapterView.performItemClick()" into mnc-dev
* commit '1a92fc592b76519cf746b7d4f9ed2878163ebbbb':
  Always send VIEW_CLICKED event from AdapterView.performItemClick()
2015-06-02 19:21:57 +00:00
Alan Viverette
8760d9df16 am 9a5b45c1: am 49ceab84: am e0e5c1cf: Merge "Clean up AbsListView constructor" into mnc-dev
* commit '9a5b45c1e1e91f00fed6d84876a670f5278f934f':
  Clean up AbsListView constructor
2015-06-02 19:20:15 +00:00