Commit Graph

2110 Commits

Author SHA1 Message Date
Winson Chung
9a355fbb0d Merge "Updating javadoc for StackView constructors (4554433)" 2011-09-06 19:41:46 -07:00
Winson Chung
abc8b50a26 Updating javadoc for StackView constructors (4554433)
Change-Id: I084c9535f9be4ae4e3942828d3b624d28eae4b06
2011-09-06 18:44:21 -07:00
Gilles Debunne
0046199dab Merge "Fix "out of bound exception" when the span has prefix." 2011-09-06 17:51:10 -07:00
Gilles Debunne
d486bd2789 Merge "Fix several issues with the "EasyEditSpan"." 2011-09-06 17:42:31 -07:00
Luca Zanolin
1564fc7c7e Fix several issues with the "EasyEditSpan".
- The easy edit span was displayed twice when in extracted mode. The orignal TextView now checks if it is in extra mode, and if so it does not display any pop-up
- The easy edit span was displayed before the view was layout causing the application to crash.

New feature:

- the span is automatically hidden after a timeout

I also renamed all the fields and classes to "EasyEdit...". There were still some field/class using an old name.

Bug: 5255363
Bug: 5247453
Bug: 5246997

Change-Id: Ic9bf05d2525e2df9017c91344a687e8cb9105417
2011-09-07 00:01:28 +01:00
Fabrice Di Meglio
c6fc20a91b Merge "Fix bug #5262565 Need to remove CharCount TextDirectionHeuristics" 2011-09-06 15:12:25 -07:00
Luca Zanolin
2346e0117d Fix "out of bound exception" when the span has prefix.
Change the behavior of the highlight marking the "suggested text" and not the differences.

Bug: 5252699
Change-Id: I4c7e9fc9bac81da8b5f643990b86a336363d7968
2011-09-06 22:56:59 +01:00
Svetoslav Ganov
6436876156 Merge "AbsListView does not populate accessibility events correctly." 2011-09-06 12:52:06 -07:00
Fabrice Di Meglio
e3bf88da23 Fix bug #5262565 Need to remove CharCount TextDirectionHeuristics
- update unit tests too

Change-Id: I7c518f58a9f17cb679bc3913bdd38243f7ad2195
2011-09-06 11:08:45 -07:00
Svetoslav Ganov
aa56534722 AbsListView does not populate accessibility events correctly.
The toIndex of accessibility events fired from a AbsListView
is exclusive but should be inclusive i.e. it was reported one
more that it has to be.

bug:5256286

Change-Id: I496959fdfb6760b0c74899730c4cc558e89234a6
2011-09-05 16:41:51 -07:00
Fabrice Di Meglio
34d2eba560 Fix bug #5243493 TextView selection is not working correctly when there is some RTL run into it
Part 2

- make selection handles aware of the run direction

Change-Id: Idf41036de53d8968e7ae27eb87aea09e86bcd652
2011-09-02 18:03:21 -07:00
Adam Powell
a59e3146b7 Merge "Fix bug 5201420 - Appease the monkeys" 2011-09-02 17:01:28 -07:00
Adam Powell
e1bf486846 Fix bug 5201420 - Appease the monkeys
Make ListView.onFocusChanged more tolerant of missing adapters.

Change-Id: Icae1cfd02fe369d3fd0e3c6531adb973f44f3036
2011-09-02 16:56:57 -07:00
Adam Powell
a1b92c5e8b Fix bug 5231904 - Fix wobbly progress spinners
Make ProgressBar maintain aspect ratio on indeterminate progress drawables.

Make RotateDrawable tolerate left/top bounds != 0.

Change-Id: Iee03030caa98f72a8745f1ae3fb0de108ff663d4
2011-09-02 16:37:41 -07:00
Gilles Debunne
572527f2c3 Merge "Remove the suggestion underline when the TextView loses focus." 2011-09-02 13:54:48 -07:00
Gilles Debunne
a41bc33855 Merge "Popup windows positions are updated when a TextView is scrolled" 2011-09-02 13:24:20 -07:00
Gilles Debunne
f3d78eac0f Merge "Added an add to dictionary option in suggestions for misspelled words" 2011-09-02 13:19:24 -07:00
Gilles Debunne
26b5cf40b1 Merge "Fixes around text selection" 2011-09-02 13:17:44 -07:00
Gilles Debunne
1737fcd689 Merge "Fix for NPE in Switch" 2011-09-02 13:17:13 -07:00
Luca Zanolin
fe5e9834a3 Remove the suggestion underline when the TextView loses focus.
Only the easy correction (i.e., voice ime corrections) will lose the underline, while the misspelled span will not.

Change-Id: If96c17473dd70c99b808739ddde800cc93551e2a
2011-09-02 19:41:42 +01:00
Gilles Debunne
70a6312f09 Fixes around text selection
Text selection mode was started by two consecutive taps inside a
field with selectAllOnFocus.

ArrowKeyMovementMethod does not respect the possible cancelLongPress and handles up events.
As a result a scroll that happens to end up at its initial position will be considered a tap
and will move the cursor.
This is however not considered as a tap in TextView and a possible selection mode would not
be stopped in that case.
Fixed by making ArrowKeyMovementMethod aware of the cancel that happened in Touch.

Change-Id: I07372b703f250e1edc7ee0665318ce30441b9187
2011-09-02 11:26:46 -07:00
Gilles Debunne
e90bed18cc Added an add to dictionary option in suggestions for misspelled words
Change-Id: I031f17a76b4a81ae375b778046b8c391f9b8b2b2
2011-09-02 09:04:26 -07:00
Svetoslav Ganov
17b0317e8d Merge "Accessibility events fired from AdapterView underpopulated." 2011-09-01 18:39:29 -07:00
Svetoslav Ganov
c48c47c820 Accessibility events fired from AdapterView underpopulated.
Accessibility events fired by an AdapterView did not report
the index of the first and last visible items, rather only
the total item count.

bug:5225039

Change-Id: I6931d82f0418c659f26e1e8a345da69da99690c5
2011-09-01 18:22:37 -07:00
Svetoslav Ganov
d5e6527f5f Merge "Polish of the accessibility feedback of Date and Time pickers" 2011-09-01 18:14:38 -07:00
Svetoslav Ganov
3fec3fe0e3 Polish of the accessibility feedback of Date and Time pickers
bug:5228006
bug:5228004

Change-Id: I927e3a6dcbf4f81eab6f506fc38842d8e7a37aa1
2011-09-01 18:04:27 -07:00
Gilles Debunne
f682a77d5e Popup windows positions are updated when a TextView is scrolled
The View's internal scroll was not triggering an update of the popup windows' positions.

Also fixes an update problem when a new long press moved the action popup window.

Change-Id: Ic3bb39fc55981c67db2a15ef2e90aad37a36d116
2011-09-01 18:00:52 -07:00
Gilles Debunne
e724ee4b04 Fix for NPE in Switch
Happens when the checked state is set in XML in the CompoundButton
constructor. The drawable are not yet loaded at that point.

This still work since the Switch constructor calls setChecked, which
will invalidate.

Change-Id: I76459307e77596ce0f2759e9449eb42287c6bad7
2011-09-01 16:58:05 -07:00
Gilles Debunne
8a16f92270 Merge "Using ListView for Suggestion popup window" 2011-09-01 11:42:23 -07:00
Adam Powell
89935e41c5 Make EdgeEffect public API.
This enables apps to make use of the system's visual edge effect used
during overscroll in 2D content.

Also un-@hide the getCurrVelocity methods from Scroller/OverScroller,
without which it becomes cumbersome to obtain values to pass to the
EdgeEffect#onAbsorb method.

Change-Id: I40e452455f5cb5d45d1fb3687f739fc8eae65560
2011-08-31 14:59:19 -07:00
Gilles Debunne
0eea668151 Using ListView for Suggestion popup window
New background assets from Bug 5204807.
New text selection color and associated handles, bug 5217848.

Change-Id: I4eaea6be732843d8ff344400d029b4a1b80b084f
2011-08-31 11:18:52 -07:00
Adam Powell
282e377d8b Ellipsize marquee TextViews that aren't currently animating
On some devices the fading edge effect can be expensive. Offer an
alternative for screens full of textviews.

Change-Id: I0382b4ea0f8b0c6948cb68611f3679dbf5e2898a
2011-08-30 17:35:15 -07:00
Gilles Debunne
b5305007a6 Merge "Add EditTextShortcutSpan to provide edit short cut in the text view." 2011-08-30 15:53:33 -07:00
Luca Zanolin
e6d3682189 Add EditTextShortcutSpan to provide edit short cut in the text view.
At the moment, EditTextShortcutSpan allows only the deletion of the text. In the future, we may decide to add extra functionality,
like "retry" where all the text is removed and a specific IME is triggered.

Fix the underline. The underline is not defined in thickness, and not as a multiplier of the default underline thickness.

Change the behaviour of SuggestionRangeSpan to match the specification.

Change-Id: I80437d9887c7a2ff8f62c38afbb0cb7add7ee9c8
2011-08-30 18:04:34 +01:00
Gilles Debunne
57324c7382 Moving action popup window when moving text selection
Long press to select, the action popup (Paste) is displayed.
A second long press moves the selection (selection mode is still on),
but the action popup's location was not updated.

Change-Id: I2ac133e608dbca35ec0236b47b42f029623fc303
2011-08-29 14:42:17 -07:00
Gilles Debunne
9906847cef Bug 5218421: new NPE is SpellChecker when using Japanese language
The spell checker session is null because the Japanase language is not supported.

Change-Id: I41d2157e8f66799fdb6dff718e8903ce6f1bb9fe
2011-08-29 14:12:14 -07:00
Gilles Debunne
474cac1c21 Merge "Suggestions popup window is dismissed on tap outside." 2011-08-29 12:58:36 -07:00
Chet Haase
150176d830 Made the Switch class public.
Tweaked the API of Switch slightly and made the class public (it was
hidden before).

Change-Id: I4a099e8afd18a11a5850252025ae3bbbb866830d
2011-08-29 10:59:58 -07:00
Adam Powell
9a5cc2810b Fix bug 5124021 - Menu visibility incorrect when restoring ListView
selection mode

Fix visibility of menus when action modes are initiailized early.

Fix ListView problems persisting check states.

Change-Id: Idc21036dc39259e72f0e6831a0ccb4695f8858ef
2011-08-28 17:13:16 -07:00
Romain Guy
aa1c88de02 ToggleButton could keep a reference to a previous drawable
Change-Id: Ic19a8e86c61b58926504daf35f0de41358a899b4
2011-08-26 16:21:03 -07:00
Fabrice Di Meglio
d32f27aec0 Merge "Fix bug #5199577 TextView with android:password="true" is showing the "dots" on the left even if the password chars are RTL" 2011-08-26 14:05:09 -07:00
Gilles Debunne
87a4d87ecf Merge "Bug 5218421. Spell check crash with Japanese characters" 2011-08-26 13:28:28 -07:00
Gilles Debunne
d6e3494421 Bug 5218421. Spell check crash with Japanese characters
The word iterator returns no word in that case, and this is not
supported by TextInfo.

Change-Id: Iaf31c58638c02d3cdc7b88bc0d1201e793e84f17
2011-08-26 10:13:18 -07:00
Fabrice Di Meglio
7810b5f8cf Fix bug #5199577 TextView with android:password="true" is showing the "dots" on the left even if the password chars are RTL
- force TextView to LOCALE text heuristic when in "password" mode
- remove TEXT_LAYOUT_DIRECTION_UNKNOWN_DO_NOT_USE
- LocaleUtils.getLayoutDirectionFromLocale() returns "LTR" is locale is NULL or ROOT

Change-Id: I182c46aaf2d73c8b18967fffa230bfabec91ed06
2011-08-25 18:43:37 -07:00
Adam Powell
ba5fe92361 Merge "Fix bug 5199326 - ListView's fast scroller is out of sync with contents" 2011-08-25 15:26:36 -07:00
Adam Powell
35948b7ed5 Fix bug 5199326 - ListView's fast scroller is out of sync with contents
Also fix a bug where the fast scroll track was not being properly
invalidated while animating out.

Change-Id: Ie90568a993699d5d061985985e3d93165d1d2219
2011-08-25 14:17:12 -07:00
Gilles Debunne
8e7e95f22f Merge "Bug 5166707: NPE fixed in getFocusedRect" 2011-08-25 13:45:11 -07:00
Gilles Debunne
fd419b051a Bug 5166707: NPE fixed in getFocusedRect
Change-Id: I1e59ac739f1258c0047a667443f80b2c09ffa12c
2011-08-25 11:53:26 -07:00
Gilles Debunne
28294cc744 Suggestions popup window is dismissed on tap outside.
But now the tap is not handled at all, as it was before. To do this, the popup window
is now focusable. As a result, the TextView's window loses focus. We hide the
cursor to prevent a non-blinking visible cursor. We should also fake the
state of the parent TextView to keep it visually focussed.

SuggestionRangeSpan and SpellCheckSpan had to made Parcelable since they are recreatedi
when the TextView is re-created when the popup is dismissed.

Change-Id: Ic99b2c4f02c282394f214938dd19168547af4886
2011-08-25 11:45:09 -07:00
Gilles Debunne
616b20c0de Remove spell log that exposes typed text in the logs
Change-Id: I88a31f7e1fb93f0550d1cd5eb86afacbc19afd29
2011-08-25 11:33:06 -07:00