Commit Graph

1921 Commits

Author SHA1 Message Date
Shuo Qian
f5f508c01d Throw new IllegalStateException in CallRedirectionService when the call redirection is not initialized yet
Test: Build
Bug: 193482535
Change-Id: I3609362043684249b6d6981fc7d2ab42c676db76
2021-07-16 20:18:21 +00:00
Tyler Gunn
60e5eb6d61 Add a hidden extra key for caller number verification status.
This is used to work around a bug in the remote connection service API
where this property is not being passed through to Telecom.

Test: Use connection manager carrier and verify that VERSTAT is now
propagated to Telecom.
Bug: 192608283

Change-Id: Ie45e7c05d78623085cd2be32470a5870d243745c
2021-07-01 16:55:32 -07:00
Grace Jia
3ad3cb75af Protect TelecomManager#getPhoneAccount with necessary permissions.
Bug: 183407956
Test: make, CTS test
Change-Id: I0ff68f29865c0bb2b316b3fc73d2c5adc37e4a36
(cherry picked from commit b13eb2c476)
2021-06-21 18:37:05 +00:00
Grace Jia
b150ae9b2a Merge "Add error log of addConnetionService in RemoteConnectionManager." into sc-dev 2021-06-04 16:36:21 +00:00
Tyler Gunn
4fab561f27 Merge "Fix potential exceptions in CallDiagnosticService and missing locks." into sc-dev 2021-05-24 20:26:49 +00:00
Tyler Gunn
07d3736f5d Fix potential exceptions in CallDiagnosticService and missing locks.
There is a possibility of a call receiving a details update when it has
already been removed from the CallDiagnosticService.  Handling this case
by just ignoring the details update (since it isn't relevant as the call
is now removed).
Also noted there were a number of places where access to the shared
maps was not synchronized as it should be.

Test: Run manual tests and note no more CDS crashes from SCONE app.
Fixes: 188939131
Change-Id: Ic1f96fd60a70432bef0daaa2e9729c66401ba4ac
2021-05-21 16:20:16 -07:00
Brad Ebinger
722cacf24d Clarify some UCE API docs
Adds some clarifications for how UCE operates
in Android 12.

Fixes: 188580687
Test: docs only change
Change-Id: I139455c286378ccfac876014656f8d3177bdba9d
2021-05-18 23:00:26 +00:00
Tyler Gunn
177d3788ac Merge "Add hidden extra for communicating whether D2D is available" into sc-dev 2021-05-12 16:54:43 +00:00
Grace Jia
6caf1e22d0 Add error log of addConnetionService in RemoteConnectionManager.
There's UnsupportedOperationException in RemoteConnectionManager which
means sometimes we can't find corresponding ConnectionService and we
can't find the root cause of this. Try to print more log if there's
RemoteException when we add ConnectionService.

Bug: 175466894
Test: Manual test
Change-Id: Ia34cf8777c17c3eb45476018125d9b92db391e28
2021-05-11 06:12:01 -07:00
Tyler Gunn
78a59ff70b Add hidden extra for communicating whether D2D is available
Test: Added unit test
Bug: 163085177
Change-Id: I65f7fb38f0582e20899a54859d850982c6637237
2021-05-07 16:41:19 -07:00
Shuo Qian
839508eea2 Handles Telephony service not up fatal exception in CallerInfoAsyncQuery
Bug: 181062609
Test: Treehugger
Change-Id: I5df03a61f55f863e17594aa3239433a5048a4890
2021-05-06 16:26:33 +00:00
Tyler Gunn
11b91fa682 Merge "Fix potential strict mode violation when stopping RTT." into sc-dev 2021-05-03 22:45:06 +00:00
Tyler Gunn
a9d2a35854 Merge "Clarify API docs for setShouldScreenCallViaAudioProcessing." am: 3b35faf805 am: d076349808 am: beab886f6f
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1692377

Change-Id: If9015713e366e211ba58d571666f307fcde92ac7
2021-05-01 01:49:22 +00:00
Tyler Gunn
3b35faf805 Merge "Clarify API docs for setShouldScreenCallViaAudioProcessing." 2021-04-30 23:27:59 +00:00
Tyler Gunn
4cd4248dce Fix potential strict mode violation when stopping RTT.
When the RTT call was cleaned up, the "close()" method was not being
called.  In practice I think the Dialer app never really stops RTT, but
the APIs (and test app) do allow it to be stopped mid-session.  I'm
hypothesizing that is why we don't see this.

Test: Use Telecom test dialer to start and end RTT session.  Observe no
strict mode violation.
Fixes: 186869727

Change-Id: Id474b493ac3fe39e97360f3ac326279fc9a9a5eb
2021-04-30 16:23:15 -07:00
Tyler Gunn
a5ee1ca4e0 Clarify API docs for setShouldScreenCallViaAudioProcessing.
Make it clear that this is only visible to the system dialer.

Test: Build docs
Fixes: 186671257
Change-Id: Ia4633d010ab7d48a7bae0afe3bd32bc9f16447d4
2021-04-30 10:41:54 -07:00
Tyler Gunn
a6502cc4d6 Merge "Remove deprecated at birth DiagnosticCall class." into sc-dev 2021-04-30 15:54:09 +00:00
Brad Ebinger
bde5c37520 Bound Telecom logging recursion
Put a bound on the recursion in Session#toString
to ensure we do not accidently cause a Stack overflow

Bug: 186694546
AOSP: aosp/1691210
Test: atest TeleServiceTests
Change-Id: I52f44dd02d0d860d0894e9b84fded8cf5ff5a18e
2021-04-29 21:18:17 +00:00
Brad Ebinger
9ee6f30273 Bound Telecom logging recursion
Put a bound on the recursion in Session#toString
to ensure we do not accidently cause a Stack overflow

Bug: 186694546
Test: atest TeleServiceTests
Merged-In: I52f44dd02d0d860d0894e9b84fded8cf5ff5a18e
Change-Id: I52f44dd02d0d860d0894e9b84fded8cf5ff5a18e
2021-04-29 21:15:21 +00:00
TreeHugger Robot
2ac5334517 Merge "Add unit test init method." into sc-dev 2021-04-29 04:53:40 +00:00
Tyler Gunn
5ea5afff1e Remove deprecated at birth DiagnosticCall class.
This was left in place for Google3 compatibility during development; this
is no longer required as the usages have been cleaned up.

Test: Build / run CTS
Fixes: 186659702
Change-Id: Ib386c3f9912870b11b1a37863dccfa9d3b5cb7a9
2021-04-28 13:15:30 -07:00
Nazanin Bakhshi
08b9d388b4 Merge "add more details for BluetoothCallQualityReport#isChoppyVoice Bug: 175706147 Test: none" am: 1c09bf0d67 am: 1b6140c6c0 am: c9c6f3ad64
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1682049

Change-Id: Ic6ffdfc765e780ff2596d44ede8bbe97e5fab7bc
2021-04-21 17:56:13 +00:00
Nazanin
fa513c770e add more details for BluetoothCallQualityReport#isChoppyVoice
Bug: 175706147
Test: none

Change-Id: Id47e10dbae7303dde04878745ffe7b08cf1507a7
2021-04-20 13:49:52 -07:00
Brad Ebinger
d0812639e0 Move READ_PHONE_STATE compat id to @hide
Bug: 185121376
Test: atest CtsTelephony2TestCases CtsTelecomTestCases2
Change-Id: I0207faf30c85cc3275e312939bec570390129304
2021-04-17 16:24:06 -07:00
Tyler Gunn
c7e07b99a5 Add unit test init method.
When trying to write some connectionservice unit tests, it became clear
that the mAreAccountsInitialized precondition adds a LOT of overhead
and test scaffolding.  It was easier to just be able to bypass that
in the unit tests.

Test: Added as part of unit test.
Bug: 178649879
Change-Id: Ibed3e69215dad59b252193f701508c18f43b59a2
2021-04-06 12:15:04 -07:00
Treehugger Robot
9864e155a8 Merge "[LSC] Add LOCAL_LICENSE_KINDS to frameworks/base" am: 7226ad3729 am: a087245e03 am: 3dd40d172b
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1661581

Change-Id: I99cb5fd94c4ee02688709ad00e3ffbc3e2f388e7
2021-04-01 13:47:07 +00:00
Bob Badour
de423b7a58 [LSC] Add LOCAL_LICENSE_KINDS to frameworks/base
Added SPDX-license-identifier-Apache-2.0 to:
  drm/java/Android.bp
  graphics/java/Android.bp
  identity/Android.bp
  identity/java/Android.bp
  keystore/java/Android.bp
  location/java/Android.bp
  location/tests/Android.bp
  lowpan/java/Android.bp
  media/mca/effect/java/Android.bp
  media/mca/filterfw/java/Android.bp
  media/mca/filterpacks/java/Android.bp
  mime/java/Android.bp
  mms/java/Android.bp
  opengl/java/Android.bp
  rs/java/Android.bp
  sax/java/Android.bp
  services/tests/servicestests/test-apps/PackageParsingTestManifests/Android.bp
  telecomm/java/Android.bp
  telephony/common/Android.bp
  tests/FlickerTests/test-apps/Android.bp

Added SPDX-license-identifier-Apache-2.0 SPDX-license-identifier-BSD to:
  telephony/java/Android.bp

Bug: 68860345
Bug: 151177513
Bug: 151953481

Test: m all

Exempt-From-Owner-Approval: janitorial work
Change-Id: I2ee0af9ce8f74de2172b359b41d2c52a8b8f7e6c
2021-03-31 19:55:25 -07:00
Hall Liu
1b53c7b5e1 Merge "Add PROPERTY_DOWNGRADED_CONFERENCE to logging" am: 2e0c2171fd am: ff4a4a29e7 am: 9c05c40060
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1358163

Change-Id: Icf555d5e3bceda3bc1260b64c6d7394d4f9adb50
2021-03-31 23:30:47 +00:00
Hall Liu
2e0c2171fd Merge "Add PROPERTY_DOWNGRADED_CONFERENCE to logging" 2021-03-31 22:38:53 +00:00
Anton Hansson
5013902a24 Merge changes I97086e30,Ic55df4cf,I81a08c29 am: 4199ef90b9 am: 4bc578052d am: ec1f981309
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1655736

Change-Id: I5d242cf5b18c4b556105cfcfe78df2ac18a8544e
2021-03-31 18:01:32 +00:00
Anton Hansson
9b2c4a650b Move framework java filegroups into subdirectories
All the java code used to build the framework jar and run metalava
was previously defined in the toplevel Android.bp files. Move these
into the subdirs where the source actually lives.

This simplifies the rules themselves (no path and needless prefix) and
declutters the top level Android.bp.

Test: m
Change-Id: I97086e309eacb879d16facb8497d9940fa5ddaf6
2021-03-30 12:26:55 +01:00
Brad Ebinger
a8366aeae4 Enforce READ_PHONE_STATE for APIs involving call state
For API version 31+, ensure that READ_PHONE_STATE is checked on
APIs that retrieve/notify the call state of the device.

Bug: 157233955
Test: atest CtsTelecomTestCases2 CtsTelephony2TestCases
Change-Id: I9f8674a3075d3e0f75ee4f41eefce328c0fa6b91
2021-03-25 15:11:00 -07:00
Sooraj Sasindran
a390714daf Merge "Add more documentation to PROPERTY_CROSS_SIM" into sc-dev 2021-03-24 21:02:56 +00:00
Sooraj Sasindran
fa1e57a296 Add more documentation to PROPERTY_CROSS_SIM
Add more documentation to PROPERTY_CROSS_SIM

Bug: 179307655
Test: build
Change-Id: Ie57214ad6a2049de4ccdf93d90571cec11338d06
2021-03-23 17:13:58 +00:00
Tyler Gunn
4fcf638eb9 Merge "Move Call state into Call.Details" into sc-dev 2021-03-22 17:19:22 +00:00
Tyler Gunn
0a1c6d1bb4 Propagate call quality reports from Telephony to CallDiagnosticService.
Complete plumbing for call quality reports to get to the CDS.

Test: Manual network testing.
Test: Modify CTS tests to cover these cases.
Bug: 163085177
Change-Id: I2bb68d29c4ad11cc8738c26cd69404fde4348843
2021-03-19 16:39:11 +00:00
Tyler Gunn
1e406ca235 Move Call state into Call.Details
The Telecom Call object is primarily a control object which allows
control of a call and receipt of events related to a call.  The actual
properties and data pertaining to a call all exists in Call.Details...
except for the call state (RINGING,ACTIVE, HOLD, etc).
This CL moves the call state to the Call.Details class to remove this
one dangling property of the base Call class.

Test: Run Telecom CTS test suite.
Bug: 163085177
Change-Id: I59413d3e14d03b48263a5cb351fe4e9a553b578e
2021-03-18 16:47:14 -07:00
Tyler Gunn
066de6034e Rename DiagnosticCall to CallDiagnostics.
Keep DiagnosticAll in a deprecated form to maintain binary compatibility
with ongoing work in other repos.

Test: run CTS
Test: run unit tests
Fixes: 182241145
Change-Id: Ia14113bcce344bb589408b74eaab74d413de9e7e
2021-03-16 16:17:50 -07:00
Tyler Gunn
deb61608ce Merge "Propagate Telephony disconnect cause to Telecom." into sc-dev 2021-03-15 18:28:08 +00:00
Tyler Gunn
110fb53e16 Merge "API review changes to CallDiagnosticService" into sc-dev 2021-03-12 22:35:04 +00:00
Tyler Gunn
801962126d API review changes to CallDiagnosticService
1. Remove NETWORK_TYPE and AUDIO_CODEC constants in favor of existing
constants in TelephonyManager and Connection.  Add API docs explaining
the simplifications of these two concepts.
2. Add more documentation on DiagnosticCall#sendDeviceToDeviceMessage
to explain the D2D protocol and the bandwidth challenges inherent.
3. Remove DiagnosticCall#getCallDetails.
4. Provide provision for developer-defined Executor in the
CallDiagnosticService; added docs there and in DiagnosticCall explaining
the threading model used.

Test: Ran CTS tests
Fixes: 182241145
Change-Id: Icb0d8a05add778a0cfcbe3448063cd9dcee3abc1
2021-03-12 09:42:46 -08:00
Hall Liu
c22a378048 Merge "Clarify semantics in call composer extras" into sc-dev 2021-03-12 17:08:00 +00:00
Grace Jia
0a77d3fc8a Merge "Annotation and doc improvement for adhoc conference APIs." am: 0251d617a5 am: e4bc4e9ca5 am: 3e96c1328c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1412812

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie849bba0805a1a43a841ae204337c12d3f5d9791
2021-03-12 00:51:05 +00:00
Hall Liu
48c3c14a2a Clarify semantics in call composer extras
Docs updates:
* setCallExtraParcelable must take a framework-defined parcelable
* EXTRA_PICTURE_URI takes an android.net.Uri
* Remove redundant documentation on setCallComposerStatus

Fixes: 182510687
Test: docs only
Change-Id: I43f776cf8bcb72c4121515536a3790cf44bf1638
2021-03-11 16:17:31 -08:00
Grace Jia
0251d617a5 Merge "Annotation and doc improvement for adhoc conference APIs." 2021-03-11 23:07:54 +00:00
Tyler Gunn
bc9ecbcfbe Propagate Telephony disconnect cause to Telecom.
Propagate telephony disconnect causes and imsreasoninfo to Telecom for
propagation to CAllDiagnosticService.

Plumb through disconnect message override in CallDiagnosticService.

Test: Added new CTS test coverage for these APIs.
Test: Manual test with telecom test app; verify the disconnect message is
overridden.
Bug: 163085177

Change-Id: I0c6938f2d0a46d535ae201364193ef58e07ec488
2021-03-10 19:02:38 -08:00
Hall Liu
3074ceab62 Merge "Add onBindClient for testing" am: 53252b14e5 am: 40a22b24b0 am: 8c022a831a
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1625243

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I2e05f57f4ec6b01082c0e1eac97a2a23ce677cbd
2021-03-10 21:02:07 +00:00
Hall Liu
53252b14e5 Merge "Add onBindClient for testing" 2021-03-10 19:24:43 +00:00
Hall Liu
eb7c9eaf16 Add onBindClient for testing
Add an overrideable method in ConnectionService that gets called when
telecom binds, since onBind is final and it's unsafe to make not-final.

Bug: 181057509
Test: atest CtsTelecomTestCases
Change-Id: I80088185402789fec499b8659ca8b74bcec05748
2021-03-09 20:29:40 -08:00
Tyler Gunn
4b033d7316 Merge "CallDiagnosticService API" am: c90335033b am: 9882ff4bf8 am: d3bf1aa209
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1607109

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie91efc29698d27946f83b751bef2fe89d612c9a2
2021-03-03 00:16:56 +00:00