Commit Graph

10440 Commits

Author SHA1 Message Date
TreeHugger Robot
049b12a9cc Merge "Process joystick MotionEvents correctly." 2017-10-13 21:01:39 +00:00
TreeHugger Robot
f32edc9f65 Merge "Replace mNotifyAutofillManagerOnClick by mPrivateFlag." 2017-10-13 18:31:52 +00:00
TreeHugger Robot
02a20b7025 Merge "Added new ViewNode properties for Autofill (minEms, maxEms, maxLength)." 2017-10-13 18:13:04 +00:00
Felipe Leme
f39c3c1395 Replace mNotifyAutofillManagerOnClick by mPrivateFlag.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Bug: 67006548

Change-Id: I2027e5d6d952b473c4d20b2aac15792d230ae43c
2017-10-13 09:37:24 -07:00
Siarhei Vishniakou
461faf9d0e Process joystick MotionEvents correctly.
Joystick MotionEvents, such as AXIS_HAT0Y and AXIS_HAT0X,
are translated into KeyEvents KEYCODE_DPAD_UP,
KEYCODE_DPAD_DOWN, etc for navigating menus. When two or more
AXIS_HAT0Y events are batched into a single event, this would
not be recognized by the SyntheticJoystickHandler as a down/up
event, thus missing the event entirely. This commit updates
SyntheticJoystickHandler to use the entire MotionEvent,
including the HistoricalEvent portions.

Bug: 36069459
Test: Connected Sony DS4 joystick, recorded the event
that reproduces the bug with inputstudio. Replayed the
event after patch, the bug could not be reproduced.

Change-Id: I7c15c3a7c9ac326481214b1f6b553ae39c459bc4
2017-10-12 21:09:22 -07:00
TreeHugger Robot
8ff1a4b14c Merge "Fix identation in the switch block." 2017-10-13 03:21:57 +00:00
TreeHugger Robot
f055302a73 Merge "Flags to enable/disable smart selection in EditText" 2017-10-13 00:33:44 +00:00
Abodunrinwa Toki
0e6b43ed58 Flags to enable/disable smart selection in EditText
1. smart_selection_enabled_for_edit_text
   Disables smart selection for editable text.
2. smart_selection_dark_launch
   Dark launch TextClassifierImpl.suggestSelection(...)
   In this mode we run the method, but never change the user's
   selection to measure the quality of the results based on what
   the user actually wanted.

Bug: 65959640
Test: Manually tested flags turn on/off feature with 'adb shell
settings put global' and GServices override.
Test: bit FrameworksCoreTests:android.provider.SettingsBackupTest
Change-Id: Iacc561c8ee004b0123de66ad1ee06b1f56b4e4b4
2017-10-12 23:50:53 +01:00
TreeHugger Robot
fac6655cf5 Merge "New Autofill API: SaveInfo.setTriggerId()" 2017-10-12 22:39:49 +00:00
Rob Carr
53966760d7 Merge "Use new SurfaceFlinger transaction API." 2017-10-12 22:08:03 +00:00
Siarhei Vishniakou
27358ef48d Fix identation in the switch block.
Currently, case and switch start at the same
ident level, which fails the presubmit hooks.

Test: make
Change-Id: I4e22fe0c633541c00cfda3ed27731f78490e8fae
2017-10-12 13:03:22 -07:00
Felipe Leme
a937238eae Let service set the SaveRequest.getClientState() on dataset auth responses.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testFillResponseAuthClientStateSetOnIntentOnly
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testFillResponseAuthClientStateSetOnFillResponseOnly
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testFillResponseAuthClientStateSetOnIntentAndFillResponse

Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testDatasetAuthClientStateSetOnIntentOnly
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testDatasetAuthClientStateSetOnFillResponseOnly
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testDatasetAuthClientStateSetOnIntentAndFillResponse

Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 67588471

Change-Id: I05a56bfc02400ce87077c93301abc0e0e1aa59a6
2017-10-12 12:03:42 -07:00
Felipe Leme
2fe3ade813 New Autofill API: SaveInfo.setTriggerId()
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.SimpleSaveActivityTest#testExplicitySaveButton
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.SimpleSaveActivityTest#testExplicitySaveButtonWhenAppClearFields
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Bug: 65118073
Fixes: 67006548

Change-Id: Id12179086567d014f35fe4177b041745fb19bafd
2017-10-12 09:55:45 -07:00
Phil Weaver
b19789f80a Merge "Don't recycle replaced nodes in a11y cache" into oc-mr1-dev am: 15c8747ad9
am: 73e2acb9ae

Change-Id: I906748223efd88d5d48889b2866725ba13c0268e
2017-10-12 02:30:42 +00:00
Phil Weaver
9704426d14 Don't recycle replaced nodes in a11y cache
This is a patch for another bug. When the cache refreshes
nodes, it marks the transaction to bypass the cache. We
still, however, replace the cached node. If we recycle
the node as well, we end up refreshing it after it's been
recycled and end up with a sealed node in the cache. That
node can then be obtained and then throw an exception when
a setter is called. These exceptions are almost impossible
to debug.

I'm going to leave the bug open to roll this CL back and
fix the cache's behavior, but this fix seems safer this
late.

Bug: 35626351
Test: Ran a11y CTS and unit tests. Verified on instrumented
master build that the error indeed goes away. Removing one
line from unit tests that requires recycling.

Change-Id: Icc9a43ee49cf7c6bfa996839b35954faaf31621c
2017-10-11 15:51:33 -07:00
TreeHugger Robot
f65d166959 Merge "Removed remaining use of static stack ids." 2017-10-11 21:27:05 +00:00
Wale Ogunwale
44f036fd5a Removed remaining use of static stack ids.
Replace by windowingMode and activityType.

Test: Existing tests pass.
Test: go/wm-smoke
Bug: 64146578
Change-Id: I2ff026de3ead1a3e7136df17c68ed37d7aae5495
2017-10-11 07:40:46 -07:00
Robert Carr
e13b58e15b Use new SurfaceFlinger transaction API.
For now we reimplement global transactions in the Java side
JNI layer.

Bug: 64815723
Bug: 64816140
Bug: 64815766
Test: Existing tests pass. go/wm-smoke
Change-Id: I6c0a7b5e65b1b6cc844ac61f3269629af60a4244
2017-10-09 16:52:48 -07:00
John Reck
949cfe1018 Deprecate view drawing cache
Test: Looked at docs

Change-Id: I95a487d126bd15a4085e777d58c60b6342ee64a8
2017-10-09 16:10:37 -07:00
Felipe Leme
aa7e2294be Added new ViewNode properties for Autofill (minEms, maxEms, maxLength).
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.LoginActivityTest#testNewTextAttributes
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 38323227

Change-Id: I6d8606f2d0668644ae1bd33e982edef0ec1e8e63
2017-10-06 15:55:19 -07:00
TreeHugger Robot
75f4b23500 Merge "An update on dirty rect invalidates" 2017-10-06 01:10:54 +00:00
John Reck
a53402084e An update on dirty rect invalidates
Bug: 67104277
Test: looked at docs
Change-Id: Ieb97c73bb8d63fddb232534e54091a73303e2258
2017-10-05 14:49:22 -07:00
TreeHugger Robot
d5ad2ff575 Merge "Clarify that getLocalState is always valid for DragEvent" 2017-10-05 19:03:54 +00:00
Evan Rosky
22113f0423 Merge "Enable new initial-focus behavior for P" 2017-10-05 00:29:16 +00:00
Felipe Leme
e541b65c03 Merge "Sets AutofillClient on attachBaseContext()" into oc-mr1-dev am: 6d17d9d0cf
am: 63b45a87d5

Change-Id: Ib7ae51cf0336c4cea8ff90d60995816d43b3fa36
2017-10-04 22:42:29 +00:00
Felipe Leme
bb567ae6c0 Sets AutofillClient on attachBaseContext()
When an activity overrides attachBaseContext(), the attached context must share
the same AutofillCient, otherwise it will break autofill in the activity.

Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.AttachedContextActivityTest
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 67350639

Change-Id: I6b0c4c2fab5fa68eb6ee0714e107ca0816efb2cb
2017-10-04 12:23:23 -07:00
Andrei Stingaceanu
6c591dd3c3 Merge "[Magnifier - 1] Initial implementation and wiring" 2017-10-04 09:38:53 +00:00
Felipe Leme
114a441554 Added ViewNode.getWebScheme().
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases
Test: cts-tradefed run commandAndExit cts-dev -m CtsAssistTestCases

Fixes: 65207762

Change-Id: Ia8f7b3f5fce8cf0cc783e861fd7e1f1f7f78db19
2017-10-03 14:54:49 -07:00
Andrei Stingaceanu
d2eadfa4b1 [Magnifier - 1] Initial implementation and wiring
* implementation of a magnifier which can be attached to any view
* important APIs:
** show(float centerXOnScreen, float centerYOnScreen, float scale)
** dismiss()
* smart offset => shows below if there is no space above
* controlled by boolean flag (easy to turn off)
* attached the magnifier to Editor's handles
* vertically snaps to the middle of the line containing the
  selection
* horizontally snaps to the offset of the character where
  the selection starts/ends

Bug: 66657373
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: manual test that shows the magnifier working
Change-Id: I1d4616b8bb1210d869ac47dca137ea9636355250
2017-10-03 16:45:54 +01:00
Jorim Jaggi
6c23b00b46 Merge "Fix crash when dumping empty LayoutParams" 2017-09-29 10:43:47 +00:00
Jan Althaus
3bf929524d Merge "Adding multiple action support to TextClassification" 2017-09-29 10:41:09 +00:00
Jorim Jaggi
2d3954f6f6 Fix crash when dumping empty LayoutParams
Test: WindowManager_LayoutParamsTest
Change-Id: Ie80181fbef354a6d4b6569c66a4e37d526e7ddd6
Fixes: 66953119
2017-09-28 16:56:46 +02:00
Jan Althaus
92d76838f8 Adding multiple action support to TextClassification
This introduces no user visible changes. All users of the TextClassifier
still just query the default action.

Bug: 320611
Test: Manually tested with a locally modified action mode that supports multiple actions.
Change-Id: I8e8714e04d70f4787ecf605bb7e27ef7d1af4d79
2017-09-28 15:39:41 +02:00
Wale Ogunwale
68278568de HOME_STACK_ID, ASSISTANT_STACK_ID, and RECENTS_STACK_ID be gone!
Replaced usages with ACTIVITY_TYPE_HOME, ACTIVITY_TYPE_ASSISTANT
and ACTIVITY_TYPE_RECENTS.

Test: go/wm-smoke
Test: Existing tests pass.
Bug: 64146578
Change-Id: I62c55c99df86dba8c9ba9d9986049de1b1083234
2017-09-27 21:08:10 -07:00
Phil Weaver
d17e402a7e Merge "Add null check in a11y callback" into oc-mr1-dev am: 4dfeb4f0e4
am: 0e8e7830fc

Change-Id: I88c8d335a4b91072d5e9bfcc4c2a7b21ec46565b
2017-09-26 19:38:44 +00:00
Phil Weaver
4dfeb4f0e4 Merge "Add null check in a11y callback" into oc-mr1-dev 2017-09-26 19:22:51 +00:00
Svet Ganov
c2840f9f9f Merge "Hide autofill popup if anchor removed" into oc-mr1-dev am: 8e5e30c5eb
am: 89934be670

Change-Id: Idc925398f0b28ffe7220634cd9b74fba22de7278
2017-09-25 22:41:17 +00:00
TreeHugger Robot
8e5e30c5eb Merge "Hide autofill popup if anchor removed" into oc-mr1-dev 2017-09-25 22:24:25 +00:00
Jan Althaus
f5405080bf Merge "Fixed bug in handling of OTHER as terminal" into oc-mr1-dev am: e95197a664
am: 35d91afa74

Change-Id: I7d6f531823244508d53497f0a28ba610b80c0569
2017-09-25 15:46:30 +00:00
Jorim Jaggi
7ace43b538 Merge "Improve window manager layout attribute dumping" 2017-09-25 15:11:30 +00:00
Jorim Jaggi
484851b914 Improve window manager layout attribute dumping
Test: adb shell dumpsys window
Change-Id: I9c76e6a6950265b49667cc19998282ef0c682815
2017-09-25 13:31:04 +02:00
Jan Althaus
34aa294b96 Fixed bug in handling of OTHER as terminal
This bug resulted in a tap on a non-default action mode item to get logged
as OTHER, followed by ABANDON.

Bug: 64914512
Test: Manually tested that logs are correct.
Change-Id: I3cdba7ccff896939e22c567843f335c54d4a97f3
2017-09-25 09:56:21 +02:00
Svet Ganov
77150c5fbb Hide autofill popup if anchor removed
Test: Manual
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

bug:64601372

Change-Id: Ic55dabb99cd5015d318ab3be1231b6aa5c67294e
2017-09-23 10:13:06 -07:00
Chavi Weingarten
7f5265ebfc Merge "Added jni and SurfaceControl methods for native setColor" 2017-09-22 20:33:46 +00:00
Phil Weaver
05a2982f0c Add null check in a11y callback
Bug: 65475473
Test: Verified it still builds
Change-Id: I9ad1249c44cb73153066f67164c90333779d284e
2017-09-22 20:09:14 +00:00
Felipe Leme
f04ea961a0 Merge "Remove finished sessions on ACTION_CLOSE_SYSTEM_DIALOGS." into oc-mr1-dev am: 56e5c3944b
am: 64a6188032

Change-Id: I568c3a67d43b0a1eb1af4350f523ba291c5ea9f2
2017-09-21 17:14:41 +00:00
Karthik Ravi Shankar
896564bef1 Merge "Fix window visibility during layout" into oc-mr1-dev am: 7a59a62276
am: 11f25ba1a0

Change-Id: I3620a51554e6e8101d5a013f9287339bb1031806
2017-09-21 01:38:23 +00:00
TreeHugger Robot
e551ca7751 Merge "Changed reparentChild method name to reparent." 2017-09-21 01:04:06 +00:00
Felipe Leme
650f7abc3f Remove finished sessions on ACTION_CLOSE_SYSTEM_DIALOGS.
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.SimpleSaveActivityTest#testTapHomeWhileSaveUiIsShowing
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases -t android.autofillservice.cts.SimpleSaveActivityTest#testTapHomeWhileDatasetPickerUiIsShowing
Test: cts-tradefed run commandAndExit cts-dev -m CtsAutoFillServiceTestCases

Fixes: 65414762

Change-Id: I7dc9fd8f40341164e0ca320ff49b99cf8614fdbf
2017-09-20 17:19:29 -07:00
chaviw
7643140c7c Changed reparentChild method name to reparent.
The native reparentChild was changed to reparent to represent that the
current layer is getting re-parented. Updated the jni and Java code to
reflect that.

Test: Device boots

Change-Id: I390d2efba61c626f2162f75f650700d53ab178a5
2017-09-20 17:35:43 +02:00