Commit Graph

2138 Commits

Author SHA1 Message Date
Gilles Debunne
2bfc75a6d9 Merge "Bug 5255124: Move cursor to the end of a word after correction popup alternates selection" 2011-09-09 16:01:08 -07:00
Gilles Debunne
4f2b0dc552 Merge "Bug 5278456: text highlight color depends on the type of suggestion spans." 2011-09-09 15:52:09 -07:00
Gilles Debunne
1a87ba4636 Bug 5255124: Move cursor to the end of a word after correction popup alternates selection
Change-Id: Idd3edc72edf864f256df173bcf643163192ecbde
2011-09-09 15:02:10 -07:00
Svetoslav Ganov
99e109915e Merge "The time and data pickers did not support IME editor action correctly." 2011-09-09 11:24:24 -07:00
Svetoslav Ganov
5b60d38a8a Merge "Update the sharing UI according to latest UX specs." 2011-09-09 11:18:40 -07:00
Michael Jurka
6c0d41a4ea Merge "Fix FrameLayout padding when foreground drawable is set" 2011-09-08 20:56:35 -07:00
Michael Jurka
02473da2b0 Fix FrameLayout padding when foreground drawable is set
The padding of the foreground drawable was being added to the padding that already existed, even if the foreground drawable was drawing within the padded region. This was preventing having a foreground drawable and a background drawable set on a FrameLayout that overlapped perfectly.

Change-Id: I355ff9323fb49afc5816f47ec9e257e0ff849861
2011-09-08 20:39:16 -07:00
Svetoslav Ganov
a53efe9923 The time and data pickers did not support IME editor action correctly.
1. Updated TextView to traverse all focusable items. It was searching focus
   down and up and was missing right and left focusabled. Updated the focus
   seach to use FOCUS_FORWARD and FOCUS_BACKWARD - now all focusable views
   are visited.

2. TimePicker and DatePicker were not specifying the IME options for
   the next and done editor actions.

bug:5264046

Change-Id: Ief80863fc312582f2f76928bf6e915f620c427e5
2011-09-08 20:19:48 -07:00
Gilles Debunne
fa4e2d994b Bug 5278456: text highlight color depends on the type of suggestion spans.
Change-Id: I76ac02b7688a297c0e83d593f446a4cf2ee36015
2011-09-08 18:35:54 -07:00
Fabrice Di Meglio
2295cc77c7 Merge "Fix bug #2246815 Error popups on EditText should span the width of the screen instead of the width of the EditText field" 2011-09-08 18:27:29 -07:00
Svetoslav Ganov
f2e7540021 Update the sharing UI according to latest UX specs.
bug:3362473

Change-Id: Ic302c289e28061f53446f98e5b97573d57d9cfb8
2011-09-08 18:19:13 -07:00
Fabrice Di Meglio
e4231461f4 Fix bug #2246815 Error popups on EditText should span the width of the screen instead of the width of the EditText field
Part 2

- use "textview_error_popup_default_width" as a dimension resource instead of a basic constant

Change-Id: Ieb89fc416105716ab491749a82390a7e784b1755
2011-09-08 18:15:50 -07:00
Fabrice Di Meglio
0669577b13 Merge "Fix bug #2246815 Error popups on EditText should span the width of the screen instead of the width of the EditText field" 2011-09-08 17:35:01 -07:00
Fabrice Di Meglio
33438be008 Fix bug #2246815 Error popups on EditText should span the width of the screen instead of the width of the EditText field
- cap the popup to 240 (Validated with UX team)

Change-Id: I2923825a19b7c79fa0d1233300f42e10bdda8df7
2011-09-08 17:19:04 -07:00
Gilles Debunne
15208ac500 Merge "No vibration when long pressing in the empty part of an EditText" 2011-09-08 11:18:53 -07:00
Gilles Debunne
df1324c3cf Merge "Longpressing in landscape correctly starts selection mode." 2011-09-08 11:18:36 -07:00
Gilles Debunne
0c4f8ec6d3 Merge "Updated text selection color. As in 133272" 2011-09-08 11:18:23 -07:00
Steve Block
703bde8ca5 Merge "Add FrameLayout.getMeasureAllChildren()" 2011-09-08 10:38:15 -07:00
satok
76866208f8 Merge "Send onViewClicked in the extract mode" 2011-09-07 19:50:54 -07:00
satok
a67a3cfc7c Send onViewClicked in the extract mode
Bug: 5257838
Change-Id: I16547aab86812f2db45deb879ad887dc38968164
2011-09-08 11:46:35 +09:00
Svetoslav Ganov
aacbf9111b Merge "Not visible view should not be announced or interacted with." 2011-09-07 18:24:25 -07:00
Svetoslav Ganov
0b0a41d8e2 Not visible view should not be announced or interacted with.
1. Some invisible views' text was reported by accessibility events.

2. Accessibility actions could have been perfromed on invisible views.

bug:5264355

Change-Id: I68184fb436a3e10e947ec6f1eae02aa3d0d1cb7f
2011-09-07 18:06:06 -07:00
Gilles Debunne
e28454a237 No vibration when long pressing in the empty part of an EditText
Bug 5272224. Vibration should be limited to the start of an action mode,
which is not the case here.

Change-Id: I0f2263edb24e73f10297d27e109bb37c46fe96bc
2011-09-07 18:03:46 -07:00
Gilles Debunne
98fb9ed4c1 Longpressing in landscape correctly starts selection mode.
Two issues here:
1. selection mode was stopped when extracted mode started,
thus loosing the selection.
2. starting selection mode shows a transient action bar which
is then hidden when extracted mode starts. Detect this case
and do not start selection mode, which will start in extracted
mode. This also solves 1.

Change-Id: I61d6e8d2071e9d3b1a136915b685962bbc093bd0
2011-09-07 17:15:41 -07:00
Fabrice Di Meglio
4147abcd84 Merge "Fix bug #5252977 TextView selection handles appearing in a weird state" 2011-09-07 14:54:55 -07:00
Winson Chung
9a355fbb0d Merge "Updating javadoc for StackView constructors (4554433)" 2011-09-06 19:41:46 -07:00
Fabrice Di Meglio
03e4d64587 Fix bug #5252977 TextView selection handles appearing in a weird state
- a remove of a listener was missing as dismis() and hide() need to
share the same semantics

Change-Id: I01dc5a971324d0aa0942e365d5302d93a1a51a16
2011-09-06 19:08:51 -07:00
Winson Chung
abc8b50a26 Updating javadoc for StackView constructors (4554433)
Change-Id: I084c9535f9be4ae4e3942828d3b624d28eae4b06
2011-09-06 18:44:21 -07:00
Gilles Debunne
0046199dab Merge "Fix "out of bound exception" when the span has prefix." 2011-09-06 17:51:10 -07:00
Gilles Debunne
d486bd2789 Merge "Fix several issues with the "EasyEditSpan"." 2011-09-06 17:42:31 -07:00
Luca Zanolin
1564fc7c7e Fix several issues with the "EasyEditSpan".
- The easy edit span was displayed twice when in extracted mode. The orignal TextView now checks if it is in extra mode, and if so it does not display any pop-up
- The easy edit span was displayed before the view was layout causing the application to crash.

New feature:

- the span is automatically hidden after a timeout

I also renamed all the fields and classes to "EasyEdit...". There were still some field/class using an old name.

Bug: 5255363
Bug: 5247453
Bug: 5246997

Change-Id: Ic9bf05d2525e2df9017c91344a687e8cb9105417
2011-09-07 00:01:28 +01:00
Gilles Debunne
6fbe5ca643 Updated text selection color. As in 133272
b/5217848

Change-Id: I628c65af941d575a402a38f45bc923ebb4256c56
2011-09-06 15:35:56 -07:00
Fabrice Di Meglio
c6fc20a91b Merge "Fix bug #5262565 Need to remove CharCount TextDirectionHeuristics" 2011-09-06 15:12:25 -07:00
Luca Zanolin
2346e0117d Fix "out of bound exception" when the span has prefix.
Change the behavior of the highlight marking the "suggested text" and not the differences.

Bug: 5252699
Change-Id: I4c7e9fc9bac81da8b5f643990b86a336363d7968
2011-09-06 22:56:59 +01:00
Svetoslav Ganov
6436876156 Merge "AbsListView does not populate accessibility events correctly." 2011-09-06 12:52:06 -07:00
Fabrice Di Meglio
e3bf88da23 Fix bug #5262565 Need to remove CharCount TextDirectionHeuristics
- update unit tests too

Change-Id: I7c518f58a9f17cb679bc3913bdd38243f7ad2195
2011-09-06 11:08:45 -07:00
Svetoslav Ganov
aa56534722 AbsListView does not populate accessibility events correctly.
The toIndex of accessibility events fired from a AbsListView
is exclusive but should be inclusive i.e. it was reported one
more that it has to be.

bug:5256286

Change-Id: I496959fdfb6760b0c74899730c4cc558e89234a6
2011-09-05 16:41:51 -07:00
Fabrice Di Meglio
34d2eba560 Fix bug #5243493 TextView selection is not working correctly when there is some RTL run into it
Part 2

- make selection handles aware of the run direction

Change-Id: Idf41036de53d8968e7ae27eb87aea09e86bcd652
2011-09-02 18:03:21 -07:00
Adam Powell
a59e3146b7 Merge "Fix bug 5201420 - Appease the monkeys" 2011-09-02 17:01:28 -07:00
Adam Powell
e1bf486846 Fix bug 5201420 - Appease the monkeys
Make ListView.onFocusChanged more tolerant of missing adapters.

Change-Id: Icae1cfd02fe369d3fd0e3c6531adb973f44f3036
2011-09-02 16:56:57 -07:00
Adam Powell
a1b92c5e8b Fix bug 5231904 - Fix wobbly progress spinners
Make ProgressBar maintain aspect ratio on indeterminate progress drawables.

Make RotateDrawable tolerate left/top bounds != 0.

Change-Id: Iee03030caa98f72a8745f1ae3fb0de108ff663d4
2011-09-02 16:37:41 -07:00
Gilles Debunne
572527f2c3 Merge "Remove the suggestion underline when the TextView loses focus." 2011-09-02 13:54:48 -07:00
Gilles Debunne
a41bc33855 Merge "Popup windows positions are updated when a TextView is scrolled" 2011-09-02 13:24:20 -07:00
Gilles Debunne
f3d78eac0f Merge "Added an add to dictionary option in suggestions for misspelled words" 2011-09-02 13:19:24 -07:00
Gilles Debunne
26b5cf40b1 Merge "Fixes around text selection" 2011-09-02 13:17:44 -07:00
Gilles Debunne
1737fcd689 Merge "Fix for NPE in Switch" 2011-09-02 13:17:13 -07:00
Luca Zanolin
fe5e9834a3 Remove the suggestion underline when the TextView loses focus.
Only the easy correction (i.e., voice ime corrections) will lose the underline, while the misspelled span will not.

Change-Id: If96c17473dd70c99b808739ddde800cc93551e2a
2011-09-02 19:41:42 +01:00
Gilles Debunne
70a6312f09 Fixes around text selection
Text selection mode was started by two consecutive taps inside a
field with selectAllOnFocus.

ArrowKeyMovementMethod does not respect the possible cancelLongPress and handles up events.
As a result a scroll that happens to end up at its initial position will be considered a tap
and will move the cursor.
This is however not considered as a tap in TextView and a possible selection mode would not
be stopped in that case.
Fixed by making ArrowKeyMovementMethod aware of the cancel that happened in Touch.

Change-Id: I07372b703f250e1edc7ee0665318ce30441b9187
2011-09-02 11:26:46 -07:00
Gilles Debunne
e90bed18cc Added an add to dictionary option in suggestions for misspelled words
Change-Id: I031f17a76b4a81ae375b778046b8c391f9b8b2b2
2011-09-02 09:04:26 -07:00
Svetoslav Ganov
17b0317e8d Merge "Accessibility events fired from AdapterView underpopulated." 2011-09-01 18:39:29 -07:00