Commit Graph

1406 Commits

Author SHA1 Message Date
Tomasz Mikolajewski
8b832fc6fc Merge "Reduce memory allocations and improve sorting in DocumentsUI by 8.42%." into nyc-dev
am: cc63de4

* commit 'cc63de4ff7ad1b52d78b3a82929f11767b879790':
  Reduce memory allocations and improve sorting in DocumentsUI by 8.42%.
2016-03-18 02:30:56 +00:00
Tomasz Mikolajewski
007151a90d Reduce memory allocations and improve sorting in DocumentsUI by 8.42%.
Reland after a revert. No changes.

Bug: 27286016
Change-Id: I0988062106faf4086c44d9b344649ef2cb86d3e7
2016-03-18 02:15:10 +00:00
Tomasz Mikolajewski
20b50785b6 Merge "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%." into nyc-dev
am: 4683d4c

* commit '4683d4c91441f060432a71f2a2f10add546cf204':
  Precompute cursor indexes in DocumentsUI and improve perf by 2.7%.
2016-03-18 01:52:14 +00:00
Tomasz Mikolajewski
4683d4c914 Merge "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%." into nyc-dev 2016-03-18 01:48:16 +00:00
Aga Wronska
59623a82c2 Merge "Add config flag to hide home directory ("Documents") from the roots list. Make home root hidden by default." into nyc-dev
am: 836ed4a

* commit '836ed4a582691a4c42709645b2636d35efcd4de9':
  Add config flag to hide home directory ("Documents") from the roots list. Make home root hidden by default.
2016-03-18 01:00:48 +00:00
Aga Wronska
836ed4a582 Merge "Add config flag to hide home directory ("Documents") from the roots list. Make home root hidden by default." into nyc-dev 2016-03-18 00:54:16 +00:00
Tomasz Mikolajewski
2e4e14789e Precompute cursor indexes in DocumentsUI and improve perf by 2.7%.
Relands after a revert, with a tiny fix.

Bug: 27286016
Change-Id: Ifb6cea46a86e8158b05db5dbf87878892c6cc702
2016-03-18 09:48:24 +09:00
Aga Wronska
5d267472e5 Merge "Generate more descriptive delete confirmation message." into nyc-dev
am: d35446a

* commit 'd35446ab0195e5907bd4a1ea4fbb006029569196':
  Generate more descriptive delete confirmation message.
2016-03-17 23:55:35 +00:00
Aga Wronska
824ac17ae3 Generate more descriptive delete confirmation message.
Change-Id: I194ef353aec9d2841b5f3fc8dfd76df6286ce969
Fixed: 27489240
2016-03-17 16:44:10 -07:00
Aga Wronska
b4129d785c Add config flag to hide home directory ("Documents") from the roots list.
Make home root hidden by default.

Change-Id: Ia9f97f3cad7ab102d65e01d6e0dd9bc39ab72f21
Fixed: 27683725
2016-03-17 11:57:29 -07:00
Tomasz Mikolajewski
056ac7131d Merge "Add a performance test for launching DocumentsUI." into nyc-dev
am: f9845b4

* commit 'f9845b4ecff6d1829a787eb61e44022c79b16beb':
  Add a performance test for launching DocumentsUI.
2016-03-17 17:35:38 +00:00
Tomasz Mikolajewski
83fb2a9525 Update comment for compareToIgnoreCaseNullable().
am: 5cd060a

* commit '5cd060a931c85a2e3351f6943e8d30ba553d0b25':
  Update comment for compareToIgnoreCaseNullable().
2016-03-17 17:35:35 +00:00
Ben Kwa
77a44bdbf0 Merge "DocsUI: Don\'t animate selection changes on all bind events." into nyc-dev
am: 7705999

* commit '7705999afd7d4b9d837deb41b89cad4ed0d84b3a':
  DocsUI: Don't animate selection changes on all bind events.
2016-03-17 17:35:19 +00:00
Ben Kwa
c1e808c374 Merge "Add delete key support." into nyc-dev
am: db1f58a

* commit 'db1f58a0a544732025b99c2f3ca03f3f1d995e95':
  Add delete key support.
2016-03-17 17:35:16 +00:00
Ben Kwa
3f53fc7862 Merge "DocsUI: Don\'t crash on invalid window sizes." into nyc-dev
am: e0413ed

* commit 'e0413ed38a385a9a632926f6c11980ef44fb2e8b':
  DocsUI: Don't crash on invalid window sizes.
2016-03-17 17:35:14 +00:00
Aga Wronska
f49ea1be73 Merge "Revert "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%." It ia causing tests failures and exception at the app start." into nyc-dev
am: 5ecade7

* commit '5ecade7512bfcb138a9a9363ae11122df4ea9044':
  Revert "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%." It ia causing tests failures and exception at the app start.
2016-03-17 17:35:06 +00:00
Tomasz Mikolajewski
f9845b4ecf Merge "Add a performance test for launching DocumentsUI." into nyc-dev 2016-03-17 08:11:53 +00:00
Tomasz Mikolajewski
5cd060a931 Update comment for compareToIgnoreCaseNullable().
Bug: 27286016
Change-Id: I0ff4d59e24e8afe129aa8a2921d3de71d3df7236
2016-03-17 06:20:12 +00:00
Tomasz Mikolajewski
e46d7f93ad Add a performance test for launching DocumentsUI.
The test launches the DocumentsUI as picker, then waits until the
main thread idles, which guarantees that roots are loaded and UI
rendered.

It confirms, that the recent system cache improves cold start
performance by around 24% on my configuration (from 1685ms to 1357ms).

Bug: 27370274
Change-Id: I738202ea434a7bfe7080fc0994f636ef0e7847cd
2016-03-17 15:12:17 +09:00
Ben Kwa
7705999afd Merge "DocsUI: Don't animate selection changes on all bind events." into nyc-dev 2016-03-16 23:26:52 +00:00
Ben Kwa
db1f58a0a5 Merge "Add delete key support." into nyc-dev 2016-03-16 23:24:44 +00:00
Ben Kwa
e0413ed38a Merge "DocsUI: Don't crash on invalid window sizes." into nyc-dev 2016-03-16 22:52:35 +00:00
Ben Kwa
1a63c613ea DocsUI: Don't crash on invalid window sizes.
Our layout code asserts when passed an (invalid) width of 0.  The assert
is unnecessary as we already handle this situation by always laying out
the content pane with a column count of at least 1.

Also, per Steve, bump the minimum column count in grid mode to 2.

BUG=27150284

Change-Id: I8aa87beaaf4907ef5248999d0c590deef732589f
2016-03-16 15:50:58 -07:00
Aga Wronska
5ecade7512 Merge "Revert "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%." It ia causing tests failures and exception at the app start." into nyc-dev 2016-03-16 20:54:42 +00:00
Ben Kwa
eb61aac503 Add delete key support.
- Pull the action mode up from the ActionMode listener into the
  DirectoryFragment.  There is no way to globally check on action mode,
  so fragment-level coordination on the action mode requires a
  fragment-level variable.

- Add a key handling clause for the delete key.  Unfortunately this
  can't be set up as a shortcut key, because shortcuts all have to be
  modified with the "Ctrl" key.

BUG=27409328

Change-Id: I48d1c87613ee7434728828e3b745fadb3bc915c1
2016-03-16 13:53:07 -07:00
Aga Wronska
f3244e870e Revert "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%."
It ia causing tests failures and exception at the app start.

This reverts commit d35a974b76.

Change-Id: I2577f723a7e25d4dcc12050791c65a900ac41f7d
2016-03-16 13:49:58 -07:00
Ben Kwa
2c0af78388 Merge "Add support for dpads." into nyc-dev
am: 7f24543

* commit '7f245435c5e5e1a30d3b9a24400daec659e6c58e':
  Add support for dpads.
2016-03-16 20:25:47 +00:00
Ben Kwa
7f245435c5 Merge "Add support for dpads." into nyc-dev 2016-03-16 20:24:09 +00:00
Ben Kwa
6f2ae39283 Merge "Fix band selection problems." into nyc-dev
am: 415c062

* commit '415c0627b3127c15fcbe5435fbbf6626064dd6a5':
  Fix band selection problems.
2016-03-16 20:12:15 +00:00
Steve McKay
23096f337d Merge "Don\'t allow selection in copy dest picker." into nyc-dev
am: 08e5936

* commit '08e5936485a830ee80c4bf42a8402e1d13a783f9':
  Don't allow selection in copy dest picker.
2016-03-16 20:12:14 +00:00
Ben Kwa
415c0627b3 Merge "Fix band selection problems." into nyc-dev 2016-03-16 20:06:14 +00:00
Steve McKay
08e5936485 Merge "Don't allow selection in copy dest picker." into nyc-dev 2016-03-16 20:05:48 +00:00
Ben Kwa
a3c09b4b9b DocsUI: Don't animate selection changes on all bind events.
When directory contents update, this causes all items to be bound, which
can cause flickering even though item selection state hasn't changed.

Add a boolean var to trigger UI animations only when selection changes
are triggered by the selection manager.

BUG=27680153

Change-Id: I892d8111cf3ba7e1610d94af4a1a646f1cdb5546
2016-03-16 12:13:21 -07:00
Steve McKay
88edde4d33 Don't allow selection in copy dest picker.
Bug: 27490262
Change-Id: I1938a900cfd3693739c2ac10b5eea3176a4ca82c
2016-03-16 12:01:52 -07:00
Ben Kwa
c29fd8d149 Fix band selection problems.
BUG=27364174
BUG=27645942

Change-Id: Ib14680db708f1ddf1f5dc9dff8b93b655fa3f123
2016-03-16 11:02:48 -07:00
Felipe Leme
c4b20a4e65 Merge "Polished Scoped Directory Access UI." into nyc-dev
am: 8a2d1d9

* commit '8a2d1d9c3dec5d7dc16d46ca2b453c9bfa957ec1':
  Polished Scoped Directory Access UI.
2016-03-16 16:46:24 +00:00
Felipe Leme
8a2d1d9c3d Merge "Polished Scoped Directory Access UI." into nyc-dev 2016-03-16 16:22:20 +00:00
Geoff Mendal
9158196c78 Merge "Import translations. DO NOT MERGE" into nyc-dev 2016-03-16 14:21:48 +00:00
Geoff Mendal
e8ec8bd1f4 Import translations. DO NOT MERGE
Change-Id: I33545a8fee9b65fa3e11fdb86c1b6c9d2bcdc7ec
Auto-generated-cl: translation import
2016-03-16 07:14:47 -07:00
Tomasz Mikolajewski
d88d16a0cd Merge "Reduce memory allocations and improve sorting in DocumentsUI by 8.42%." into nyc-dev
am: e542b16

* commit 'e542b162e9853a79f28efe6d00402159bf14fe84':
  Reduce memory allocations and improve sorting in DocumentsUI by 8.42%.
2016-03-16 12:59:58 +00:00
Tomasz Mikolajewski
49ca224623 Reduce memory allocations and improve sorting in DocumentsUI by 8.42%.
Bug: 27286016
Change-Id: Icc84aaaedd396d82f4ca7de63a682deebe1e1b93
2016-03-16 09:59:55 +00:00
Tomasz Mikolajewski
50ce9082cf Merge "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%." into nyc-dev
am: 54f264f

* commit '54f264fcdb74f585d43a77159b28a11d2e77bf88':
  Precompute cursor indexes in DocumentsUI and improve perf by 2.7%.
2016-03-16 09:30:42 +00:00
Tomasz Mikolajewski
54f264fcdb Merge "Precompute cursor indexes in DocumentsUI and improve perf by 2.7%." into nyc-dev 2016-03-16 09:25:29 +00:00
Tomasz Mikolajewski
d35a974b76 Precompute cursor indexes in DocumentsUI and improve perf by 2.7%.
Bug: 27286016
Change-Id: I0ad852faef46ba9eccc90ca32d8c2ea0e2d5cd98
2016-03-16 16:40:09 +09:00
Daichi Hirono
eb84681f56 Merge "Move to downloads root instead of home root." into nyc-dev
am: 5551228

* commit '5551228717c0abe1beb262ca708070ede6c7a368':
  Move to downloads root instead of home root.
2016-03-16 04:25:25 +00:00
Daichi Hirono
5551228717 Merge "Move to downloads root instead of home root." into nyc-dev 2016-03-16 04:21:06 +00:00
Steve McKay
5abf7de9bd Merge "Add FLAG_PARTIAL. Partial files can\'t be copied." into nyc-dev
am: 709be25f04

* commit '709be25f04fd390b220eec1c0f5578df3be2b17e':
  Add FLAG_PARTIAL. Partial files can't be copied.
2016-03-16 01:41:13 +00:00
Felipe Leme
493611f541 Polished Scoped Directory Access UI.
- Set proper style on custom alert dialog view.
- Fixed padding.
- Removed redundant style.
- Fixed checkbox color.

BUG: 26750152

Change-Id: Ibf3984e1b0a092affc58f1377b89b6ab7ea2a3aa
2016-03-15 16:56:15 -07:00
Steve McKay
168e464812 Add FLAG_PARTIAL. Partial files can't be copied.
This allows us to exclude in-progress downloads from copy.
Will update Downloads in a followup CL to flag active downloads.

Bug: 27526321
Change-Id: I50d1db5cfb69bc6b47e10cc0f520a51e3d3cb43e
2016-03-15 16:51:23 -07:00
Felipe Leme
1206353534 Merge "Add a "Do not ask again" checkbox." into nyc-dev
am: a651601771

* commit 'a651601771b8a5b227e075353c240dc059f71eaa':
  Add a "Do not ask again" checkbox.
2016-03-15 18:51:31 +00:00