Commit Graph

11 Commits

Author SHA1 Message Date
Steve Block
856f2859e8 Fix some bugs in DumpRenderTree2 when forming HTML diffs
Change-Id: Id98c1b7dde1961c2dab4214a36ad43916baf8011
2010-09-29 18:51:42 +01:00
Steve Block
fd487ad1b8 Use the empty string when expected text results are missing in DumpRenderTree2
Change-Id: I204583ecc9c6a8017349124d5813c693c7f00dc9
2010-09-29 18:51:42 +01:00
Steve Block
c0f90a8f93 Trim empty lines when comparing text results in DumpRenderTree2
Change-Id: I94c9de8e6131f6b60456700e9d5a3b27c8c9d1c3
2010-09-29 18:51:41 +01:00
Maksymilian Osowski
394e0fb849 Updated Summarizer to use SQLite DB.
It avoids OOM issues by dumping the memory to the DB every
few hundred tests and then reading them in chunks when
generating summaries, etc.

Change-Id: I5f63d960d456f17e9f2189230a7ae0ca5607ce51
2010-09-17 16:35:46 +01:00
Steve Block
8a6def0247 Update DumpRenderTree2 to handle failing tests where no meaningful diff is available
Currently, DumpRenderTree2 asigns the following result codes
{PASS, FAIL_RESULT_DIFFERS, FAIL_NO_EXPECTED_RESULT, FAIL_TIMED_OUT,
FAIL_CRASHED}

This is not strictly correct, as a test may fail for any of three
reasons - crashing, timing out, or the the result not being as
expected. Therefore, it's possible for a test to fail even if the
result is as expected.

This patch updates AbstractResult to handle each of the three reasons
for failure separately. We then test all three to determine if the
test has passed.

This allows us to correctly report whether or not the result differs
from expected for a failing test.

Change-Id: I7adcfe72c4dd0bd3de2e1b868d9807be6eb5bddf
2010-09-17 13:21:22 +01:00
Maksymilian Osowski
01c1f9d9e9 The results now show which expected result was used.
Bug: 2889857
Change-Id: If2b7e6e6a22ddb5db6c6a50a358e8f263914e6c0
2010-09-02 17:18:48 +01:00
Maksymilian Osowski
dd4bff62b5 First batch of layoutTestController functions + some fixes and tweaks.
Change-Id: I9dae192c498d8e19fd75861a1a6cf1f079ad9c6f
2010-08-03 15:22:34 +01:00
Maksymilian Osowski
6d0dae6a65 Upgraded DRT2 to generate nice HTML summaries of the tests.
Change-Id: Ibe4ee3af30fe20aeab2f3fed9c4c5693c9a0f268
2010-07-29 17:17:36 +01:00
Maksymilian Osowski
5f0ccd76a8 Moved practically all of the prerefactoring functionality to the new design.
Renamed LayoutTestsRunner activity to TestsListActivity. It will be responsible for restrating the Executer after the crash. Now it only starts
it.
Renamed LayoutTestsRunnerThread to TestsListPreloaderThread. It only preloads tests now.
LayoutTest class is no longer needed, its functionality is in LayoutTestsExecuter.
Most of the functionality from LayoutTestsRunnerThread is now in ManagerService.

Change-Id: I08924d949ceb9f8816888bc8e795256d0542fa99
2010-07-27 16:15:35 +01:00
Maksymilian Osowski
7ddc0b7a72 First stage of refactoring the code to handle crashes gracefully.
There is a new activity (LayoutTestsExecuter) added that is responsible for acutally running the tests and sending the actual results to the new
ManagerService class. This class will take over most of the functionality of the current LayoutTestsRunnerThread. At the moment
LayoutTestsRunnerThread is changed so that after computing the tests' list it sends the list to LayoutTestsExecuter. The rest of the code is
never called. It will be shifted to the service.

Current implementation of ManagerService only prints the log message on receiving the bundle with actual results from LayoutTestsExecuter.

Change-Id: I5adcbc20bb18ebf24324974bc66e4b31c4b81902
2010-07-26 10:37:41 +01:00
Maksymilian Osowski
4ee7f4b194 LayoutTest class with supporting classes (AbstractResult, TextResult).
These classes are responsible for actually running the tests, checking the results, generating visual diffs, etc.

Change-Id: I9b7f554409db1c97ac086c456db3aea3b993b5c6
2010-07-21 15:20:47 +01:00