Commit Graph

2454 Commits

Author SHA1 Message Date
Fabian Kozynski
6936cd12d2 Redlines adjustments
A bunch of redline fixes in management screens. Some of them hacks.

Also, make sure that visibility update is posted in correct thread.

Test: manual
Fixes: 155302803
Change-Id: I5c31904e2a70c2be224acf5d5aeb76f876cef695
2020-04-30 12:14:03 -04:00
TreeHugger Robot
d3b000cafe Merge "Move ImeAwareTextEdit from Settings to android.widget" into rvc-dev 2020-04-29 05:17:30 +00:00
Kevin Chyn
412bd81933 Move ImeAwareTextEdit from Settings to android.widget
Also use it for AuthCredentialPasswordView

Bug: 154161590

Test: BiometricPromptDemo, authenticate with password
Change-Id: I17601848dd9be3d0580988e3ff613c3793dfed51
2020-04-28 18:06:25 -07:00
Matt Pietal
94316e9058 Controls Ui - Handle error scenarios
1. Handle errors on action responses
2. Handle errors on control state load
3. Handle retries for PIN prompts

Bug: 150931809
Test: mock app
Change-Id: Ibfb6fc6eb2f94c31d4438bdeb5709800b8256463
2020-04-28 11:56:34 -04:00
Miranda Kephart
65225acf1e Merge "Fix screenshot UI entrance animation" into rvc-dev 2020-04-28 14:34:51 +00:00
Julia Reynolds
8582df5cc7 Add experience for shortcut-less convos
- no conversation specific controls
- no 'bubble this' button
- turn off interim placeholder channels
- fix msg tracking - only shortcut-less notifs matter

Test: atest
Bug: 154814754
Change-Id: Ia04ce496d4e7b2f353c71865f338b5229192c395
2020-04-28 12:11:47 +00:00
TreeHugger Robot
c0941a1016 Merge "Show "Device" for remote playback device." into rvc-dev 2020-04-28 04:38:29 +00:00
Robert Snoeberger
c981dc94ef Show "Device" for remote playback device.
Since we currently don't have access to the name of a remote device,
show a default string "Device" for the device name. In addition,
disable tap on the output switcher.

Fixes: 151486245
Test: manual - cast GPM to home mini and check output switcher in player
for correct icon and string. Additionally, check that tap is disabled.

Change-Id: I31d81f00f0b506b1e2ddc3158043e93cc6db35a8
2020-04-27 22:46:29 -04:00
TreeHugger Robot
cf2562437b Merge "Fix "unlabeled" power menu overflow button." into rvc-dev 2020-04-27 22:10:43 +00:00
Aran Ink
10cdb4b475 Fix "unlabeled" power menu overflow button.
Test: Manual -- power menu overflow button reads 'menu' with talkback on instead of 'unlabeled'.
Fixes: 154537338
Change-Id: I6badcaa1f93d3aeef38d46fcf56e4683863e1b42
2020-04-27 16:22:19 -04:00
TreeHugger Robot
9153a323fd Merge "Update one-line layout for conversation notifs" into rvc-dev 2020-04-27 19:53:23 +00:00
Steve Elliott
936df15c79 Update one-line layout for conversation notifs
Fixes: 152770837
Test: manual, visual
Change-Id: I8433d5e26be4e6fe0c16acc87b29bac334011cbf
2020-04-27 11:49:13 -04:00
Fabian Kozynski
bac4388d2b Maintain alignment of subtitle in mgmt screen
The subtitle aligns on top to an invisible checkbox, so it's position
remains the same between different screens.

Test: visual
Fixes: 154759251
Change-Id: I75c28dd02e099680555acdab200a0de909b57c51
2020-04-24 15:24:59 -04:00
TreeHugger Robot
87cf6848bd Merge "Controls UI - Detail panel" into rvc-dev 2020-04-23 23:32:48 +00:00
Matt Pietal
6b4b65c380 Controls UI - Detail panel
Launch on all long press by default. Support single tap -> detail
panel for limited device types.

Bug: 154698537
Test: manual

Change-Id: I5656c11ce732cd43a6fb9145541e29bbbeb6e2b3
2020-04-22 20:22:30 -04:00
Matt Pietal
e640f15400 Merge "Global Actions - Layout tweaks" into rvc-dev 2020-04-23 00:15:31 +00:00
Fabian Kozynski
2688e2237b Merge "Fix controls management activities details" into rvc-dev 2020-04-22 18:02:25 +00:00
Miranda Kephart
a083d73f87 Fix screenshot UI entrance animation
Makes the actions container expand out horizontally, rather than
coming up from the bottom.

Test: manual
Fixes: 153725541
Change-Id: I9485ed1ca23fb18b12e3994fa61a9e07a55d2ce1
2020-04-22 13:43:30 -04:00
Fabian Kozynski
6f3caf41a3 Fix controls management activities details
Some minor fixes:
* Remove icon next to structure name in Add controls
* Remove "other apps" when there's no other app to switch.
* Change footer buttons in apps screen.

Test: manual
Fixes: 154672630
Fixes: 154673161
Fixes: 154631120
Change-Id: I45be5c78b97a0301b77fa11125a294c66903dbef
2020-04-22 10:58:31 -04:00
Miranda Kephart
9ddbe1311d Update screenshot UI for dark theme
Updates the colors used when the dark theme is on. When a
screenshot is taken, checks for the current dark theme status and
updates the assets if necessary.

Test: manual
Bug: 146560663
Change-Id: Iccc727924e04febc5be25e2205775b52ef082f6a
2020-04-22 10:37:58 -04:00
Matt Pietal
9661e3b8f3 Global Actions - Layout tweaks
1. Remove scrollbars from controls
2. Remove top padding and just use insets

Bug: 154696337
Bug: 154673173
Test: visual
Change-Id: Ie188ebabd53cf734396d829b1469735d13377532
2020-04-22 09:12:28 -04:00
Josh Tsuji
c670ebf25e Merge "Add the Manage menu!" into rvc-dev 2020-04-21 19:43:11 +00:00
Joshua Tsuji
6855cabd98 Add the Manage menu!
Now you can dismiss, un-bubble :(, or manage the settings of your bubbles.

Test: manual
Bug: 143173197
Change-Id: I4c90bdab3f3f61646153ce615fa257bc64ed8a17
2020-04-21 10:58:53 -04:00
Matt Pietal
f4b870bc67 Controls UI - Motion for activities
Transition between control activities with animations. Transition between
GlobalActionsDialog and controls activities with the same
animations. Load async data into RecyclerViews in a separate animation
but controlling alpha values on the view

Bug: 154158092
Test: visual
Change-Id: I77c192d5b23a844900f4f2be128687d6314a1baf
2020-04-21 08:27:55 -04:00
Aran Ink
711d0a9a76 Merge "Remove end margin from power menu when overflow button present." into rvc-dev 2020-04-20 15:03:17 +00:00
Beverly Tai
d9a9e55d9c Merge "Set min width + height of tappable app op buttons" into rvc-dev 2020-04-20 13:15:02 +00:00
Aran Ink
7c8fea9b13 Remove end margin from power menu when overflow button present.
Test: Manual -- extra margin not present when overflow button is shown, but returns if the button is not. Turning bug report shortcut on and off is an easy way to go above/below the overflow threshold.

Bug: 152624388
Change-Id: I5c3464c74599524ec322052bb98fb468f6e67db7
2020-04-17 14:40:14 -04:00
Beverly
04aa41172a Set min width + height of tappable app op buttons
Test: manual
Fixes: 153281363
Change-Id: I2aa856b16102d1a2adcb81553ab3f57c6b1cd502
2020-04-17 12:50:00 -04:00
TreeHugger Robot
c979a6eb22 Merge "DO NOT MERGE: Show an onboarding screen for priority conversations" into rvc-dev 2020-04-16 17:07:30 +00:00
TreeHugger Robot
bbc00f4dd0 Merge "Change checkbox back to square" into rvc-dev 2020-04-16 16:56:40 +00:00
Evan Laird
31ca547400 DO NOT MERGE: Show an onboarding screen for priority conversations
Test: atest SystemUITests
Bug: 151843296
Change-Id: I5280cff71591f8551016b6ba00d3a579507367cb
2020-04-16 11:59:43 -04:00
Fabian Kozynski
e811b6a28d Change checkbox back to square
No more stars.

Test: manual
Fixes: 154158042
Change-Id: I13d7e91ca601e5172b4f3364f564c6a0cf4c2ec8
2020-04-16 10:36:42 -04:00
Julia Reynolds
66a3d17cbc Fix some styling in notification guts
Test: manual
Fixes: 153884368
Change-Id: I6f740a5735072e68d624a1e1c2301b0030b47fe7
2020-04-16 13:20:48 +00:00
TreeHugger Robot
b28dfc88cb Merge "Add an overlay for photo preview" into rvc-dev 2020-04-15 04:28:29 +00:00
Aran Ink
0b5450ec37 Merge "Add overflow menu to GlobalActionsDialog." into rvc-dev 2020-04-14 16:12:30 +00:00
Lucas Dupin
d27f3c80f8 Merge "Make buttons react to tap" into rvc-dev 2020-04-14 15:59:25 +00:00
Lucas Dupin
6843f576a2 Make buttons react to tap
Bug: 153040823
Test: visual
Change-Id: I2cd643160eed5efd2149f332329ea7033f88a069
2020-04-13 14:42:43 -07:00
Aran Ink
cf03827a81 Add overflow menu to GlobalActionsDialog.
Test: atest GlobalActionsDialogTest
Test: Power menu items beyond the 3rd will appear in a dropdown menu instead of being truncated when controls are available. If controls are disabled (ex. 'adb shell settings put secure systemui.controls_available 0'), all items should still display in older versions of GlobalActions. Items in power overflow menu are both short- and long-pressable.

Fixes: 152625023

Change-Id: Icdbf8eb7e79a61d490d484f207eeedc47c4882c5
2020-04-13 17:14:02 -04:00
TreeHugger Robot
42aa54c1a0 Merge "Rename file because gradle doesn't like camelCase." into rvc-dev 2020-04-13 21:03:53 +00:00
Joshua Tsuji
0463180a16 Rename file because gradle doesn't like camelCase.
Test: gradle builds again, yay!
Bug: 153867127
Change-Id: I87c2f0a02c17ef8f133ca3a251e5679ad0133fe5
2020-04-13 15:27:17 -04:00
Matt Pietal
61bc481d62 Merge "Controls a11y - Ensure minHeight on dialogs" into rvc-dev 2020-04-13 18:09:27 +00:00
Matt Pietal
628061fb2b Controls a11y - Ensure minHeight on dialogs
Touchable areas in PIN/passphrase dialog prompts need minHeight

Bug: 152934177
Test: manual, hsv
Change-Id: I76a708f4d142df8c38709bc5e3ca9ee11362a96f
2020-04-13 09:22:11 -04:00
Beverly
90e20d3c6d Fix notification snooze a11y issues
- Set minimum height and width on the snooze "undo" button
- Update logic in performAccessibilityActionInternal in
ExpandableNotificationRow so that snoozing a notification from
Talkback/switch access/voice access actually performs the snooze action
- After a user selects a new snooze time option for a notification, the
snooze options close. Focus should remain on the snooze time, since that
element was just changed.
- Once a user snoozes a notification, it should focus on the child
SnoozeView instead of the greater NotificationSnooze view because only
the SnoozeView is actionable. So if focus is requested on the
NotificationSnooze view and the options aren't expanded, then focus just
on the SnoozeView.

Test: manual, use a11y scanner
Fixes: 152730944
Fixes: 152820361
Fixes: 152720315
Fixes: 152718852
Change-Id: I7e43bddfdaa3b5a1741645f7bb54af42bc953fc3

Change-Id: I4672654d4ca2eb2cf68539efb7cfb0c8f5dfb00b
2020-04-13 13:01:12 +00:00
Fabian Kozynski
0935694b5a Merge "Add controls rearrange activity" into rvc-dev 2020-04-10 21:02:01 +00:00
TreeHugger Robot
47709f0e8b Merge "Controls UI - Support detail panels" into rvc-dev 2020-04-10 20:45:45 +00:00
TreeHugger Robot
186affa9af Merge "Controls a11y - Set activity titles" into rvc-dev 2020-04-10 20:14:08 +00:00
Matt Pietal
269a7b4dce Controls a11y - Set activity titles
Set proper activity titles and do not use the default application
label. Do not allow the status text to be focusable.

Bug: 152924457
Bug: 152932546
Bug: 152927300
Test: talkback

Change-Id: Ieed21596c8160aaf945d71e274706c771f7e4693
2020-04-10 13:40:22 -04:00
Matt Pietal
dc78c84748 Controls UI - Support detail panels
Allow apps to specify whether to show full screen or within detail
panels. Default camers and thermostats to use the panel by default
when the following flag is enabled.

Enable by:
adb shell settings put secure systemui.controls_use_panel 1

Change offset from the top in Px:
adb shell settings put secure systemui.controls_panel_top_offset XXX

Bug: 152528130
Test: manual, use camera, thermostat devices

Change-Id: Ia1b12afcf4de2a0bcf7957e6425b282b1e220f46
2020-04-10 13:36:26 -04:00
TreeHugger Robot
e7979623e6 Merge "Fix clickable notification row elements" into rvc-dev 2020-04-10 16:00:17 +00:00
Fabian Kozynski
8765d35779 Add controls rearrange activity
This activity is accesses from the overflow menu in the Controls UI. It
does the following:

* Shows all favorites for current structure
* Allows for rearranging current favorites in that structure
* Allows for removing current favorites in that structure
* Links to ControlsFavoritingActivity with just that structure

Test: manual
Test: atest ControlsControllerImplTest
Test: atest FavoritesModelTest
Test: atest AllModelTest
Fixes: 149138395

Change-Id: I8a57d4f835467247b7cc360fee4e382cd5553481
2020-04-10 10:18:57 -04:00