Commit Graph

9694 Commits

Author SHA1 Message Date
Jeff Sharkey
f7d3e028ae Merge "Return to modifying raw /mnt/media_rw paths." into pi-dev 2018-05-02 21:14:17 +00:00
android-build-team Robot
e696cf636d Merge changes from topic "ifaceStatsDetail" into pi-dev
* changes:
  Remove the unused file parsing function
  Use eBPF map data for per iface stats
2018-05-02 19:17:27 +00:00
Chenbo Feng
bbabc51b5b Remove the unused file parsing function
With the new xt_bpf support for iface stats. We no longer need to parse
the per interface stats from /proc/net/dev. And since the old xt_qtaguid
code path also not depend on it, we can completly remove that helper
function since no caller is depending on it now.

Bug: 72111305
Test: runtest frameworks-net -c com.android.internal.net.NetworkStatsFactoryTest
Change-Id: Icb7eaeef0eeb9fdffd32a90316c76ee05bafffbe
Merged-In: Icb7eaeef0eeb9fdffd32a90316c76ee05bafffbe
(cherry picked from aosp commit b815c978b8)
2018-05-01 19:48:03 -07:00
Chenbo Feng
804be4a3bc Use eBPF map data for per iface stats
After adding the xt_bpf module and ifaceStatsMap, eBPF tool can now
support reading per interface data. So networkStatsFactory should move
away from parsing proc/net/dev and use the eBPF map stats instead.

Bug: 72111305
Test: atest com.android.server.net.NetworkStatsServiceTest
Change-Id: Ibcc6150d00835b3bd33af22a72e4a86e172581cf
Merged-In: Ibcc6150d00835b3bd33af22a72e4a86e172581cf
(cherry picked from aosp commit dcc56783f5)
2018-05-01 19:46:09 -07:00
Selim Cinek
1e543887f5 Merge "Fixed an issue where the messaging layout could appear empty" into pi-dev 2018-05-01 22:42:53 +00:00
Selim Cinek
7a1e03a5fb Merge "Fixed the messaging clipping for RTL languages" into pi-dev 2018-05-01 22:38:09 +00:00
android-build-team Robot
b2e6d9eee0 Merge "Avoid redundant getAllocatableBytes() calls." into pi-dev 2018-05-01 22:04:05 +00:00
Jeff Sharkey
41afa65947 Avoid redundant getAllocatableBytes() calls.
Shuffle around the ordering of resolveInstallVolume() so that we
determine the fitsOnInternal value while doing a drive-by of all
possible target volumes.  This way we only call getAllocatableBytes()
internal storage once.

Bug: 70985520
Test: atest android.content.pm.PackageHelperTests
Change-Id: I8273c239af4a13b1db17f320e15ee0ef2dc89186
2018-05-01 13:09:30 -06:00
Selim Cinek
1110fd776d Fixed the messaging clipping for RTL languages
Because in landscape the width is bigger than the height,
our clipping logic was wrong and clipped off most of the
text.

Test: add messaging style notification, switch to RTL, landscape, observe normal clipping
Change-Id: I8c74a8405280047f8b2a08ecdf3f37b0fbeeec62
Fixes: 73895612
Fixes: 78606052
2018-05-01 10:57:39 -07:00
Selim Cinek
46f589178f Fixed an issue where the messaging layout could appear empty
Change-Id: I0fe6e7a23068f10e6c867424027e7a86c9210186
Fixes: 73952748
Test: send long message, observe normal layout, not cut off
2018-05-01 09:11:26 -07:00
Jeff Sharkey
b00d5ea59a Return to modifying raw /mnt/media_rw paths.
We thought we could push everyone through sdcardfs, but secondary
devices mounted in a stable location don't give full write access to
apps holding WRITE_EXTERNAL_STORAGE, so system internals still need
to reach behind sdcardfs.

To keep sdcardfs in the loop about changes that we make behind its
back, we issue access(2) calls which should be enough for it to
invalidate any cached details.

Bug: 74132243
Test: manual
Change-Id: I727cd179a5a825b16ec4df6e2f41a079758d41c5
2018-05-01 10:03:18 -06:00
android-build-team Robot
9f88bbc064 Merge "Secondary split screen app will be next to the navigation bar (1/2)" into pi-dev 2018-05-01 00:40:27 +00:00
Matthew Ng
62c7846bf8 Secondary split screen app will be next to the navigation bar (1/2)
Refactored docked position code into PhoneWindowManager to determine
which side the docked app should go based on the position of the nav bar
in landscape (as portrait will only have top). Fixed the split screen
entrance animation for quick step's overview.

Change-Id: I30f1be9d791c23f4cd197f17487609964f78fac0
Fixes: 73250406
Test: play around with splitscreen and minimized mode
Test: atest com.android.server.policy.PhoneWindowManagerTest
2018-04-30 16:25:15 -07:00
Chavi Weingarten
33cb3b7204 Merge "Update DecorContext's Resource cache when calling getResources." into pi-dev 2018-04-30 20:38:42 +00:00
Makoto Onuki
6c2679d55d Merge "Adjust future charge start time." into pi-dev 2018-04-30 18:11:28 +00:00
Makoto Onuki
14186bfe08 Merge "Log slow message delivery on Looper" into pi-dev 2018-04-30 17:50:58 +00:00
shawnlin
a7045c9d44 Fix incorrect width of right most action button in notification
Measure the last action view normally instead of measuring it full width.

Test: enable show layout bounds and check the bounds of it.
Change-Id: I38f234928f7214baf2b532ecae63c3f4514b3247
Fixes: 78032480
2018-04-30 02:52:34 +00:00
chaviw
a213d306d5 Update DecorContext's Resource cache when calling getResources.
DecorContext is created with the resources from the activity. However,
the resources in DecorContext may not get updated properly
ResourcesManager if the original resource object it's pointing to isn't
updated by ResourcesManager. Because of this, resources for the
DecorView can be incorrect when the activity's resources are updated.
This change updates the DecorContext's resources with the activity's
resources when getResources is called to ensure they get properly
updated.

This fixes the issue where windowing mode was incorrect when determining
what the window elevation should be. It was incorrectly getting full
screen when it should have gotten pinned. This was preventing surface
insets from getting set on the WM side, so PIP windows didn't get
shadows.

Change-Id: I5af2364f81b167e3732811d7413554d035c4a021
Test: PIP has shadows
Fixes: 78214575
2018-04-27 18:04:00 -07:00
Makoto Onuki
712886fd97 Log slow message delivery on Looper
Sample log:
04-27 15:30:17.306  1000   942   942 W Looper  : Dispatch took 222ms on main, h=Handler (com.android.server.job.JobSchedulerService$JobHandler) {42042fc} cb=null msg=7 start=48162 end=48384
04-27 15:30:17.306  1000   942   942 W Looper  : Delivery took 235ms on main, h=Handler (com.android.server.job.JobSchedulerService$JobHandler) {42042fc} cb=null msg=4 start=48149 end=48384
04-27 15:30:17.773  1000   942   942 W Looper  : Dispatch took 445ms on main, h=Handler (android.app.ActivityThread$H) {5df4c77} cb=android.app.-$$Lambda$LoadedApk$ReceiverDispatcher$Args$_BumDX2UKsnxLVrE6UJsJZkotuA@badd538 msg=0 start=48406 end=48851
04-27 15:30:17.828  1000   942   942 W Looper  : Drained
04-27 15:30:24.389  1000   942   942 W Looper  : Dispatch took 718ms on main, h=Handler (android.hardware.soundtrigger.SoundTriggerModule$NativeEventHandlerDelegate$1) {d7e9947} cb=null msg=4 start=54749 end=55467
04-27 15:30:24.389  1000   942   942 W Looper  : Delivery took 621ms on main, h=Handler (com.android.server.media.MediaSessionRecord$MessageHandler) {5851574} cb=null msg=7 start=54846 end=55467
04-27 15:30:24.499  1000   942   942 W Looper  : Drained

Bug: 78590632
Test: Boot and check log
Test: setprop log.looper.1000.android.bg 1 and runtime-restart and check log
Change-Id: Ief1fc65b40b8a3d583879f55a76288e3dba6be7d
2018-04-27 17:15:46 -07:00
Abodunrinwa Toki
8e7f8ad3ce Merge "FloatingActionMode.setOutsideTouchable" into pi-dev 2018-04-27 19:46:10 +00:00
Chia-I Wu
06c0c3a933 Merge "Add COLOR_MODE_AUTOMATIC" into pi-dev 2018-04-27 15:47:41 +00:00
Sudheer Shanka
a750da1960 Merge "Schedule external stats sync on battery level change with a delay" into pi-dev 2018-04-27 03:20:38 +00:00
Sudheer Shanka
0719c6af44 Schedule external stats sync on battery level change with a delay
and fix locking in scheduleCpuStatsSyncDueToWakelockChange().

Bug: 74146897
Test: atest cts/hostsidetests/incident/src/com/android/server/cts/BatteryStatsValidationTest.java
Test: atest core/tests/coretests/src/com/android/internal/os/BatteryStatsTests.java
Change-Id: I2891dfb8a0aedf429232f45e26deab93c738506e
2018-04-26 15:43:40 -07:00
Makoto Onuki
62b3c92cbc Adjust future charge start time.
Change-Id: Id10508a917a47a767614dee5a55f0ca7dbbae6bb
Fixes: 70606388
Test: Manual test with forwarding the clock and rewinding it with "cmd battery".
2018-04-25 22:26:08 +00:00
TreeHugger Robot
abab4cbd25 Merge "Fix floating toolbar menu item spacing." into pi-dev 2018-04-25 20:13:37 +00:00
Chia-I Wu
1e0e7176bd Add COLOR_MODE_AUTOMATIC
COLOR_MODE_SATURATED disables color management and thus treat any
color space as panel color space.  COLOR_MODE_AUTOMATIC is similar
to COLOR_MODE_SATURATED in that it stretches color spaces to panel
color space, but the stretching is color space aware.

persist.sys.sf.native_mode is extended to be a integer, where

 0: use DisplayColorSetting::MANAGED
 1: use DisplayColorSetting::UNMANAGED
 2: use DisplayColorSetting::ENHANCED

Bug: 73824924
Test: manual
Change-Id: Ia356958d8e1fbae90f244ded7111de2e45aa4b3c
2018-04-25 11:35:36 -07:00
Makoto Onuki
778ce66697 DO NOT MERGE Make "Want to start battery saver?" dialog better.
- Don't line-break in "Battery" (only in English)
- Add "Learn more" link.

Bug: 78261259

Test: Manual test with:
- adb shell dumpsys battery unplug
- adb shell settings delete secure low_power_warning_acknowledged
- Enable battery saver
- Make sure the link is clickable if a link is set.
- Make sure there's no "learn more" link if the link is not set in strings.xml

Change-Id: I83364f628dd596a4d50bf2aca4db7cbfe7cf4909
2018-04-25 15:27:47 +00:00
Abodunrinwa Toki
49ec54250f Fix floating toolbar menu item spacing.
We mistakenly changed floating_toolbar_menu_button_side_padding in
I309c729eb842d9388066bfb43eb18f33dbfe10b8 where in fact what we
wanted to do was to just change the mIconTextSpacing.
This cl fixes that.

Change-Id: I1b940eb12d2948f8c167c3f37ed0eba105b9f5ce
Fixes: 74032743
Test: built, observed visual look
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
2018-04-25 15:46:54 +01:00
Abodunrinwa Toki
29cb76849c FloatingActionMode.setOutsideTouchable
Make floating toolbar outside-touchable for link action mode in
non-selectable TextView.
This allows the user to be able to dismiss the toolbar by tapping
outside of the toolbar.

Bug: 78099871
Bug: 73156794
Bug: 78298142
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit CtsViewTestCases:android.view.cts.ActionModeTest
Change-Id: I8e3b460d0b1baee48d4f9cb3f92e73926eeee231
2018-04-24 14:54:33 +01:00
TreeHugger Robot
66b6d1c3bc Merge "Make password history hashing more secure" into pi-dev 2018-04-24 13:06:57 +00:00
Selim Cinek
53790c1c8f Merge changes from topic "notification_reply_action" into pi-dev
* changes:
  Cleaned up the paddings of the messaging layout and smart replies
  Changed the size of the largeIcon
  Moved the disabling from alpha to manual color blending
  Updated the color of the reply button to be more neutral
  Updated the reply icon
  Disabled reply action when pending intents are cancelled
  Split the reply icon permanently from the right icon
2018-04-24 09:10:38 +00:00
TreeHugger Robot
5f18904a00 Merge "Add spinner for smart replies." into pi-dev 2018-04-24 08:51:56 +00:00
Selim Cinek
1c72fa0249 Cleaned up the paddings of the messaging layout and smart replies
Refactored the code such that the reply icon's inset was substracted
from the overall paddings to make all of them consistent. This
will also help in the future as we don't have to update those
paddings manually anymore.

Test: test all sorts of combinations with Notify
Change-Id: I8c6c9951bc73c88d95cb443c8e618c7adca7ebd3
Fixes: 78441535
2018-04-24 14:33:29 +08:00
TreeHugger Robot
46c2b1451c Merge "Reset binder call stats along with batterystats" into pi-dev 2018-04-23 23:05:31 +00:00
Sudheer Shanka
6bc6e21be7 Merge "Rate limit battery external stats collection in takeUidSnapshot(s)." into pi-dev 2018-04-23 21:34:57 +00:00
Fyodor Kupolov
8aa51245e9 Reset binder call stats along with batterystats
Test: dumpsys batterystats --reset && dumpsys binder_calls_stats
Bug: 75318418
Change-Id: Ibdbd95468bba876b1f91357b86f7a8d45af2daed
2018-04-23 14:21:20 -07:00
Sudheer Shanka
e56013aa31 Rate limit battery external stats collection in takeUidSnapshot(s).
Bug: 74146897
Test: atest cts/tests/tests/os/src/android/os/health/cts/SystemHealthManagerTest.java
Test: atest core/tests/coretests/src/com/android/internal/os/BatteryStatsTests.java
Change-Id: I2e01146718c3ce65d230308097622b958cb2897a
2018-04-23 11:38:36 -07:00
Kenny Guy
a0f6de8ab2 Add spinner for smart replies.
Add a spinner to MessagingGroup that is enabled
when the user has clicked on a smart reply.

Bug: 73607490
Test: atest SystemUiTests

Change-Id: I4d892c19b5df2b443761819929a83f016967e217
2018-04-23 18:58:19 +01:00
TreeHugger Robot
981d61ddf8 Merge "Enabled aggregated per-uid stats collection by default" into pi-dev 2018-04-23 17:49:06 +00:00
Selim Cinek
384804b42d Split the reply icon permanently from the right icon
Previously these would overlap, but they are now completely
separate.

Test: ensure that all notification styles still work with the new affordance.
Change-Id: I16f5f863b4afac27494a4a7615631bca240ca532
Fixes: 72750728
2018-04-23 16:19:21 +08:00
Rubin Xu
f01e90789e Make password history hashing more secure
Instead of hashing the password directly which makes it possible to bruteforce
the password offline, hash the password together with the synthetic password.
This means without knowledge of the synthetic password, the hash itself is
useless.

As a consequence of this change, saving and checking historical password would
now also require the current device password to be provided. Checking password
history also takes more time due to the need to unwrap synthetic password, at
around 100-200ms.

Bug: 32826058
Test: manual
Change-Id: Icb65171b8c8b703d8f0aa3a8cb2bf7ad96c1332d
2018-04-21 09:46:23 +01:00
Fyodor Kupolov
3f3af617ae Enabled aggregated per-uid stats collection by default
Enabled collection of number of calls per-uid. It has relatively small
overhead. Memory impact is minimal and cpu overhead is also small -
250 ns vs 1500 ns with detailed tracking

Detailed tracking is disabled by default. Controlled by
persist.sys.binder_calls_detailed_tracking

Added commands to reset and enable/disable detailed stats:
dumpsys binder_calls_stats --reset
dumpsys binder_calls_stats --enable-detailed-tracking
dumpsys binder_calls_stats --disable-detailed-tracking

Test: manual
Bug: 75318418
Change-Id: I7c1280c025001b6d2b46e4a37bad841712b6da2f
2018-04-20 16:12:41 -07:00
TreeHugger Robot
cbfe423122 Merge "No divider between floating toolbar item groups" into pi-dev 2018-04-20 16:53:31 +00:00
Mihai Popa
66d41f87ea No divider between floating toolbar item groups
The CL removes the vertical divider that used to exist between adjacent
menu item groups in the floating toolbar, as well as the extra padding
between these, in order to adapt to the new UX requirements. The CL also
centers the text view inside a button, when there is no icon shown at
the left of the text view. This is only relevant when the minimum size
of the button is larger than the text measured width, and we want the
text to be centered inside the button in this case.

Bug: 74032743
Test: manual testing
Change-Id: I309c729eb842d9388066bfb43eb18f33dbfe10b8
2018-04-20 11:05:47 +00:00
Makoto Onuki
dbdf5df96e Merge "Split provider / service dumpsys into platform and non-platform" into pi-dev 2018-04-19 17:21:48 +00:00
Dieter Hsu
afc909d3ba Merge "Add rank & count event to notification clicks and dismisses" into pi-dev 2018-04-18 13:05:43 +00:00
Dieter Hsu
d39f0d52dc Add rank & count event to notification clicks and dismisses
For click/action click/dismiss, passing rank(0-based) and
count at the time of the actions to events.

Bug: 70724602
Test: runtest systemui-notification
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/notification
Change-Id: I07c440f84ccb745f744eb4e317881b72d2b41683
2018-04-18 03:28:48 +00:00
Makoto Onuki
0b575a3cdf Split provider / service dumpsys into platform and non-platform
Also extend the timeout to 60 seconds.
- Because each provider / service dump may time out, the total time should relatively be large.

Bug: 78017892
Fix: 78017892

Test: Manual test with the following dumpsys commands:
dumpsys activity provider all
dumpsys activity provider all-platform
dumpsys activity provider all-non-platform
dumpsys activity provider com.android.providers.contacts/com.android.providers.contacts.VoicemailContentProvider
dumpsys activity provider com.android.providers.contacts/.VoicemailContentProvider
dumpsys activity provider contacts
dumpsys activity provider voicemail
dumpsys activity provider 4d45a78

dumpsys activity service all
dumpsys activity service all-platform
dumpsys activity service all-non-platform
dumpsys activity service bluetooth

Test: atest /android/pi-dev/frameworks/base/core/tests/coretests/src/com/android/internal/util/DumpTest.java
Test: atest /android/pi-dev/frameworks/base/core/tests/coretests/src/com/android/internal/util/ParseUtilsTest.java

Test: Manual test with "adb bugreport" with adding sleep(10s) to ProviderMap.dumpProvider()

Change-Id: I00bce0090b8dbb947d7f8b1e5d01bb8a70d84bd8
2018-04-17 10:41:40 -07:00
Julia Reynolds
aa96cf3460 Exclude system notifications from visual suppression
But silence them by saying them cannot bypass DND.

Test: atest SystemUITests
Bug: 77656914
Change-Id: I044696cfdcef0e4a14be21173949612480722236
2018-04-17 15:27:35 +00:00
TreeHugger Robot
5291268754 Merge "Remove implementation of deprecated RecoveryController methods." into pi-dev 2018-04-16 22:14:22 +00:00