Commit Graph

1812 Commits

Author SHA1 Message Date
Brad Ebinger
a8366aeae4 Enforce READ_PHONE_STATE for APIs involving call state
For API version 31+, ensure that READ_PHONE_STATE is checked on
APIs that retrieve/notify the call state of the device.

Bug: 157233955
Test: atest CtsTelecomTestCases2 CtsTelephony2TestCases
Change-Id: I9f8674a3075d3e0f75ee4f41eefce328c0fa6b91
2021-03-25 15:11:00 -07:00
Sooraj Sasindran
a390714daf Merge "Add more documentation to PROPERTY_CROSS_SIM" into sc-dev 2021-03-24 21:02:56 +00:00
Sooraj Sasindran
fa1e57a296 Add more documentation to PROPERTY_CROSS_SIM
Add more documentation to PROPERTY_CROSS_SIM

Bug: 179307655
Test: build
Change-Id: Ie57214ad6a2049de4ccdf93d90571cec11338d06
2021-03-23 17:13:58 +00:00
Tyler Gunn
4fcf638eb9 Merge "Move Call state into Call.Details" into sc-dev 2021-03-22 17:19:22 +00:00
Tyler Gunn
0a1c6d1bb4 Propagate call quality reports from Telephony to CallDiagnosticService.
Complete plumbing for call quality reports to get to the CDS.

Test: Manual network testing.
Test: Modify CTS tests to cover these cases.
Bug: 163085177
Change-Id: I2bb68d29c4ad11cc8738c26cd69404fde4348843
2021-03-19 16:39:11 +00:00
Tyler Gunn
1e406ca235 Move Call state into Call.Details
The Telecom Call object is primarily a control object which allows
control of a call and receipt of events related to a call.  The actual
properties and data pertaining to a call all exists in Call.Details...
except for the call state (RINGING,ACTIVE, HOLD, etc).
This CL moves the call state to the Call.Details class to remove this
one dangling property of the base Call class.

Test: Run Telecom CTS test suite.
Bug: 163085177
Change-Id: I59413d3e14d03b48263a5cb351fe4e9a553b578e
2021-03-18 16:47:14 -07:00
Tyler Gunn
066de6034e Rename DiagnosticCall to CallDiagnostics.
Keep DiagnosticAll in a deprecated form to maintain binary compatibility
with ongoing work in other repos.

Test: run CTS
Test: run unit tests
Fixes: 182241145
Change-Id: Ia14113bcce344bb589408b74eaab74d413de9e7e
2021-03-16 16:17:50 -07:00
Tyler Gunn
deb61608ce Merge "Propagate Telephony disconnect cause to Telecom." into sc-dev 2021-03-15 18:28:08 +00:00
Tyler Gunn
110fb53e16 Merge "API review changes to CallDiagnosticService" into sc-dev 2021-03-12 22:35:04 +00:00
Tyler Gunn
801962126d API review changes to CallDiagnosticService
1. Remove NETWORK_TYPE and AUDIO_CODEC constants in favor of existing
constants in TelephonyManager and Connection.  Add API docs explaining
the simplifications of these two concepts.
2. Add more documentation on DiagnosticCall#sendDeviceToDeviceMessage
to explain the D2D protocol and the bandwidth challenges inherent.
3. Remove DiagnosticCall#getCallDetails.
4. Provide provision for developer-defined Executor in the
CallDiagnosticService; added docs there and in DiagnosticCall explaining
the threading model used.

Test: Ran CTS tests
Fixes: 182241145
Change-Id: Icb0d8a05add778a0cfcbe3448063cd9dcee3abc1
2021-03-12 09:42:46 -08:00
Hall Liu
c22a378048 Merge "Clarify semantics in call composer extras" into sc-dev 2021-03-12 17:08:00 +00:00
Grace Jia
0a77d3fc8a Merge "Annotation and doc improvement for adhoc conference APIs." am: 0251d617a5 am: e4bc4e9ca5 am: 3e96c1328c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1412812

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie849bba0805a1a43a841ae204337c12d3f5d9791
2021-03-12 00:51:05 +00:00
Hall Liu
48c3c14a2a Clarify semantics in call composer extras
Docs updates:
* setCallExtraParcelable must take a framework-defined parcelable
* EXTRA_PICTURE_URI takes an android.net.Uri
* Remove redundant documentation on setCallComposerStatus

Fixes: 182510687
Test: docs only
Change-Id: I43f776cf8bcb72c4121515536a3790cf44bf1638
2021-03-11 16:17:31 -08:00
Grace Jia
0251d617a5 Merge "Annotation and doc improvement for adhoc conference APIs." 2021-03-11 23:07:54 +00:00
Tyler Gunn
bc9ecbcfbe Propagate Telephony disconnect cause to Telecom.
Propagate telephony disconnect causes and imsreasoninfo to Telecom for
propagation to CAllDiagnosticService.

Plumb through disconnect message override in CallDiagnosticService.

Test: Added new CTS test coverage for these APIs.
Test: Manual test with telecom test app; verify the disconnect message is
overridden.
Bug: 163085177

Change-Id: I0c6938f2d0a46d535ae201364193ef58e07ec488
2021-03-10 19:02:38 -08:00
Hall Liu
3074ceab62 Merge "Add onBindClient for testing" am: 53252b14e5 am: 40a22b24b0 am: 8c022a831a
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1625243

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I2e05f57f4ec6b01082c0e1eac97a2a23ce677cbd
2021-03-10 21:02:07 +00:00
Hall Liu
53252b14e5 Merge "Add onBindClient for testing" 2021-03-10 19:24:43 +00:00
Hall Liu
eb7c9eaf16 Add onBindClient for testing
Add an overrideable method in ConnectionService that gets called when
telecom binds, since onBind is final and it's unsafe to make not-final.

Bug: 181057509
Test: atest CtsTelecomTestCases
Change-Id: I80088185402789fec499b8659ca8b74bcec05748
2021-03-09 20:29:40 -08:00
Tyler Gunn
4b033d7316 Merge "CallDiagnosticService API" am: c90335033b am: 9882ff4bf8 am: d3bf1aa209
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1607109

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ie91efc29698d27946f83b751bef2fe89d612c9a2
2021-03-03 00:16:56 +00:00
Tyler Gunn
9882ff4bf8 Merge "CallDiagnosticService API" am: c90335033b
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1607109

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I2958205678f4340e96ce6e845718e994a0231afc
2021-03-02 22:11:20 +00:00
Tyler Gunn
c90335033b Merge "CallDiagnosticService API" 2021-03-02 21:33:02 +00:00
Shuo Qian
a63d125010 Merge "Companion InCallService API review" am: b7cc3c6106
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1607479

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: Ib967a0256b39150a190dc4cb7b8b7f7a00d3fdd7
2021-03-01 18:57:21 +00:00
Tyler Gunn
d582184178 CallDiagnosticService API
The CallDiagnosticService API is an OEM-backed API which allows an OEM
provided app to monitor the state of ongoing telephony calls on the
device and to help the user navigate connectivity or audio issues
related to these calls.  It also provides a means for the app to send
and receive device to device messages between devices during an ongoing
call (where supported) in order to facilitate a better calling experience.

Test: Added new CTS test suite for API.
Test: Manual test of CDS behavior using telecom command line option to
override the active CDS to the telecom test app implementation.
Bug: 163085177

Change-Id: I1f37408d2aa6c630f0f9e3d6b6eb8a390d804d7e
2021-02-25 23:08:29 +00:00
Shuo Qian
93273fd60d Companion InCallService API review
Test: atest; make docs
Bug: 179116441
Change-Id: Id75e727f6c3fc42132a80f7258bf790be79acf19
Merged-In: Id75e727f6c3fc42132a80f7258bf790be79acf19
2021-02-25 22:01:27 +00:00
sqian
7a2b711b00 Companion InCallService API review
Test: atest; make docs
Bug: 179116441
Change-Id: Id75e727f6c3fc42132a80f7258bf790be79acf19
Merged-In: Id75e727f6c3fc42132a80f7258bf790be79acf19
(cherry picked from commit d30bd60beb)
2021-02-25 20:40:12 +00:00
Xin Li
be473bf819 Merge ab/7061308 into stage.
Bug: 180401296
Merged-In: I4bf82035631ccff6d5a6144d6d9b1d203b076851
Change-Id: I1b5f3a672a55eaabba0f5389bab110b395553559
2021-02-21 09:39:53 -08:00
Hall Liu
7390314002 User arg object in onCallFilteringCompleted
In Connection#onCallFilteringCompleted, use a single data class argument
instead of making a hodgepodge of args.

Fixes: 180616846
Test: atest CtsTelecomTestCases
Change-Id: I33e80e3f59418c5d87799661c0764da029cc9f62
2021-02-18 18:52:07 -08:00
Hall Liu
1b1e39ad6b Merge changes from topics "call-screening-refactor", "composer-call-screening" into sc-dev
* changes:
  Add APIs to support call composer filtering
  Refactor CallScreeningService's internal structure
2021-02-17 18:52:23 +00:00
Hall Liu
d4c62b99d5 Add APIs to support call composer filtering
Add APIs in callscreeningservice to allow the screening service to
specify which call composer attachments should be shown to the user.

Fixes: 179412110
Test: atest ConnectionServiceTest ExtendedInCallServiceTest
Change-Id: Ib7d3213ecda8f612461e6e36375c16261fc5492a
2021-02-12 14:04:27 -08:00
Hall Liu
5efe997539 Refactor CallScreeningService's internal structure
Use a single AIDL method and perform logic in Telecom instead of slicing
up the call response on the client side.

Also pass through the call response to the connection service.

Bug: 179412110
Test: atest ConnectionServiceTest CallScreeningServiceTest
Change-Id: I878c0ce34142da104dc0e2795487b03a6bdacb5f
2021-02-12 14:04:10 -08:00
Grace Jia
e7382b6103 Merge "Set default value of EXTRA_ADD_SELF_MANAGED_CALLS_TO_INCALLSERVICE true." am: f67a99fe60 am: a8cafc65ff am: b609dab7b7
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1571460

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I5cb615dd3bceee20b3fb43977a6792abc14302b4
2021-02-11 03:52:17 +00:00
Grace Jia
b609dab7b7 Merge "Set default value of EXTRA_ADD_SELF_MANAGED_CALLS_TO_INCALLSERVICE true." am: f67a99fe60 am: a8cafc65ff
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1571460

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I487626731aed71285fa359470b01e4227f5162c4
2021-02-11 03:48:52 +00:00
Grace Jia
f67a99fe60 Merge "Set default value of EXTRA_ADD_SELF_MANAGED_CALLS_TO_INCALLSERVICE true." 2021-02-11 03:23:42 +00:00
TreeHugger Robot
792a5985bb Merge "Fix faulty log statement" into sc-dev 2021-02-04 23:11:32 +00:00
Adrian Roos
d68bee2746 API: Suppress existing NullableCollections lints am: 6a6aa5e23d am: 4da67dd2f6 am: 98eb82a6d3
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1566096

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I314b97d2677f26b0a9c09a52918df49096450aea
2021-02-04 17:09:38 +00:00
Adrian Roos
98eb82a6d3 API: Suppress existing NullableCollections lints am: 6a6aa5e23d am: 4da67dd2f6
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1566096

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I931b4ec091173789f480ecc761044a27944c4b85
2021-02-04 16:49:00 +00:00
Adrian Roos
4da67dd2f6 API: Suppress existing NullableCollections lints am: 6a6aa5e23d
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1566096

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I2d47151b7e26e82706f2d94a13c4067fe71fc168
2021-02-04 16:19:34 +00:00
Adrian Roos
60f3d5cee4 Merge changes from topic "nullablecollection"
* changes:
  API: Suppress existing NullableCollections lints (TaskOrganizer)
  API: Suppress existing NullableCollections lints
2021-02-04 15:53:34 +00:00
Grace Jia
8b22bb4bce Set default value of EXTRA_ADD_SELF_MANAGED_CALLS_TO_INCALLSERVICE
true.

Self-managed connections need to bind to special in-call service in
order to expose itself to bluetooth stack.

Bug: 178679937
Test: Manually use duo to make self-managed calls and make sure it's
audible on BT

Change-Id: I7c3c56e9c65d43f598645aee5842e97fd73d300e
2021-02-02 15:37:32 -08:00
Nazanin Bakhshi
494a6eb0d3 Merge "Add an event and a parcelable to receive bluetooth framework call quality signal" am: 99955ce46b am: 63bb8c664e
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1566906

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I52fc8a9d4f397c4076d966ae68ad8fe366f61f10
2021-02-02 21:02:16 +00:00
Hall Liu
b28a6e05cb Fix faulty log statement
Bug: 177613111
Test: manual
Change-Id: I95830d4af1542671e6a06596e2661d41f124838e
2021-02-02 11:28:28 -08:00
Nazanin Bakhshi
99955ce46b Merge "Add an event and a parcelable to receive bluetooth framework call quality signal" 2021-02-02 19:21:22 +00:00
Nazanin
9bf6b3de91 Add an event and a parcelable to receive bluetooth framework call
quality signal

Bug: 173137125
Test: manual test check for regression
Change-Id: I38e70ea284707d39cec7cb4fbdfd36be4f83e403
Merged-In: I38e70ea284707d39cec7cb4fbdfd36be4f83e403
2021-02-01 21:36:48 +00:00
Grace Jia
3771f5e563 Merge "Add relative APIs for InCallService that can support self-managed connections that want to expose itself." am: 59c47d24fc am: f5468331b4
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1526998

MUST ONLY BE SUBMITTED BY AUTOMERGER

Change-Id: I166bd3ba72e1ffa4e6297bd7ec69fde1f15bd1d7
2021-02-01 19:34:58 +00:00
Grace Jia
4e8dc10871 Add relative APIs for InCallService that can support self-managed
connections that want to expose itself.

Add PhoneAccount#EXTRA_ADD_SELF_MANAGED_CALLS_TO_INCALLSERVICE and
Connection#onInCallServiceTrackingChanged.

Bug: 161144815
Test: CtsTelecomTestCases
Change-Id: I0a42ea79a1cd46aa9df3399c4fa2e9396321778a
Merged-In: I0a42ea79a1cd46aa9df3399c4fa2e9396321778a
2021-02-01 14:51:31 +00:00
Adrian Roos
6a6aa5e23d API: Suppress existing NullableCollections lints
Bug: 152525509
Bug: 154763999
Test: make checkapi
Change-Id: Iecd0927e6be5496b2fbd1a49396db5439257ffe4
2021-02-01 15:04:10 +01:00
Hall Liu
8fee7eaa81 Rename TelecomManager.EXTRA_INCOMING_PICTURE
Rename to EXTRA_PICTURE_URI, since we also need to set it for outgoing
calls in order to write to the call log correctly.

Bug: 177613111
Test: atest CallComposerTest
Change-Id: Ie171c8f978db7de30e81800c464b2bd68aff73f8
Merged-In: Ie171c8f978db7de30e81800c464b2bd68aff73f8
2021-01-28 12:28:29 -08:00
Hall Liu
a749abcead Add support for integrating call composer
* Minor bugfix in call log to handle USER_CURRENT
* add TelephonyLocalConnection that allows frameworks/opt/telephony to
call code (indirectly) in packages/services/Telephony

Bug: 177613111
Test: atest CallComposerTest

Merged-In: I602b51da6009c884364a026781ca3c160978fbd1
Change-Id: I61af7553b4b3d71fe87c86fca62941747d43ef55
2021-01-28 12:28:25 -08:00
Grace Jia
41895157db Annotation and doc improvement for adhoc conference APIs.
Annotate Conference#onAnswer with @VideoState
Mark parameters of adhoc conference APIs with @NonNull.
Document the distinction between returning null and returning a failed conference.
Bug: 165801368
Test: make

Change-Id: Ic0bd1a1e431ca0dec52afc8a28996929684236ba
2021-01-20 14:21:04 -08:00
Grace Jia
e99fde9678 Add relative APIs for InCallService that can support self-managed
connections that want to expose itself.

Add PhoneAccount#EXTRA_ADD_SELF_MANAGED_CALLS_TO_INCALLSERVICE and
Connection#onInCallServiceTrackingChanged.

Bug: 161144815
Test: CtsTelecomTestCases
Change-Id: I0a42ea79a1cd46aa9df3399c4fa2e9396321778a
2021-01-19 15:04:09 -08:00