Commit Graph

1923 Commits

Author SHA1 Message Date
Mady Mellor
01dd1a233d Merge "Allow bubbles to be displayed at the bottom of the screen" 2019-02-22 22:30:05 +00:00
Wei Wang
141852c378 Merge "Remove HardwarePropertiesManager usage" 2019-02-22 21:28:11 +00:00
TreeHugger Robot
0b90bd7703 Merge "Disable flaky tests" 2019-02-22 17:33:43 +00:00
Wei Wang
d98422ea43 Remove HardwarePropertiesManager usage
Bug: 116866524
Bug: 77790357
Test: Build
Test: atest PowerUITest
Change-Id: I5b5c9c56c9123872a3626fdb55508d1594bf3878
2019-02-22 23:18:50 +08:00
TreeHugger Robot
c78acd2554 Merge "Use size to inflate nav bar buttons instead of rotation" 2019-02-22 07:59:50 +00:00
Lucas Dupin
597dfafa62 Disable flaky tests
Bug: 124858892
Test: make
Change-Id: Ie780916f6d7d008d559f772b31117bcd593d50e1
2019-02-21 18:28:46 -08:00
Mady Mellor
44ee2fec72 Allow bubbles to be displayed at the bottom of the screen
* Positions the bubbles to show at the bottom of the screen, above the
 'dismiss' target UI by default
* Adds flag to toggle bubbles to show at the top of the screen instead
* Adds flag to show bubble header as a footer instead

Test: manual - have bubbles, expand them, note that they are positioned at
      bottom of screen
Bug: 123540009
Change-Id: I938d3ab7d4ec6f6bd88f3a33f73a97d5f80a45f5
2019-02-21 16:12:09 -08:00
Sherry Huang
a2c5d1a7f3 Merge "Implement USB-C overheat warning" 2019-02-21 23:09:08 +00:00
Sherry Huang
ce02ed3a46 Implement USB-C overheat warning
When device USB-C port is susceptible to short circuits and
overheating, pop up a warning dialog and keep showing until
user clicks OK button or see care steps.

Test: manually set the emulated temperature to trigger warning
Test: atest SystemUITests

Change-Id: I4f6080187196a9716f12a9817dc10d3265dc202b
Bug: 110134720
Bug: 116866524
Bug: 77790357
Bug: 117178820
2019-02-21 22:00:47 +08:00
Charles Chen
aa94d95bfc Use size to inflate nav bar buttons instead of rotation
For a landscape or close-to-square device, the button layout of
nav bar was abnormal since System UI assumes the nav bar position
would change if device rotated.
However, for default landscape device, nav bar will be always on
the buttom.

This patch resolve the assumption by using nav bar
direction (horizon/vertical) instead of rotation.
Also renaming the layout for consistency.

Test: atest SystemUITests
Test: atest NavigationBarFlaterViewTest
Test: manual - rotate the phone and comapre to my Pixel2
Test: manual - test the peproduce steps and the layout of nav bar buttons is normal
Fix: 124428114

Change-Id: I23444bcb2a44555e7116f6140a29147c5a03ed69
2019-02-21 15:44:57 +08:00
Lucas Dupin
98ab00f921 Merge "Named wake lock reasons" 2019-02-21 00:25:59 +00:00
Lucas Dupin
ed880e695b Merge "Always update view when metadata changes" 2019-02-21 00:24:46 +00:00
Lucas Dupin
76527eeb0a Always update view when metadata changes
Otherwise skipping songs wouldn't change the contents of AOD.

Test: manual
Fixes: 124527003
Change-Id: Ie644aa451390712ae529c849a743ec083b8229ee
2019-02-20 14:24:36 -08:00
Lucas Dupin
ee4c9b7d39 Named wake lock reasons
Fixes: 121039718
Test: atest ScrimControllerTest
Test: atest KeepAwakeAnimationListenerTest
Test: atest SettableWakeLockTest
Test: atest WakeLockTest
Test: adb shell dumpsys activity service com.android.systemui
Change-Id: I612874da597fba6974edd1f702932ee1a5629fc7
2019-02-20 09:59:45 -08:00
Ahan Wu
b492452166 Remove DrawableEngine and related logics
We will always render image wallpaper with GLEngine so the
DrawableEnigne is no longer necessary.

Remove DrawableEngine and related code including tests makes the code
more clean.

Bug: 123617158
Test: Manually set wallpaper by Photos and rotate home
Test: runtest systemui

Change-Id: I630112e755b74217e44518ec93273c99fb173f24
2019-02-20 20:37:06 +08:00
TreeHugger Robot
be4dac8639 Merge "Generate realistic preview images of custom clock faces." 2019-02-20 03:41:56 +00:00
Ned Burns
dd7c11d5ac Merge "Remove doInflateSynchronous() from InflationCallback" 2019-02-20 01:48:12 +00:00
Ned Burns
342c3a0186 Remove doInflateSynchronous() from InflationCallback
Trying to simplify this callback in preparation for streamlining
the inflation pipeline. This method only exists to enable some tests;
changed it to be a field and/or param in appropriate places.

Test: atest
Change-Id: I6e630fab5ba168d5accb57b403f9b5b0a224dff1
2019-02-19 14:11:36 -05:00
Robert Snoeberger
71e5079154 Generate realistic preview images of custom clock faces.
Bug: 123704608
Test: atest ClockManagerTest
Change-Id: I2dcc50120995f99ed170cc01a934d1db728f5963
2019-02-19 11:02:04 -05:00
Jeff Chang
f90b5b0d5c Merge "Fix the flaky test case : testRecentsButtonDisabledOnSecondaryDisplay" 2019-02-18 11:30:15 +00:00
Lucas Dupin
204033722b Do not show media icon on AOD for active stream
Otherwise it would be duplicated in the keyguard slice area

Test: visual
Fixes: 124139684
Change-Id: Id86f1c034e7ac860849c2c1ba876dabaff71f911
2019-02-15 13:28:46 -08:00
Jeff Chang
fa9ba88505 Fix the flaky test case : testRecentsButtonDisabledOnSecondaryDisplay
Wait for the display state ready before the testing

Bug: 123217660
Test: atest NavigationBarButtonTest#testRecentsButtonDisabledOnSecondaryDisplay
Change-Id: Iaa1808db5985d2f239932ae0fd69c4ee4dfccf4b
2019-02-15 15:43:28 +08:00
TreeHugger Robot
5db74fbe16 Merge "Rename NotificationInflater to NotificationContentInflater" 2019-02-15 05:43:26 +00:00
Josh Tsuji
10a73a04c9 Merge "Updates individual bubble dismissal logic and animation." 2019-02-15 03:46:03 +00:00
Lucas Dupin
5fe2936fcb Merge "Fix contrast exception" 2019-02-15 03:26:08 +00:00
Lucas Dupin
6cfa5cd35f Fix contrast exception
Fixes: 124378093
Test: atest NotificationViewWrapperTest
Change-Id: Ie232e14fb4aed8b6a387c9ca4bd766e9d3f3a900
2019-02-14 17:34:12 -08:00
TreeHugger Robot
5c50e8d1c3 Merge "Adds a valid Activity target for Bubble metadata" 2019-02-14 23:17:28 +00:00
Ned Burns
1a5e22f84a Rename NotificationInflater to NotificationContentInflater
We have two separate inflation steps; this class name was confusing.

Test: atest
Change-Id: Iaacf8bf81c755cc2ea217d81674fbacfd52360e4
2019-02-14 15:17:00 -05:00
Joshua Tsuji
442b62779b Updates individual bubble dismissal logic and animation.
This makes it so that bubbles can be dragged out, and the rest of the stack will animate to close the gap. If the bubble is dismissed (either by a hard fling or by placing it in the dismiss area), it'll animate away. Otherwise, it'll animate back into the row of bubbles.

This CL also simplifies the touch handler code. Along with eliminating some redundant paths in onTouch, this also deletes the FloatingView interface. Now that the stack and individual bubbles act so differently, it makes less sense to have a single interface for moving them.

Test: atest SystemUITests
Bug: 123541855
Bug: 123022862
Bug: 124058992
Change-Id: I57e3df19a191a6da0b5ed5d40c350bebb29f74ff
2019-02-14 14:33:54 -05:00
Mady Mellor
a238198ad5 Merge "Make BubbleData @Inject" 2019-02-14 19:16:05 +00:00
Mark Renouf
a9fbb6ed90 Adds a valid Activity target for Bubble metadata
Test: atest BubbleControllerTest
Bug: 123631037
Change-Id: Ied0e686febd2d1a7478e84faade958e187db0ef7
2019-02-14 14:10:06 -05:00
Mady Mellor
cfd06c1e5a Make BubbleData @Inject
Follow up comments from ag/6274141

Test: atest BubbleControllerTest
Bug: 123543995
Change-Id: Id9e74557e7b1a91f5fbf05bf9b94aeaf3e2d17be
2019-02-14 17:38:42 +00:00
Fabian Kozynski
a6ff80bfb5 "Fix" NPE in PhoneStatusBarPolicy
Callback returns a copy of the list
Makes PrivacyItemController dumpable

Test: atest
Test: adb shell dumpsys activity service com.android.systemui/.SystemUIService Dependency
Fixes: 124234367

Change-Id: I1400ee8294f34b129723bb0f0ce7745dafaf5545
2019-02-14 09:36:21 -05:00
TreeHugger Robot
61dac1aa50 Merge "Revert "Revert "Switch clock face while docked.""" 2019-02-13 22:45:48 +00:00
Mady Mellor
4514a30506 Merge "Move ActivityView into BubbleExpandedView" 2019-02-13 21:35:18 +00:00
Fabian Kozynski
2ec3c24143 Merge "Injected proper deps in PrivacyItemController" 2019-02-13 20:20:28 +00:00
Robert Snoeberger
b300a4ee45 Revert "Revert "Switch clock face while docked.""
This reverts commit 708e739811.

Reason for revert: The issue motivating the revert was an earlier presubmit failure for my change.

Change-Id: Icdb7f4dddc5bbee8ce1f54bb8cee550ef0a4639e
Bug: 124252294
2019-02-13 20:15:12 +00:00
Fabian Kozynski
8176539e2f Injected proper deps in PrivacyItemController
Test: atest
Change-Id: Ib12d5d6af0f8cfacbb91a2e2cd1887f337a1d61e
Fixes: 121388507
2019-02-13 11:37:56 -05:00
TreeHugger Robot
dc3e98eabb Merge "Revert "Switch clock face while docked."" 2019-02-13 06:00:56 +00:00
Lucas Dupin
708e739811 Revert "Switch clock face while docked."
This reverts commit 0ac3cdfa3f.

Reason for revert: Causes presubmit error
Fixes: 124252294

Change-Id: I881b24a60dd3a98afb807264d1e4318127a8c91b
2019-02-13 00:25:38 +00:00
Lucas Dupin
e570af67de Restore keyguard status area header
Fixes: 123340905
Fixes: 123958307
Test: atest KeyguardSliceViewTest
Test: manual, playing media
This reverts commit ed00262486.

Change-Id: I1cc60346f9176b913ee0404b2b31981f736664ce
2019-02-12 15:21:24 -08:00
TreeHugger Robot
44426e2142 Merge "Switch clock face while docked." 2019-02-12 23:17:43 +00:00
Mady Mellor
3dff9e6d65 Move ActivityView into BubbleExpandedView
This is initial work that needs to come before moving bubbles to the
bottom of the screen and enabling horizontal swiping.

* Moves ActivityView out of BubbleView and into BubblExpandedView
* New 'bubble' object that wraps the notification entry and the two
  bubble views (icon + expanded), this is utilized by BubbleStackView
* BubbleData is the knower of bubbles and used by BubbleController &
  BubbleStackView as source of truth

Bug: 123543995
Test: atest BubbleControllerTest (existing tests all pass)
Change-Id: I710d908e78ed2aef6a0e482b70c21fa0640d250c
2019-02-12 11:33:49 -08:00
Robert Snoeberger
0ac3cdfa3f Switch clock face while docked.
Bug: 120772327
Test: Added tests ClockManagerTest and DefaultClockSupplierTest
Change-Id: I404c6d52e1bd087d453d928faf373cf8dea9e2b2
2019-02-12 13:43:36 -05:00
Gustav Sennton
26ebfe8933 Merge "Test to null-check NotificationEntryManager.performRemoveNotification()" 2019-02-12 16:44:36 +00:00
TreeHugger Robot
d06756ceae Merge "Prevent, again, custom clock view from being visible on Home screen." 2019-02-11 23:18:18 +00:00
Nadia Benbernou
c3a11501a5 Merge "Style changes to blocking helper for Q. Bug:123900539 Test: Manual testing on device and unit tests." 2019-02-11 19:15:15 +00:00
Robert Snoeberger
a1df7fb8f3 Prevent, again, custom clock view from being visible on Home screen.
Bug: 124133570
Test: Added to KeyguardClockSwitchTest.
Change-Id: Id697fc8d25de2842c06d777047ce627a8b7793eb
2019-02-11 14:11:30 -05:00
Gustav Sennton
744e7e1cf3 Test to null-check NotificationEntryManager.performRemoveNotification()
Bug: 123327642
Test: atest NotificationEntryManagerTest

Change-Id: Ia1e971e6e786798821809a1e801d462f3c189e83
2019-02-11 17:54:03 +00:00
Julia Reynolds
7cf2c9de2e Merge "Show low priority ppl notifications in top part of UI" 2019-02-10 23:10:41 +00:00