* changes:
If the update is non-interruptive don't re-bubble it
Don't bubble things when we shouldn't
Ignore updates to bubbles that aren't from the system
The splitting tasks will be reparented to RecentAnimationSplitTasks
overlay layer in order to animate them together. However, the other
animating apps should also be placed to the same overlay layer so all of
them can be layered properly during the transition.
Fix: 239630217
Test: action menu shows above split pairs in overview panel
Change-Id: Idf4038fe575e37cdf9db16ba672208df45160ec1
I haven't been able to reproduce this outside of tests on acloud
devices, but if you visit a bubble for the first time (causes an
update to the notif) and then dismiss it sometimes the user dismiss
can happen before we get the update back from notification manager
service and the bubble will get re-bubbled incorrectly.
To fix this, if a bubble is in the overflow (or active) and there's
an update to the notification that is non-interruptive, we shouldn't
re-bubble that content because there wasn't a new message, just some
change on the notification.
Bug: 238896626
Test: atest BubblesTest
Test: atest --no-bazel-mode --iterations 20 PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.ExpandAndDragToDismissTest
(with vadim's changes & other CLc)
Change-Id: If0b7b3d3d1875ddd1df6a1412db8c42456de35c5
I haven't been able to repro these issues outside of tests on
cuttlefish, but I think logically these fixes make sense & seem to
resolve the test issue.
- Ensure non-notifying updates to bubbles in the overflow don't
clobber the FLAG_BUBBLE state
- onRankingUpdate should only bubble stuff up if it's not active and
not in the overflow (previously just not active)
Bug: 238896626
Test: atest BubblesTest#testNonInterruptiveUpdate_doesntOverrideOverflowFlagBubble
Test: atest --no-bazel-mode --iterations 20 PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.ExpandAndDragToDismissTest
(with vadim's changes & another CL)
Change-Id: Id588c1130e62533a23dc931dfb4fe3c92125a905
The new notif pipeline code adds a concept of updates from the system
vs from sysui. Currently bubbles is responding to all updates but
I think we really only care about updates from the system (i.e. from
NotificationManagerService).
Bug: 238896626
Test: atest BubblesTest#testNonSystemUpdatesIgnored
Test: atest --no-bazel-mode --iterations 20 PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.ExpandAndDragToDismissTest
(with vadim's CLs and a 2nd change to be uploaded)
Change-Id: I3ffd6eb0f0a07448b2117924be514347c6e80b16
- This is the only transition controller that isn't using ShellInit,
which means that it currently adds itself as a handler too early.
Bug: 238217847
Test: atest PinnedStackTests
Test: atest WMShellFlickerTests:com.android.wm.shell.flicker.pip.AutoEnterPipOnGoToHomeTest
Change-Id: Ia6dd437d52b8e7f249c86ed4b013fcbf04c31265
- When Transitions migrated to ShellInit, the default/remote handlers
got added after PipTransitionController (which should really also
use ShellInit (to be fixed in a follow up CL)). For now, we can
be explicit about where they should be added in the list.
Bug: 241515409
Bug: 241484248
Test: atest PinnedStackTests
Test: atest WMShellFlickerTests:com.android.wm.shell.flicker.pip.AutoEnterPipOnGoToHomeTest
Change-Id: I696327004e06e7ddd402a509fa18c86c60b244d4
There are already animations for most of these operations (eg. in
launcher), so instead of "claiming" the transition animation
and doing nothing, this should just update state (window decor)
and then let other handlers play the animations.
Bug: 241486751
Test: launch app from launcher, go back.
Change-Id: Ic5d01b76c04d6adab484d53d24d1a89b001a4c80
The task surface might be released before running in the sync queue for
the case like trampoline launch, so check if the surface is valid before
processing it in StageTaskListener.
Fix: 239490752
Test: atest WMShellUnitTests
Test: no crash when dragging a "clean" shortcut of Files to enter split
Change-Id: I8f927f644149cf9b24f4c9110f8ac745bb558dcd
> Generating only one bitmap when creating appIcon
> Extracting the scale during icon generation for main icon
instead of running icon normalizer again
> Avoiding unnecessary color extraction on main icon
Bug: 238937089
Test: Verified on device
Change-Id: Ia01801f15e5982593852f05c2512d0f1f737f5f7
It will restore the shifted split layout after entered overview panel,
this makes sure to update the proper finish transaction so the split
layout will be updated properly after animated the transition.
Also support to modify the finish transaction when a transition got
merged, so we can append clean-up operations for the cases like merging
an enter split screen transition to another handler.
Fix: 238856352
Test: enabled shell transition, verified split layout has been
shifted/restored properly after re-entering a split pair.
Change-Id: I630c54ed7c25246634c314eb9b2561a8556d8570
