Commit Graph

2306 Commits

Author SHA1 Message Date
Mark Renouf
b448dbc0fc Merge "Updates BubbleData sorting and grouping to spec" into qt-dev am: d6cddfedf9
am: 5a3826bead

Change-Id: If58709393408c875253364860582316fdf133ea3
2019-05-08 10:45:38 -07:00
Mark Renouf
d6cddfedf9 Merge "Updates BubbleData sorting and grouping to spec" into qt-dev 2019-05-08 16:58:20 +00:00
Mark Renouf
ba5ab51bc3 Updates BubbleData sorting and grouping to spec
This change adds onBubbleOrderChanged to BubbleStackView
to try to keep the order synchronized. There are some known
issues with the animation and visual state, which will be
addressed in a follow up CL.

Bug: 123542488
Test: BubbleControllerTest BubbleDataTest
Change-Id: Ie5a679df2f3069236f4d67a3fce4189b39b9eb28
2019-05-08 11:23:15 -04:00
Ned Burns
a068cddb89 Add "Gentle Notifications" header to gentle section am: 9eb06333c4
am: 1e7f890c12

Change-Id: I4aa37806df85d082e88181defe67b581cf346ce0
2019-05-07 17:45:52 -07:00
Ned Burns
1e7f890c12 Add "Gentle Notifications" header to gentle section
am: 9eb06333c4

Change-Id: Ib283b0375bef39f1aa153db9f345135bdb72ce29
2019-05-07 14:45:15 -07:00
Ned Burns
31b02a613f Merge changes from topic "gentle-header" into qt-dev
* changes:
  Add "clear all" button to gentle notif section header
  Add "Gentle Notifications" header to gentle section
2019-05-07 21:13:31 +00:00
Ned Burns
9eb06333c4 Add "Gentle Notifications" header to gentle section
Missing "clear all" support, will add in later CL.

Test: manual

Bug: 131358199
Change-Id: I18aaacb1bf3f173b151bcac8df9dd953d0a7f513
2019-05-06 14:52:07 -04:00
Amin Shaikh
092e34c732 Merge "Update icon packs." into qt-dev am: 0452dcf0b4
am: bd35702425

Change-Id: I5cdc55a33c39a59c364b6936b50db9f68f6510be
2019-05-06 11:27:32 -07:00
TreeHugger Robot
0452dcf0b4 Merge "Update icon packs." into qt-dev 2019-05-06 17:47:51 +00:00
Mady Mellor
c1eafa6643 Merge "Follow up for a comment from ag/7080956" into qt-dev am: 66a23bf4f4
am: 1f86ad9b22

Change-Id: Ifc49d6be2c08e735b6a95d6cbfc6a4b62641a0f9
2019-05-04 08:55:03 -07:00
Sooraj Sasindran
7f4b359082 Merge "Make sure to read the opportunistic carrier display property" into qt-dev am: c3cfb0f702
am: 587c4f3919

Change-Id: I969cc05744aa443c5d3d3a6b00b433b9e1d9248d
2019-05-04 02:46:48 -07:00
Dave Mankoff
3142280d21 Merge "Change FalsingManager to an interface for easier swapping." into qt-dev am: c47b4a8d2a
am: c59926e5e1

Change-Id: I183d4844a25409409bb8695848bb9a283602e8e3
2019-05-04 00:26:57 -07:00
Mady Mellor
1a46bede13 Merge "Ensure the notification is removed when bubble is removed & fix cancel all" into qt-dev am: 8496f4eeef
am: 808091a285

Change-Id: I1b14d3f7a23aec3d8e883a6209567482ed6daed5
2019-05-03 21:34:27 -07:00
Mady Mellor
1a4e86fb33 Follow up for a comment from ag/7080956
Test: treehugger
Bug: 128459529
Change-Id: I79a559b3f992eae38bface74383a7a42d2261769
2019-05-04 02:25:25 +00:00
Robert Snoeberger
28943db454 Merge "Merge "Compute background color." into qt-dev am: a3fb334c6f" into qt-dev-plus-aosp
am: 237e648e43

Change-Id: I333db9fc9ac7587ab8708b94fcc5ff35fd8457e1
2019-05-03 18:41:09 -07:00
TreeHugger Robot
c3cfb0f702 Merge "Make sure to read the opportunistic carrier display property" into qt-dev 2019-05-04 00:27:22 +00:00
TreeHugger Robot
c47b4a8d2a Merge "Change FalsingManager to an interface for easier swapping." into qt-dev 2019-05-03 22:09:37 +00:00
Sooraj Sasindran
b7d633b4a6 Make sure to read the opportunistic carrier display property
Make sure to read the opportunistic carrier display property
Bug: 131849855
Test: verified that carrier text is displayed correctly

Change-Id: I93f9da8d0a9a8dae276370a0cca2df889229d4c3
2019-05-03 14:25:43 -07:00
Selim Cinek
c1f6e882d4 Merge "Merge "Fixed that clicking on the remoteinput didn't work from AOD" into qt-dev am: 70c8685a94" into qt-dev-plus-aosp
am: 388a7e0d82

Change-Id: Ib5e013cb7da9a007a28499e9a0b34d465a1037fb
2019-05-03 14:17:23 -07:00
Amin Shaikh
b7b4c25cad Update icon packs.
- Add back arrow for QS customizer
- Update work profile status bar / QS / corp badge icon to GM2
- Add Settings and Launcher overlay icons

Bug: 131346125
Test: visual
Change-Id: I61b56b04993ef19b5e66c9ad3d78eddcfce3aeb1
2019-05-03 14:29:54 -04:00
Amin Shaikh
377447b2d0 Merge "Merge "Add icon packs for themepicker." into qt-dev am: 2c09b3be23" into qt-dev-plus-aosp
am: b800b56398

Change-Id: I55c252e608a0bcdc78b83a0dd185a0d22562a504
2019-05-03 10:12:34 -07:00
Mady Mellor
8496f4eeef Merge "Ensure the notification is removed when bubble is removed & fix cancel all" into qt-dev 2019-05-03 17:06:39 +00:00
Sunny Goyal
42b9673254 Merge "Removing support for menu button from NavBar" into qt-dev am: 5b63fb978f
am: f71d4fd631

Change-Id: Idcbea3c1529b06b61504e3c8da4757579984ab33
2019-05-03 09:51:05 -07:00
Dave Mankoff
dde5ee6953 Change FalsingManager to an interface for easier swapping.
This is a refactor. It touches a lot of files, but zero functionality.
The primary change is changing FalsingManager.getInstance() into
FalsingManagerFactory.getInstance(); chaning FalsingManager into an
interface, and then turning the existing FalsingManager into
FalsingManagerImpl, an implementation of that interface. Other changes
are merely references to those classes.

Bug: 130256776
Test: atest SystemUITests
Change-Id: I5d64a7673e4efc554105dd841b27807361ed3828
2019-05-03 10:13:39 -04:00
Robert Snoeberger
a3fb334c6f Merge "Compute background color." into qt-dev 2019-05-03 12:55:57 +00:00
TreeHugger Robot
1bad5360b9 Merge "Acquire DockManager via dagger" into qt-dev 2019-05-03 07:33:37 +00:00
Mady Mellor
c2ff011d5f Ensure the notification is removed when bubble is removed & fix cancel all
Bubbles has some particular notification behaviour needs:

1) Whenever there is a bubble, the notif is kept around but may be hidden
   from the shade
2) When the bubble is dismissed, if the notif is no longer in the
   shade => really remove the notification
3) When the bubble is dismissed, if there is still a notification in the
   shade => notif stays around and is normal
4) Clear all should only hide the bubble notification, not remove the
   bubble
5) Apps canceling a notification that has a bubble will cancel the bubble

This CL does this by:

* Including the removal reason removeNotification path
* Adding a NotificationRemoveInterceptor that gets the option of overriding
  the removal
* BubbleController has this new interceptor and uses the removal reason
  to determine what should happen to the bubble & if the notification
  should be allowed to be removed
* When the bubble is dismissed, if the notif is no longer in the shade,
  then actually remove that notification

Test: atest BubbleControllerTest NotificationEntryManagerTest
Bug: 130347307
Bug: 130687293
Change-Id: I4459864a2ee5522076117f84ae37022bdfe4ee5d
2019-05-02 19:59:45 -07:00
TreeHugger Robot
60ca420b33 Merge "Acquire DockManager via dagger" 2019-05-03 02:37:52 +00:00
Lucas Dupin
65bcb4b011 Merge "Merge "Do not expand NPV when unoccluding with bouncer" into qt-dev am: 0e9667a356" into qt-dev-plus-aosp
am: 2d4b628673

Change-Id: Ia9cd7a339007c2fbccb19b0a3dbfd7f3453eaf8e
2019-05-02 18:08:52 -07:00
Lucas Dupin
931292f5ad Acquire DockManager via dagger
Bug: 123606744
Test: atest ClockManagerTest DozeDockHandlerTest DozeTriggersTest
Change-Id: I9439103c26797efe67cc0bf45b9cdfc9caccc479
2019-05-02 17:45:18 -07:00
Selim Cinek
70c8685a94 Merge "Fixed that clicking on the remoteinput didn't work from AOD" into qt-dev 2019-05-02 23:08:58 +00:00
Selim Cinek
f7d88932e2 Fixed that clicking on the remoteinput didn't work from AOD
Because we are freeing the AOD view, the view was not attached
to the window anymore and therefore we would not trigger the
remote input. Additionally if the expanded view was already showing
on AOD, we also wouldn't wait on it to become visible, also leading
to an issue where the user couldn't reply.
This also fixes an issue where the notificaiton would be invisible
if it was replied to in a group.

Fixes: 118365629
Fixes: 110072505
Change-Id: Ied33ed19eacc115006f5457f427acd4fefe0494b
2019-05-02 13:41:53 -07:00
Robert Snoeberger
fb1e926302 Compute background color.
Don't try to get it from the notification because the notification
is inflated in an async task.

Fixes: 130775480
Test: visual -- played music with GPM and checked background updated
Change-Id: I891f06b05b4ca4ba570a3b405fefa7b049f05cca
2019-05-02 15:17:17 -04:00
TreeHugger Robot
2c09b3be23 Merge "Add icon packs for themepicker." into qt-dev 2019-05-02 18:52:25 +00:00
TreeHugger Robot
5b63fb978f Merge "Removing support for menu button from NavBar" into qt-dev 2019-05-02 18:35:40 +00:00
Sunny Goyal
ded62f07cd Removing support for menu button from NavBar
Bug: 131763491
Test: Verfied menu button do not show on legacy app
Change-Id: If1091c00b768c08084c07e352f16e20fa3c90a02
2019-05-02 08:46:13 -07:00
Aaron Heuckroth
a9738ca5cd Merge "Add GlobalActionsColumnLayout to replace HardwareUILayout." into qt-dev am: dc22284752
am: d57ce8a73c

Change-Id: I14fb71a7d3f53e0449567e6418c00684271a0dc5
2019-05-02 00:37:03 -07:00
Tarandeep Singh
a4fc81ad18 Merge "Propagate light nav bar info" into qt-dev am: fabb5ebb59
am: bed3be618f

Change-Id: Idc3fb94e466179d7edd04aa23e34e49c5410e912
2019-05-01 22:26:27 -07:00
Selim Cinek
799464fc9b Merge "Made sure smart actions now launch also inline same as activity launches" into qt-dev am: 899e3ee0dc
am: 4b8a862449

Change-Id: I668706f70f58b01e2f43c3d22428cb7eb4885143
2019-05-01 21:37:22 -07:00
Matt Pape
55a51bf8d3 Merge "Migrate usage of single property lister to multi prop listener." into qt-dev am: 8e24abad64
am: 554e191d4b

Change-Id: Ibc55770e1e02ed4fb8a44c6f765ec080395068bf
2019-05-01 20:38:19 -07:00
Evan Laird
3cd55e27fc Merge "Re-enable dismiss in any direction" into qt-dev am: 34e3123201
am: a42cdc21c1

Change-Id: Ib6881e1ce5d39cdf1ed6ed4a0359de06b8a0137a
2019-05-01 20:22:43 -07:00
Fabian Kozynski
dd72dd05f8 Merge "Remove STOPSHIP code from CarrierTextControllerTest" into qt-dev am: 39ac1d5012
am: 7a734a376a

Change-Id: I32f41be2dbf3febd296ce3ea2a1fb580a6a9ffb7
2019-05-01 19:50:42 -07:00
Lucas Dupin
0e9667a356 Merge "Do not expand NPV when unoccluding with bouncer" into qt-dev 2019-05-02 01:48:55 +00:00
Chen Xu
a38f790ee1 Merge "Merge "improve mism support for phonestatelistner" into qt-dev am: 62751b8014" into qt-dev-plus-aosp
am: fd1359d926

Change-Id: I9dae41bb301e2ad2e717f20a7f7403c300575d5f
2019-05-01 15:16:42 -07:00
Lucas Dupin
e9e7071512 Do not expand NPV when unoccluding with bouncer
Otherwise the notification shade would be expanded behind the
the pin pad.

Test: manual
Test: atest StatusBarKeyguardViewManagerTest
Fixes: 120767257
Change-Id: Ic8f5e4477e75dddbefc5e2c5decd0f5a74289591
2019-05-01 14:41:49 -07:00
Aaron Heuckroth
dc22284752 Merge "Add GlobalActionsColumnLayout to replace HardwareUILayout." into qt-dev 2019-05-01 21:17:15 +00:00
TreeHugger Robot
fabb5ebb59 Merge "Propagate light nav bar info" into qt-dev 2019-05-01 18:44:39 +00:00
Julia Reynolds
898fbbe0f0 Merge "Another guts redesign" into qt-dev am: 69ca6f531e
am: 8065b7f518

Change-Id: I2fc5834d07f9f670b7e23fb6a7093c9b291d4233
2019-05-01 11:44:29 -07:00
Selim Cinek
899e3ee0dc Merge "Made sure smart actions now launch also inline same as activity launches" into qt-dev 2019-05-01 18:09:15 +00:00
Selim Cinek
ab4589a222 Made sure smart actions now launch also inline same as activity launches
This will make the association with smart actions closer. This changes
the transition when opening an action from a two step close shade - open app
to a direct animation into the app from the notification.

Fixes: 123591046
Test: atest SystemUiTests
Change-Id: I3c92aa20437ca7c37ef27ae6618df1959ef63137
2019-05-01 18:09:00 +00:00