Commit Graph

13379 Commits

Author SHA1 Message Date
Mike Digman
7980546c03 Merge "Clean up Sharesheet pinning, add app icon, remove DS pin menu" into rvc-dev 2020-05-21 20:05:58 +00:00
TreeHugger Robot
059d812ef9 Merge "Use shortcut long labels if available in Sharesheet" into rvc-dev 2020-05-21 19:01:42 +00:00
Mike Digman
64c704390d Clean up Sharesheet pinning, add app icon, remove DS pin menu
Remove "App info" item from all long-press menus as it's no
longer needed. Prevent DS targets from showing a long-press
menu. Simplify code surrounding this, in part, for future
migration to a popup menu.

Fixes: 157156399
Test: manual
Change-Id: I3e29e3dd46268cc344dcc93059f2bda1eeef32f1
2020-05-21 11:17:51 -07:00
Mike Digman
ed44706beb Use shortcut long labels if available in Sharesheet
For disambiguation between targets, it's important to see
the most detailed label provided by apps. This change is aligned
with the logic being used to display conversation shortcuts.

Fixes: 157142833
Test: manual
Change-Id: I203afc794730cac5c92717035af0ea47d8e6496b
2020-05-20 11:08:55 -07:00
TreeHugger Robot
606980b356 Merge "Fix talkback for switch on work in ResolverActivity" into rvc-dev 2020-05-20 17:55:54 +00:00
Kholoud Mohamed
77bc0f15e3 Fix talkback for switch on work in ResolverActivity
Set the focus to the work tab when switch on
work profile is clicked.

Fixes: 152014143
Test: Manually tested the bug no longer happens
Change-Id: Iba72f238cdaf564256648327d12a54c6227dd23b
2020-05-20 15:29:07 +01:00
Mike Digman
caec1a7440 Add pinned target indicator to Sharesheet, update visuals
After a user pins an app it takes up a persistent space in the
suggested app row. Users may forget they've pinned an app as
there's no indicator. Add an in-line icon to label suggested
targets as pinned. No indicator should be shown in the A-Z list.
This CL also updates related visual styling to get close to
redlines.

Bug: 150405021
Bug: 152978014
Test: manual
Change-Id: Iee774b88e284617449a673d7e622c0ce233ded1a
2020-05-18 12:13:21 -07:00
TreeHugger Robot
d96e01d282 Merge "In new direct share ranking, expand DS row as long as there are enough targets parking in memory, even if targets are still loading on UI." into rvc-dev 2020-05-18 14:56:34 +00:00
Song Hu
b548df99a7 In new direct share ranking, expand DS row as long as there are enough
targets parking in memory, even if targets are still loading on UI.

Backfill targets of top 8 apps into DS row instead of top 4, if the row
is not full.

Bug: 156470651
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Test: atest com.android.internal.app.ChooserActivityTest
Change-Id: Idefd6c225fca723d6d266b78ef41a4201483c634
2020-05-18 06:13:34 -07:00
TreeHugger Robot
28e8a2c0ca Merge "Adjust float-to-int brightness conversion to be purely in float." into rvc-dev 2020-05-18 12:47:31 +00:00
TreeHugger Robot
e79c1056b2 Merge "De-duplicate with callerTargets(added by using Intent.EXTRA_INITIAL_INTENTS) when adding DisplayResolveInfo." into rvc-dev 2020-05-15 23:10:41 +00:00
Mike Digman
0b079c3383 Merge "Add app grouping indicators to Sharesheet" into rvc-dev 2020-05-15 21:54:16 +00:00
TreeHugger Robot
16715e7f85 Merge "Remove QS details prototype code" into rvc-dev 2020-05-15 21:10:37 +00:00
TreeHugger Robot
12ea0e4d4a Merge "Correct Sharesheet icon and badge sizing" into rvc-dev 2020-05-15 20:42:21 +00:00
Mike Digman
438d1320f1 Add app grouping indicators to Sharesheet
When an app publishes multiple share targets those are now
grouped under a single target. However, there is no visual
indicator of grouping. This adds that in.

Test: manual, custom built apks for testing
Fixes: 150481688
Change-Id: Ibf72cec3a337a71387928d30126b286519f03f73
2020-05-15 12:05:32 -07:00
Song Hu
276e384e4c De-duplicate with callerTargets(added by using Intent.EXTRA_INITIAL_INTENTS) when adding DisplayResolveInfo.
Bug: 154611479
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Change-Id: I812c8275fc6f12ad52f56419eedd0c580530704a
2020-05-15 10:01:52 -07:00
Santos Cordon
ed5a8fe9b7 Adjust float-to-int brightness conversion to be purely in float.
By converting to int and back as part of the final steps in sending the
brightness to the HAL, we undo the whole benefit of having floating
point brightness.  This change alters the conversion to an int-range
without using the int-primitives. This helps maintain the existing
precision.

Bug: 155875691
Test: Manually verify with logs that the float value isn't altered
before going to the HAL (it previously was).
Test: atest CtsDisplayTestCases
Test: atest DisplayManagerServiceTests
Change-Id: Ibf2f8d00c575d440c3fe437b32c0613bcd471c2a

Change-Id: Ie9569efb7b951c15ffcf2306ff9f864f858df8b1
2020-05-15 17:52:52 +01:00
Fabian Kozynski
36ddca1cf3 Remove QS details prototype code
Also remove some other leftover prototype code

Test: manual
Fixes: 156645457
Change-Id: I21f442b2501f00c78c51826a805e7be91a214c7d
2020-05-14 15:57:40 -04:00
Matt Pietal
c9544a7e92 Sharesheet - Fix app stacking
When there was greater than 2 candidates for app stacking, the prior
targets would get dropped.

Bug: 156220800
Test: atest ChooserActivityTest
Change-Id: Ia8494bb81e95c5415d080148a0c4f98bd243c142
2020-05-13 21:19:40 -04:00
Mike Digman
d45a8b5d60 Correct Sharesheet icon and badge sizing
SimpleIconFactory previously used fixed resources to render
icons and badges. Resolver and Chooser need different icon and
badge dimensions. This cause scaling issues. Move those sizes to
a styleable attr. New dimensions align with design red lines.

Test: manual
Fixes: 155813501
Change-Id: I765ba7aab1346eacf9e1cf7b6cdbfbbb14dbc3bb
2020-05-13 12:32:19 -07:00
Antoan Angelov
b98da91c63 Merge "Initialize workProfileUserHandle before initial check for work tabs" into rvc-dev 2020-05-13 18:06:06 +00:00
Miranda Kephart
a4b9474647 Merge "Fix NPE in ScreenshotHelper" into rvc-dev 2020-05-13 16:20:14 +00:00
arangelov
8519218a73 Initialize workProfileUserHandle before initial check for work tabs
The shouldShowTabs() call checks for the existence of the work
profile user, which is actually initialized after that call.

Fixes: 156462936
Test: manual
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Change-Id: Iff840826f7b008420f1a254c1044c05c27764d0c
2020-05-13 13:59:22 +00:00
TreeHugger Robot
f4fa3eb9fa Merge "Hide the top intent resolver divider when there are tabs" into rvc-dev 2020-05-13 12:41:43 +00:00
TreeHugger Robot
58c274fdcb Merge "When android:ui process receives callback result of AppPredictionService sortTargets, directly handles result instead of sending to Handler which takes extra time to dispatch messages." into rvc-dev 2020-05-13 00:57:28 +00:00
Beverly Tai
3fb4151b06 Merge "Inject LockPatternUtils into KeyguardUpdateMonitor" into rvc-dev 2020-05-12 22:40:44 +00:00
TreeHugger Robot
f30c225fcb Merge "Add OWNERS for display, haptics, input and power" into rvc-dev 2020-05-12 20:17:39 +00:00
Michael Wright
2e7e81c950 Add OWNERS for display, haptics, input and power
Bug: 156349083
Test: N/A
Change-Id: Ia8afccfc2e470095ae3d52c827c0ac78b7c120ae
2020-05-12 19:11:13 +01:00
Miranda Kephart
cc92b9c370 Fix NPE in ScreenshotHelper
Check for null before unbinding the screenshot process.

Test: manual
Bug: 155726862
Change-Id: Ica1cc521b6a510b5e15e42e1e2a87ebf613a53aa
2020-05-12 13:47:33 -04:00
Beverly
f882ee2164 Inject LockPatternUtils into KeyguardUpdateMonitor
For better testability of KeyguardUpdateMonitor. We don't actually want
to register callbacks to the real lock settings. But if we ever do in
tests, we make sure to cleanup the callbacks in
KeyguardUpdateMonitor.destroy().

Test: atest SystemUITests
Fixes: 156230507
Change-Id: I2548c15da29ef5a15f6d3b512fbfd344ca2bd355
2020-05-12 12:59:13 -04:00
Menghan Li
084b2de544 Merge "Refines volume key shortcut confirm dialog strings" into rvc-dev 2020-05-12 16:10:51 +00:00
menghanli
3cba1dc1c5 Refines volume key shortcut confirm dialog strings
- Provide more clear content for single and multiple services are
enabled.
- Avoid non-a11y users accidentally turning shortcut on without
reading this carefully. Hence we put "don't turn on" as the
primary action.

Bug: 155249323
Bug: 138582063
Test: atest AccessibilityShortcutControllerTest
Change-Id: I1c391bb0516bcebfbf6161b94cc0c0b80e0bb72f
2020-05-12 16:05:50 +00:00
Abhijeet Kaur
e0ae189f8a Merge "Add manage mode workflow for ExternalStorageProvider" into rvc-dev 2020-05-12 14:39:19 +00:00
Alex Kershaw
760754ec61 Hide the top intent resolver divider when there are tabs
Fixes: 155174577
Test: manual
Change-Id: If35f4902e793767cbd38e1f5770d55c4e7b22872
2020-05-12 12:02:42 +01:00
Antoan Angelov
ff779f6d8e Merge "Don't show layout with default if in tabbed view" into rvc-dev 2020-05-11 14:49:18 +00:00
Abhijeet Kaur
553625de0a Add manage mode workflow for ExternalStorageProvider
In Scoped Storage world, access to "Android/data" style directories are
hidden for privacy reasons. Allow ExternalStorageProvider to show these
hidden files when in manage mode.

Bug: 150366834
Test: Android/data and Android/obb is visible from Files App, but are
hidden in Picker view from StorageTestApp and Gmail (GMAIL > Compose >
Attach > Go to Pixel > Android)

Change-Id: I58b4fc23d9b479df4fc0480ae55f1f2070d0cb7c
2020-05-11 11:39:40 +01:00
Jason Hsu
5c8f27a56e Merge "Logs accessibility shortcut behavior." into rvc-dev 2020-05-10 03:06:30 +00:00
jasonwshsu
d9aa03245c Logs accessibility shortcut behavior.
* Uses the atom AccessibilityShortcutReported in westworld.

Bug: 151285965
Test: make statsd_testdrive && ./out/host/linux-x86/bin/statsd_testdrive 266
Change-Id: Iba9d829ae35c7a336c38007101bdddfcd3dc2ddb
2020-05-09 22:31:05 +08:00
Song Hu
0debe440bd When android:ui process receives callback result of AppPredictionService sortTargets, directly handles result instead of sending to Handler which takes extra time to dispatch messages.
Bug: 155551642
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Test: manually test on the device
Change-Id: I7a28dbebfb4bf9cdf1fe27dd224c72ef9b44f2fe
2020-05-08 10:24:51 -07:00
Kevin Chyn
f67a780c33 Merge "[DO NOT MERGE] Add sysUiSessionId between BiometricService and AuthController" into rvc-dev 2020-05-07 23:22:02 +00:00
Kevin Chyn
fa7069d83c [DO NOT MERGE] Add sysUiSessionId between BiometricService and AuthController
Bug: 155420058

Test: BiometricPromptDemo, inspect logs

Change-Id: I47cffa4e8acb1e5f098572d26e47882ff5e9be26
2020-05-07 14:06:57 -07:00
arangelov
aa307e28ca Don't show layout with default if in tabbed view
Fixes: 155890640
Fixes: 150939321
Test: atest ChooserActivityTest
Test: atest ResolverActivityTest
Test: manually verified default layout is not shown

Change-Id: I11c543331b44039a7a2ae85a1b2a67b8525739a4
2020-05-07 16:16:45 +01:00
Matt Pietal
2f16758a0a Merge "Sharesheet/Resolver a11y adjustments" into rvc-dev 2020-05-07 11:38:59 +00:00
Antoan Angelov
afbd12c4ed Merge "Fix sharesheet scroll jankiness." into rvc-dev 2020-05-07 10:56:05 +00:00
Feng Cao
254545cae5 Merge "Support re-attaching the inline suggestion view to window" into rvc-dev 2020-05-07 05:23:15 +00:00
Feng Cao
b46851c964 Support re-attaching the inline suggestion view to window
* Before this change, when the inline suggestion view is detached from
  the IME window (e.g. due to layout change), the remote view content
  will not show again even after the view is reattached to the window
  on the IME side. This patch fixes it by requesting the remote view
  owner (the ext services) for a new SurfacePackage when the view is
  re-attached to the window (see javadoc of SurfaceControlViewHost for
  why this works).
* This patch also fixes the issue where the SurfaceControlViewHost was
  never released in the ext services. This is done by notifying the
  ext services (through system server) when the view is detached from
  the IME window, and then the system server will release the
  SurfaceControlViewHost if after N(=500) ms the view is not re-attached
  to a window.
* After the SurfaceControlViewHost is released, if the view is
  re-attached to the window later, a new SurfaceControlViewHost will be
  created to back the same InlineContentView.
* The current code structure also lays a foundation for a subsequent
  change to allow reusing the same remote view for inline suggestions
  during filtering.

Test: atest CtsAutofillServiceTestCases (sanity test)

Bug: 153615023
Bug: 154683107

Change-Id: Idc587e1e82a96b792c351796464821b7aad7cd89
2020-05-06 19:30:39 -07:00
Ben Lin
c43997ba15 Merge "Enforce max size for resizing operations." into rvc-dev 2020-05-06 21:17:02 +00:00
Matt Pietal
877b5ec262 Sharesheet/Resolver a11y adjustments
1. Announce app name with direct share targets
2. Don't speak 'heading' in direct share rows
3. Don't close resolver/sharesheet when swiping left
4. Talkback will announce # of rows and columns for sharesheet

Fixes: 141908464
Fixes: 155153657
Fixes: 151897812
Fixes: 149437892
Fixes: 80319063
Test: talkback
Change-Id: I16586208407ba56814d3cf69648e660bded72ccf
2020-05-06 15:27:54 -04:00
Song Hu
f52438f9a2 Merge "Send onCreatePredictionSession, sortAppTargets, requestPredictionUpdate immediately instead of sending them to main thread Looper queue of ChooserActivity." into rvc-dev 2020-05-06 19:03:46 +00:00
Song Hu
d52863d12b Send onCreatePredictionSession, sortAppTargets, requestPredictionUpdate
immediately instead of sending them to main thread Looper queue of
ChooserActivity.

These methods are relatively latency-sensitive. When main thread Looper queue has many backlogs, it takes long time
to dispatch requests.

Bug: 155551642
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Test: manually test on the device
Change-Id: I7d00e49c6a30fec478e620bc98180d379f801fc8
2020-05-06 10:17:29 -07:00