Commit Graph

9919 Commits

Author SHA1 Message Date
Rob Carr
93d5c06222 Merge "Preserve non-floating state when entering pinned stack." into oc-dev am: f5b6818009
am: dff4323f01

Change-Id: Ie007a26d4d0264f5a0609cbc0996a5a509734382
2017-05-16 01:28:14 +00:00
Rob Carr
f5b6818009 Merge "Preserve non-floating state when entering pinned stack." into oc-dev 2017-05-15 23:17:33 +00:00
Phil Weaver
5649d3e93b Merge "Add null check to a11y call." into oc-dev am: 9289faa163
am: 6f40533f4e

Change-Id: I096085f2da8bdde5b53167d25d0beabcb3d491cb
2017-05-15 17:13:49 +00:00
Phil Weaver
9289faa163 Merge "Add null check to a11y call." into oc-dev 2017-05-15 16:56:29 +00:00
Felipe Leme
316a22bd3f Start a new session on manual request after session is "gone". am: 7f33cd350b
am: 4f87698d30

Change-Id: I9d6ecfde09c79e53624750fdc574d17869980403
2017-05-14 09:51:36 +00:00
Felipe Leme
7f33cd350b Start a new session on manual request after session is "gone".
When the autofill service returns a null FillResponse, the session is marked
"gone" because the service cannot autofill it. But there might be cases where
the view structure change and it's now autofillable, so need to allow users
to manually request autofill again in such cases.

Fixes: 38205945
Test: CtsAutoFillServiceTestCases pass
Test: LoginActivityTest.testAutofillManuallyAfterServiceReturnedNoDatasets()
Test: LoginActivityTest.testAutofillManuallyAndSaveAfterServiceReturnedNoDatasets()

Change-Id: I9b23c255e563dd0646bf266d31ddb10dcc4f7f6d
2017-05-14 00:31:45 -07:00
Jason Monk
780ae3595c Merge "Fix the status icon colors in QS" into oc-dev am: d472349229
am: e093068eb1

Change-Id: I2bbe4b8dc4f0e9173d00129e8b25a4ccb3977188
2017-05-13 13:22:13 +00:00
Jason Monk
d472349229 Merge "Fix the status icon colors in QS" into oc-dev 2017-05-13 13:10:58 +00:00
Felipe Leme
abdcd76fda Merge "Couple autofill fixes." into oc-dev am: 5fd8672d71
am: 9b32a707f2

Change-Id: I7c565e7896055ecae4f48716ff166087df39e8a8
2017-05-13 04:05:44 +00:00
TreeHugger Robot
5fd8672d71 Merge "Couple autofill fixes." into oc-dev 2017-05-13 03:54:23 +00:00
Abodunrinwa Toki
a0f4621b5d Merge "TextClassifier: Ensure url scheme is in lowercase" into oc-dev am: ebd6bb561d
am: 3f940359c5

Change-Id: I063bb700b07b4341019b557251bde6d053d011e1
2017-05-12 23:18:39 +00:00
Abodunrinwa Toki
ebd6bb561d Merge "TextClassifier: Ensure url scheme is in lowercase" into oc-dev 2017-05-12 22:50:54 +00:00
Felipe Leme
7a1deb7c5f Couple autofill fixes.
- Fixed PFLAG3_NOTIFY_AUTOFILL_ENTER_ON_LAYOUT value - it was overlapping with
PFLAG3_ASSIST_BLOCKED.
- Added missing permission on methods called by Shell command.
- Improved debugging.

Bug: 38173625

Test: android.autofillservice.cts.MultipleFragmentLoginTest#loginOnTwoFragments

Change-Id: Ie7880c97d38298e06134709c5c2e9e38fa1bacbb
2017-05-12 15:34:48 -07:00
Felipe Leme
321a829b4b Merge "Removed deprecated APIs." into oc-dev am: 4b91fe8699
am: 3eee11cb4d

Change-Id: I39859572bfd0b8e34d02ad96147364e0f4ce2ee5
2017-05-12 20:41:35 +00:00
Philip P. Moltmann
15a028c929 Merge "Not specify return val of View#onSaveInstanceState" into oc-dev am: 1454afce82
am: 89d98d34cb

Change-Id: I93d3cbb6e0b6e7bbc7a535c0ebf437c16319075f
2017-05-12 20:27:57 +00:00
Jason Monk
9a376bcd45 Fix the status icon colors in QS
Requires lots of theming magic

Test: visual
Change-Id: I1cd28b570f30989b496065c0e06a5aca461deb41
Fixes: 37619734
2017-05-12 16:16:39 -04:00
TreeHugger Robot
4b91fe8699 Merge "Removed deprecated APIs." into oc-dev 2017-05-12 20:13:15 +00:00
TreeHugger Robot
1454afce82 Merge "Not specify return val of View#onSaveInstanceState" into oc-dev 2017-05-12 19:14:53 +00:00
Phil Weaver
63e4503991 Add null check to a11y call.
No good will come from posting that a null View has
changed. Adding a null check so the failure will happen
when the bad call is made, rather than later when we
try to act on it in a handler.

Bug: 38122973
Test: Ran accessibility unit and cts tests.
Change-Id: I1e9aaf2a18180fcdfd0fbc0e5b716eb96446af33
2017-05-12 10:40:53 -07:00
Felipe Leme
73fedacfeb Removed deprecated APIs.
Test: CtsAutoFillServiceTestCases pass
Test: manual verification with existing service

Bug: 37563972

Change-Id: Ibea2810f9230f06e59d2d81e4ba853de54987956
2017-05-12 10:32:45 -07:00
Abodunrinwa Toki
86ef9827da TextClassifier: Ensure url scheme is in lowercase
packageManager.resolveActivity(intentWithUppercaseScheme, 0) returns null.
 This means we don't find an activity to handle the browser intent.
 Create a browser intent with url's scheme in lowercase instead.

Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Fixes: 36504599
Change-Id: Idb0c5b73d54cf77d5d6fb4ee0af4478ec11e8b82
2017-05-12 13:13:25 +01:00
Abodunrinwa Toki
d7e4ef1ffb Merge "TRON: Count smart selection events." into oc-dev am: 6bf9b9a5f3
am: 1609833a2d

Change-Id: Ie7ccac9d9f93b69944d868be738bd37bfe37931d
2017-05-12 12:07:13 +00:00
TreeHugger Robot
6bf9b9a5f3 Merge "TRON: Count smart selection events." into oc-dev 2017-05-12 11:54:37 +00:00
Evan Rosky
5f607f135a Merge "Merge "Only save focus in keyboard navigation clusters when appropriate" into oc-dev am: f14aea9f8b" into oc-dev-plus-aosp
am: 4b5e7163ac

Change-Id: Iabddf8006df6b06eaa6349d8299259f5f3496146
2017-05-12 05:05:11 +00:00
Svet Ganov
45bd1bbd33 Merge "Detect isVisibleToUser post layout" into oc-dev am: a7af385208
am: 73d5b089b9

Change-Id: I1369c5ccb51f7b147144a4cd3576729f920e5bbd
2017-05-12 02:06:50 +00:00
Philip P. Moltmann
517bafa59d Not specify return val of View#onSaveInstanceState
.. as the comment was incorrect since a long time.

Bug: 37802299
Test: compiled
Change-Id: I10fe0b1c0f7f4ccaade38c87136a3785f2685798
2017-05-11 15:32:15 -07:00
Evan Rosky
f14aea9f8b Merge "Only save focus in keyboard navigation clusters when appropriate" into oc-dev 2017-05-11 22:26:18 +00:00
Abodunrinwa Toki
1d77557517 TRON: Count smart selection events.
Logs:
 - Smart selection occured
 - TextView menu item activated on smart selection
 - Smart selection reset
 - Smart selection modified

Test: Manually checked logging happens as per go/tron-howto and verified
nothing is broken in related classes by running:
bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
bit FrameworksCoreTests:android.widget.TextViewActivityTest

Bug: 32572232
Change-Id: Ia9081d92ae9aea50d863455be770eecd0c73be1a
2017-05-11 23:04:29 +01:00
TreeHugger Robot
a7af385208 Merge "Detect isVisibleToUser post layout" into oc-dev 2017-05-11 20:38:28 +00:00
Albert Chaulk
bcee3cc3fa Merge "Propagate UIDs for all SurfaceControl instances" into oc-dev am: 6c34dd58f6
am: eccbbe4ca2

Change-Id: I350bb7899eaa1e9919d6fdf8079afd11be4e9918
2017-05-11 15:52:48 +00:00
Albert Chaulk
6c34dd58f6 Merge "Propagate UIDs for all SurfaceControl instances" into oc-dev 2017-05-11 15:19:28 +00:00
Derek Sollenberger
ef16269e41 Merge "Add an O-release targetAPI check for Canvas.setBitmap. am: d70695ee34" into oc-dev-plus-aosp
am: 172bd07308

Change-Id: Iddc0babe08b2e1a9abe1bebe117fa66832417cff
2017-05-11 14:56:32 +00:00
Derek Sollenberger
d70695ee34 Add an O-release targetAPI check for Canvas.setBitmap.
For apps targeting releases earlier than O setBitmap will attempt
to preserve the matrix from the previous bitmap.  It does not however
attempt to reconstruct the save/restore stack or the clip.

Test: manual test of messenger app referenced in the bug
Bug: 37589964
Change-Id: I67f0928a3f84a8be41da38ef1868e79bdeb03e46
2017-05-11 09:28:02 -04:00
Phil Weaver
c3a67fca97 Merge "Remove outdated security note from A11yEvent" into oc-dev am: ea60efa8ef
am: 052bf032cb

Change-Id: I0ef433251e0e53af6ed00a34433cdea0edaf18eb
2017-05-11 09:20:31 +00:00
Phil Weaver
066fdf5d3f Merge "Clarify documentation for notification a11y events" into oc-dev am: 69a0f3f020
am: ce67e46e9a

Change-Id: I4ce14090b8a203f838dbb3d9fb18b2225ac053ce
2017-05-11 07:15:45 +00:00
Svet Ganov
84390348ea Merge "Properly position dataset picker UI" into oc-dev am: d915aecfaa
am: d0bfa95b4c

Change-Id: I8387cbce6e288c02a5e469dc80245528ae2381e1
2017-05-11 07:08:00 +00:00
Svet Ganov
68f583879f Detect isVisibleToUser post layout
Test: MiltipleFragmentsLogin test no longer fails.
      All auto fill CTS tests pass.

bug:38173625

Change-Id: I6e36229bc9517c7339c77cbc5f236e8399ef4283
2017-05-10 20:11:45 -07:00
TreeHugger Robot
ea60efa8ef Merge "Remove outdated security note from A11yEvent" into oc-dev 2017-05-11 02:27:19 +00:00
TreeHugger Robot
69a0f3f020 Merge "Clarify documentation for notification a11y events" into oc-dev 2017-05-11 01:57:08 +00:00
Albert Chaulk
e4338f843b Propagate UIDs for all SurfaceControl instances
Previously, a default value was being propagated for surfaces constructed
though paths other than WindowManagerService.createSurfaceControl. This
allows us to handle all surfaces in VR in a better way

Bug: 36589137
Test: Launch chrome (uses SurfaceView)
Change-Id: I8434c356ebe51173cae161ec1405e3d5f9a17723
2017-05-10 20:13:09 -04:00
Svet Ganov
374cae1e61 Properly position dataset picker UI
Test: all autofill CTS tests pass

bug:37958210
bug:37986800

Change-Id: Ic2cb3b8c6762a922bdb7c632e451772b7a006739
2017-05-10 23:38:51 +00:00
Robert Carr
18f622f08c Preserve non-floating state when entering pinned stack.
When transitioning between the fullscreen and pinned states
we often have a situation where we go from having a navigation and
status bar in the window to not. We'd like to use the source bounds
animation to crop these out rather than a sudden jump or scaling
but in order to do so we need to ensure they last until the end
of the animation. We track this state, and return the appropriate
value from isFloating. Furthermore, we add support to the bounds
animation to use the content frame as a source bounds when there
is no source bounds present, this means that we can crop out the
navigation and status bar so they will be invisible by the end of
the animation.

Bug: 37531386
Test: Manual
Change-Id: I72c549e3a3318534428d17b68ebee5832c32e6d7
2017-05-10 15:16:17 -07:00
Svetoslav Ganov
2b3385ab9d Merge "Allow null fill values to support authentication case" into oc-dev am: 90bcc1c8bc
am: 0e4f1bab09

Change-Id: I4f95cb012fd5d8b96c2beb097aa3b09c8c557b74
2017-05-10 06:43:26 +00:00
Svetoslav Ganov
a9379d0b44 Allow null fill values to support authentication case
If a dataset needs to be authenticated the fill service
may not have the values but needs to tell the system for
which fields to show the fill UI. We now allow passing
a null value to mean the view is a part of the dataset
semantically but its value should remain unchanged.

If a dataset has no values, i.e. the related autofill ids
are mapped to null, we cannot properly filter. In this case
we always match such items regardless what the user typed.

While at this improved accessibility support for filtering
to announce when the number of items being filtered changes.

Also while at this allowed a dataset authentication to return
a response which replaces the current response and refreshes
the UI. Matching datasets with null values to any text plus
allowing a response to be returned from a dataset auth enables
the use case where there is always "Import" item at the
end of the list which when clicked can show arbitrarily more
data entries associated to other apps.

Another change is that we now provide the client state
bundle on both request and dataset auth.

Finally, this change gets rid of dataset waiting auth and
response waiting auth concepts since the reference to the
response and the dataset is piped with the auth request.

Fixed a bug where the width of the autofill UI was not
properly measured by going over all items in the adapter.
Now we measure enough height to fit the first three and the
width id the width of the widest item in the adapter.

Test: Added LoginActivityTest#testDatasetAuthTwoFieldsReplaceResponse
      Added LoginActivityTest#testDatasetAuthTwoFieldsNoValues
      Added LiginActivityTest#filterTextNullValuesAlwaysMatched
      All autofill CTS tests pass

bug:37724701
bug:37424539

Change-Id: Ic19e5d7cbdbb7d110c9e7da0ad60b540cbf1aecf
2017-05-09 17:40:28 -07:00
Phil Weaver
33c7136dde Clarify documentation for notification a11y events
This javadoc was confusing the TalkBack team, so I've
clarified that these events can come from either a
notification or a toast. I also removed a note that I
found confusing and, as far as I could tell, was not
correct anyway.

Bug: 34851364
Test: Docs changes only. Relying on TreeHugger.
Change-Id: Ie5c6efd6e32ce1e33f8cc45c795cda7d7b2e6583
2017-05-09 16:17:02 -07:00
Rob Carr
bb8131b1d7 Merge "SurfaceView: Release Surface with SurfaceControl." into oc-dev am: 3630fd4e11
am: 9cbe611f4a

Change-Id: I1b18f556b4b42f81ddca69ae5ce420d7a612bf6b
2017-05-09 17:14:05 +00:00
Phil Weaver
2bd8bdc89f Merge "NumberPicker a11y (and a11y-inspired) fixes" into oc-dev am: 8d25b77e4c
am: bcc047ca4f

Change-Id: I7814872b4f530ed408587887225243a3fc1c59ce
2017-05-09 17:10:02 +00:00
Phil Weaver
2cb0972340 Merge "Fix crash in a11y cache" into oc-dev am: 64d6e3e11d
am: 2af1fda3ca

Change-Id: Ib2aaaf46de7a402e34288ea9dcad45b9b2ba55eb
2017-05-09 16:46:34 +00:00
Rob Carr
3630fd4e11 Merge "SurfaceView: Release Surface with SurfaceControl." into oc-dev 2017-05-09 15:49:29 +00:00
Phil Weaver
8d25b77e4c Merge "NumberPicker a11y (and a11y-inspired) fixes" into oc-dev 2017-05-09 15:36:00 +00:00