Commit Graph

11508 Commits

Author SHA1 Message Date
Vishnu Nair
aeab1b8251 SF: Remove setFinalCrop impl 1/2
setFinalCrop functionality is reimplemented by creating a new bounds layer
and applying a crop on this layer. see ag/4625718

Test: go/wm-smoke

Change-Id: I3ffb6dc2e2afd5170f6c6dee9e928ed0600656b1
2018-08-29 08:37:38 -07:00
TreeHugger Robot
1545cd72a2 Merge "Remove IInputMethodClient.setUsingInputMethod()" 2018-08-28 20:33:18 +00:00
Yohei Yukawa
68723904fb Remove IInputMethodClient.setUsingInputMethod()
This is a no-op method.

Bug: 112722651
Test: compile
Test: atest CtsInputMethodTestCases CtsInputMethodServiceHostTestCases
Change-Id: Ic990588c868f9173bbbe73dcfc5b193642dcc294
2018-08-28 11:37:09 -07:00
Robert Carr
b6cd643969 Implement construction of container layers
Expose existing native functionality. In preparation for use as
bufferless-input-catching-surfaces.

Bug: 80101428
Bug: 113136004
Bug: 111440400
Change-Id: I455792aec3ee58d9dd20016b484ce7c27808d522
2018-08-27 18:14:14 -07:00
Ryan Mitchell
b9b540baf1 AFW: Lookup shared library resource ids
Shared libraries were failing to retrieve correct resource ids from the
values of attributes in xml files. The packages of the shared ids were
not changed from 0 to their runtime assigned package ids.

Bug: 112776204
Test: atest FieldsClassificationTest#testGetAlgorithm
Change-Id: I509bc7632f5ec3e9b644e590934e6cf569a4d938
2018-08-24 10:11:01 -07:00
TreeHugger Robot
ed037dbf41 Merge "Prevent ViewRootImpl.mDisplay become null." 2018-08-23 00:29:11 +00:00
Phil Weaver
1f089e605a Merge "Stop leaking view during a11y sorting" 2018-08-22 16:54:46 +00:00
wilsonshih
0042e4516f Prevent ViewRootImpl.mDisplay become null.
For some timing cases client side may not get desired display with old
displayId.
For this issue, client side has just received configuration change and
handle it in ActivityThread#handleActivityConfigurationChanged. At the
same time, DisplayManagerService was about to destory display. When
ViewRootImpl want to update display with new DisplayAdjustments, it got
null because the old displayId was removed.
For this scenario, fallback to use default display. Usually there should
be other displayId change event comes from server side to ask client update.

Change-Id: Ifb843f82b753761cb6306e7482b38a0ffd89498d
Fix: 73558361
Test: atest CtsWindowManagerDeviceTestCases
Test: atest CtsActivityManagerDeviceTestCases
2018-08-22 09:43:55 +08:00
Phil Weaver
6adf3a18e4 Stop leaking view during a11y sorting
I added a reference to a view in a pooled object,
but did not clear the reference to it when releasing it.
Thus the links to the View (and its Context) live as long
at the static object.

This code is only called when accessibility is on.

Bug: 112792715
Test: make
Change-Id: If716c33b91aac3a1da5fd4a857daa5b4b9b7e151
2018-08-21 16:08:42 -07:00
Lucas Dupin
96d9c3f91e Merge "Do not allow wallpapers that are too large" 2018-08-21 21:30:01 +00:00
Adrian Roos
031546664b Merge "Cutout: Add developer setting to mask the display cutout" into pi-dev am: c05c2d1e48
am: 6a403d8d5b

Change-Id: Ifc872c48e4670183f1f0fd3a4162d1eeb6c5c5e4
2018-08-21 13:38:33 -07:00
Adrian Roos
6a403d8d5b Merge "Cutout: Add developer setting to mask the display cutout" into pi-dev
am: c05c2d1e48

Change-Id: I728ce64b53d02f5a75f04071a04f5e6d0f61987c
2018-08-21 13:11:53 -07:00
Adrian Roos
c05c2d1e48 Merge "Cutout: Add developer setting to mask the display cutout" into pi-dev 2018-08-21 19:51:58 +00:00
Adrian Roos
8c28c7c2d9 Cutout: Add developer setting to mask the display cutout
Adds an option to mask the cutout by effectively shrinking the logical display
such that developers can test apps as if the device did not have a notch.

Bug: 112876936
Test: Go to Settings > Developer Options > Simulate display with cutout > "No cutout". Cutout should be hidden. Rotate screen, take screenshots, screenrecord, screen off animation should all work as expected.
Change-Id: I5cdb201734d238bf3785ab55843114e4b5b4ee41
2018-08-21 21:47:51 +02:00
Lucas Dupin
d8e1244225 Do not allow wallpapers that are too large
DisplayListCanvas, that draws Bitmaps on the Android framework,
has a bitmap size limit. Let's respect the limit to guarantee
that SystemUI won't crashloop when a bitmap is over 100MB

Test: manual, setting wallpaper
Change-Id: Iff91e73722a912efe095f80e263e160cc2456a11
Fixes: 111330638
2018-08-21 09:20:48 -07:00
Mathew Inwood
532fa6656d resolve merge conflicts of 597229d681 to stage-aosp-master
am: ec73e7514f

Change-Id: I9e65a3550b6ee6e266410519db2fcb41f666ad80
2018-08-21 02:48:25 -07:00
Mathew Inwood
ec73e7514f resolve merge conflicts of 597229d681 to stage-aosp-master
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I0807ae67e0ed3e84f17af962dc8b7a3152f8103f
Merged-In: I4147b038ed7adf0311ee9918b44766f82a057eaf
2018-08-21 09:31:16 +01:00
Felipe Leme
dde594d606 Merge "Improved AutofillManager and Activity dump() methods:" into pi-dev
am: c9443e3894

Change-Id: I1fc878c1ff3dbd204c619c1514e989399dd51895
2018-08-20 18:38:29 -07:00
TreeHugger Robot
c9443e3894 Merge "Improved AutofillManager and Activity dump() methods:" into pi-dev 2018-08-21 01:18:09 +00:00
Felipe Leme
7fa1e0b408 Merge "Log AutofillClient on CompatibilityBridge.onAccessibilityEvent()." into pi-dev
am: db7648f374

Change-Id: Iba6484c33a6c272304be097a773b96d0d6f45550
2018-08-20 13:56:24 -07:00
TreeHugger Robot
db7648f374 Merge "Log AutofillClient on CompatibilityBridge.onAccessibilityEvent()." into pi-dev 2018-08-20 20:29:21 +00:00
Felipe Leme
cf612f44ab Merge "Log CompatibilityBridge.onAccessibilityEvent()" into pi-dev
am: e4d35b6dc0

Change-Id: I62f3895c3fb448faad084507615f7a09a5b5af96
2018-08-20 12:32:02 -07:00
TreeHugger Robot
e4d35b6dc0 Merge "Log CompatibilityBridge.onAccessibilityEvent()" into pi-dev 2018-08-20 19:07:10 +00:00
Mathew Inwood
e5ad598d11 Add @UnsupportedAppUsage annotations
For packages:
  android.view.textservice
  android.view.textclassifier.logging
  android.view.textclassifier
  android.view.inputmethod
  android.view.autofill
  android.view.accessibility
  android.view

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: Ie4663ebd4640b2893e575e599582d2c9530da313
Merged-In: I4147b038ed7adf0311ee9918b44766f82a057eaf
2018-08-20 14:52:19 +01:00
TreeHugger Robot
b2484fa070 Merge "Add TestApi for CtsActivityManagerDeviceTestCases." 2018-08-20 13:30:18 +00:00
Mathew Inwood
a570dee977 Add @UnsupportedAppUsage annotations
For packages:
  android.view.textservice
  android.view.textclassifier.logging
  android.view.textclassifier
  android.view.inputmethod
  android.view.autofill
  android.view.accessibility
  android.view

This is an automatically generated CL. See go/UnsupportedAppUsage
for more details.

Exempted-From-Owner-Approval: Mechanical changes to the codebase
which have been approved by Android API council and announced on
android-eng@

Bug: 110868826
Test: m
Change-Id: I4147b038ed7adf0311ee9918b44766f82a057eaf
2018-08-20 10:04:42 +01:00
Laura Davis
ed3bc12e2a Merge "Docs: Inserted links to relevant guide pages." into pi-dev am: 283f55f7de
am: 6497c5bd21

Change-Id: Ida8426c0ca4f0fd755df2783fb16ea5d9e5e72ad
2018-08-17 16:13:46 -07:00
TreeHugger Robot
2ab281361c Merge "isFocusable should also check for clear focus." 2018-08-17 22:59:53 +00:00
Laura Davis
6497c5bd21 Merge "Docs: Inserted links to relevant guide pages." into pi-dev
am: 283f55f7de

Change-Id: I1a42ff1b3485e35e152b354039aa5c072e0a1e70
2018-08-17 15:14:38 -07:00
TreeHugger Robot
7d3e4c87ee Merge "Log AutofillClient on CompatibilityBridge.onAccessibilityEvent()." 2018-08-17 21:18:41 +00:00
Felipe Leme
4226033998 Improved AutofillManager and Activity dump() methods:
- Print compatibility mode info and activity token on AutofillManager.dump().
- Add --autofill option on Activity so it just dump autofill state.

Also fixed checkstyle import warnings on ActivityManagerShellCommand.

Bug: 112417431
Bug: 112584717

Test: adb shell dumpsys activity top --autofill

Change-Id: Id56b56a5d7e591d5204663a1da1322a15f8ef3aa
(cherry picked from commit b546ca7916)
2018-08-17 14:18:37 -07:00
TreeHugger Robot
ef734b2978 Merge "Improved AutofillManager and Activity dump() methods:" 2018-08-17 20:58:58 +00:00
Felipe Leme
3438421295 Log AutofillClient on CompatibilityBridge.onAccessibilityEvent().
This is useful to identify cases where a browser used a trampoline activity to
launch its rendering activity.

Bug: 112584717
Bug: 112690889

Test: adb logcat AutofillManager

Change-Id: I5e58cd8c8dc67ddeed8aa0996233dca9b89cc0d3
(cherry picked from commit 7d4461d133)
2018-08-17 13:55:58 -07:00
Felipe Leme
a9aacf9bfd Log CompatibilityBridge.onAccessibilityEvent()
Altough these are super spammy, they're super valuable when debugging why
compat mode doesn't work.

Bug: 112417431
Fixes: 112584717

Test: adb logcat AutofillManager

Change-Id: I1574b51b1c6caf783038b82ff207986b726b2e8b
(cherry picked from commit 5d35d3d2d6)
2018-08-17 13:54:38 -07:00
TreeHugger Robot
6e354f0a2c Merge "Parcel mCharacters in KeyEvent" 2018-08-17 14:09:07 +00:00
Laura Davis
43e75d98d8 Docs: Inserted links to relevant guide pages.
This is the proof of concept for adding relevant
links in API pages to narrative content.
The design doc is hosted at:
https://docs.google.com/document/d/1Y6bFua27Gs7ONZ27gz0nHz3Djv0WND_V_rX-XvbeB3U/edit?usp=sharing

Test: make ds-docs

Bug: 112478848
Change-Id: Ic3842629c802fe89582d4d7b4a153e54d4ba1713
2018-08-16 16:57:18 -07:00
Felipe Leme
7d4461d133 Log AutofillClient on CompatibilityBridge.onAccessibilityEvent().
This is useful to identify cases where a browser used a trampoline activity to
launch its rendering activity.

Bug: 112584717
Bug: 112690889

Test: adb logcat AutofillManager

Change-Id: I5e58cd8c8dc67ddeed8aa0996233dca9b89cc0d3
2018-08-16 10:57:38 -07:00
Qasid Ahmad Sadiq
2a53ad9e4d isFocusable should also check for clear focus.
Caused by: ag/4401555
AccessibilityNodeInfo.isFocusable was changed to use actions.
In ani.isFocusable we should also check of the existance of the clear
focus action.
While I am here, clean up the View so it doesn't use deprecated and
inconsequential calls anymore. The appropriate actions were already
being created a few lines below the removed lines.
And in hasActionWithId, let's not allocate an iterator needlessly.
Test: Ran Accessibility Service CTS Tests.
Fix: 111887592

Change-Id: Iece7f1bdcaeac9b23135777984ef4ec314519284
2018-08-15 22:41:32 +00:00
TreeHugger Robot
0253c3f48a Merge "Protect a11y cache against loops in node hierarchy" 2018-08-15 16:32:20 +00:00
Felipe Leme
b546ca7916 Improved AutofillManager and Activity dump() methods:
- Print compatibility mode info and activity token on AutofillManager.dump().
- Add --autofill option on Activity so it just dump autofill state.

Also fixed checkstyle import warnings on ActivityManagerShellCommand.

Bug: 112417431
Bug: 112584717

Test: adb shell dumpsys activity top --autofill

Change-Id: Id56b56a5d7e591d5204663a1da1322a15f8ef3aa
2018-08-15 09:12:22 -07:00
Riddle Hsu
c80cac6c67 Merge "Get gravity of menu panel by display" 2018-08-15 14:27:10 +00:00
Riddle Hsu
a4d6fa229c Get gravity of menu panel by display
Also:
 - Reorganize import of DisplayContent and PhoneWindow.
 - Fix DisplayContent leakage in wm test.
   (SurfaceFlinger abort in createLayer -> addClientLayer with
    "Suspected IGBP leak: 4097 IGBPs (4096 max)")

Bug: b/111362047
Test: atest FrameworksServicesTests:DisplayContentTests# \
      testGetPreferredOptionsPanelGravityFromDifferentDisplays

Change-Id: I9c5a0f59a86fda08bd532cb2b66bab76b2dfa6c8
2018-08-15 20:51:57 +08:00
Phil Weaver
f1eb10b3f4 Protect a11y cache against loops in node hierarchy
Plugging a hole where we would recycle a node that is its
own ancestor twice if it was a descendant of the last
child we iterated over.

Bug: 112549653
Test: Adding new test case that reproduced the issue before
and now passes.

Change-Id: I6afc83655d4d7ca1c01f21703c8f9f9ac23e4ac6
2018-08-15 03:13:51 +00:00
TreeHugger Robot
c3fcd6a143 Merge "Log CompatibilityBridge.onAccessibilityEvent()" 2018-08-14 22:09:37 +00:00
Aurimas Liutikas
735dd9adaf Merge "Add @TestApi annotation to a few @hide APIs that were used in CTS." 2018-08-14 20:52:57 +00:00
Felipe Leme
5d35d3d2d6 Log CompatibilityBridge.onAccessibilityEvent()
Altough these are super spammy, they're super valuable when debugging why
compat mode doesn't work.

Bug: 112417431
Fixes: 112584717

Test: adb logcat AutofillManager

Change-Id: I1574b51b1c6caf783038b82ff207986b726b2e8b
2018-08-14 11:44:45 -07:00
Kweku Adams
87c60a029c Updating incident protos.
Adding more comments and fixing some style issues.

Test: Android builds
Change-Id: I70f74c029cf0aed99aaf55b484729a2f3d289e94
2018-08-13 18:51:06 -07:00
Joshua Baxter
f2b05f9d10 Merge "docs: fixed typo" into pi-dev am: ce01dba2b7
am: 8b3e98c424

Change-Id: Ibcdebeeefbb7a9e95fd14fa2724fb76df04ea090
2018-08-13 16:24:16 -07:00
Aurimas Liutikas
80e4e18b8c Add @TestApi annotation to a few @hide APIs that were used in CTS.
CtsViewTestCases tests were using @hide APIs. This change makes some
of these APIs @TestApi, so CtsViewTestCases can just link againts test_current.

Test: make -j
Bug: 37778825
Change-Id: I685ab5f0d1d5fcb5557ce4d93fe4f55cc695ed3d
2018-08-13 16:13:37 -07:00
Joshua Baxter
8b3e98c424 Merge "docs: fixed typo" into pi-dev
am: ce01dba2b7

Change-Id: I096c86efb2a34567b2a79cbe5b3a8dbe6b64800c
2018-08-13 16:04:10 -07:00