Commit Graph

14437 Commits

Author SHA1 Message Date
Daniel Sandler
625770f7fd Merge "Fixed bug: Not everyone has home controls yet, or pets." 2020-06-25 14:34:51 +00:00
TreeHugger Robot
7bc874bf3c Merge "Request keyguard dismissal from suspend dialog" 2020-06-24 23:59:57 +00:00
Dan Sandler
16c814f927 Fixed bug: Not everyone has home controls yet, or pets.
Fixes: 156301524
Test: # to enable controls component
      adb shell am start -n com.android.egg.test/com.android.egg.neko.NekoActivationActivity
      # manual step: activate controls from GlobalActions
      # to visit the cat list
      adb shell am start -n com.android.egg.test/com.android.egg.neko.NekoLand
      # to check on the status of the food bowl job (once
      # the food bowl control has been tapped)
      adb shell cmd jobscheduler get-job-state com.android.egg.test 42
      # to trigger the food immediately
      adb shell cmd jobscheduler run com.android.egg.test 42
Change-Id: I985a930bb5dd56d99eb57a340e4affe08c09724b
2020-06-24 23:20:37 +00:00
Suprabh Shukla
9f542ba103 Request keyguard dismissal from suspend dialog
Sometimes a suspended app may be started while the device is locked. The
suspend dialog should request the user to unlock in these cases.

Test: Manual:
1. Suspend camera app.
2. Lock the screen.
3. Try to launch the camera while the screen is locked, e.g., by double
tapping the power button.

Bug: 157867645
Change-Id: Ie3b5e2903804bc8b385de4fc9276dd55a8108c0f
2020-06-24 20:56:32 +00:00
Josh Tsuji
9d9e3f0993 Merge "Hide the IME using InputMethodManagerInternal, because doing it that way actually works." into rvc-dev am: 88e88190eb am: 644d1add13 am: 5648d9349e am: d32a0e7a8a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11948939

Change-Id: I3760639b9ffb949ce9770333fe12e803e76ad3b4
2020-06-24 03:44:22 +00:00
Josh Tsuji
5648d9349e Merge "Hide the IME using InputMethodManagerInternal, because doing it that way actually works." into rvc-dev am: 88e88190eb am: 644d1add13
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11948939

Change-Id: I7cfe3666b94962ddb1c099babe8fa311342b92f6
2020-06-24 03:04:19 +00:00
Josh Tsuji
88e88190eb Merge "Hide the IME using InputMethodManagerInternal, because doing it that way actually works." into rvc-dev 2020-06-24 02:31:47 +00:00
TreeHugger Robot
cafffe1686 Merge "Tap convo avatar to expand/collapse" into rvc-dev am: 254b6cbd3a am: 4d1eb4fd9e am: ee3625d989 am: bb5a3586c0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11973242

Change-Id: Ia92707eecf7f716bad4c432570aa17cd1768f437
2020-06-23 22:14:11 +00:00
Automerger Merge Worker
d028bf2be4 Merge "Merge "Fix NPE in sharesheet on devices without Work Profile." into rvc-dev am: 58bb12f7f8 am: 14ae5d77ee am: 57962cd18b" into rvc-qpr-dev-plus-aosp am: f3333136f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11971848

Change-Id: I7842f94bd3a7a2755bcd859c88a376e959a6ffc7
2020-06-23 22:11:53 +00:00
TreeHugger Robot
bb5a3586c0 Merge "Tap convo avatar to expand/collapse" into rvc-dev am: 254b6cbd3a am: 4d1eb4fd9e am: ee3625d989
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11973242

Change-Id: I22b65eee504807bbcd6e5ba0c8874dbabad12a88
2020-06-23 22:00:30 +00:00
TreeHugger Robot
33e574fd7a Merge "Tap convo avatar to expand/collapse" into rvc-dev am: 254b6cbd3a am: 4d1eb4fd9e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11973242

Change-Id: I687f4abff8fdd8b12b44897947c780bf36989964
2020-06-23 21:46:59 +00:00
TreeHugger Robot
57962cd18b Merge "Fix NPE in sharesheet on devices without Work Profile." into rvc-dev am: 58bb12f7f8 am: 14ae5d77ee
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11971848

Change-Id: Ic79fe42260dee8274a389f6b6644694bcb858722
2020-06-23 21:46:39 +00:00
TreeHugger Robot
254b6cbd3a Merge "Tap convo avatar to expand/collapse" into rvc-dev 2020-06-23 21:41:18 +00:00
TreeHugger Robot
58bb12f7f8 Merge "Fix NPE in sharesheet on devices without Work Profile." into rvc-dev 2020-06-23 21:25:24 +00:00
TreeHugger Robot
053c236d42 Merge "Remove circular ref from MessagingLinearLayout" into rvc-dev am: f33516115a am: 8b4a786347 am: 5b26462646 am: 13a3f8f6ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11971391

Change-Id: I3b99a6f0f8c4fa151b8561808f6b1719c27d46b8
2020-06-23 18:47:18 +00:00
Alison Cichowlas
c391362e95 Fix NPE in sharesheet on devices without Work Profile.
Fixes: 159710864
Test: chooseractivitytests & manual
Change-Id: I664955eef96eebab0b412d19ed31292c7439f142
2020-06-23 14:20:32 -04:00
TreeHugger Robot
5b26462646 Merge "Remove circular ref from MessagingLinearLayout" into rvc-dev am: f33516115a am: 8b4a786347
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11971391

Change-Id: I98651e68e278012d3195f2a253ec49ab3893d088
2020-06-23 18:09:24 +00:00
Steve Elliott
0afc301462 Tap convo avatar to expand/collapse
Fixes: 153751368
Test: manual
Change-Id: I42b0f05604797faba6ae3769b32bcbbe74d56a4e
2020-06-23 13:55:16 -04:00
TreeHugger Robot
f33516115a Merge "Remove circular ref from MessagingLinearLayout" into rvc-dev 2020-06-23 17:35:37 +00:00
Joshua Tsuji
53f6e83df0 Hide the IME using InputMethodManagerInternal, because doing it that way actually works.
This technique is also used by the Recents animation to hide the IME. It replaces the AV back press workaround entirely, which fixes the IME hanging around issue (and by extension, the weirdness around the insets).

Test: open a bubble (go/use-bubbles), focus an input field, then tap outside the bubbles UI to close the stack, observe that the IME hides
Test: open a bubble, focus an input field, switch to another bubble, observe IME hides
Test: open bubble, focus input field, switch to another bubble, focus input field, switch to the original bubble, focus input field, collapse stack, observe IME hides (previously the IME would remain visible)
Bug: 159369847
Bug: 159561847
Change-Id: I09f27b3c187a7bcfbef663cd3101a74ad8ab95ab
2020-06-23 11:57:34 -04:00
Steve Elliott
1b0f20efee Remove circular ref from MessagingLinearLayout
Fixes: 157507646
Test: manual
Change-Id: Ic2b2f99f9f80c11639849128670b335b5ec25566
2020-06-23 10:51:56 -04:00
Adrian Roos
06b04e967a Merge "IME animation: hide IME-related navbar icons until perceptible" into rvc-dev am: e658c76b5c am: ba68b71a5c am: 1b3d71002f am: b78766031f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11837615

Change-Id: I13528f9621e3c504b53c34f20e3baecbe3468c1f
2020-06-23 07:58:59 +00:00
Adrian Roos
b78766031f Merge "IME animation: hide IME-related navbar icons until perceptible" into rvc-dev am: e658c76b5c am: ba68b71a5c am: 1b3d71002f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11837615

Change-Id: I9bfe4da48628fa5f06b6646bbc44efae04f5f297
2020-06-23 07:48:09 +00:00
Adrian Roos
331b36e9f1 Merge "IME animation: hide IME-related navbar icons until perceptible" into rvc-dev am: e658c76b5c am: ba68b71a5c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11837615

Change-Id: I004df2ce6233ade571fea0083d29a741b5a56100
2020-06-23 07:21:16 +00:00
Adrian Roos
e658c76b5c Merge "IME animation: hide IME-related navbar icons until perceptible" into rvc-dev 2020-06-23 07:06:48 +00:00
Alison Cichowlas
b8bade075a Merge "When Nearby is present as a chip, exclude it from app list." into rvc-dev am: 974d17209e am: c71b0edf6f am: f231e027f2 am: 55e138075c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11931365

Change-Id: Id605f8db28f64885e583530951c0df8e76a05b2f
2020-06-22 17:35:25 +00:00
TreeHugger Robot
248ed38aa0 Merge "Turn off quiet mode in the background, allowing the dialog to dismiss quicker." into rvc-dev am: 63458fb6e5 am: f978d16719 am: 5f20fc8f85 am: e559e16c16
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11931083

Change-Id: I066cb13cc16652694ba0cd9749d6aafce2d03722
2020-06-22 17:34:29 +00:00
Alison Cichowlas
55e138075c Merge "When Nearby is present as a chip, exclude it from app list." into rvc-dev am: 974d17209e am: c71b0edf6f am: f231e027f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11931365

Change-Id: Id0a70a98b3f6a52b4d5dfa3475b7d77fe7b3e677
2020-06-22 17:14:27 +00:00
TreeHugger Robot
e559e16c16 Merge "Turn off quiet mode in the background, allowing the dialog to dismiss quicker." into rvc-dev am: 63458fb6e5 am: f978d16719 am: 5f20fc8f85
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11931083

Change-Id: I0ebd2bcbdd3f2eca1fb51a6aed8e5e89e7a66c6b
2020-06-22 17:14:05 +00:00
Alison Cichowlas
1597a9eacf Merge "When Nearby is present as a chip, exclude it from app list." into rvc-dev am: 974d17209e am: c71b0edf6f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11931365

Change-Id: I028ebbaa2071ccf91e2e9cc95e86b4e44242c360
2020-06-22 17:04:22 +00:00
TreeHugger Robot
7ab65c71fb Merge "Turn off quiet mode in the background, allowing the dialog to dismiss quicker." into rvc-dev am: 63458fb6e5 am: f978d16719
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11931083

Change-Id: I58ba69b1ae45270b02c715d09d5d34abd0ab536d
2020-06-22 17:03:47 +00:00
Alison Cichowlas
974d17209e Merge "When Nearby is present as a chip, exclude it from app list." into rvc-dev 2020-06-22 16:31:47 +00:00
TreeHugger Robot
63458fb6e5 Merge "Turn off quiet mode in the background, allowing the dialog to dismiss quicker." into rvc-dev 2020-06-22 16:09:41 +00:00
TreeHugger Robot
c593334af7 Merge "Ignore onStartInput when WINDOW_FOCUS_GAIN_REPORT_WITH_SAME_EDITOR" into rvc-dev am: 70ad33113f am: 2d8df39d7c am: 92809870d0 am: e0659980e2
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11863061

Change-Id: I7b850b58050727567ec05b140b8c99f27fd0032f
2020-06-22 15:59:27 +00:00
TreeHugger Robot
92809870d0 Merge "Ignore onStartInput when WINDOW_FOCUS_GAIN_REPORT_WITH_SAME_EDITOR" into rvc-dev am: 70ad33113f am: 2d8df39d7c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11863061

Change-Id: I756f28edde2a871597dacfc8213f7b22b144ce46
2020-06-22 15:16:51 +00:00
Adrian Roos
c22eec9d35 IME animation: hide IME-related navbar icons until perceptible
During transitions and while the IME is controlled by the app,
the IME may be "visible" as far as the IME framework is concerned,
but not actually perceptible by the user due to offsets or alpha
applied to the leash.

This may lead to out-of-place navbar symbols for the IME, especially
in gesture nav.

To avoid this, the ImeInsetsSourceConsumer now notifies the IMF of
whether it has made the IME unperceptible to the user.

For now, we ignore the cases where the IME is controlled by something
other than the client window - in that case, we just revert to the
previous behavior of it being always considered perceptible.

Fixes: 158079255
Test: manual, launch email compose activity, observe that back button only indicates once IME appears
Test: atest InsetsAnimationControlImplTest
Change-Id: I4dc9d6513d0559156f7da39244f3fc5ebc952ed4
2020-06-22 16:55:54 +02:00
TreeHugger Robot
70ad33113f Merge "Ignore onStartInput when WINDOW_FOCUS_GAIN_REPORT_WITH_SAME_EDITOR" into rvc-dev 2020-06-22 14:51:15 +00:00
Alison Cichowlas
e7a70aca7b Merge "Refresh both lists and pinning preferences on change." into rvc-dev am: 582aeba50c am: 45b4885a90 am: 4ab48187ce am: a41fbbc593
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11947583

Change-Id: I6fbf26a567c9cb6a6223d4beba5fe587b4b65918
2020-06-22 13:57:14 +00:00
Alison Cichowlas
4ab48187ce Merge "Refresh both lists and pinning preferences on change." into rvc-dev am: 582aeba50c am: 45b4885a90
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11947583

Change-Id: Idb3549c950ca5ba9dc432d5fd557ef64f1ec42e8
2020-06-22 13:29:43 +00:00
Alison Cichowlas
582aeba50c Merge "Refresh both lists and pinning preferences on change." into rvc-dev 2020-06-22 12:58:57 +00:00
Stanislav Zholnin
d3fbb9fe8b Merge "Prevent developer provided strings from being uploaded through statsd." into rvc-dev am: 7a65a7a37c am: 113387f309 am: 7f757a3006 am: 1ed2d1e39a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11930479

Change-Id: Ib06abfe9399b0c69ab26c137b77f395033c55219
2020-06-22 09:14:07 +00:00
Stanislav Zholnin
7f757a3006 Merge "Prevent developer provided strings from being uploaded through statsd." into rvc-dev am: 7a65a7a37c am: 113387f309
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11930479

Change-Id: Idd9acf7078c05270b99bf064702e92257ddc2496
2020-06-22 08:40:35 +00:00
Ming-Shin Lu
48bfc3165c Ignore onStartInput when WINDOW_FOCUS_GAIN_REPORT_WITH_SAME_EDITOR
CL[1] introduces new WINDOW_FOCUS_GAIN_REPORT_ONLY flows to notify
InputMethodService only reports IME input target to WM when focusing to
the next window and its input connection remains.

Originally in android Q and prior devices, we don't need such report
mechnism but just skip to start new input connection and ignore
onStartInput / onFinishInput for the above use case.

Since starts from Android R, new IME insets control APIs relying on this
mechanism (see CL[2]) to keep the actual IME input target up-to-date.

As we expected there should be no new input connection and additional
onFinishInput when CL[1] landed.

However, in IMMS, startInputUncheckedLocked will be called
to callback additional onStartInput for InputMethodService, which mostly
is not expected, except when focusing the same window after device
turned screen on, we need to start input and callback onStartInput to
align with the behavior of android Q or the prior platform.

Besides, to have more clear code logic and debugging concept of
ignoring onStartInput and onFinishInput only when focused the same editor
with input connection remains, we remove WINDOW_FOCUS_GAIN_REPORT_ONLY
reason and introduced 2 more start input reasons to distinguish the
different behavior:
    - WINDOW_FOCUS_GAIN_REPORT_WITH_SAME_EDITOR
    - WINDOW_FOCUS_GAIN_REPORT_WITHOUT_EDITOR

[1]: I45a9814d812ad906f417c24200fd4219959e2423
[2]: I9e8984b7e5aa989a53ece9e2576393f795b9ef94

Fix: 158624922
Test: atest FocusHandlingTest InputMethodStartInputLifecycleTest
Test: manual as below steps:
    1. Use Gboard, Open the emoji keyboard
    2. Swipe down to reveal notification shade
    3. Swipe up to dismiss notifications
    4. Expect the Emoji keyboard is still open without close

Change-Id: I2da99ae67b9ce4051dec0c0f0e975ebe6e1ab118
2020-06-22 12:22:33 +08:00
Alison Cichowlas
d5c946dae9 Refresh both lists and pinning preferences on change.
This fixes several issues relating to pinning and work profile.
(In future, we might want to maintain a separate pinned list for
WP than for main profile - this CL doesn't address that but
doesn't prevent it.)

Fixes: 159038941, 159035711
Test: atest ChooserActivityTest, manual with WP enabled thru TestDPC
Change-Id: Ibbe908a60dfeee859e576c5e1473123f02147958
2020-06-21 10:23:30 -04:00
Alison Cichowlas
3d88dccf7c When Nearby is present as a chip, exclude it from app list.
Fixes: 156514997
Test: atest ChooserActivityTest; manual with Nearby enabled
Change-Id: Ibfb1cd2b25d41e56aea7ecd861af78ae7b48898b
2020-06-19 14:43:16 -04:00
Stanislav Zholnin
54762b293e Prevent developer provided strings from being uploaded through statsd.
- in situation when developer provides message when op is noted, do not
report it through stack trace collection infrastructure
 - collect only statcktraces for OP_FLAG_SELF and OP_FLAG_TRUSTED_PROXIED to
match collection of appops counts

Test: atest  android.app.appops.cts.RuntimeMessageCollectionTest
Fixes: 159433071
Change-Id: I1ab56a530832873a1f1f68aba5ab6eabc9e8a17a
2020-06-19 19:43:03 +01:00
Jonathan Scott
3e7c68412e Turn off quiet mode in the background, allowing the dialog to dismiss
quicker.

Test: Manual test of launching a work app with quiet mode on.
Bug: 158934594
Change-Id: I36a9e8717ce5b6aa5e4009468364914fcc73b80c
2020-06-19 18:17:53 +01:00
Evan Rosky
3f9c68de77 Merge "Fix support for split-screen w/ non-resizable home" into rvc-dev am: a9233b0aab am: 3f8e82957e am: f9700f4717 am: 88980fc349
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11897517

Change-Id: Id7502d29842a1f4696105e094af789bc139d07cb
2020-06-19 03:04:22 +00:00
Evan Rosky
f9700f4717 Merge "Fix support for split-screen w/ non-resizable home" into rvc-dev am: a9233b0aab am: 3f8e82957e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11897517

Change-Id: I6f2754f8dd65c187952c1ab0adc328ed6dc8977c
2020-06-19 02:35:16 +00:00
Evan Rosky
a9233b0aab Merge "Fix support for split-screen w/ non-resizable home" into rvc-dev 2020-06-19 02:06:38 +00:00