Commit Graph

15003 Commits

Author SHA1 Message Date
Alex Mang
41f94e585f Merge changes from topic "feedback"
* changes:
  Flag guarding all notification feedback UI
  Adding automatic option in long press menu
  Adding notification guts to feedback icon
  Add notification feedback indicator icon.
2020-06-18 20:38:37 +00:00
Ady Abraham
5068b95c40 Merge "WM: Replace eEarlyWakeup flags with explicit eEarlyWakeup start and end flags" into rvc-dev am: 278f00319f am: 66bab75ea1 am: e212052243 am: 2a57fdcd37
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11852824

Change-Id: I8c15fa26c30c3eabd39e73eba45ec50211bee740
2020-06-18 05:44:09 +00:00
Ady Abraham
e212052243 Merge "WM: Replace eEarlyWakeup flags with explicit eEarlyWakeup start and end flags" into rvc-dev am: 278f00319f am: 66bab75ea1
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11852824

Change-Id: I19c91a7b9d2229f1fd95d58182cd1060d75cf060
2020-06-18 05:11:37 +00:00
Ady Abraham
66bab75ea1 Merge "WM: Replace eEarlyWakeup flags with explicit eEarlyWakeup start and end flags" into rvc-dev am: 278f00319f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11852824

Change-Id: Iae325723452bbb5ac9c941d8e84d95d0c80337b4
2020-06-18 04:51:35 +00:00
Ady Abraham
278f00319f Merge "WM: Replace eEarlyWakeup flags with explicit eEarlyWakeup start and end flags" into rvc-dev 2020-06-18 04:36:03 +00:00
Vishnu Nair
2ed39d82db WM: Replace eEarlyWakeup flags with explicit eEarlyWakeup start and end flags
eEarlyWakeup flag is used as a hint to SurfaceFlinger to adjust its
offsets so it can wakeup earlier and have sufficient time to compose
more complex scenes.

This flag has been replaced with explicit start and stop flags which
ensure the SurfaceFlinger offsets remain consistent during animation.

Bug: 158127834
Test: go/wm-smoke
Test: systrace to verify new tracepoint and offset behavior

Change-Id: Ib9c35c01a6bf02f88ec7cb1778e01909bd2f9055
2020-06-17 23:10:30 +00:00
TreeHugger Robot
bb97cab140 Merge "Revert "Add logs that indicate why a surface is invalid"" into rvc-dev am: d82080094e am: 0b235515ce am: 3d61c943b8 am: 4d3b81c34b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11874469

Change-Id: I6bb15e1d50e5a92f6ee6b0f03b99bf9cdaa6ac64
2020-06-17 14:57:38 +00:00
TreeHugger Robot
3d61c943b8 Merge "Revert "Add logs that indicate why a surface is invalid"" into rvc-dev am: d82080094e am: 0b235515ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11874469

Change-Id: Ia68ee7a6a29ecab20ffe97471398a3c93c58b6b1
2020-06-17 14:34:16 +00:00
TreeHugger Robot
0b235515ce Merge "Revert "Add logs that indicate why a surface is invalid"" into rvc-dev am: d82080094e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11874469

Change-Id: I744413842bbc74724268c1fe58187a74f4d90461
2020-06-17 14:15:17 +00:00
Jorim Jaggi
e1f741becf Revert "Add logs that indicate why a surface is invalid"
This reverts commit 0fd6748bf6.

Bug: 159056748
Change-Id: I850c0d29e07c74143868c6c63cef63649a449c9e
2020-06-17 14:12:50 +02:00
Wilson Wu
ed78e4510f Merge "Refine InputMethodManager#isAcceptingText API" 2020-06-17 02:58:10 +00:00
TreeHugger Robot
c65f53e0be Merge "SurfaceView: Check ViewRootImpl non-null" into rvc-dev am: 3764cbaac4 am: 38972ce1f6 am: a95675bfcf am: 735b5257d6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11884759

Change-Id: I26a71d11230d12611723a9b0185923c4f2048d9c
2020-06-17 01:28:12 +00:00
TreeHugger Robot
a95675bfcf Merge "SurfaceView: Check ViewRootImpl non-null" into rvc-dev am: 3764cbaac4 am: 38972ce1f6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11884759

Change-Id: If2e1fe9ee2983bd5414ca65a8777ce278a1474ae
2020-06-17 00:54:27 +00:00
TreeHugger Robot
38972ce1f6 Merge "SurfaceView: Check ViewRootImpl non-null" into rvc-dev am: 3764cbaac4
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11884759

Change-Id: Iecdbbd14f2a4e78b1614b199efb4abd004c6445b
2020-06-17 00:38:07 +00:00
TreeHugger Robot
9a3fa17f6c Merge "Revert "Disable user animations on insets whose visible frame is empty"" into rvc-dev am: 11fcb1987a am: 37de161ec5 am: a62362b295 am: dc1a9eba2f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11883882

Change-Id: I41b211a28b689d4e23da25038c44c78c7a05e7c1
2020-06-17 00:19:30 +00:00
TreeHugger Robot
3764cbaac4 Merge "SurfaceView: Check ViewRootImpl non-null" into rvc-dev 2020-06-17 00:16:36 +00:00
TreeHugger Robot
a62362b295 Merge "Revert "Disable user animations on insets whose visible frame is empty"" into rvc-dev am: 11fcb1987a am: 37de161ec5
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11883882

Change-Id: I87dcee6341c69226c000062e38b30a988b3064b7
2020-06-16 23:34:36 +00:00
TreeHugger Robot
37de161ec5 Merge "Revert "Disable user animations on insets whose visible frame is empty"" into rvc-dev am: 11fcb1987a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11883882

Change-Id: I2b97b5a88908579d3ff142fa21b1b41f59188b03
2020-06-16 23:18:15 +00:00
TreeHugger Robot
11fcb1987a Merge "Revert "Disable user animations on insets whose visible frame is empty"" into rvc-dev 2020-06-16 23:01:15 +00:00
Yohei Yukawa
f35971dfca Revert "Disable user animations on insets whose visible frame is empty"
This reverts commit 0b9450bab9.

Reason for revert:
Broke ImeInsetsControllerTest#testChangeSizeWhileControlling

Bug: 157777145
Fix: 159154994
Test: atest CtsInputMethodTestCases
Test: atest InsetsSourceConsumerTest
Change-Id: I6c47ec5f8498a3566c543d4d1d6ef62e325ccd8e
2020-06-16 21:32:01 +00:00
Robert Carr
c34aea875a SurfaceView: Check ViewRootImpl non-null
This call to updateRelativeZ may be triggered from the
RT frame callback which may be triggered after we are detached
from the Window and in that case will be null. If we are detached
we are also going invisible so there is no need
to set a relativeZ.

Bug: 158706756
Test: Existing tests pass
Change-Id: I46aa824807b7b275e6a015c428fe7467a72ca949
2020-06-16 11:47:07 -07:00
Yabin Huang
1f2df92e74 Update FocusFinder am: 713af5fdd3 am: 74f91531c8 am: 30f2b4afad
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11825630

Change-Id: Ic96f3bdcc2178fdcc2477c17f59db6fe3bf5eb73
2020-06-16 18:04:44 +00:00
Yabin Huang
74f91531c8 Update FocusFinder am: 713af5fdd3
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11825630

Change-Id: I7636504c50fa48e92e89f557461a35bd0aea015a
2020-06-16 17:41:50 +00:00
Tiger Huang
ce21ca5c09 Merge "Let animations of insets controller can be disabled" into rvc-dev am: 299734b637 am: 3f6f662d51 am: 115e3a75a9 am: c31434f630
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11570106

Change-Id: I1f2e81dc03074ed424f8546d423cb49f19982e02
2020-06-16 15:29:08 +00:00
Charles Chen
8f6b6dffe7 Merge "Trust System UI owned display to receive keys" into rvc-dev am: 94deecfda2 am: d09b0f10bf am: 8fccd6e144 am: a7050e9667
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11570100

Change-Id: I6fcea62dffe51d3cbc522beb8e63e90ab27fb6d1
2020-06-16 14:56:54 +00:00
Tiger Huang
115e3a75a9 Merge "Let animations of insets controller can be disabled" into rvc-dev am: 299734b637 am: 3f6f662d51
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11570106

Change-Id: I9c5d977f49cb2f54a0bb9f1fcb8b100718e041c0
2020-06-16 14:56:03 +00:00
Tiger Huang
c448e5eba6 Merge "Let animations of insets controller can be disabled" into rvc-dev am: 299734b637
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11570106

Change-Id: I303066b63ad1397ff0d91d20db0586a01266afb5
2020-06-16 14:44:14 +00:00
Charles Chen
a7050e9667 Merge "Trust System UI owned display to receive keys" into rvc-dev am: 94deecfda2 am: d09b0f10bf am: 8fccd6e144
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11570100

Change-Id: I75db01ccbe3e051b0fe21522efe771387632e31f
2020-06-16 14:37:56 +00:00
Tiger Huang
299734b637 Merge "Let animations of insets controller can be disabled" into rvc-dev 2020-06-16 14:31:41 +00:00
Charles Chen
94fe22f674 Merge "Trust System UI owned display to receive keys" into rvc-dev am: 94deecfda2 am: d09b0f10bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11570100

Change-Id: Iac08bb390ee1a5d6bbfc02afdb57e980cdad7597
2020-06-16 14:29:09 +00:00
Charles Chen
dd7e0fded2 Merge "Trust System UI owned display to receive keys" into rvc-dev am: 94deecfda2
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11570100

Change-Id: I93a7522c1ce94e379269b9a1a0de802916dcbb32
2020-06-16 14:14:14 +00:00
Charles Chen
94deecfda2 Merge "Trust System UI owned display to receive keys" into rvc-dev 2020-06-16 13:56:55 +00:00
Tiger Huang
6dae2090a1 Merge "Disable user animations on insets whose visible frame is empty" into rvc-dev am: ae9ce9716d am: 07d77fce08 am: ad8e892660 am: 38cc421fdd
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11754098

Change-Id: I0851d1c548670e0e8eec4b0ee0e82d295a5cd9d7
2020-06-16 10:02:25 +00:00
Tiger Huang
ad8e892660 Merge "Disable user animations on insets whose visible frame is empty" into rvc-dev am: ae9ce9716d am: 07d77fce08
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11754098

Change-Id: I73e27dead5774a4cf9ce4618ec8e5fdbea833416
2020-06-16 09:38:08 +00:00
Tiger Huang
f0ab382fae Merge "Disable user animations on insets whose visible frame is empty" into rvc-dev am: ae9ce9716d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11754098

Change-Id: Ib5fbf8e6412d1d46a9295adcffa30d9b6286e89a
2020-06-16 09:32:11 +00:00
Tiger Huang
ae9ce9716d Merge "Disable user animations on insets whose visible frame is empty" into rvc-dev 2020-06-16 09:26:33 +00:00
TreeHugger Robot
c68df8b2e6 Merge "Add event log for view_enqueue_input_event." 2020-06-16 06:04:42 +00:00
Chris Ye
a33291e6e2 Add event log for view_enqueue_input_event.
Log out the input events to help debugging unresponsive UI issues.

Examples:
06-15 19:00:53.725  2272  2272 I view_enqueue_input_event: [Motion - Cancel,NavigationBar0]
06-16 02:28:35.318  3650  3650 I view_enqueue_input_event: [Key - Cancel,com.google.android.apps.nexuslauncher/com.google.android.apps.nexuslauncher.NexusLauncherActivity]

Bug: 154660150
Test: Manual test of swiping screen and watch event log.

Change-Id: I08c6be21ec01d9da2c67e2b59c15ba780de227be
2020-06-15 19:26:38 -07:00
Charles Chen
b28fb721f5 Trust System UI owned display to receive keys
A11y service cannot get focus of bubbles because it's not a
System owned display. This patch makes System UI owned display
a trusted display. Moreover, this patch refactors the logic to
identify a trusted display by introducing FLAG_TRUSTED and
removes the trusted display check along with supportsSystemDecorations()
because the check has been included in supportsSystemDecorations().

fixes: 155823002
Bug: 152416787
Test: atest DisplayContentTests
Test: atest WindowFocusTests
Test: atest TaskDisplayAreaTests
Test: atest MultiDisplaySystemDecorationTests
Test: atest DisplayTest
Change-Id: Ie684c6488904e5aa8cae166a455c6d55455e5f55
2020-06-16 02:10:21 +08:00
Tiger Huang
f23211979e Let animations of insets controller can be disabled
In some cases, System UI needs to hide navigation bar without any
animation, i.e. transitioning to AOD. This CL creates a method in
insets controller to disable/enable animations.

Fix: 150729581
Test: Enable AOD, and go to AOD from home screen by pressing power key.
Test: Enter/leave bouncer while screen is on.
Change-Id: I3fb7be898b9e615c661d07eca97c9ffcb6bbf8c3
2020-06-15 19:36:37 +08:00
Tiger Huang
3b81a13ec1 Merge "Let position of system bars can be restored by swipe" into rvc-dev am: ac4e36b948 am: 5078e7a8c1 am: 2121d62ccd am: c30d4a180c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11612964

Change-Id: I5aeadac674b84e7aee61c4d8765ec37c265dcdf6
2020-06-15 09:58:17 +00:00
Tiger Huang
2121d62ccd Merge "Let position of system bars can be restored by swipe" into rvc-dev am: ac4e36b948 am: 5078e7a8c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11612964

Change-Id: I73e23ea1a5052d4f0afb02f58fae4bf3a91825e5
2020-06-15 09:34:02 +00:00
Tiger Huang
c298524cb0 Merge "Let position of system bars can be restored by swipe" into rvc-dev am: ac4e36b948
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11612964

Change-Id: Ie1912992be2ab8a3046b713b825753e1d63ca63b
2020-06-15 09:17:33 +00:00
Tiger Huang
ac4e36b948 Merge "Let position of system bars can be restored by swipe" into rvc-dev 2020-06-15 08:54:46 +00:00
Tiger Huang
0b9450bab9 Disable user animations on insets whose visible frame is empty
Floating IME or fullscreen IME won't cause insets (except the area
overlapped with navigation bar). It doesn't make much sense to let
apps move the IME at these cases.

Fix: 157777145
Test: atest InsetsSourceConsumerTest
Change-Id: Ibdf5454843c880d7e726a66a8f1107ca511e5025
2020-06-14 19:14:26 +08:00
Alex Mang
8c0ef2dccf Adding notification guts to feedback icon
Feedback icon is now tappable and opens up notification guts

Test: manually on device
Change-Id: I7c19d612fa90980a274e8c48561333fc1131c688
2020-06-14 00:34:24 -07:00
Alex Mang
919746849c Add notification feedback indicator icon.
This icon will be used to indicate an adjustment was made for this
notification and to solicit feedback. Currently it's not tappable. Will
add this in a later commit.

Test: manually on device
Change-Id: I730953a0d1286cd1ee2686fe4603f9642fa5d958
2020-06-13 15:48:02 -07:00
Tony Huang
f5988173b4 Merge "Only add divider when it need to show" into rvc-dev am: a73d6ecb84 am: dbe759768c am: ed4937c342 am: 6bcf2f4762
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11612936

Change-Id: Ie7fe1337675aadfa8b147463a411d9fc62c42c0c
2020-06-12 04:07:39 +00:00
Wilson Wu
967338c225 Refine InputMethodManager#isAcceptingText API
-. Use synchronized(mH) lock to guard it for thread safe
-. Update java doc of this API

Bug: 158539274
Test: atest CtsInputMethodTestCases
Change-Id: I5233b19a2a64d7b2c06b8fd5b6397ef5ca65d367
2020-06-12 11:30:18 +08:00
Tony Huang
dbe759768c Merge "Only add divider when it need to show" into rvc-dev am: a73d6ecb84
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11612936

Change-Id: I2274b246c949846a48d622090c17be3d0baed4b3
2020-06-12 03:24:57 +00:00