Commit Graph

9375 Commits

Author SHA1 Message Date
TreeHugger Robot
74d9b14f21 Merge "Update material_deep_teal_500 to #008577." into pi-dev 2018-03-21 17:45:25 +00:00
Leon Scroggins
d848f75f99 Merge "Report native allocation size of AnimatedImageDrawable" into pi-dev 2018-03-21 16:48:19 +00:00
Leon Scroggins III
eb3b38e22c Report native allocation size of AnimatedImageDrawable
Bug: 73641604
Test: infeasible

Fix nNativeByteSize's return value to be jlong, instead of long.
Add up the bytes used by the SkAnimatedImage and SkPictures and store
them on the AnimatedImageDrawable for registration.
Note that this is an approximation, and it assumes it will be drawn to a
hardware canvas and animated.
2018-03-21 09:28:00 -04:00
John Reck
0e4864725a Revert "Revert "Break down jank between frame drops vs. triple buffered""
This reverts commit a6d8fbf4ea.

Fixes an out-of-bounds read in COMPARISONS by switching up
how comparisons works. Instead of requiring all jank types
to have an associated COMPARISON's entry, which kHighInputLatency
and kMissedDeadline don't, instead have each
COMPARISON indicate which JankType it applies to so it can
be independently sized from JankTypes.

Bug: 70220906
Bug: 75566601
Test: launching & using maps works
Change-Id: I7fd90daeb320b4627e42c3418c89726d860998c1
2018-03-19 16:36:32 -07:00
TreeHugger Robot
fbb4b82156 Merge "Revert "Break down jank between frame drops vs. triple buffered"" into pi-dev 2018-03-19 19:44:14 +00:00
Aaron Whyte
a6d8fbf4ea Revert "Break down jank between frame drops vs. triple buffered"
This reverts commit 09979fbee7.

Reason for revert: Based on stacktraces and change history, I think this is causing a cluster of P crashes.
https://b.corp.google.com/issues?q=(%22android%22%20%22:uirenderer::JankTracker::finishFrame%22)
Bug: 75566601
Bug: 75811585
Bug: 75407175
Bug: 75736222
Bug: 75391447
Bug: 75659839

Change-Id: I59a8c2d8906d347210c77fb3628f5801bc299bfb
2018-03-19 17:53:48 +00:00
Andrew Sapperstein
5c228d5eb9 Update material_deep_teal_500 to #008577.
Better for accessibility.

Also update some direct usage of the old value to use canonical versions.

Bug: 74118164
Test: asset swap
Change-Id: If0f07f04f72a16dc3662e2cf3a93e2b040d0bdb8
2018-03-18 11:24:49 -07:00
John Reck
564284759f Don't use IPC in isolateProcess
Fixes: 74395652
Test: hwuiunit passes in 'shell stop' state (pseudo-isolated process),
      manually checked non-isolated processes still have working vsync
      via systrace of RT animations demo

Change-Id: I630ea011dc7eb2efa265b25673d3304b3b2510d3
2018-03-16 17:34:02 -07:00
Yi Jin
854c8d3d05 Remove comments of privacy.proto to avoid this accidently go to AOSP
Bug: 72950747
Test: manual
Change-Id: I06a897170996fc0aa493bda76495c6ef1e484961
2018-03-15 15:02:59 -07:00
John Reck
613783a909 Merge "Break down jank between frame drops vs. triple buffered" into pi-dev 2018-03-15 19:48:54 +00:00
Stan Iliev
cebb647802 kClear blend mode is drawn as kDstOut
kClear blend mode is drawn as kDstOut on hardware canvas for
compatibility with Android O and older.
On SDK released with Android P, the kClear blend mode is respected.

Bug: 71602378
Test: Ran Flo app
Change-Id: I6b0fa8b8bf5aa14aa5a351a914bf2ed0469ac660
(cherry picked from commit f9a461feaf)
2018-03-15 15:28:15 +00:00
Seigo Nonaka
83143d005b Remove mtOffset from drawTextRun
Bug: 72998298
Test: atest CtsWidgetTestCases:EditTextTest
    CtsWidgetTestCases:TextViewFadingEdgeTest
    FrameworksCoreTests:TextViewFallbackLineSpacingTest
    FrameworksCoreTests:TextViewTest FrameworksCoreTests:TypefaceTest
    CtsGraphicsTestCases:TypefaceTest CtsWidgetTestCases:TextViewTest
    CtsTextTestCases FrameworksCoreTests:android.text
    CtsWidgetTestCases:TextViewPrecomputedTextTest

Change-Id: Ia886c1ce9f7387559d7fe00b34ce03378d56ecec
2018-03-15 04:09:19 +00:00
John Reck
09979fbee7 Break down jank between frame drops vs. triple buffered
Bug: 70220906
Test: JankyScene vs. systrace vs. jankstats
Change-Id: Ia012685020cc5bcabbd3f92f0bdeb84eaf50733d
2018-03-14 15:00:05 -07:00
Derek Sollenberger
415a74b565 Update text alignment when using drawTextOnPath.
This is only a partial fix for the bug, but does ensure that Skia
doesn't attempt to realign the text after minikin already has.

Test: CtsGraphicsTestCases and test app in bug.
Bug: 25360203
Change-Id: I6222963b23b910f0261f562f8816604575d540fa
2018-03-14 15:03:13 -04:00
Pirama Arumuga Nainar
b7913e1f8a Revert "Disable LTO temporarily for hwui"
Bug: http://b/62839002
Bug: http://b/74395273

Turn LTO back on for hwui.  The reason for the build breaks were stale profile files in ccache. We'll hold off on updating profile files until this can be fixed.  LTO can be turned back on in the mean time.

This reverts commit 7184e28b3a.

Change-Id: I051c39a44be6a85682393e7d6e78f49b30bb85e1
2018-03-09 00:04:43 +00:00
Pirama Arumuga Nainar
7184e28b3a Disable LTO temporarily for hwui
Bug: http://b/62839002

LTO does not seem to interact well with PGO profile-file updates and
incremental builds in the build servers.

Test: build
Change-Id: I42175b2376b374d00ec169d4fe8d84cd938b21e5
2018-03-07 23:24:02 -08:00
Kweku Adams
eadd123d68 Dumping stack traces to proto.
Bug: 72177715
Test: flash device and check incident.proto output
Change-Id: Id2a15e0fc62b66efe875949af97f0eb651c7e322
(cherry picked from commit 5c804e2b98)
2018-03-07 21:50:12 +00:00
Leon Scroggins
e781724b41 Merge "Draw AnimatedImageDrawable mirrored if desired" into pi-dev 2018-03-07 18:51:16 +00:00
Yi Jin
5ee0787024 Use uint64_t instead of long long as API type for consistent reason.
Bug: 74118023
Test: manual
Change-Id: Icd5f506c76d3a008a79cb6c9d2061962ca7fdd40
2018-03-05 18:18:27 -08:00
Leon Scroggins III
5e8447f74d Draw AnimatedImageDrawable mirrored if desired
Bug: 73529437
Test: I27af7c3b2e08fa50bc19e08930d970931ce4b5e9

If isAutoMirrored, and the layout direction is RTL, make
AnimatedImageDrawable draw flipped.

Change-Id: I9a3436ef4cb9df2845a67663a2503c2c1a3dba89
2018-03-05 15:06:40 -05:00
Adam Lesinski
f3c951fd52 Merge "Change ownership of AAPT2 and libandroidfw" 2018-03-02 22:38:46 +00:00
Adam Lesinski
40a32d9ff0 Merge "Refactor AssetManager" 2018-03-02 22:05:45 +00:00
Adam Lesinski
a95e841846 Change ownership of AAPT2 and libandroidfw
toddke@ is now the new owner of these projects.

Test: none
Change-Id: Ie92b020e0ba063f48ce8a76ebaef768fe0d554f1
2018-03-02 12:11:03 -08:00
TreeHugger Robot
ffcd4bc88f Merge "Enable ThinLTO for hwui" 2018-03-02 19:11:22 +00:00
TreeHugger Robot
cbc22b8bec Merge "Allow debuggable apps to do skp capture" 2018-03-02 19:09:31 +00:00
Stan Iliev
6c4b6e8b0e Fix a crash when grContext was deleted
Fix a crash when trimMemory has occurred and then a java
VectorDrawable object is deleted.

Test: Ran Camera app
Bug: 72837472
Change-Id: I4bdc5975a9ceccc09af17edd9905345f97c2660f
2018-03-02 14:41:08 +00:00
John Reck
6afa009c0c Allow debuggable apps to do skp capture
Change-Id: Ibb56887b28eb8260bf2ca0b38dbe78233e9cfaf4
Fixes: 74086676
Test: verified can still capture an skp
2018-03-01 17:28:35 -08:00
Zhizhou Yang
f30f112da0 Enable ThinLTO for hwui
ThinLTO will benefit hwui on both performance and code size.

Now that hwui is with PGO, ThinLTO provides 3.8% performance improvement
on top of it (tested using hwui benchmarks on marlin device).

Enabling ThinLTO also decreases current code size of libhwui.so by 3.2%.

To be mentioned, Thinlto property in bp file will go through all static
libraries that hwui depends on (such as libskia) and enable Thinlto for
them when building hwui.

Test: Build and run benchmarks with ThinLTO enabled.
Bug: http://b/62839002
Change-Id: I89466d50c3715f6e7b0518ff10240bf8a5e9714c
2018-03-01 11:21:30 -08:00
Adam Lesinski
bebfcc46a2 Refactor AssetManager
Bug: 64071469
Test: atest CtsContentTestCases
Change-Id: Ia6856157e8813856268fba003e1e591d690cb26e
2018-02-28 19:06:48 -08:00
Steven Moreland
df7675f1cb Merge "Don't use cutils/Atomic.h" am: 07735797a2 am: a272d540d8
am: 0f4ca4a5c0

Change-Id: I4b9798b39d890537f888415b5ac283227970e4de
2018-02-28 14:13:52 +00:00
Steven Moreland
0f4ca4a5c0 Merge "Don't use cutils/Atomic.h" am: 07735797a2
am: a272d540d8

Change-Id: Ie442c255e43f2ebe80ef5423aa4508930d72c44c
2018-02-28 14:01:17 +00:00
TreeHugger Robot
ec98448f15 Merge "Implement a new section to attach LAST_KMSG to incident report This section simply gzip a large file and stores result in GZippedFileProto" 2018-02-28 03:02:16 +00:00
TreeHugger Robot
f3537c2054 Merge "Updates jank metrics in statsd to include uid." 2018-02-27 20:47:33 +00:00
Yi Jin
1a11fa1097 Implement a new section to attach LAST_KMSG to incident report
This section simply gzip a large file and stores result in GZippedFileProto

This greatly improves the size, before gzip, the last kmsg size ~500KB,
after gzip the proto size is ~60KB.

Bug: 73354384
Test: atest incidentd_test and manual on device test
Change-Id: I9bfc2cf07384487671edbffb5f0bd8495608fea6
2018-02-27 11:36:29 -08:00
TreeHugger Robot
255ed5cbdc Merge "[Magnifier-26] Wire up frame callback for realsies" 2018-02-27 02:13:46 +00:00
David Chen
77ef671c41 Updates jank metrics in statsd to include uid.
We need the uid to easily know which app to blame for producing the
frame with excessively long render time. Also updates the errors so
it's more obvious if the error is in parsing versus the other checks.

Test: Test that statsd builds and verified CTS test still passes.
Change-Id: Ib6518f2d9fe6f9c78d548b6dcbdb67a0f211ff5c
2018-02-26 17:18:20 -08:00
Mihai Popa
9568800d90 [Magnifier-26] Wire up frame callback for realsies
Test: none yet
Bug: 73810478
Bug: 72041926
Change-Id: I7154ed4b3d2cd820dc8c8ff55eed130be87d1606
2018-02-26 11:23:27 -08:00
TreeHugger Robot
be01248470 Merge "Remove obsolete pragma statements" 2018-02-26 15:38:58 +00:00
Siarhei Vishniakou
bfd4914b60 Remove obsolete pragma statements
These pragma statements used to guard against compiler warnings in Sk..
code. They are no longer necessary.

Test: make
Change-Id: I9f7f88276edb546ba08c7344c142eb487a04f978
2018-02-23 15:48:10 -08:00
Steven Moreland
fb7952f57e Don't use cutils/Atomic.h
Test: builds
Change-Id: I74485a5cbecb8710714f7bf3e54da61dd787838f
2018-02-23 15:02:42 -08:00
Leon Scroggins
08ddee7303 Merge "Add AnimatedImageDrawable.getLoopCount" 2018-02-23 20:39:21 +00:00
Greg Daniel
c9a8945477 Update call to null out GrVkAlloc in VulkanManager
Test: manual testing

Change-Id: Ia0af7526cad2dc4614afc73c31bf07e25890c677
2018-02-23 13:16:59 -05:00
Leon Scroggins III
1474b78888 Add AnimatedImageDrawable.getLoopCount
Bug: 73791004
Test: Id0335f15fdf0ebdc16d1edcabca547b9399c506f
Change-Id: I1c048196e45b91a1039c1f89e2176592765d2967
2018-02-23 09:43:00 -05:00
TreeHugger Robot
a64f88700b Merge "Need to add report id and sequence number to uniquely mark a incident report data." 2018-02-20 20:09:51 +00:00
Yi Jin
41d6192401 Need to add report id and sequence number to uniquely mark a incident
report data.

Bug: b/65451198
Test: N/A
Change-Id: I12f2c80c57e00e92888a295d432f2ec7e0d95ffd
2018-02-20 10:32:27 -08:00
TreeHugger Robot
8b3a832cdd Merge "Remove Skia RenderPipeline saveLayer logic for software layers." 2018-02-20 18:09:04 +00:00
Derek Sollenberger
52230bc215 Remove Skia RenderPipeline saveLayer logic for software layers.
Test: CtsUiRenderingTestCases:LayerTests
Bug: 72052698
Change-Id: Ief845c409755e6bc61849a6ab3506ef60161f231
2018-02-20 10:59:44 -05:00
Yi Jin
329130b7e4 Put metadata or stats into each dropbox incident report.
Bug: 65451198
Test: atest incidentd_test
Change-Id: Ib406b177ad7f1b4bda7fef2e606fc66a9836e060
2018-02-14 16:12:57 -08:00
TreeHugger Robot
b1c36318f7 Merge "Fix AnimatedImageDrawable drawn in software" 2018-02-12 20:38:17 +00:00
TreeHugger Robot
d6d5e0cc77 Merge changes from topic "revert-assetmanager2-02-09-2018"
* changes:
  Revert "Replace AssetManager with AssetManager2 implementation"
  Revert "libandroidfw: Make sure to set the 'app as lib' flag"
  Revert "Make idiomatic use of ApkAssets and AssetManager"
  Revert "libandroidfw: Add ApplyStyle and SetConfiguration benchmark"
  Revert "libandroidfw: Improve performance of AssetManager2"
  Revert "AssetManager2: Allow out of order type/type spec"
  Revert "AssetManager2: Fix list function"
  Revert "AssetManager2: Fix issue with native cast"
2018-02-10 03:42:41 +00:00