Commit Graph

13004 Commits

Author SHA1 Message Date
Automerger Merge Worker
097b548c24 Merge "PhoneWindow: Fix potential memory leak" into rvc-dev am: ee540c3245 am: 8d0a2cfa51 am: 6df8137b23 am: 452c6b1b22
Change-Id: I40f583452f5c40ef411b252768ae10e51791c343
2020-02-28 15:00:25 +00:00
Adrian Roos
ee540c3245 Merge "PhoneWindow: Fix potential memory leak" into rvc-dev 2020-02-28 13:58:48 +00:00
Automerger Merge Worker
9cb0920938 Merge "Zygote: migrate zygote start time metrics to StatsLog" into rvc-dev am: 720830ee90 am: 421713ccea am: 35887d7217 am: c840ab6b9c
Change-Id: I2fb4a01ac9c5ca55eaafc1118a13184e727d2aae
2020-02-28 00:54:28 +00:00
Keun young Park
ebac6a0d9b Zygote: migrate zygote start time metrics to StatsLog
- Also log second zygote start time as well.

Bug: 132691841
Test: check statsd dump
Change-Id: If749707dc5bcfefaeac1a476add076d2925af46d
2020-02-27 18:55:54 +00:00
Automerger Merge Worker
5caf1948e8 Merge "Include pending media as well when deleting mediastore entries." into rvc-dev am: 442399b1c1 am: 377d13b37e am: 49cf50aef9 am: f5f2b98b63
Change-Id: I504020913aca72138b00dd2e04553e974e007adf
2020-02-27 18:33:29 +00:00
Nicholas Ambur
626b24958f Merge "remove client token passing active VI service" into rvc-dev 2020-02-27 18:01:24 +00:00
Sudheer Shanka
442399b1c1 Merge "Include pending media as well when deleting mediastore entries." into rvc-dev 2020-02-27 17:49:53 +00:00
Adrian Roos
cd9cf09965 PhoneWindow: Fix potential memory leak
Fixes an issue where PhoneWindow and thus Activity can be leaked through AttachInfo through
the OnContentApplyWindowInsetsListener.

Fixes: 148799801
Test: make droid; atest WindowTest
Change-Id: I1de5518c84fd7e6d1aa1542a9252b1c600f5712d
2020-02-27 17:01:09 +00:00
Automerger Merge Worker
c650f81ce8 Merge "Pipe windowToken for hideSoftInput" into rvc-dev am: 73b1d16d28 am: cec5307235 am: ef8ebae6e5 am: 9048c195bd
Change-Id: I8c57e69f16efa58d320c44caf5da795743137c3c
2020-02-27 08:08:22 +00:00
Taran Singh
73b1d16d28 Merge "Pipe windowToken for hideSoftInput" into rvc-dev 2020-02-27 07:14:04 +00:00
Tarandeep Singh
4fe5b654a1 Pipe windowToken for hideSoftInput
Pipe the windowToken of the window requesting hideSoftInput just like we
did it for showSoftInput [1].
This calls hideInsets on the correct display when control target is
different from IME target e.g. ActivityView.
Also hideInsets should be called on InsetsControlTarget instead which was
originally attempted in [2]

[1]: Ia49e23dd077d264a58d28a7b8acffde54b7db187
[2]: I7133e151a1037c42b275b97857936437a7a6725f

Bug: 149870112
Bug: 133381284
Test: Manually using steps mentioned in bug.

Change-Id: Ia596a392eb73ae46debd097151c8c9a7edd59833
2020-02-27 04:13:25 +00:00
Automerger Merge Worker
7d2e051d92 Merge "Add API constraints to ScheduledJobStateChanged atom" into rvc-dev am: 13ecf63ba4 am: 2477a07249 am: 8900c9a867 am: c60fc6dd96
Change-Id: I12ea889ce87d61ddaa6e84ed23da6e7595ae33f4
2020-02-27 03:48:05 +00:00
TreeHugger Robot
13ecf63ba4 Merge "Add API constraints to ScheduledJobStateChanged atom" into rvc-dev 2020-02-27 02:57:01 +00:00
Automerger Merge Worker
5c14fe0612 Merge "Move libstatssocket to shared." into rvc-dev am: cb50e94e7a am: 92851d4d55 am: 2198604a5c am: 4cc58dd008
Change-Id: I1b06900ea5f2298df552925b17068256a0a71e3d
2020-02-27 01:44:55 +00:00
Automerger Merge Worker
9eb82b7af2 Merge "Remove IME surface when hidden" into rvc-dev am: 05b07c2657 am: 6b925b391b am: 9dbb1c7868 am: 66a16fbb54
Change-Id: I66fc20443e4c42f67561898c63b19669c37a562c
2020-02-27 01:44:22 +00:00
Christian Wailes
f10e42e2ae Merge "Cleanup of Zygote files" 2020-02-27 01:14:29 +00:00
Jeffrey Huang
cb50e94e7a Merge "Move libstatssocket to shared." into rvc-dev 2020-02-27 01:00:01 +00:00
Taran Singh
05b07c2657 Merge "Remove IME surface when hidden" into rvc-dev 2020-02-27 00:53:09 +00:00
Automerger Merge Worker
bad916c8a8 Merge "Start InstanceIDs at 1." into rvc-dev am: e1e7c02af4 am: 04d3a37b74 am: 764d127601 am: 59152ba9fc
Change-Id: Ieff2e27823a9b977292a89355b1ad9795430de62
2020-02-26 21:26:23 +00:00
Jeffrey Huang
21f7e6a3f6 Move libstatssocket to shared.
This fixes the boot loop when zygote tries
to log to statsd during boot time.

Linking libstatssocket statically from two different places
causes translation errors resulting in multiple instances of the
same struct being created. This meant that the struct is no longer
shared across the same process for opening/closing of the socket.

Bug: 149889582
Test: Phone boots
Change-Id: Ibfa25c0fe7874ba08157a5ec43601c5cf8305723
2020-02-26 11:51:26 -08:00
Tarandeep Singh
94c9a8328e Remove IME surface when hidden
When IME is no longer shown, notify IMS to hide the window surface.
This reclaims the memory allocated to IME window surface.

Fix: 150163310
Test: atest CtsInputMethodTests
      Manually:
      1. Open any app that has editor  and run
         adb shell  dumpsys SurfaceFlinger | grep Total
      2. Note down total memory
      3. Tap on editor and IME shows. Note down memory
         using command in #1. It should go up by ~27MB
      4. Hide IME and note down memory again.
         It should revert to original value in #1.

Change-Id: I6c2a13dd40b22d3fd62b4763ba369992e5ff1138
2020-02-26 18:58:33 +00:00
Eugene Susla
ab14c55c1f Generate @NonNull setter args and @MaySetToNull to opt out
Bug: 143653080
Test: source /usr/local/google/home/eugenesusla/android2/master/frameworks/base/tests/Codegen/runTest.sh
Change-Id: Iba8da34c91fd09e266429ab131add1d53449506b
2020-02-25 19:04:47 -08:00
Chris Wailes
94b45280d4 Cleanup of Zygote files
This CL cleans up some warnings in the ZygoteInit.java and
ZygoteServer.java files.  These warnings were mostly about unused
variables, protection class changes, and dead code.  Some changes
to code in Zygote.java and ZygoteConnection.java were needed due to
function signature changes.

Test: Built and booted image
Change-Id: I6ba33cfcb4729a75dbbd4f908f4b46110d3bb991
2020-02-25 15:55:31 -08:00
Will Brockman
4f0f9d2d85 Start InstanceIDs at 1.
Protobufs make it easy to confuse default and unset values.

Test: atest NotificationManagerServiceTest
Fixes: 149760215
Change-Id: Ia27f33cb8331960369f86e75ac3cfa148dad887a
2020-02-25 18:57:32 +00:00
TreeHugger Robot
20ea7f5258 Merge "Introduce SoftInputShowHideHistory" into rvc-dev 2020-02-25 05:35:25 +00:00
Nicholas Ambur
1ec50c8f2f remove client token passing active VI service
Previous implementation relied on client to pass a token which the
service used to verify if it was the active service. This is seen to be
a security concern as there is no way to verify how the client obtained
the token. Instead, a check is done to confirm the caller's UID matches
the UID of the active service.

In the case of voice model enrollment, KeyphraseEnrollmentInfo class is
leveraged. A client is allowed to enroll if it is the active voice
interaction service or if it is a voice model enrollment application
bundled with the system image.

All previous manifest permision checks still apply.

Bug: 148159858
Test: gts-tradefed run gts-dev -m GtsAssistIntentTestCases -t \
com.google.android.assist.gts.KeyphraseModelManagerTest \
\#testShouldEnrollOnlyWhenActiveService

Merged-In: Ie2c4653d365770a9123a22bc69822518b4ccc568
Change-Id: Ie2c4653d365770a9123a22bc69822518b4ccc568
(cherry picked from commit c6f4118f9e)
2020-02-25 01:20:05 +00:00
Nicholas Ambur
d291d14a39 Merge changes from topic "voiceinteraction-access-control"
* changes:
  remove client token passing active VI service
  add enrollment application UID tracking
2020-02-24 23:13:11 +00:00
Suprabh Shukla
1b5778d119 Add API constraints to ScheduledJobStateChanged atom
This helps us know if jobs with a particular constraint are being
starved or otherwise dysfunctional due to a bug.

Test: make statsd_testdrive &&
./out/host/linux-x86/bin/statsd_testdrive 8

Sample output:
    atom {
      scheduled_job_state_changed {
        attribution_node {
          uid: 10224
          tag: ""
        }
        job_name: "android.jobscheduler.cts.jobtestapp/.TestJobService"
        state: SCHEDULED
        stop_reason: STOP_REASON_CANCELLED
        standby_bucket: RESTRICTED
        job_id: 691
        has_charging_constraint: true
        has_battery_not_low_constraint: true
        has_storage_not_low_constraint: false
        has_timing_delay_constraint: false
        has_deadline_constraint: true
        has_idle_constraint: true
        has_connectivity_constraint: true
        has_content_trigger_constraint: false
      }

Bug: 138239687
Change-Id: I175e5a0f5cc2cb3be447ccb58142006946092e75
2020-02-24 19:09:46 +00:00
Dieter Hsu
0dbbb422e2 Retry TTS speaking for a11y shortcut warning dialog
TTS engine might fetch data over the network or prepare data when
binding tts service at first time after boot that may take a few
seconds. Because the dialog is shown only once and on-demand for
enableing accessibility shortcut, it's unable to speak successfully
unless others have bound tts ahead of time.

Bug: 139887992
Test: 1. adb shell settings delete secure accessibility_shortcut_dialog_shown
      2. manual reboot, long press both vol keys and tts speaks
Test: Add 2nd user and long press both vol keys and tts speaks
Test: atest AccessibilityShortcutControllerTest

Change-Id: I6290f0a64d1a51aa46f13e7d88a15a096ddb0fdc
Merged-In: I6290f0a64d1a51aa46f13e7d88a15a096ddb0fdc
2020-02-24 08:14:12 +00:00
lumark
d85e158db8 Introduce SoftInputShowHideHistory
Add SoftInputShowHideHistory class to monitor showSoftInput / hideSoftInput
histories, each entry data contains:
  - ClientState: IME focused client process pid / uid who
  shows / hides soft input
  - Current focused window
  - Target display ID
  - Reason: describes why show / hide input
  - Request show or hide input
  - Timestamp

Bug: 141738570
Test: manual by calling "adb shell dumpsys input_method"
Change-Id: I21ad1708d68eae59dcd3d414248193fb130dadc2
Merged-In: 10ecd64cdd
(cherry picked from commit 10ecd64cdd)
2020-02-24 07:55:29 +00:00
Dieter Hsu
7fb7b739e3 Retry TTS speaking for a11y shortcut warning dialog
TTS engine might fetch data over the network or prepare data when
binding tts service at first time after boot that may take a few
seconds. Because the dialog is shown only once and on-demand for
enableing accessibility shortcut, it's unable to speak successfully
unless others have bound tts ahead of time.

Bug: 139887992
Test: 1. adb shell settings delete secure accessibility_shortcut_dialog_shown
      2. manual reboot, long press both vol keys and tts speaks
Test: Add 2nd user and long press both vol keys and tts speaks
Test: atest AccessibilityShortcutControllerTest

Change-Id: I6290f0a64d1a51aa46f13e7d88a15a096ddb0fdc
2020-02-24 15:32:06 +08:00
Sudheer Shanka
7d28b5bf81 Include pending media as well when deleting mediastore entries.
Bug: 146914674
Bug: 140565622
Bug: 137381621
Test: manual
Change-Id: I903a13deb467b45839a7d03b60754c8fc464456c
2020-02-24 05:50:33 +00:00
Nicholas Ambur
c6f4118f9e remove client token passing active VI service
Previous implementation relied on client to pass a token which the
service used to verify if it was the active service. This is seen to be
a security concern as there is no way to verify how the client obtained
the token. Instead, a check is done to confirm the caller's UID matches
the UID of the active service.

In the case of voice model enrollment, KeyphraseEnrollmentInfo class is
leveraged. A client is allowed to enroll if it is the active voice
interaction service or if it is a voice model enrollment application
bundled with the system image.

All previous manifest permision checks still apply.

Bug: 148159858
Test: gts-tradefed run gts-dev -m GtsAssistIntentTestCases -t \
com.google.android.assist.gts.KeyphraseModelManagerTest \
\#testShouldEnrollOnlyWhenActiveService

Change-Id: Ie2c4653d365770a9123a22bc69822518b4ccc568
2020-02-23 20:43:17 -08:00
TreeHugger Robot
e57202e8d9 Merge "Introduce SoftInputShowHideHistory" 2020-02-22 07:17:47 +00:00
TreeHugger Robot
f2d6183351 Merge "Revert "Enable compositor shadows for PIP"" 2020-02-22 04:57:39 +00:00
Vishnu Nair
b77bc9bef4 Revert "Enable compositor shadows for PIP"
This reverts commit 1f03c5017a.

Reason for revert: client composition in pixel4 doesn't behave as expected. Multiple layers including pip and wallpaper are selected for client composition. 

Change-Id: I3d6be8b9b1768aeda35411b45b426c83a7379e36
2020-02-21 22:26:37 +00:00
Richard Gaywood
2a04318b00 Merge "Add method to return merged stats to AIDL" 2020-02-21 15:21:30 +00:00
TreeHugger Robot
f748ca137e Merge changes from topic "revert-10338939-YCRBMILGZV"
* changes:
  Revert "[NS D03] Migrate the bad wifi avoidance policy"
  Revert "[NS D04] Implement a simple speed comparison between scores."
2020-02-21 08:51:09 +00:00
Andrii Kulian
f753ea6cd6 Do not verify display context in DecorContext constructor
Non-activity context can be passed to DecorContext, so an exception
can be thrown when Context#getDisplay() call does verification.
An example is that a free dialog uses Application context as its context.

Bug: 149928768
Test: manual: test crashed apps reported in bugs before/after this patch.
Change-Id: Ib302c23cb8e2e388e7468f37f1b63b83ef52ef0e
2020-02-21 07:29:11 +00:00
Chalard Jean
5845d54106 Revert "[NS D03] Migrate the bad wifi avoidance policy"
Revert submission 10338939

Reason for revert: The feature was punted out of R.
Reverted Changes:
I32c12702c:[NS D04] Implement a simple speed comparison betwe...
I688593cc0:[NS D03] Migrate the bad wifi avoidance policy

Change-Id: I640635a1ed94bed3b53466abe2a988caf0eca2b0
2020-02-21 06:47:35 +00:00
TreeHugger Robot
2cf1cf436f Merge "Remove exception from OverlayConfig zygote method" 2020-02-20 21:13:47 +00:00
Haining Chen
6c839dd1c6 Merge "Implementations of biometric contraints for weak and convenience tiers (1) 24 hours fallback (2) 4 hours idle timeout" 2020-02-20 21:05:24 +00:00
Antoan Angelov
3688af691b Merge "Enable ViewPager swiping for intent resolver." 2020-02-20 20:48:57 +00:00
Ryan Mitchell
857ce7ace1 Remove exception from OverlayConfig zygote method
The AssetManager constructor is marked UnsupportedAppUsage and the
recent changes to OverlayConfig caused an exception to be thrown when
the function is not called from the root process.

Previously a warning message would be logged indicating that no static
overlays would be loaded. Removing the uid check will restore the
previous behavior.

Also remove the system uid checks for initializeSystemInstance so PMS
service can also be constructed during testing.

Bug: 149806146
Test: invoke new AssetManager() from non-root thread
Change-Id: I55af2cddeba4df7a99c281c93e0181b9e2139139
2020-02-20 11:11:29 -08:00
Ryan Mitchell
290bc3ba36 Merge "Add test mapping for Overlayconfig" 2020-02-20 17:45:19 +00:00
Richard Gaywood
3ee7557fb5 Add method to return merged stats to AIDL
For procstats aggregated stats collection, we need to expose the
aggregated ProcessStats object back to the caller.

Change-Id: Ifb52f813d679e3e0a1e061f983d8b4f539d6d72a
Test: nothing yet
2020-02-20 16:09:20 +00:00
Ryan Mitchell
105c546159 Add test mapping for Overlayconfig
Bug: 138458867
Test: atest
Change-Id: Ia5e3d8d4b548aae3f1cd44d5c2cf0db5bf420d34
2020-02-20 15:33:34 +00:00
Charles Chen
c56ce6fd08 Merge "Exempt-From-Owner-Approval: Report non-visual Context misuse" 2020-02-20 12:30:06 +00:00
Automerger Merge Worker
214e7a5f62 Merge "Check argument in PowerProfile.getNumCoresInCpuCluster" am: 74952231df am: 310c1b76ea am: 15bcefd386
Change-Id: I2029bc94536f3617da34bfc4ac18489819baa14a
2020-02-20 11:14:20 +00:00
Automerger Merge Worker
310c1b76ea Merge "Check argument in PowerProfile.getNumCoresInCpuCluster" am: 74952231df
Change-Id: Id1bf2fa710c24ba76efbc5ad9b83dab63b8c334a
2020-02-20 10:47:24 +00:00