Commit Graph

302 Commits

Author SHA1 Message Date
Mike LeBeau
6d54c172c3 am 1fffbd97: Fix keyboard not showing for global search on Dream. Rather than trying to call the hidden showSoftInputUnchecked method to show the IME in SearchDialog#show(), override onWindowFocusChanged in our subclass of AutoCompleteTextView so that whenever it gets
Merge commit '1fffbd97fa756ef7d3e7e885a5c1c8bb64380c20'

* commit '1fffbd97fa756ef7d3e7e885a5c1c8bb64380c20':
  Fix keyboard not showing for global search on Dream. Rather than trying to
2009-07-14 18:56:32 -07:00
Mike LeBeau
1fffbd97fa Fix keyboard not showing for global search on Dream. Rather than trying to
call the hidden showSoftInputUnchecked method to show the IME in SearchDialog#show(),
override onWindowFocusChanged in our subclass of AutoCompleteTextView so that whenever
it gets focus, we call the public showSoftInput method, passing in the ACTV, which is
the correct way to do this.

This fixes http://b/1930989.
2009-07-14 17:05:24 -07:00
Karl Rosaen
ce63850ff0 am 53d24af7: Respect onSearchRequested in Dialog and actually launch search. Also dismiss self.
Merge commit '53d24af774ad943ff26ef529c949f9c433806421'

* commit '53d24af774ad943ff26ef529c949f9c433806421':
  Respect onSearchRequested in Dialog and actually launch search.  Also dismiss self.
2009-07-14 16:03:39 -07:00
Karl Rosaen
53d24af774 Respect onSearchRequested in Dialog and actually launch search. Also dismiss self. 2009-07-14 15:52:58 -07:00
Android (Google) Code Review
c66c0abbb8 am 83a066c6: Merge change 7135 into donut
Merge commit '83a066c6d8ed953c3f5a1a44316509c9a9b0c6c2'

* commit '83a066c6d8ed953c3f5a1a44316509c9a9b0c6c2':
  Fixes lock on Home. Adds a new API on Dialog to get a callback when the dialog
2009-07-14 14:53:00 -07:00
Android (Google) Code Review
83a066c6d8 Merge change 7135 into donut
* changes:
  Fixes lock on Home. Adds a new API on Dialog to get a callback when the dialog shows.
2009-07-14 14:51:06 -07:00
Romain Guy
045163ac16 Fixes lock on Home. Adds a new API on Dialog to get a callback when the dialog
shows.
2009-07-14 14:50:31 -07:00
Dianne Hackborn
dace230043 resolved conflicts for merge of b06ea706 to master 2009-07-14 12:51:00 -07:00
Dianne Hackborn
b06ea70653 Add reporting of activity movement for search manager.
This adds a new API with the activity manager to find out about movement between
activities.  For my sanity, the old IActivityWatcher is now renamed to
IActivityController, and the new activity movement interface is named
IActivityWatcher.

This changes the search manager itself to use the new API to manage its state.
Note that there are still problems when going back to the search dialog after
it was hidden -- the suggestions window no longer appears until you explicitly
dismiss and re-show it.
2009-07-14 11:37:11 -07:00
Bjorn Bringert
cc916aa691 am c1d82e68: Use activity icon when search suggestion icon is missing
Merge commit 'c1d82e68eb4aae1b575e82b08e71a87670cc1532'

* commit 'c1d82e68eb4aae1b575e82b08e71a87670cc1532':
  Use activity icon when search suggestion icon is missing
2009-07-14 10:21:47 -07:00
Bjorn Bringert
c1d82e68eb Use activity icon when search suggestion icon is missing
New left-hand side icon fallback logic in search dialog:

1. If the search dialog gets no icon column, it shows no
   icon (like before). This would handle the case of in-app
   search where the provider does not include icons.
2. If the icon column is empty, or there is an error converting
   the icon id or URI to a drawable, the search dialog identifies
   the suggestion source by looking at the
   SUGGEST_COLUMN_INTENT_COMPONENT_NAME.
3. If SUGGEST_COLUMN_INTENT_COMPONENT_NAME is empty or not set,
   the current searchable activity is considered the suggestion source.
4. Try to get the activity icon of the suggestion source.
5. Fall back to the application icon of the suggestion source
   if there is no activity icon.
6. Fall back to some generic icon if there is no application icon.

Fixes http://b/issue?id=1905757
2009-07-14 13:52:01 +01:00
Mitsuru Oshima
a62e3e4d0f am ba3ba579: * Use cached resources for widgets
Merge commit 'ba3ba57921dedaaef669719c0359c0caf60e008b'

* commit 'ba3ba57921dedaaef669719c0359c0caf60e008b':
  * Use cached resources for widgets
2009-07-12 21:56:30 -07:00
Satish Sampath
17596e3adc am b1665f2e: Fix regression in handling the \'Go\' button
Merge commit 'b1665f2e15439f693b1ef75cb1c07593f99edde7'

* commit 'b1665f2e15439f693b1ef75cb1c07593f99edde7':
  Fix regression in handling the 'Go' button
2009-07-12 06:06:21 -07:00
Mitsuru Oshima
ba3ba57921 * Use cached resources for widgets 2009-07-11 21:50:16 -07:00
Satish Sampath
b1665f2e15 Fix regression in handling the 'Go' button
This was introduced in CL https://android-git.corp.google.com/g/6460.
Bug: http://b/issue?id=1970776
2009-07-10 22:35:48 +01:00
Bjorn Bringert
88588d137b am 0e01ea41: Deprecate DialogInterface methods in SearchManager
Merge commit '0e01ea41b215941128a4ea8dee454e6b35a4e798'

* commit '0e01ea41b215941128a4ea8dee454e6b35a4e798':
  Deprecate DialogInterface methods in SearchManager
2009-07-10 00:50:45 -07:00
Bjorn Bringert
0e01ea41b2 Deprecate DialogInterface methods in SearchManager
android.app.SearchManager implements
DialogInterface.OnDismissListener and DialogInterface.OnCancelListener
and thus exposes the methods onCancel(DialogInterface dialog) and
onDismiss(DialogInterface dialog). This was used by the SearchManager
to register itself as a listener on the search dialog, but is no
longer used.

This was an implementation detail that leaked into the public
API. Removing them would change the API, so they are deprecated instead.

Fixes http://b/issue?id=1962203
2009-07-10 07:16:47 +01:00
Android (Google) Code Review
13725324a7 am dded214e: Merge change 6689 into donut
Merge commit 'dded214eb92cebdd7fb2e6405173ffc1932e795a'

* commit 'dded214eb92cebdd7fb2e6405173ffc1932e795a':
  Don't crash the app when restore agent bringup throws
2009-07-09 16:00:24 -07:00
Christopher Tate
d1475e0375 Don't crash the app when restore agent bringup throws
Restore runs during the SetupWizard, before the phone is usable per se, so we
want to avoid presenting the usual "Application whatever has crashed..." dialog
to the user in the middle of that process.  This change modifies the exception
handling around agent bringup so that agent-originated exceptions are caught and
a null agent binder reported to the backup manager.

There are three points during this code sequence at which an exception can be
thrown due to application-code error:

+ the app's manifest can name a nonexistent or malformed BackupAgent class,
incurring a VM-level exception like ClassNotFound or BadCast.
- the agent's onCreate() method could crash/throw.
- the agent's onBind() method could crash/throw.

The new code arrangement here puts a try/catch around all of these possible
failure points.  When the code is invoked for backup, any caught exception is
merely rethrown.  During restore, however, execution is allowed to proceed
through reporting the app's agent binder back to the activity manager.  If any
exception was thrown, this reported binder will be null, i.e. a clean failure
notification to the backup manager.

What this code does *not* do at present is tear down the app when an exception
has been thrown.  This is happens if the exception is allowed to propagate.
Doing so cleanly is problematic, however, in circumstances where mutiple apps
and agents share a process.  Leaving the background process around until it is
torn down by the usual policies is probably the safer course at present.
2009-07-09 15:36:17 -07:00
Satish Sampath
97b3ed69db am 313ea433: Make suggestion text color change based on the item state.
Merge commit '313ea433d18e7fd5438b94c0606c496fcc7a2f88'

* commit '313ea433d18e7fd5438b94c0606c496fcc7a2f88':
  Make suggestion text color change based on the item state.
2009-07-09 12:49:53 -07:00
Android (Google) Code Review
bda4584bf6 am f9b7faee: Merge change 6503 into donut
Merge commit 'f9b7faee88313c4daf3e3fb34203978de20b7ce0'

* commit 'f9b7faee88313c4daf3e3fb34203978de20b7ce0':
  Hide soft keyboard in SearchDialog.dismiss()
2009-07-09 12:49:26 -07:00
Satish Sampath
313ea433d1 Make suggestion text color change based on the item state.
We support a ColorStateList reference now as a valid font color value
in the given html and manage html strings for all supported states
which we dynamically set while drawing the items.

This will get checked in along with changes to GlobalSearch,
EnhancedGoogleSearchProvider and Browser to make them use the new
model.

Bug: http://b/issue?id=1865037
2009-07-09 16:48:16 +01:00
Android (Google) Code Review
f9b7faee88 Merge change 6503 into donut
* changes:
  Hide soft keyboard in SearchDialog.dismiss()
2009-07-09 00:29:38 -07:00
Romain Guy
125cfce09d am 6de4aed1: Fixes #1933428. Call onPrepareDialog() on managed dialogs after their onCreate() is finished.
Merge commit '6de4aed1c67263269f83f579ec5b06263d173ef3'

* commit '6de4aed1c67263269f83f579ec5b06263d173ef3':
  Fixes #1933428. Call onPrepareDialog() on managed dialogs after their onCreate() is finished.
2009-07-08 14:45:11 -07:00
Romain Guy
6de4aed1c6 Fixes #1933428. Call onPrepareDialog() on managed dialogs after their onCreate() is finished. 2009-07-08 13:56:28 -07:00
Android (Google) Code Review
cd964761dc am 91b0a701: Merge change 6284 into donut
Merge commit '91b0a7013e4b6d170087cb4c9a3c35b787f92a6b'

* commit '91b0a7013e4b6d170087cb4c9a3c35b787f92a6b':
  Run search UI on its own thread.
2009-07-08 13:52:26 -07:00
Bjorn Bringert
ec8ee34e06 Hide soft keyboard in SearchDialog.dismiss()
Before it was hidden in cancel(), which does not get
called when the search dialog is dismissed by clicking
on a suggestion.

Fixes http://b/issue?id=1967633
2009-07-08 21:49:42 +01:00
Bjorn Bringert
444c727e0e Run search UI on its own thread.
Details:

- Add a new SearchDialogWrapper class that makes sure
  all access to the SearchDialog is run one a single thread
  other than the main ServerThread.
- Don't save/restore seach dialog state in Activity.
  This resulted in lots of calls to the SearchManager
  throughout the life cycle of all activities, for
  the questionable benefit of restoring the search dialog
  in a few cases.
- Remove search UI state save/restore, and the isVisible()
  method from SearchManagerService. They are no longer used,
  and were tricky to implement since they return values from
  the search UI thread to the service.
- Handle configuration changes in searchDialogWrapper instead
  of calling through from Activity.

Fixes http://b/issue?id=1938101

TODO:
- Activity.performPause() calls stopSearch(). This call may not happen
  until the new activity has been started. If the new activity starts a
  search immediately, this search could be cancelled by the old activity's
  call top stopSearch().
2009-07-08 17:43:49 +01:00
Satish Sampath
f1d0b7cd10 am d21572cd: NEW_API: Expose autoUrlDetect searchable attribute.
Merge commit 'd21572cd446e56efe94689324107927ac2bffd2a'

* commit 'd21572cd446e56efe94689324107927ac2bffd2a':
  NEW_API: Expose autoUrlDetect searchable attribute.
2009-07-08 09:17:21 -07:00
Satish Sampath
d21572cd44 NEW_API: Expose autoUrlDetect searchable attribute.
If provided and true, URLs entered in the search dialog while searching within this activity would be detected and treated as URLs (show a 'go' button in the keyboard and invoke the browser directly when user launches the URL instead of passing the URL to the activity). If set to false any URLs entered are treated as normal query text.
The default value is false. This is an optional attribute.
2009-07-08 15:09:08 +01:00
Simon Schoar
8cf97d9982 Removed usage of tabs for indention 2009-07-07 12:45:46 -07:00
Simon Schoar
d45c9f4ceb Prevent IndexOutOfBoundsException on toString() if vibrate array is empty (non null)
example: notification.vibrate = new long[0];
2009-07-07 12:45:33 -07:00
Mitsuru Oshima
ce3082e745 am 569076c9: widgets scaling fix. Use container\'s compatibility info and display metrics when container and widgets disagree.
Merge commit '569076c9f6bdadb4d3285a26e069634a839b5b87'

* commit '569076c9f6bdadb4d3285a26e069634a839b5b87':
  widgets scaling fix. Use container's compatibility info and display metrics when container and widgets disagree.
2009-07-06 21:24:08 -07:00
Mitsuru Oshima
569076c9f6 widgets scaling fix. Use container's compatibility info and display metrics when container and widgets disagree. 2009-07-06 21:13:39 -07:00
Romain Guy
a2b5dab5b7 am 870e09fc: Fixes #1963229. Introduces Context#isRestricted().
Merge commit '870e09fcd2dfdc12ac318962efd28b0420c562bb'

* commit '870e09fcd2dfdc12ac318962efd28b0420c562bb':
  Fixes #1963229. Introduces Context#isRestricted().
2009-07-06 17:10:41 -07:00
Romain Guy
870e09fcd2 Fixes #1963229. Introduces Context#isRestricted().
A restricted Context is a special type of Context that prevents specific features
from being used. For instance, android:onClick, used by View, can be dangerous when
used from within apps widgets. By using a restricted Context to inflate apps widgets,
widgets providers are prevented from using android:onClick.
2009-07-06 16:45:17 -07:00
Android (Google) Code Review
ace82fbabd am 21509240: Merge change 6283 into donut
Merge commit '21509240b0ba00675ffc69038f20726bf8666c57'

* commit '21509240b0ba00675ffc69038f20726bf8666c57':
  Fix a bug where clicking the "more results" suggestion with the trackball
2009-07-06 14:45:16 -07:00
Mike LeBeau
617202a53a Fix a bug where clicking the "more results" suggestion with the trackball
did not seem to expand to show the corpus selectors. (http://b/1906643)

It turns out that when the trackball was used to select this item, onItemClick
was getting called on the listener twice in AutoCompleteTextView#onKeyUp:
once when we call onKeyUp on the DropDownListView, and once a little further
down when we call performCompletion(). In our case, performCompletion() is
useless since it was intended for normal AutoCompleteTextViews which populate
text into the TextView when an item in the list is clicked, but we do not
rely on this. So the easiest fix is just to make performCompletion() do nothing
in our SearchAutoComplete subclass.
2009-07-06 14:29:25 -07:00
Android (Google) Code Review
0d0012ef16 am 54af78a3: Merge change 5950 into donut
Merge commit '54af78a3f7064e04d7ebd64c985d4149f9f7b05c'

* commit '54af78a3f7064e04d7ebd64c985d4149f9f7b05c':
  Fix memory leaks in system_server
2009-07-02 15:23:56 -07:00
Satish Sampath
ed9f4c4c2f am fef8d3e4: Make search UI open up quicker to the user.
Merge commit 'fef8d3e4d8f6f46c098d04b3a57409c947ec1c75'

* commit 'fef8d3e4d8f6f46c098d04b3a57409c947ec1c75':
  Make search UI open up quicker to the user.
2009-07-02 15:23:32 -07:00
Android (Google) Code Review
0901c82336 am 91c91b74: Merge change 5817 into donut
Merge commit '91c91b74df12e40c31a50ecb807ac60bed2ccb58'

* commit '91c91b74df12e40c31a50ecb807ac60bed2ccb58':
  Replace indeterminate progress animated asset with new ones
2009-07-01 16:01:40 -07:00
Android (Google) Code Review
54af78a3f7 Merge change 5950 into donut
* changes:
  Fix memory leaks in system_server unlink DeathRecipients in a whole bunch of places to avoid memory leaks
2009-07-01 12:52:39 -07:00
Suchi Amalapurapu
fff2fda019 Fix memory leaks in system_server
unlink DeathRecipients in a whole bunch of places to avoid memory leaks
2009-07-01 12:55:30 -07:00
Satish Sampath
fef8d3e4d8 Make search UI open up quicker to the user.
On invoking the search UI, the drop down list box with past queries and shortcut items
appears after a few hundreds of milliseconds on screen. This was because we were
displaying the drop down within the onFilterCompleted callback after the list box filtered
the items based on the given query text. While that code path is necessary, for the first
invocation of the search dialog with an empty query we can show the list box before the
text stuff happens. This change does that, issuing an async request to show the drop
down after pending events have been processed.

Without this change, on an average it took 350ms for the code to show the drop down.
With this change, on an average it takes 150ms.
2009-07-01 17:55:31 +01:00
Romain Guy
b5537c4522 Replace indeterminate progress animated asset with new ones 2009-06-30 12:39:18 -07:00
Android (Google) Code Review
4658e8ece6 am 05ebcb51: Merge change 5609 into donut
Merge commit '05ebcb5172679a6c196cbf23d7174c04dd9f6ae0'

* commit '05ebcb5172679a6c196cbf23d7174c04dd9f6ae0':
  Update spinner's drawables. Clean up resources, pave the way for new animation.
2009-06-29 20:20:11 -07:00
Romain Guy
f4f7046183 Update spinner's drawables. Clean up resources, pave the way for new animation. 2009-06-26 19:21:54 -07:00
Android (Google) Code Review
2df7c15aa0 am b505ae41: Merge change 5459 into donut
Merge commit 'b505ae4195d9b8a93c71b1f9da6d7d8c3aaa3c08'

* commit 'b505ae4195d9b8a93c71b1f9da6d7d8c3aaa3c08':
  Make the BackupHelperDispatcher properly handle multiple helpers.
2009-06-25 18:06:01 -07:00
Joe Onorato
4ababd922e Make the BackupHelperDispatcher properly handle multiple helpers. 2009-06-25 20:36:09 -04:00
Android (Google) Code Review
9c71fc972e am a7251991: Merge change 5288 into donut
Merge commit 'a7251991ffb6a26e4cf23e60633c8250c78bd9df'

* commit 'a7251991ffb6a26e4cf23e60633c8250c78bd9df':
  Invoke getSystem.updateConfiguration when binding an application to
2009-06-25 12:16:48 -07:00