Commit Graph

1487 Commits

Author SHA1 Message Date
Jason Chang
206ad5db63 Merge "Add metrics log for One-handed mode Shortcut toggle switch" into sc-dev am: 56bb99d410
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15207284

Change-Id: If2a40b20a577f56084854de918b3a1776e92247b
2021-07-09 11:42:23 +00:00
Jason Chang
97b75f09ed Add metrics log for One-handed mode Shortcut toggle switch
To write metrics log for One-handed mode Shortcut toggle switch state.

Bug: 192641587

Test: Local add logs to verify before writing metrics logs API call
Test: atest SystemUITests
Test: atest WMShellTests
Change-Id: I02fda724bf2960355d78f1a26ac6d65225687176
2021-07-09 03:24:58 +00:00
Bill Lin
8db534922d Merge "Improve SystemUIBootTiming performance in OneHandedController" into sc-dev am: 7f162ddaf0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15175505

Change-Id: I678c86456cea4da5cee5be133fde3bba4881da10
2021-07-09 02:02:24 +00:00
Bill Lin
7f162ddaf0 Merge "Improve SystemUIBootTiming performance in OneHandedController" into sc-dev 2021-07-09 02:00:33 +00:00
Evan Rosky
33edb79a30 Merge "Hooks for interracting with stage split components using legacy recentsanimation" into sc-v2-dev 2021-07-08 22:05:54 +00:00
Chris Li
c769062301 Merge "Revert "Revert "Not show size compat UI when task is not visible""" into sc-dev am: 50c03ea7ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15237129

Change-Id: I8c2e257e5a2b7d89814288d5d8cd2e24af76c722
2021-07-08 22:03:19 +00:00
Chris Li
64c167d613 Merge "Skip stage-split stateChange tests when using shell transit" into sc-v2-dev 2021-07-08 20:12:32 +00:00
Chris Li
a23a2bb5db Revert "Revert "Not show size compat UI when task is not visible""
This reverts commit 76370b6fe6.

Reason for revert: Fix the merge break in ShellTaskOrganizerTests.java

Fix: 193069342
Test: atest WMShellUnitTests:ShellTaskOrganizerTests
Change-Id: I02c4bddc407eaac0ebb7cd5abb0b394f242d4d6e
2021-07-08 12:09:40 -07:00
Chris Li
e7ed99bfc2 Merge "Remove TaskInfo#topActivityToken usage in size compat for security" into sc-dev 2021-07-08 18:05:40 +00:00
Evan Rosky
17b6a3939f Hooks for interracting with stage split components using legacy recentsanimation
Recents is pretty complicated, so the best way to deal with this is to
have launcher notify/query shell when entering recents. This gives
shell a chance to prepare and then provide relevant leashes (for now
just the bar, but it may include others in the future like side-
outline).

Bug: 192292305
Test: Enable SPLIT_SELECT and go to recents from split.
Change-Id: Iff6b14a1b0b95f207bdaa341c62fc6582659e923
2021-07-08 09:03:29 -07:00
Evan Rosky
5ca3820ae6 Hook up split-launch to legacy transition system
Part 1 of hooking up stage-split to legacy stuff. This
actually routes the legacy remoteAnimation through shell
in order to gather the dividerbar and interract with the
WindowProcessController

Bug: 192279476
Test: atest WindowOrganizerTests.
      use SPLIT_SELECT to launch 2 apps in split and observe.
Change-Id: I4f8802e6eb33f068fae0e4b3c12942bea76e332b
2021-07-08 09:02:59 -07:00
Leon Jeng
979db138fe Revert "Not show size compat UI when task is not visible" am: 76370b6fe6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15232572

Change-Id: Ib61cabd6c4d77d4fa5cd3f64b2272fcd684db153
2021-07-08 10:01:44 +00:00
Leon Jeng
76370b6fe6 Revert "Not show size compat UI when task is not visible"
This reverts commit adb92508c0.

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?branch=git_master&target=coral-userdebug&lkgb=7530814&lkbb=7530923&fkbb=7530923, bug b/193105445

Bug: 193105445
Change-Id: I697229da6986d6466d7f13872e9ae7a727b80838
2021-07-08 09:48:10 +00:00
Chris Li
2d8b03190d Merge "Not show size compat UI when task is not visible" into sc-dev am: 927c644bfa
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15225378

Change-Id: Ic80035d84e4e2f2a5471bd4f85cc90ff61cda49f
2021-07-08 07:01:54 +00:00
Bill Lin
3aafe19994 Improve SystemUIBootTiming performance in OneHandedController
Fix race condition in SystemUIBootTiming issue.

1. Avoid updateOneHandedEnabled() called twice during init
   a. [O] come from setOneHandedEnabled()
   b. [X] come from setSwipeToNotificationEnabled()
2. Passively waiting shortcut enabled changed callback, and then
         query setting ACCESSIBILITY_BUTTON_TARGETS status.
3. Add a new flag isShortcutEnabled to cache shortcut enabled
   state.
4. By new OHM Settings UX design setSwipeToNotificationEnabled()
   should NOT setEnabledGesturalOverlay().
5. Remove redundant auto enabled Toast and print in log instead.
   (In general case, user is not able to see the Toast)

Test: atest google/perf/boottime/boottime-test
Test: atest SystemUITests
Test: atest WMShellTests
Test: manual factory reboot, OHM should disabled by default
Bug: 192612924
Change-Id: I8b24c99bc8bd5bfb17c73a6bb8494109d9a8170d
2021-07-08 14:14:25 +08:00
Chris Li
927c644bfa Merge "Not show size compat UI when task is not visible" into sc-dev 2021-07-08 05:53:15 +00:00
Chris Li
1245aefa49 Remove TaskInfo#topActivityToken usage in size compat for security
Security report shows that this can cause leak token of different app.

Replace the functionality with a callback to the TaskOrganizerController
to restart activity when size compat restart button is clicked.

Bug: 186776724
Test: manually verify the restart button still works
Change-Id: I097b9f02e8435e6765695b9d5a531a4e165bac66
Merged-In: I097b9f02e8435e6765695b9d5a531a4e165bac66
2021-07-07 21:09:24 -07:00
Chris Li
9d86a7b10f Merge "Remove TaskInfo#topActivityToken usage in size compat for security" into sc-v2-dev 2021-07-08 03:49:35 +00:00
Jerry Chang
5917a9cc73 Merge "Prevent flickering between fullscreen and multi-window of main stage" into sc-v2-dev 2021-07-08 01:36:39 +00:00
Chris Li
adb92508c0 Not show size compat UI when task is not visible
Before, when a size compat task was hidden, the size compat UI might
still be showing. Now, remove the UI when the task is no longer visible.

Bug: 193069342
Test: manually verify the size compat button is not showing in recents
Change-Id: Ia17a97f5e7a9af497d8da16b31bb5169dd502d53
2021-07-07 17:46:08 -07:00
Ben Lin
be4ca9ad6d Merge "PiP: Update accessibility window as menu shows/hides." into sc-dev am: c701a4c904
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15191317

Change-Id: I88408f18855c48bbbb2a68966b65d1ac3e63d054
2021-07-08 00:16:18 +00:00
Ben Lin
c701a4c904 Merge "PiP: Update accessibility window as menu shows/hides." into sc-dev 2021-07-08 00:01:25 +00:00
Chris Li
ae54032e9a Remove TaskInfo#topActivityToken usage in size compat for security
Security report shows that this can cause leak token of different app.

Replace the functionality with a callback to the TaskOrganizerController
to restart activity when size compat restart button is clicked.

Bug: 186776724
Test: manually verify the restart button still works
Change-Id: I097b9f02e8435e6765695b9d5a531a4e165bac66
2021-07-07 12:50:53 -07:00
Ben Lin
d48bec9beb PiP: Update accessibility window as menu shows/hides.
When calculcating accessibility regions w/ shell root, currently since
shell root has no information on the child views' alpha, visibility,
etc, it is always detected as active by the a11y controller. Update the
accessibility region for PIP as menu shows and hides so that the
controller can take this into consideration.

Bug: 192524653
Test: Switch access to PIP when menu shows - able to navigate around
menu items. Switch Access to PIP when menu is gone - able to select PIP
itself.

Change-Id: I7d5649ecbf98751a117c58ac8127584bc3196910
2021-07-07 12:25:00 -07:00
Bill Yi
71be08107c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9120bcce06036ec258aea077d3e60134b7a2c1d1
2021-07-07 13:40:10 +00:00
Wei Sheng Shih
7eb36efc22 Merge "Prevent apply system insets on splash screen from FITS_SYSTEM_WINDOWS" into sc-dev am: f8a49bec00
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15218875

Change-Id: Ic84b6592fa3a930645f2c86d7cdca5b798e0b186
2021-07-07 11:26:48 +00:00
Wei Sheng Shih
f8a49bec00 Merge "Prevent apply system insets on splash screen from FITS_SYSTEM_WINDOWS" into sc-dev 2021-07-07 11:11:03 +00:00
wilsonshih
d5957a4735 Prevent apply system insets on splash screen from FITS_SYSTEM_WINDOWS
Similar to b/191339594, the context from application contains
View_fitsSystemWindows attributes, thus apply system insets to the
root FrameLayout.

Fixes: 192404431
Test: manual launch several apps from Launcher/Notification.
Tets: atest SplashscreenTests
Change-Id: I4746550de5e2a35ec364e09b631e87b41556a8b9
2021-07-07 11:28:30 +08:00
Jerry Chang
9009a944be Prevent flickering between fullscreen and multi-window of main stage
When both stage's visibility changed to visible, main stage might
receives visibility changed before side stage if it has higher z-order
than side stage. Make sure we only update main stage's windowing mode
with the visibility changed of side stage to prevent stacking multiple
windowing mode transactions which result to flicker issue.

Fix: 192926422
Bug: 186614428
Test: trigger stage split and toggle IME panel on main stage to reorder
main stage above side stage, obesrved stage split won't flicker after
dismissed keyguard.

Change-Id: Ib5e69fa35cc8d0c2b68415ae0689aea2988c7549
2021-07-06 15:15:15 +00:00
Evan Rosky
12056ba8f2 Skip stage-split stateChange tests when using shell transit
with shell transitions, the transition itself manages stage-split
state.

Bug: 183993924
Test: atest StageTaskListenerTests
Change-Id: Ic742d3a23c080d68812a5795ab490b56eea7e4a4
2021-07-06 03:42:31 +00:00
Evan Rosky
dfe1fc5554 Hook up shell transit to metrics and interleave abort with merge
Hooks up shell transitions to the activitymetricslogger and proto
state for app-transitions.

Also fixes interleaving of transition abort and merge.

Bug: 183993924
Test: atest ActivityMetricsLoggerTests
Change-Id: I0ecee0cc23093d00a83e0c8b0ce2c0b9a8ce7aff
2021-07-05 20:32:07 -07:00
Vadim Caen
c56fa470bd Merge "Implement the legacy splash screen behavior" into sc-dev am: 2be72d030b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14920934

Change-Id: If3cb25fa466589eed613c1b122e638533631a549
2021-07-05 15:46:35 +00:00
Vadim Caen
2be72d030b Merge "Implement the legacy splash screen behavior" into sc-dev 2021-07-05 15:35:01 +00:00
Tony Huang
6366de237e Merge "Set resizing to false if no fling animation" into sc-v2-dev 2021-07-05 06:11:11 +00:00
TreeHugger Robot
6be2b2eff1 Merge "Fix NPE in TvPipController" into sc-dev am: 03b61d22b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15156230

Change-Id: I020a1fe1734400f83b6a7fde85717da1e0826bf8
2021-07-02 22:40:42 +00:00
TreeHugger Robot
03b61d22b6 Merge "Fix NPE in TvPipController" into sc-dev 2021-07-02 22:25:09 +00:00
TreeHugger Robot
3760ff5953 Merge "Switch back to sync IInputMethodManager" into sc-dev am: 4e944d4634
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15176334

Change-Id: I98fc3154d5384ac6c0d75428c059d6fe8e4c7b68
2021-07-02 15:37:19 +00:00
Tony Huang
3912b53d18 Set resizing to false if no fling animation
While dobble taps gesture, it may moves the divider bar
meanwhile, it means we set resizing to true but didn't set it back
to false because position is same and no animation. We should set
resizing to false for such status.

Also fix such bug on legacy split screen. We call stopDragging with
no animation in some status, it should call setResizing false too.

Fix: 192635568
Test: Eanble stage split with any two apps and dobble tap on divider
      many times.
Change-Id: I170e3de347cc5fc19eaa1cd3d64922b2b631e550
2021-07-02 09:12:49 +00:00
Yohei Yukawa
9dde701446 Switch back to sync IInputMethodManager
This CL logically reverts recent CLs [1][2][3][4][5][6][7][8][9] to
switch back to the previous sync IPC approach in IInputMethodManager
except for the following two IPCs.

 * reportPerceptibleAsync
 * removeImeSurfaceFromWindowAsync

Reason for revert:
We need more time to understand its performance implications.

 [1]: If4b40244a2e0e3b11c38c1da9340ba8e5166ad64
      b9590fa1e1
 [2]: If79e063641a01b325c63eb9f871f5b992d7c0b72
      5a5648dcb5
 [3]: I1547b98b2aacf764e33aadc9ab784f2013f58f2f
      d833f0dab4
 [4]: I646ef4ae0570aae1812ea267f309441fdec6938d
      38fd020616
 [5]: Iaa63e01453da4ff0e3f446eac036b3be3180cb73
      4a820ccc41
 [6]: Id516fd1c961f43ac3e139c88d7ed004c188d458b
      0a32fd21ef
 [7]: Icb396ae5d74060af69c4ecb16723b2e37b9f2067
      c4663ba6a9
 [8]: I3eafbc28ed3acf3ba859885bf201cb06b3149b94
      f226a79fee
 [9]: Ic584203c1221fbae17f5e2d8f09e3992df061646
      5e2d9f271d

Bug: 163453493
Bug: 174892351
Fix: 190486491
Test: atest CtsInputMethodTestCases
Change-Id: If16ac0de536d9089eb04f6e07b1ee47378124658
Merged-In: If16ac0de536d9089eb04f6e07b1ee47378124658
2021-07-02 07:06:07 +00:00
Vadim Caen
f08dae3158 Implement the legacy splash screen behavior
For apps opted out of the new splash screen, we show the full background
drawable.
Ensure there has send the splash screen background color to
StartingWindowListener.

Bug: 182880656
Test: manual set useLegacy to true then verify legacy splash screen.
Test: atest WmTests:ActivityRecordTests
Test: atest StartingSurfaceDrawerTests

Change-Id: Icf662f3c5f368f447e718f82f78dc25b909ca9be
2021-07-01 15:05:06 +08:00
Hongwei Wang
395c582b62 Merge "PiP: Move tap-outside-hide block one level higher." into sc-dev 2021-07-01 04:31:08 +00:00
TreeHugger Robot
5a43b726d4 Merge "Restore split layout when wm-shell no longer controlling IME" into sc-dev 2021-07-01 00:48:07 +00:00
Ben Lin
67760d21fd PiP: Move tap-outside-hide block one level higher.
This used to be only check for drag resize case, but now that it is
disabled, this is no longer called. Move it at a higher call block so
that it is also checked for pinch resizing case.

Bug: 191529856
Test: Tap outside PIP when menu is showing, it hides
Change-Id: I810a0825a96224b395dde7d51df077fed996c3ff
Merged-In: I810a0825a96224b395dde7d51df077fed996c3ff
(cherry picked from commit 3892e8e09f)
2021-06-30 22:03:26 +00:00
TreeHugger Robot
55d4b08c43 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-06-30 20:43:10 +00:00
TreeHugger Robot
6019a35fc6 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-06-30 19:44:14 +00:00
Bill Yi
47c79280db Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I0ed984dbfb454ec6d63bf3081f42b7eed11b34b1
2021-06-30 18:14:54 +00:00
Bill Yi
87b485f2dd Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ia1e7179f98a762a7f4ea8cfc3cc6cd17e9e97072
2021-06-30 18:13:21 +00:00
Jorge Gil
e321a8eb61 Merge "Cancel ongoing PIP animations in onTaskVanished" into sc-dev am: c794661b9a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/15099049

Change-Id: I29f363203da762f76cfa99a1c40c558ed2b1cc54
2021-06-30 14:47:47 +00:00
Jacqueline Bronger
a205547d8b Fix NPE in TvPipController
Test: atest android.accessibilityservice.cts.AccessibilityWindowReportingTest#putWindowInPictureInPicture_generatesEventAndReportsProperty
Bug: 189418438
Change-Id: I28e5eb78dcade1c83ee53ed88bee84834e618615
2021-06-30 14:38:36 +00:00
Jorge Gil
c794661b9a Merge "Cancel ongoing PIP animations in onTaskVanished" into sc-dev 2021-06-30 14:27:18 +00:00