Commit Graph

21163 Commits

Author SHA1 Message Date
TreeHugger Robot
44b93686b9 Merge "Move to Extension for handling plugins plus default." 2019-01-10 20:52:03 +00:00
Fabian Kozynski
959d407aa0 Merge "Sets clickability of QuickStatusBarHeader" 2019-01-10 19:58:30 +00:00
Fabian Kozynski
1b1e82aa45 Merge "Sets views clickable according to their visibility" 2019-01-10 19:58:20 +00:00
Fabian Kozynski
c9f60fb4d2 Merge "Permission Hub opens properly from Keyguard" 2019-01-10 19:10:08 +00:00
TreeHugger Robot
dcc45dcbbc Merge "Swipe up to unlock when pulsing" 2019-01-10 18:48:30 +00:00
Robert Snoeberger
8bf1a3c125 Move to Extension for handling plugins plus default.
Bug: 118761043
Test: KeyguardClockSwitchTest adapted and passes.
Change-Id: I747274af894845a867b0d1ca38b2fd3338798e01
2019-01-10 13:44:00 -05:00
Lucas Dupin
03270e1f37 Merge "Config to disable rounded corners" 2019-01-10 17:44:31 +00:00
Ned Burns
266d408dae Merge "Move "alerted recently" logic out of NEM" 2019-01-10 17:17:47 +00:00
Fabian Kozynski
9a15b7c5ae Sets clickability of QuickStatusBarHeader
Sets the clickability based on QS expansion. Then, when it's expanded,
it is not clickable as QSPanel captures clicks. The top status bar is
always clickable

Test: manual, including brightness slider
Change-Id: Id41473f823285f115240effbea7a2d52596b9bfe
Fixes: 120873445
2019-01-10 11:13:27 -05:00
TreeHugger Robot
ccfc793fe2 Merge "Enable ActivityView in bubbles" 2019-01-10 16:03:24 +00:00
Fabian Kozynski
6c20dad4f4 Merge "AppOpsController implements Dumpable" 2019-01-10 16:00:33 +00:00
Fabian Kozynski
fe90f564de Sets views clickable according to their visibility
Small targets in QSFooterImpl that were obscured were registering
clicks, as QSFooterImpl is VISIBLE even if its elements are not.

Test: manual
Change-Id: I42a41045da2225bcd6a5f74f0e8589ddc8fef5f2
Fixes: 120677657
2019-01-10 10:21:19 -05:00
Milo Sredkov
41dc4ba3c6 Make the tap-to-edit behaviour configurable
Add a new key-value pair to smart_replies_in_notifications_flags that
controls the default tap-to-edit behaviour.

Bug: 111437455
Test: atest SmartReplyConstantsTest
Test: Try "adb shell settings put global smart_replies_in_notifications_flags edit_choices_before_sending=true" and observe
Change-Id: Ida90b98c28f4183697e84a6722768d41c72dd9cf
2019-01-10 10:44:26 +00:00
Lucas Dupin
1c32743a11 Swipe up to unlock when pulsing
Bug: 111405682
Test: adb shell am broadcast -a com.android.systemui.doze.pulse com.android.systemui
Change-Id: Ida5adb6a18f3ee992b1d154e10b35ba244f5b712
2019-01-09 16:39:36 -08:00
Fabian Kozynski
554fb7778b Permission Hub opens properly from Keyguard
Test: manual
Change-Id: I2b0fc752f9f9393dbd8b518d3762d59a9c7611a6
Fixes: 121457524
2019-01-09 17:04:56 -05:00
Ned Burns
3da3c78771 Move "alerted recently" logic out of NEM
Test: manual
Change-Id: I22c0d28fc347c55cb87f0dac7f5d11ca47ebbf5a
2019-01-09 16:25:09 -05:00
Mark Renouf
89b1a4af26 Enable ActivityView in bubbles
Test: manually
Bug: 111236845
Change-Id: I9ed749c2bfe0c883c85a32514f087785b9d63719
2019-01-09 16:17:00 -05:00
Mady Mellor
1fba2a6213 Merge "NotificationEntryListener: pre & post onEntryUpdated" 2019-01-09 19:52:26 +00:00
Lucas Dupin
f36d0dcfca Config to disable rounded corners
Some devices shouldn't render rounded corners because of graphics
limitations.

Bug: 122347746
Test: swipe up on multiple types of devices: walleye, sailfish, blueline
Change-Id: I93fcb4283ed1aa3df5569454483a8867a3bfd06b
2019-01-09 11:52:09 -08:00
TreeHugger Robot
3b20f73b80 Merge "Revert "Sets views clickable according to their visibility"" 2019-01-09 18:22:35 +00:00
Fabian Kozynski
b7b58797dd AppOpsController implements Dumpable
Test: adb bugreport
Change-Id: I4770ccef57d152adfbdfa5d4b4507666517c0238
2019-01-09 13:08:15 -05:00
Fabian Kozynski
f3a770104b Revert "Sets views clickable according to their visibility"
This reverts commit 1c36a5c708.

Reason for revert: This CL added bugs b/122371174, b/122035663

Change-Id: Id7f68ecab60f47fbf481601c5dc6c12093d78cda
Fixes: 122371174
Fixes: 122035663
2019-01-09 15:37:30 +00:00
TreeHugger Robot
455b60fe2e Merge "Add better information for invalid path" 2019-01-09 12:52:37 +00:00
TreeHugger Robot
e714a7eaa9 Merge "Don't stop adding smart suggestions just because one doesn't fit." 2019-01-09 11:44:44 +00:00
TreeHugger Robot
aa7fae74ee Merge "Remove dependency from PipAppsOpsListener to PipMotionHelper." 2019-01-09 03:44:22 +00:00
Mady Mellor
0ad5b9defd NotificationEntryListener: pre & post onEntryUpdated
Some of the listeners care about doing things to notifications prior
to the entries being filtered and some of them care about it after the
entries are filtered.

This CL introduces new method onPreEntryUpdated and alters the existing
method to be onPostEntryUpdated so that listeners can know about both
events.

Test: atest NotificationEntryManagerTest#estUpdateNotification_prePostEntryOrder
Change-Id: Ifa56fbf27cbc8f58c8eda9c95c79a57f1a52c9ac
2019-01-08 15:21:02 -08:00
Ned Burns
1016d962d6 Remove NEM dependency on GutsManager
Moved to NotificationPresenter (which will need to be broken up
eventually, not but today).

Test: atest
Change-Id: I9dd9c612738bed8e34dc0f394fc397c6b5dbf5c5
2019-01-08 16:55:58 -05:00
Jorim Jaggi
8e2189dc71 Add better information for invalid path
Test: Fling shade
Bug: 120200303
Change-Id: Id2ca27e059c58471e6f0cd262a04d19c42afe348
2019-01-08 12:43:07 +01:00
Eliot Courtney
293d86e346 Remove dependency from PipAppsOpsListener to PipMotionHelper.
Bug: 122503380
Test: compiles
Test: Open YouTube and put it into PIP. Accessing the settings and
disabling PIP correctly closes PIP.

Change-Id: I2903ad37802e4dfab9e3f145483da658c0fdbb5e
2019-01-08 09:54:48 +00:00
TreeHugger Robot
1cac57911e Merge "Hide media details on lock screen" 2019-01-08 03:21:31 +00:00
Lucas Dupin
3d560e430c Hide media details on lock screen
Media data will only be available when dozing to avoid duplication
on the notification shade.

Test: manual
Test: atest KeyguardSliceProviderTest
Bug: 111405682
Change-Id: I5e057496aa36c912293be54a4abfa62667b96db3
2019-01-07 17:15:00 -08:00
Ned Burns
f81c4c405f Extract NotificationData.Entry to top-level
NotificationData.Entry -> NotificationEntry

Both NotificationData and NotificationEntry moved
`notification.collection` package.

Test: atest
Change-Id: Ia7158eb732711ddb324e514edb9884d518edab87
2019-01-07 16:31:21 -05:00
TreeHugger Robot
8b9351ba04 Merge "Fix custom clock face showing up outside of lock screen." 2019-01-07 20:29:18 +00:00
Gustav Sennton
3515675803 Don't stop adding smart suggestions just because one doesn't fit.
Up until now we've added smart suggestions to a notification from a
certain list (in order). When we've reached a suggestion that doesn't
fit in the notification we've simply skipped the rest of the
suggestions. With this CL we only skip the suggestion that's too long,
and instead try adding the less-prioritized suggestions.

Example:
Assume the notification can fit suggestions 1, 2, and 4 (suggestion 3 is
too long to fit):
"Action1", "Action2", "LongestActionEvererererrer", "Action4"

Behaviour before this CL: only the first two suggestions are shown:
"Action1", "Action2"
Behaviour after this CL: actions 1, 2, and 4 are shown:
"Action1", "Action2", "Action4"

Bug: 121250868
Test: atest SystemUITests
Change-Id: Icd90eebe1514e88a9dd0d48db050325764830155
2019-01-07 17:27:14 +00:00
Gus Prevas
5ecd2b8e14 Moves snapViewIfNeeded() call to listener on NSSL.
This change removes the logic from NotificationEntryManager which snaps
an updated notification's view back into place and replaces it with a
NotificationEntryListener defined by the NotificationStackScrollLayout.
This allows us to remove a method from the NotificationListContainer
interface and gets us halfway to breaking the dependency from
NotificationEntryManager on NotificationListContainer.

Test: atest SystemUITests, manual
Change-Id: I744ece3fa660454d9725aa553ffebcfe8846a303
2019-01-07 09:41:11 -05:00
Ned Burns
01e3821aa3 Invert BubbleController <-> NEM dependency
Test: atest
Change-Id: I35b9dfbead7c623a6d0321943570c6115cf7eb5e
2019-01-04 20:09:28 -05:00
Ned Burns
6976087e24 Inline a few methods in NotificationEntryManager
These methods were only called in one location and either (a) weren't
safe to call in any other situation or (b) weren't conceptually
distinct from their caller.

Test: atest
Change-Id: I7bbb2e9b51b678144f13897db27ad324e78be587
2019-01-04 20:07:54 -05:00
Ned Burns
ef2ef6c909 Change onRemoteEntry() to only fire when entries are removed
Conceptually, this should be a paired match with
onNotificationAdded(). Previously we were firing this method even
if the notification was no longer present (already removed) or
if it hadn't been added yet (was in pending).

Test: atest

Change-Id: I613f60aa8cf4e1aeb7bb13ff5883a221c9b623c6
2019-01-04 20:06:07 -05:00
TreeHugger Robot
1a08863f3b Merge "Moves icon management to NotificationRowBinder." 2019-01-05 00:52:07 +00:00
TreeHugger Robot
b0185ca9d1 Merge "Move ShadeController to SystemUIFactory to allow customization." 2019-01-04 23:48:22 +00:00
TreeHugger Robot
bbb539a172 Merge "Fixes notification swipe snapping when menu is empty." 2019-01-04 23:38:38 +00:00
TreeHugger Robot
441f143110 Merge "Removes unused fields from NotificationEntryManager." 2019-01-04 23:19:55 +00:00
TreeHugger Robot
bf435d53ac Merge changes from topic "foreground-service-controller-2"
* changes:
  Factors out notification listening from ForegroundServiceController.
  Collapses ForegroundServiceControllerImpl into interface.
2019-01-04 22:20:45 +00:00
Gus Prevas
86928bb177 Moves icon management to NotificationRowBinder.
This change moves the calls in NotificationEntryManager to
NotificationData.Entry.createIcons() and .removeIcons() to
NotificationRowBinder.inflateViews() to encapsulate all the view
handling in the latter class (and so that we can eventually not create
those icon views right away).

Test: atest SystemUITests, manually
Change-Id: Ie515c85b81ce6ad5de607b83e8f242d7ae03326e
2019-01-04 16:46:32 -05:00
Gus Prevas
9258646f98 Removes unused fields from NotificationEntryManager.
Test: atest SystemUITests
Change-Id: Ia2b361fbfa9d3aa3c18a9a4577eda28bdc22b080
2019-01-04 16:06:12 -05:00
TreeHugger Robot
e2ad62f797 Merge "Let the clock be updated in real time during the pulse" 2019-01-04 20:16:22 +00:00
Gus Prevas
fe15aa1f9f Fixes notification swipe snapping when menu is empty.
This change modifies the swipe handling logic in NotificationSwipeHelper
such that it doesn't attempt to snap to the "menu open" state when the
menu is zero width (i.e. it's snapping on a left-to-right gesture and
the menu is only enabled for right-to-left swipes).  This prevents us
from getting in to a state where the menu was considered "open" when it
wasn't, which caused the next gesture to be handled incorrectly.

Change-Id: I3b78e95de7266e5a469637007ca78f7af2caab49
Fixes: 121077588
Test: manually
2019-01-04 15:13:21 -05:00
Gus Prevas
eb4e2e1139 Factors out notification listening from ForegroundServiceController.
This change introduces the ForegroundServiceNotificationListener
component, which contains the logic formerly in
ForegroundServiceController for updating its state in response to
notification events.  ForegroundServiceNotificationListener adds a
standard NotificationEntryListener to the NotificationEntryManager,
allowing us to remove the explicit calls from NotificationEntryManager;
splitting this out to its own class prevents us from introducing a
circular dependency since NotificationEntryManager still needs to use
the query methods on ForegroundServiceController.

Test: atest SystemUITests, manual
Change-Id: Iec72aa3a9fd90e3f0079db3b2a3c4f1882e59731
2019-01-04 14:05:43 -05:00
Robert Snoeberger
60854080d3 Fix custom clock face showing up outside of lock screen.
Bug: 122349591
Test: Added tests to KeyguardClockSwitchTest
Change-Id: Ie5f39ab598e993759ec628a071af81a52629a574
2019-01-04 13:19:53 -05:00
Ben Lin
90cd6110c5 Move ShadeController to SystemUIFactory to allow customization.
ShadeController is implemented by StatusBar, which is possible to be
swapped by OEMs via using config_statusBarComponent.

Bug: 122277074
Test: Compiles
Change-Id: Ia714405803a37deca9a694d07772e005902ab6bc
2019-01-04 10:18:40 -08:00