Commit Graph

10234 Commits

Author SHA1 Message Date
Phil Weaver
6a65b75e47 Merge "Prohibit using recycled AccessibilityNodeInfos." 2017-07-25 18:35:34 +00:00
Andrei Stingaceanu
1244815e8f Remove @hide from ViewGroup debug methods
Allow developers to easily add their own debugging info
when developing custom ViewGroups.

Bug: 30117235
Test: tests still pass
Change-Id: Ia83005b4dc727c7b959a50e7b0130582f6e89762
2017-07-25 10:00:21 +00:00
Phil Weaver
11e5e3f875 Prohibit using recycled AccessibilityNodeInfos.
Bug: 37858096
Test: Adding a CTS test to verify an exception when using a
node after recycling it. Ran a11y CTS and unit tests.

Change-Id: I5486a7abec681cb6fbb315ff87f0915d5505b8f3
2017-07-24 13:37:03 -07:00
Michael Wright
d487520e4c Merge "Remove non-safe mode boot vibration." into oc-dr1-dev
am: 149ff697ff

Change-Id: Ie8964116ffb3dccd6b683f0fff764d128107ac4f
2017-07-24 12:52:43 +00:00
TreeHugger Robot
149ff697ff Merge "Remove non-safe mode boot vibration." into oc-dr1-dev 2017-07-24 12:46:25 +00:00
Selim Cinek
3a82a4a0f2 Merge "Removing contents hidden string for public notifications" into oc-dr1-dev
am: 8650c7c0f1

Change-Id: I10d7ab191f47bf167a5be5e0d11d7698aae58cd1
2017-07-23 12:57:19 +00:00
TreeHugger Robot
8650c7c0f1 Merge "Removing contents hidden string for public notifications" into oc-dr1-dev 2017-07-23 12:51:43 +00:00
TreeHugger Robot
572cb5242d Merge "Expose shared buffer mode/auto refresh on Surface" into oc-mr1-dev 2017-07-22 03:01:02 +00:00
Romain Guy
0bbf0b41cc Expose shared buffer mode/auto refresh on Surface
These features can be set on a surface to reduce perceived latency
at the expense of visible tearing.

Bug: 63858546
Test: Manual, CTS test coming

Change-Id: Ica3f480bd1cb8f77dff57218d2fa8783433d3396
2017-07-21 16:11:17 -07:00
Michael Wright
33d6c08aa6 Remove non-safe mode boot vibration.
Ding, dong the BZZZT is dead.

Bug: 22414771
Test: manual
Change-Id: I011a9b475a6497db6e9440647d6d5c60dcf171b7
2017-07-21 19:11:24 +01:00
Jorim Jaggi
d8aa259df1 Merge "Fix snapshots for dialogs" into oc-dr1-dev
am: 089d45de8f

Change-Id: I6429fcdc5c012f653143cb8b8161b8f1626293f9
2017-07-21 16:17:39 +00:00
Jorim Jaggi
089d45de8f Merge "Fix snapshots for dialogs" into oc-dr1-dev 2017-07-21 16:10:52 +00:00
Michael Wright
f0613cdab7 Merge "Add config to force display to transition to off after doze" into oc-dr1-dev
am: cb423e42b3

Change-Id: Ie643ec6a1c917aa2d9364dbc431121f19a8a7e31
2017-07-21 15:00:18 +00:00
TreeHugger Robot
cb423e42b3 Merge "Add config to force display to transition to off after doze" into oc-dr1-dev 2017-07-21 14:53:44 +00:00
Jorim Jaggi
e6c6ecb2b0 Fix snapshots for dialogs
When taking a snapshot, always include the full stack bounds.

When showing a snapshot starting window, use the SystemUI flags
from the top fullscreen window in the task - this is the same way
as we do it when the real windows are going to be visible.

Test: Revoke contacts permissions, launch contacts, go to recents,
go back.
Test: go/wm-smoke
Fixes: 63268663

Change-Id: If8d9701f6d34abd56116ed04fe27fe82688e506a
2017-07-21 13:39:19 +02:00
Selim Cinek
499c20f25d Removing contents hidden string for public notifications
We're now only showing the notification header instead of the
repetitive contents hidden string. On Aod, we're still showing
a string however, since without it, it looked too empty.

Test: manual, set sensitive setting on lockscreen, observe notifications
Change-Id: If2bb66b9b3b366715aa68087e5c35cf1cdff3693
Fixes: 63741232
2017-07-20 14:16:13 -07:00
Rob Carr
362a400f09 Merge "Fix incorrect SV calculation in non-RT codepath." into oc-dr1-dev
am: f62e79791b

Change-Id: I59fd7563e1bb82def0e9321b6340c97e249bdcfc
2017-07-20 18:47:17 +00:00
Rob Carr
f62e79791b Merge "Fix incorrect SV calculation in non-RT codepath." into oc-dr1-dev 2017-07-20 18:32:31 +00:00
Michael Wright
05e76fe38f Add config to force display to transition to off after doze
Some display hardware can't do the transition from doze display states
to the on display state cleanly, so in order to hide any janky-ness of
the transition we force the display off and cover the screen with a
black surface. This lets us keep the screen black until SystemUI and the
display are both ready.

Bug: 63531607
Test: manual
Change-Id: I66bd483e5f01e1dbd5069465aa122828af5f1903
2017-07-20 18:21:29 +01:00
Adrian Roos
747938ed61 Merge "AOD: Prevent animations and rotations while going to sleep" into oc-dr1-dev
am: 29119b6f5f

Change-Id: I5deca2c8224d629eadc18a7f7742c6f8d43b133d
2017-07-20 16:12:21 +00:00
Adrian Roos
7c89480c0e AOD: Prevent animations and rotations while going to sleep
A recent change allowed animations while the screen is
turning on, but not fully turned on; this allows rotations
while the device is going to sleep though. To prevent that,
we now disallow animations if the device is going to sleep too.

In addition, we also prevent the rotation animation when the screen
is not fully on or non-interactive.

Change-Id: I9b84f68a02a07067e48b11c008bcaf4bcb7c41a0
Fixes: 63760853
Test: Turn phone to landscape on an app that can rotate. Press power button. Verify AOD shows without a rotation; go/wm-smoke
2017-07-20 13:24:52 +00:00
Robert Carr
c90e5f8656 Fix incorrect SV calculation in non-RT codepath.
We were using width/height as top/bottom...not much more to it
than that :).

Bug: 62752640
Test: go/wm-smoke
Change-Id: I57f081b4fab555f0f551e753618725bdd3780305
2017-07-18 14:52:52 -07:00
Rob Carr
e75643d542 Merge "Fix rotation animation selection." into oc-dr1-dev am: cee8098178
am: 228571391e

Change-Id: Idd2a3c23233f0758cc96a55da97b99c6ee8a7c94
2017-07-18 20:01:05 +00:00
Robert Carr
427ba4ff55 Fix rotation animation selection.
The default manifest value needs to be unspecified, not rotate,
as rotate overrides the LayoutParams specified value.

Bug: 63151981
Test: Manual from bug. go/wm-smoke.
Change-Id: I2ad6e3fdd06eeef0166bbe09d07b57cc45ed6e50
2017-07-17 18:37:06 -07:00
Evan Rosky
99b254be5c Merge "Clean up @hide usages in cts tests" 2017-07-15 01:17:35 +00:00
TreeHugger Robot
eb5a57142a Merge "Revert "Revert "Make scrollbarSize in Material Design theme configurable""" 2017-07-14 19:12:51 +00:00
Evan Rosky
c5420ea31b Clean up @hide usages in cts tests
Bug: 62066671
Bug: 62067303
Test: ViewGroupTest and View_FocusHandlingTest still pass
Change-Id: I010a570bfcea212f1319a26f616c7841e841c00d
2017-07-13 15:36:56 -07:00
Abodunrinwa Toki
a49d2eedc9 Merge "TextClassification.text is nullable" 2017-07-13 20:06:12 +00:00
Andrii Kulian
917a641101 Merge "Position app with short aspect ratio opposite of nav bar" into oc-dr1-dev am: a40af83c32
am: 8d99ed44f2

Change-Id: I28cee4719647f5c1746e62fe8c73ebdc99be6c65
2017-07-13 03:47:30 +00:00
Andrii Kulian
3a1619d68e Position app with short aspect ratio opposite of nav bar
When an application doesn't support tall aspect ratio of the
screen where it's displayed, it should be positioned on the
opposite side from navigation bar. It's supposed to create
an effect of extended black nav bar.

Bug: 62893418
Test: go/wm-smoke
Test: ActivityRecordTests#testPositionLimitedAspectRatioNavBarBottom
Test: ActivityRecordTests#testPositionLimitedAspectRatioNavBarLeft
Test: ActivityRecordTests#testPositionLimitedAspectRatioNavBarRight
Change-Id: I2cd3d236ee8d0cc263fee4c0a436d78c755eb9b7
2017-07-12 14:04:35 -07:00
Abodunrinwa Toki
d44286f942 TextClassification.text is nullable
Removes the @NonNull requirement on TextClassification.text.
e.g. TextClassifier.NO_OP doesn't classify text and thus returns
TextClassification.EMPTY which doesn't set TextClassification.text.
This is ideal as we need not make copies of this object when NO_OP
was performed.

Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
bit FrameworksCoreTests:android.widget.TextViewActivityTest
bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Change-Id: I0b3ac5bf0027cbd67ba40d1110f1100280c8c3a2
2017-07-12 20:26:27 +01:00
TreeHugger Robot
d1e123cbad Merge "Autofill: Add API for virtual view visibility" 2017-07-12 17:36:29 +00:00
Svetoslav Ganov
4db89ba82e Autofill: Add API for virtual view visibility
Test: VirtualContainerActivityTest

bug:38509603

Change-Id: I3546c99d0b13316337c5015e003337b8019194a9
2017-07-11 19:43:01 -07:00
Phil Weaver
9e90a7236a Merge "NumberPicker a11y (and a11y-inspired) fixes" 2017-07-11 23:12:20 +00:00
Philip P. Moltmann
ebbe2d4899 Verify regex on CharSequenceTransformation
... Also
- change the constructor of the Builder of this class
- Do not crash if the subsitutions for the regexes are invalid

Change-Id: I965d5830f4932eb40ec22d7fa308815955920a99
Bug: 62534917
Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
2017-07-10 15:15:48 -07:00
Robert Carr
17c3a03be0 Merge "SurfaceView: Avoid initializing Surface from an invalid SurfaceControl." into oc-dev am: 401b8907d0 am: 2f927d56cf
am: 7de9f7a334

Change-Id: I00846580b78758631cd6db262c1b5057204515f6
2017-07-07 03:35:15 +00:00
Robert Carr
7de9f7a334 Merge "SurfaceView: Avoid initializing Surface from an invalid SurfaceControl." into oc-dev am: 401b8907d0
am: 2f927d56cf

Change-Id: I2916aa9a24b84d4f379c8ebebc7e19eb4adc96f4
2017-07-07 03:29:06 +00:00
Robert Carr
5482790a3f Merge "SurfaceView: Avoid initializing Surface from an invalid SurfaceControl." into oc-dev
am: 401b8907d0

Change-Id: Ib7a916fb484fb3a7924315169d162f4fdddd8a06
2017-07-07 03:22:50 +00:00
TreeHugger Robot
401b8907d0 Merge "SurfaceView: Avoid initializing Surface from an invalid SurfaceControl." into oc-dev 2017-07-07 03:10:12 +00:00
Robert Carr
7c67b7d097 SurfaceView: Avoid initializing Surface from an invalid
SurfaceControl.

In a recent CL we introduced a call to Surface#createFrom, in order to
recreate the Surface object from the underlying SurfaceControl, as a
workaround to emulate when it was parcelled over binder in the past.
However this is causing BufferQueue abandoned errors when stopping and
resuming some applications. To understand them, we need to revisit the
SurfaceView destruction process when handling onStop.

First mWindowStopped will be set to true (SurfaceView#windowStopped),
and we should then enter updateSurface. Our requested visibility will
now be false and so we emit the Surface destroyed callbacks. Notice in
the finally block in mUpdateSurface, we will release mSurface, but we
will NOT null mSurfaceControl. Inline documentation explains why.

In the case that the activity is not actually being destroyed, it's
possible that we may not get a dispatchDetachedFromWindow. This means
that we will not null mSurfaceControl. Now if the activity is
un-stopped and we re-enter updateSurface we encounter a problem
state. "creating" will be set to false since mSurfaceControl != null,
however mSurfaceControl will not point to a valid surface.

Prior to the introduction of the #createFrom call, this unwanted state
didn't cause any problems. Because mSurface was released back in the
finally block as we were stopping we now fall out of the
mSurface.isValid() block in updateSurface. As we reach the finally
block again, we would now set mSurfaceControl=null since the app was
no longer stopped. Later when we reach updateSurface again (which
tends to happen quite often) it will now be null and we will correctly
set creating=true, create a valid SurfaceControl, and move along
happily. However following, the introduction of this
Surface#createFrom call we will now reinitialize the Surface from an
invalid underlying SurfaceControl. This means we will enter the
mSurface.isValid block, but will proceed to emit an invalid Surface to
the client in the callbacks.

We avoid this state by making creating=true even if
SurfaceControl=non-null when the calculated visibility changes from
invisible to visible.

Bug: 63251745
Test: Manual of app from bug and apps from previous related bugs. go/wm-smoke. Additional manual testing of many SV apps.
Change-Id: Icc32a34cac239d65267da705cc23feb23e1ceb67
2017-07-06 15:53:04 -07:00
Abodunrinwa Toki
5b0a5fc160 Merge "Make ActionMode.isUiFocusable a TestApi" 2017-07-06 20:44:58 +00:00
Adrian Roos
076cc55973 Merge "AOD: Skip window animations while dozing" into oc-dr1-dev am: 92b6b7090c
am: fd9d88beb3

Change-Id: I76a5fdc6db9a849eeacf47278391e5d7eae53fc2
2017-07-06 18:08:36 +00:00
TreeHugger Robot
92b6b7090c Merge "AOD: Skip window animations while dozing" into oc-dr1-dev 2017-07-06 17:53:24 +00:00
Adrian Roos
e94c15ca96 AOD: Skip window animations while dozing
Fixes: 37245619
Test: go/wm-smoke; Go to home, turn off phone, observe that during the transition to AOD the navigation bar hide animation does not play.
Change-Id: I9a2fce4295900648a680e8e7e8fee0fbb447dd3d
2017-07-06 17:13:07 +02:00
Siarhei Vishniakou
0a5d805ae1 Merge "Hide VIRTUAL_KEY_RELEASE constant." into oc-dr1-dev am: 20a240fc5d
am: c7b722117c

Change-Id: Icec2d07d2edf93fc9c9e130eeea175e5418cc518
2017-07-05 22:51:57 +00:00
TreeHugger Robot
4c3c19fbc1 Merge "Added PRIVATE_FLAG_HIDE_NON_SYSTEM_OVERLAY_WINDOWS window flag." 2017-07-01 02:06:02 +00:00
Abodunrinwa Toki
ba51f15998 Make ActionMode.isUiFocusable a TestApi
Test: bit CtsViewTestCases:android.view.cts.ActionModeTest
Bug: 62070427
Change-Id: I21b24d2a497bdc5234539bcc662ad707bb7f34dc
2017-07-01 02:10:04 +01:00
Wale Ogunwale
01ad4345f9 Added PRIVATE_FLAG_HIDE_NON_SYSTEM_OVERLAY_WINDOWS window flag.
When a window with this flag is visible, then any other window added
by an application process that requires OP_SYSTEM_ALERT_WINDOW
permission or that are of TYPE_TOAST will be hidden.

Bug: 62196835
Test: go/wm-smoke
Test: Added the new flag to the RecentsActivity onCreate, launched FB
chat heads and observed the head head become invisible when Recents is
visible and the chat head become visible when Recents is no longer
visible.

Change-Id: I1a3e3c5b1696a5f5b95eac187acb5a03863b4a0b
2017-06-30 14:27:38 -07:00
Siarhei Vishniakou
ff1121a735 Hide VIRTUAL_KEY_RELEASE constant.
The constant will become visible once
the corresponding feature is supported.

Bug: 62433331
Test: make
Change-Id: I310338033dd861e9fd0cc1492a8e34fb53ce0415
2017-06-30 11:02:02 -07:00
TreeHugger Robot
08a18210fb Merge "Remove the internal APIs of TSM to change spell checker settings" 2017-06-30 17:37:27 +00:00