Commit Graph

2096 Commits

Author SHA1 Message Date
Gilles Debunne
572527f2c3 Merge "Remove the suggestion underline when the TextView loses focus." 2011-09-02 13:54:48 -07:00
Gilles Debunne
a41bc33855 Merge "Popup windows positions are updated when a TextView is scrolled" 2011-09-02 13:24:20 -07:00
Gilles Debunne
f3d78eac0f Merge "Added an add to dictionary option in suggestions for misspelled words" 2011-09-02 13:19:24 -07:00
Gilles Debunne
26b5cf40b1 Merge "Fixes around text selection" 2011-09-02 13:17:44 -07:00
Gilles Debunne
1737fcd689 Merge "Fix for NPE in Switch" 2011-09-02 13:17:13 -07:00
Luca Zanolin
fe5e9834a3 Remove the suggestion underline when the TextView loses focus.
Only the easy correction (i.e., voice ime corrections) will lose the underline, while the misspelled span will not.

Change-Id: If96c17473dd70c99b808739ddde800cc93551e2a
2011-09-02 19:41:42 +01:00
Gilles Debunne
70a6312f09 Fixes around text selection
Text selection mode was started by two consecutive taps inside a
field with selectAllOnFocus.

ArrowKeyMovementMethod does not respect the possible cancelLongPress and handles up events.
As a result a scroll that happens to end up at its initial position will be considered a tap
and will move the cursor.
This is however not considered as a tap in TextView and a possible selection mode would not
be stopped in that case.
Fixed by making ArrowKeyMovementMethod aware of the cancel that happened in Touch.

Change-Id: I07372b703f250e1edc7ee0665318ce30441b9187
2011-09-02 11:26:46 -07:00
Gilles Debunne
e90bed18cc Added an add to dictionary option in suggestions for misspelled words
Change-Id: I031f17a76b4a81ae375b778046b8c391f9b8b2b2
2011-09-02 09:04:26 -07:00
Svetoslav Ganov
17b0317e8d Merge "Accessibility events fired from AdapterView underpopulated." 2011-09-01 18:39:29 -07:00
Svetoslav Ganov
c48c47c820 Accessibility events fired from AdapterView underpopulated.
Accessibility events fired by an AdapterView did not report
the index of the first and last visible items, rather only
the total item count.

bug:5225039

Change-Id: I6931d82f0418c659f26e1e8a345da69da99690c5
2011-09-01 18:22:37 -07:00
Svetoslav Ganov
d5e6527f5f Merge "Polish of the accessibility feedback of Date and Time pickers" 2011-09-01 18:14:38 -07:00
Svetoslav Ganov
3fec3fe0e3 Polish of the accessibility feedback of Date and Time pickers
bug:5228006
bug:5228004

Change-Id: I927e3a6dcbf4f81eab6f506fc38842d8e7a37aa1
2011-09-01 18:04:27 -07:00
Gilles Debunne
f682a77d5e Popup windows positions are updated when a TextView is scrolled
The View's internal scroll was not triggering an update of the popup windows' positions.

Also fixes an update problem when a new long press moved the action popup window.

Change-Id: Ic3bb39fc55981c67db2a15ef2e90aad37a36d116
2011-09-01 18:00:52 -07:00
Gilles Debunne
e724ee4b04 Fix for NPE in Switch
Happens when the checked state is set in XML in the CompoundButton
constructor. The drawable are not yet loaded at that point.

This still work since the Switch constructor calls setChecked, which
will invalidate.

Change-Id: I76459307e77596ce0f2759e9449eb42287c6bad7
2011-09-01 16:58:05 -07:00
Gilles Debunne
8a16f92270 Merge "Using ListView for Suggestion popup window" 2011-09-01 11:42:23 -07:00
Adam Powell
89935e41c5 Make EdgeEffect public API.
This enables apps to make use of the system's visual edge effect used
during overscroll in 2D content.

Also un-@hide the getCurrVelocity methods from Scroller/OverScroller,
without which it becomes cumbersome to obtain values to pass to the
EdgeEffect#onAbsorb method.

Change-Id: I40e452455f5cb5d45d1fb3687f739fc8eae65560
2011-08-31 14:59:19 -07:00
Gilles Debunne
0eea668151 Using ListView for Suggestion popup window
New background assets from Bug 5204807.
New text selection color and associated handles, bug 5217848.

Change-Id: I4eaea6be732843d8ff344400d029b4a1b80b084f
2011-08-31 11:18:52 -07:00
Adam Powell
282e377d8b Ellipsize marquee TextViews that aren't currently animating
On some devices the fading edge effect can be expensive. Offer an
alternative for screens full of textviews.

Change-Id: I0382b4ea0f8b0c6948cb68611f3679dbf5e2898a
2011-08-30 17:35:15 -07:00
Gilles Debunne
b5305007a6 Merge "Add EditTextShortcutSpan to provide edit short cut in the text view." 2011-08-30 15:53:33 -07:00
Luca Zanolin
e6d3682189 Add EditTextShortcutSpan to provide edit short cut in the text view.
At the moment, EditTextShortcutSpan allows only the deletion of the text. In the future, we may decide to add extra functionality,
like "retry" where all the text is removed and a specific IME is triggered.

Fix the underline. The underline is not defined in thickness, and not as a multiplier of the default underline thickness.

Change the behaviour of SuggestionRangeSpan to match the specification.

Change-Id: I80437d9887c7a2ff8f62c38afbb0cb7add7ee9c8
2011-08-30 18:04:34 +01:00
Gilles Debunne
57324c7382 Moving action popup window when moving text selection
Long press to select, the action popup (Paste) is displayed.
A second long press moves the selection (selection mode is still on),
but the action popup's location was not updated.

Change-Id: I2ac133e608dbca35ec0236b47b42f029623fc303
2011-08-29 14:42:17 -07:00
Gilles Debunne
9906847cef Bug 5218421: new NPE is SpellChecker when using Japanese language
The spell checker session is null because the Japanase language is not supported.

Change-Id: I41d2157e8f66799fdb6dff718e8903ce6f1bb9fe
2011-08-29 14:12:14 -07:00
Gilles Debunne
474cac1c21 Merge "Suggestions popup window is dismissed on tap outside." 2011-08-29 12:58:36 -07:00
Chet Haase
150176d830 Made the Switch class public.
Tweaked the API of Switch slightly and made the class public (it was
hidden before).

Change-Id: I4a099e8afd18a11a5850252025ae3bbbb866830d
2011-08-29 10:59:58 -07:00
Adam Powell
9a5cc2810b Fix bug 5124021 - Menu visibility incorrect when restoring ListView
selection mode

Fix visibility of menus when action modes are initiailized early.

Fix ListView problems persisting check states.

Change-Id: Idc21036dc39259e72f0e6831a0ccb4695f8858ef
2011-08-28 17:13:16 -07:00
Romain Guy
aa1c88de02 ToggleButton could keep a reference to a previous drawable
Change-Id: Ic19a8e86c61b58926504daf35f0de41358a899b4
2011-08-26 16:21:03 -07:00
Fabrice Di Meglio
d32f27aec0 Merge "Fix bug #5199577 TextView with android:password="true" is showing the "dots" on the left even if the password chars are RTL" 2011-08-26 14:05:09 -07:00
Gilles Debunne
87a4d87ecf Merge "Bug 5218421. Spell check crash with Japanese characters" 2011-08-26 13:28:28 -07:00
Gilles Debunne
d6e3494421 Bug 5218421. Spell check crash with Japanese characters
The word iterator returns no word in that case, and this is not
supported by TextInfo.

Change-Id: Iaf31c58638c02d3cdc7b88bc0d1201e793e84f17
2011-08-26 10:13:18 -07:00
Fabrice Di Meglio
7810b5f8cf Fix bug #5199577 TextView with android:password="true" is showing the "dots" on the left even if the password chars are RTL
- force TextView to LOCALE text heuristic when in "password" mode
- remove TEXT_LAYOUT_DIRECTION_UNKNOWN_DO_NOT_USE
- LocaleUtils.getLayoutDirectionFromLocale() returns "LTR" is locale is NULL or ROOT

Change-Id: I182c46aaf2d73c8b18967fffa230bfabec91ed06
2011-08-25 18:43:37 -07:00
Adam Powell
ba5fe92361 Merge "Fix bug 5199326 - ListView's fast scroller is out of sync with contents" 2011-08-25 15:26:36 -07:00
Adam Powell
35948b7ed5 Fix bug 5199326 - ListView's fast scroller is out of sync with contents
Also fix a bug where the fast scroll track was not being properly
invalidated while animating out.

Change-Id: Ie90568a993699d5d061985985e3d93165d1d2219
2011-08-25 14:17:12 -07:00
Gilles Debunne
8e7e95f22f Merge "Bug 5166707: NPE fixed in getFocusedRect" 2011-08-25 13:45:11 -07:00
Gilles Debunne
fd419b051a Bug 5166707: NPE fixed in getFocusedRect
Change-Id: I1e59ac739f1258c0047a667443f80b2c09ffa12c
2011-08-25 11:53:26 -07:00
Gilles Debunne
28294cc744 Suggestions popup window is dismissed on tap outside.
But now the tap is not handled at all, as it was before. To do this, the popup window
is now focusable. As a result, the TextView's window loses focus. We hide the
cursor to prevent a non-blinking visible cursor. We should also fake the
state of the parent TextView to keep it visually focussed.

SuggestionRangeSpan and SpellCheckSpan had to made Parcelable since they are recreatedi
when the TextView is re-created when the popup is dismissed.

Change-Id: Ic99b2c4f02c282394f214938dd19168547af4886
2011-08-25 11:45:09 -07:00
Gilles Debunne
616b20c0de Remove spell log that exposes typed text in the logs
Change-Id: I88a31f7e1fb93f0550d1cd5eb86afacbc19afd29
2011-08-25 11:33:06 -07:00
Gilles Debunne
6435a56a8c Spell checking in TextViews
New UX interactions (the Paste action is no longer displayed after a delay)
suggestionEnabled flag replaced by existing input type flag.
removeSpans fixed in SpannableStringBuilder to always send notifications
SuggestionSpan handled by TextView instead of SpannableStringBuilder

New span update algorithm to correctly handle edition around word boundaries.

Change-Id: I52c01172f19e595fa512e285a565a3fd97c3c50e
2011-08-23 13:13:54 -07:00
Fabrice Di Meglio
c2d256b415 Merge "Improve TextDirection resolution" 2011-08-22 16:24:43 -07:00
Michael Jurka
04963769e3 Merge "Track motion events before we decide to start scrolling" 2011-08-22 16:23:40 -07:00
Michael Jurka
13451a476a Track motion events before we decide to start scrolling
Change-Id: I0e2de488c62814982a21b7a7debbf1cd78e5891c
2011-08-22 15:54:28 -07:00
Svetoslav Ganov
151763d3fc Merge "Adding a callback to ShareActionProvider + make ActivityChooserView popup hide on action bar hide." 2011-08-22 09:35:00 -07:00
Fabrice Di Meglio
a646145c33 Improve TextDirection resolution
- remove unuseful heuristics
- tune Javadoc

Change-Id: Id72a158b3a17a528423d278b1cbfd95b8c2951b5
2011-08-19 16:19:37 -07:00
Amith Yamasani
1629618098 Merge "Fix an unintentional change in method signature and avoid an API change." 2011-08-19 14:29:34 -07:00
Amith Yamasani
a465b2d4c3 Fix an unintentional change in method signature and avoid an API change.
Change onDetachedFromWindow() override to a protected method, like superclass.

Change-Id: If626c5187290516d525cab5a76f5c5cabe2d87f0
2011-08-19 13:01:22 -07:00
Adam Powell
23f4cc0353 Fix bug 5099037 - No delete option when multiple videos are selected
Fix some bugs related to how action item slots are allocated in menus.

Fix some padding/margins in ActivityChooserView.

Change-Id: I12096b0165daca902c5bc8e24c1e8d54a35e9557
2011-08-18 16:19:31 -07:00
Romain Guy
7fa6e42483 Merge "Invoke requestLayout() when drawables have different sizes. Bug #5142668" 2011-08-17 20:06:14 -07:00
Romain Guy
9e648c44de Invoke requestLayout() when drawables have different sizes.
Bug #5142668

Change-Id: I0d3ae27984e69394e64b8aa0623bc3d6b22bc629
2011-08-17 20:05:38 -07:00
Chet Haase
a8a44c68ee Merge "Fix NumberPicker text positioning." 2011-08-17 18:35:07 -07:00
Chet Haase
eeafd4296b Fix NumberPicker text positioning.
NumberPicker was making incorrect assumptions about how text was
positioned and centered inside of its controls. This fix changes
the logic of how the scroll wheel draws its text items based on where
the text is positioned inside the EditText that displays the text
by default. This should ensure that the text of the scroll wheel
exactly overlays the text in the EditText view.

Change-Id: I4a7694931f19042bd4142232612490c2ab912d11
2011-08-17 18:26:56 -07:00
Fabrice Di Meglio
3de510313a Merge "Fix bug #5175022 Easy mode in MeasuredText.setPara() is no more used" 2011-08-17 17:30:46 -07:00