Commit Graph

1147 Commits

Author SHA1 Message Date
Vadim Caen
3dfd064445 Merge "Support enable default splash screen reveal aninatmion" into sc-dev am: 279e06697b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/13945686

Change-Id: I21f4c677b559b552d60231732c8603856160d992
2021-05-06 10:09:49 +00:00
Vadim Caen
279e06697b Merge "Support enable default splash screen reveal aninatmion" into sc-dev 2021-05-06 10:03:56 +00:00
Riddle Hsu
8c9001a57d Merge "Load icon of splash screen only once" into sc-dev am: a54290f36b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14439966

Change-Id: I65af03b7cdf3c53102a04750b9c816abe8724c03
2021-05-06 02:33:34 +00:00
Bill Lin
64dace014f Merge changes from topic "ohm-shortcut" into sc-dev am: f94486117f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14295086

Change-Id: Id630c07d7c9083ca9fa33f329caff2b4bd2e5711
2021-05-06 02:29:48 +00:00
Riddle Hsu
a54290f36b Merge "Load icon of splash screen only once" into sc-dev 2021-05-06 02:28:59 +00:00
Vadim Caen
bdb646b9fc Merge "Remove uses of deprecated splashscreenContent attribute" into sc-dev am: b5881bd59f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14266447

Change-Id: I2948240a8c4470e74f2a21e3e1871ef052377202
2021-05-06 02:08:47 +00:00
Jerry Chang
080b7fd59c Merge "Add a flag to determin whether to support legacy split" into sc-dev am: 6a60e58c46
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14410479

Change-Id: I429369a899c1bc54ee63607560a1a34d0cc3c0a8
2021-05-06 01:58:45 +00:00
Bill Lin
f94486117f Merge changes from topic "ohm-shortcut" into sc-dev
* changes:
  3/ Listen ONE_HANDED_MODE_ACTIVATED for A11y shortcut action
  2/ Implement Shortcut for One Handed mode feature
2021-05-05 23:43:12 +00:00
Riddle Hsu
2595465821 Load icon of splash screen only once
It is unnecessary to load icon without scale and load again
with scale. Just load the scaled one directly.

The construction time of SplashScreenView:
Dialer  : 36ms -> 24ms
Messages: 21ms -> 13ms
Contacts: 27ms -> 16ms

Bug: 187104264
Test: OpenAppMicrobenchmark
Change-Id: I0b71d3038f85a0839af862e5822e10fccbe1395d
2021-05-05 23:50:06 +08:00
Vadim Caen
b5881bd59f Merge "Remove uses of deprecated splashscreenContent attribute" into sc-dev 2021-05-05 12:45:40 +00:00
Jerry Chang
6a60e58c46 Merge "Add a flag to determin whether to support legacy split" into sc-dev 2021-05-05 06:33:39 +00:00
Mady Mellor
0cc5b6e7e3 Merge "Add the priority person highlight back to bubbles badge" into sc-dev am: ae6e4330be
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14413676

Change-Id: Ia191b80491bbab7e46fc53abee5ca157fc9ee5f1
2021-05-04 20:26:20 +00:00
Mady Mellor
ae6e4330be Merge "Add the priority person highlight back to bubbles badge" into sc-dev 2021-05-04 20:10:55 +00:00
Mady Mellor
c4ce4f0355 Merge "Bubbles: fix some issues with the pointer" into sc-dev am: 16529a2613
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14359193

Change-Id: I4642b108f2b99d6d6a0c84b3170d7f4a2e0f46db
2021-05-04 16:51:09 +00:00
Mady Mellor
16529a2613 Merge "Bubbles: fix some issues with the pointer" into sc-dev 2021-05-04 16:47:23 +00:00
Vadim Caen
c784a70726 Remove uses of deprecated splashscreenContent attribute
Test: atest CtsWindowManagerDeviceTestCases:SplashscreenTests#testSplashscreenContent
Bug: 182271482
Change-Id: If84fe4eff95afd4fe89754b25aa160f50d605c3a
2021-05-04 14:07:06 +02:00
Bill Lin
2c8a242c4e Merge "OneHandedUiEventLoggerTest sometimes flaky" into sc-dev am: 02f635462b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14408816

Change-Id: I20b461b71a79e8a815d9baf29ffae508594b5a76
2021-05-04 10:29:56 +00:00
Bill Lin
02f635462b Merge "OneHandedUiEventLoggerTest sometimes flaky" into sc-dev 2021-05-04 10:12:06 +00:00
Bill Lin
7cb819b5db Merge "Refine dump info of One Handed Mode components" into sc-dev am: 77f40a59bf
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14408817

Change-Id: Ie6d69ed12c8f8166a1f9dbb792532e414a37d946
2021-05-04 08:43:55 +00:00
Bill Lin
77f40a59bf Merge "Refine dump info of One Handed Mode components" into sc-dev 2021-05-04 08:37:59 +00:00
Mady Mellor
1f6d6d5d33 Add the priority person highlight back to bubbles badge
In BubbleViewInfo task where the icons are fetched, we were creating
the ringed badge for priority people but we weren't using it. Instead
the original badge drawable was being used.

This switched the app badge to be a bitmap & uses the bitmap with the
priority person ring.

Also fixes an issue where the ring would draw through a badge that
also had the work profile indicator. This is done by drawing the
highlight first and then drawing the badge on top.

Test: manual 1) have a conversation notif that can bubble
             2) mark it as priority
             => Observe that the bubble is created and it has the
                ringed bitmap
             3) dismiss the bubble
             => check that the ring is present on the bubble in the
                bubble overflow
             4) repeat above steps with a bubble from workprofile,
                ensure it has the ring and the workprofile badge
Bug: 185202938
Change-Id: Ief297f073f9684930b3a08fd93e90bbaae3180ca
2021-05-03 15:35:38 -07:00
Mady Mellor
794e3f0922 Bubbles: fix some issues with the pointer
* Pointer was missing if showing vertically on the right
  side, this is fixed & tried to make the code a lil more
  clear
* Pointer was missing for the bubble overflow, this is
  also fixed

Bug: 181888630
Test: manual - make sure the pointer is visible when the
               stack is expanded, check landscape left &
               right on small & large screen and check
               portrait on phone.
Change-Id: Id7dc6ae9a1f3e798940342b780940fb77ceaed3a
2021-05-03 11:54:12 -07:00
Jerry Chang
fedf86ed49 Add a flag to determin whether to support legacy split
Bug: 187041611
Test: launch with adjacent flag won't trigger stage split
Change-Id: Iefaad20636dda88caa6988802d1b7640b5077e4e
2021-05-03 23:36:45 +08:00
Bill Lin
96b0d8479a Merge "Refactor OHM to use (float)offset for translating windows" into sc-dev am: 214bff101f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14206624

Change-Id: I1215fe0f2b36e90a993c58aa53a803ad48c99e36
2021-05-03 10:17:37 +00:00
Bill Lin
214bff101f Merge "Refactor OHM to use (float)offset for translating windows" into sc-dev 2021-05-03 09:49:20 +00:00
wilsonshih
3221600d7e Support enable default splash screen reveal aninatmion
- Add a temp flag persist.debug.enable_reveal_animation so user can
enable reveal animation.
- Remove icon shift animation.
- For shift up animation, use AnimationAdapter to capture the surface
control and pass to Shell, then cancel the animation when
WindowState#removeIfPossible for starting window.
- Fix the flicker test fail issue caused from shift up animation, the
surface control should be release after the last frame was commit.
- Use SyncRtSurfaceTransactionApplier to synchronize the shift-up
animation, and use vsyncId to ensure the transaction doesn't applyied
too early.
- Do not play reveal animation for empty splash screen.

Test: atest SplashscreenTests StartingSurfaceDrawerTests
Bug: 183004107
Bug: 182815506
Bug: 184830058
Change-Id: I4fc8456633b3f4ecd69b168e0222915945210426
2021-05-03 16:20:09 +08:00
Bill Lin
0a117d8fca Refine dump info of One Handed Mode components
1) "ComponentName" + "States:" Sometimes confuse developers
   (e.g: OneHandedControllerStates)
2) The indent of OneHandedSettingsUtil is incorrect

Test: adb shell dumpsys activity service com.android.systemui
Test: make
Bug: 187014022
Change-Id: Icca01221986efdf9a1f9975efa30e485c5be36b0
2021-05-03 15:30:56 +08:00
Bill Lin
eb9b719bc5 3/ Listen ONE_HANDED_MODE_ACTIVATED for A11y shortcut action
- Observe ONE_HANDED_MODE_ACTIVATED secure settings key
- Skip action when OneHandedState is in transition
  1. STATE_ENTERING
  2. STATE_EXITING
- Skip action if current OneHandedState = request activate
  1. STATE NONE -> Shortcut request ACTIVATED : StartOneHanded
  2. STATE_ACTIVE -> Shortcut request non ACTIVATED : StopOneHanded
  3. STATE_NONE -> Shortcut request non ACTIVATED : SKip
  4. STATE_ACTIVE -> Shortcut request ACTIVATED : Skip
- Controller will update latest state to secure setting
  ONE_HANDED_MODE_ACTIVATED either trigger by gesture or shortcut

Test: atest WMShellUnitTests
Test: enable shortcut and click
Bug: 182425480
Change-Id: I03bd2679a5a08801efc9868148adfddef87171f4
2021-05-03 15:04:24 +08:00
Bill Lin
0fd7baaf31 OneHandedUiEventLoggerTest sometimes flaky
Check : go/wm-tests

Ignore the unit tests until the better approach available

Test: atest WMShellUnitTests
Bug: 184813408
Change-Id: I3139afa58ed15c535a55822504c3331771f1bfdf
2021-05-03 12:45:33 +08:00
Jerry Chang
0d7b35a288 Merge "Make sure to reorder side stage above main stage to prevent flicker" into sc-dev am: 5663de7849
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14388191

Change-Id: If2db0a33ae25332ae958e10a9c7e8511eb311c3b
2021-05-03 02:58:06 +00:00
Jerry Chang
5663de7849 Merge "Make sure to reorder side stage above main stage to prevent flicker" into sc-dev 2021-05-03 02:36:14 +00:00
Jerry Chang
57b13e327f Make sure to reorder side stage above main stage to prevent flicker
Always reorder side stage to the top whenever there's a child task
appeared in side stage. This is needed to prevent main stage occludes
newly launched task in side stage and causing itself flipping between
fullscreen and multi-window windowing mode.

Fix: 186614428
Bug: 169271875
Test: enter staged split by launching task with adjacent flag, screen
won't flicker

Change-Id: I9176a97439d687bbc7b0bf2dd9ddfdaecacfa455
2021-05-01 01:26:24 +08:00
Mady Mellor
f7d52d92ea Merge "Restrict the width of bubble expanded view on large screens" into sc-dev am: 23f3d34103
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14270441

Change-Id: I4753b93dcfd38610544c56066be2ecc791a0094b
2021-04-30 16:17:18 +00:00
Jorge Gil
c60faca801 Merge "Synchronize PIP menu fade out with task dismiss" into sc-dev am: 83c75ac733
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14355997

Change-Id: I167a8c1c1ae5d6ded349fb87c4abfa326a0fb91b
2021-04-30 16:16:47 +00:00
Mady Mellor
23f3d34103 Merge "Restrict the width of bubble expanded view on large screens" into sc-dev 2021-04-30 16:07:54 +00:00
Jorge Gil
83c75ac733 Merge "Synchronize PIP menu fade out with task dismiss" into sc-dev 2021-04-30 15:53:32 +00:00
jorgegil@google.com
b2f5a2f985 Synchronize PIP menu fade out with task dismiss
This CL addreses two issues:
1. PipMenuView.dismissPip was previously fading out the PIP
menu, waiting for that to complete, then notifying the task
organizer to remove and fade out the window, and then it would
fade the menu out again even though it was already hidden.
This resulted in a quick flash because the menu and the window
are not faded out in sync.
2. The menu fade out animation had a fixed duration of 150ms,
meaning that even if it starting fading out at the same time
as the PIP window, it would not finish at the same time because
the PIP exit anim duration is longer.

To fix both of them, the X button now hides the menu and starts
dismissing the task at the same time (once), and the dismiss
animation duration is equal to the task fade out animation
duration.

Previous: http://recall/-/e8RgaQ0dFlwFuh0c7GRpyy/g7XMbvBGMyAOKZMuFlYpW0
With CL: http://recall/-/e8RgaQ0dFlwFuh0c7GRpyy/g7XMbvBGMyAOKZMuFlYpW0

Bug: 182727923
Test: Tap X to dismiss PIP, no flashes seen
Change-Id: If9bdda8d0fd8b819c00ec4a592d1b2441d642d00
2021-04-29 17:56:02 -07:00
Mady Mellor
515ee7ab93 Merge "Fix text color for bubble user education screens" into sc-dev am: 8e29f94a89
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14356512

Change-Id: Id9a69bec94e3a237372df6a432a5520ceea4a56c
2021-04-29 23:04:11 +00:00
Ben Lin
12e9afe8f3 Merge "PiP: Take inset into consideration when calculating stash offset." into sc-dev am: 7fc1313d39
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14345460

Change-Id: I464d5459fc5fd8b01ebde0060d6cede0094b515d
2021-04-29 23:03:29 +00:00
Mady Mellor
8e29f94a89 Merge "Fix text color for bubble user education screens" into sc-dev 2021-04-29 23:00:20 +00:00
Ben Lin
7fc1313d39 Merge "PiP: Take inset into consideration when calculating stash offset." into sc-dev 2021-04-29 22:51:26 +00:00
Mady Mellor
8e5f4733ee Restrict the width of bubble expanded view on large screens
* Width is restricted via padding applied to the view when the device
  is considered large screen
* Adjusted animation code so bubbles slide in from edges when showing
  vertically
* Overflow uses max height available when on a large screen
* Fixed a bug where overflow height wasn't being updated correctly
  since it's no longer using an activity
* Fixed a bug where when the view was expanded & you rotated its
  position could be off

Test: manual - expand bubble on large screen from left / right edges
               in landscape & portrait
            => bubbles should be anchored to edge they are opened from
               & positioned vertically along the edge
             - expand bubble on phone in portrait
            => bubbles should be anchored to the top edge &
               horizontally
             - expand bubble on phone in landscape, check overflow
            => bubbles should be anchored to the edge they are opened
               from & positioned vertically along the edge, the
               overflow should have a restricted width
Bug: 175211639

Change-Id: I7c3f3024260a08ebdf4c6e7c7724e51fbc480f61
2021-04-29 15:24:49 -07:00
Mady Mellor
435ab536c2 Fix text color for bubble user education screens
Test: manual - look at user education screens for the bubble stack and
               manage button in light & dark theme and make sure the
               text is as expected
Bug: 183238079
Change-Id: Ia83b2e849f46c3e3eb055ff263a0171f4ad62288
2021-04-29 12:57:07 -07:00
Chris Li
90d3da5260 Merge "Move legacy split screen flicker tests for non-resizable to presubmit" into sc-dev am: f9c4ee1fd3
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14117547

Change-Id: I66cfd066ff59165d2b1693d8394a64e6c2ff0571
2021-04-29 17:51:01 +00:00
Chris Li
f9c4ee1fd3 Merge "Move legacy split screen flicker tests for non-resizable to presubmit" into sc-dev 2021-04-29 17:49:15 +00:00
Nataniel Borges
5f8d88059f Merge "Fix pip window visibility assertions" into sc-dev am: 8a26f00f1f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14327906

Change-Id: I340e84e0598d9106014411499413584f22d50ebf
2021-04-29 15:57:21 +00:00
Nataniel Borges
8a26f00f1f Merge "Fix pip window visibility assertions" into sc-dev 2021-04-29 15:51:59 +00:00
TreeHugger Robot
efa8819afa Merge "Disable flaky app pair assertions" into sc-dev am: c8a0871269
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14325416

Change-Id: Ibd9419dfac9cc7be99874b2d9c0c950a3a6b1f2f
2021-04-29 15:20:44 +00:00
TreeHugger Robot
c8a0871269 Merge "Disable flaky app pair assertions" into sc-dev 2021-04-29 15:18:23 +00:00
Nataniel Borges
4b2f1da126 Fix pip window visibility assertions
1) Fix `Could not find: PipApp`, the test previously used the launcher name, instead of the window name for assertion

2) The command previously missed a `verify` call to actually execute the assertion

Bug: 186115871
Bug: 186445782
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Ie9274e273bcda2be24491705cd28d7dc0d5ea5db
2021-04-29 12:02:31 +02:00