Commit Graph

5460 Commits

Author SHA1 Message Date
TreeHugger Robot
b1fe173f1f Merge "Fix AugmentedAutofillService onFillRequest() wrong focused AutofillId for WebView" into rvc-dev am: cc4f13e0ab
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/11700779

Change-Id: If21669fc2a76cfee6bbf7c875ad23a913328801e
2020-06-02 21:11:06 +00:00
Joanne Chung
fbc89efee3 Fix AugmentedAutofillService onFillRequest() wrong focused AutofillId for WebView
When AutofillManagerService try to trigger AugmentedAutofill, it uses
AutofillId.withoutSession() to get the AutollId without session. It
will return invalid "parentId:NO_ID" if the virtual AutofillId is
created with FLAG_IS_VIRTUAL_INT. The virtual AutofillId flag should
be FLAG_IS_VIRTUAL_INT or FLAG_IS_VIRTUAL_LONG, we should get
mVirtualIntId for FLAG_IS_VIRTUAL_INT or mVirtualLongId for
FLAG_IS_VIRTUAL_LONG.

Bug: 156408900
Test: atest android.autofillservice.cts.augmented
Test: atest android.view.autofill.AutofillIdTest#\
testVirtual_Long_withoutSession
Test: atest android.view.autofill.AutofillIdTest#\
testVirtual_Int_withoutSession
Test: Manual. Write a simple cts test for webview and check the
focused AutofillId is correct while switching between the field.

Change-Id: I7ebb4d7cfb6d6f383724b798dae69269ae3a27be
2020-06-03 01:06:24 +08:00
Charles Chen
c1ee356ca6 Merge "Fix get display from display context derived context not working" into rvc-dev am: 13e3568567
Change-Id: Ibdb1cea64d43db5b54b5905ee544b6e374fe60ff
2020-05-30 06:51:42 +00:00
Charles Chen
13e3568567 Merge "Fix get display from display context derived context not working" into rvc-dev 2020-05-30 06:35:35 +00:00
Charles Chen
e22c4cb3c6 Fix get display from display context derived context not working
In ContextImpl, we checked the flag "mIsAssociatedWithDisplay" to
identify if a context can access a display or not. The flag wasn't
passed from outer context, and it leads to an issue that context
which created from #createConfigurationContext from display context
failed to obtain display instance.

This CL passes mIsAssociatedWithDisplay from outer context and
also add test to verify the behavior.

fixes: 157719118
Test: atest ContextTest ContextAccessTest

Change-Id: Ibeb2a08c75f90304e12dcf99293c84409c5eea34
2020-05-30 12:46:59 +08:00
Narayan Kamath
cc9f819283 Merge "Revert ResolverActivity changes associated with browseables." into rvc-dev am: 101fcc5746
Change-Id: I3cd05030567145ae5528db56a3b4d73faa4fb814
2020-05-28 11:30:32 +00:00
Narayan Kamath
101fcc5746 Merge "Revert ResolverActivity changes associated with browseables." into rvc-dev 2020-05-28 10:35:09 +00:00
Heemin Seog
164713ecfe Merge "Add climate bar insets" into rvc-dev am: 58169786a6
Change-Id: Iea5d4299f49aa5d886c5482a5916d80ef8596eba
2020-05-27 15:49:24 +00:00
Heemin Seog
58169786a6 Merge "Add climate bar insets" into rvc-dev 2020-05-27 15:38:32 +00:00
Narayan Kamath
754186806d Revert ResolverActivity changes associated with browseables.
Reverts changes 69df963, 0c7c5d59, 6cbef19 and others. These changes
don't revert cleanly because of several refactorings layered on top
of the original changes.

The main objective of these change is to get rid of mUseLayoutForBrowseable
and associated codepaths as we treat choosing between browseables the
same as other choices.

Bug: 157460946
Test: manual
Test: atest ResolverActivityTest
Test: atest ChooserActivityTest

Change-Id: Ibe9f2289289f7f5da3986e6892a2ee4ff65765a0
2020-05-27 12:48:15 +01:00
Heemin Seog
d79e4f49d2 Add climate bar insets
This can be used to support a 3rd kind of system bar to inset the
applicaiton space.

Bug: 152763889
Test: manual
Change-Id: I3ba75886e94a9fe80a0d1a920749d152dda64031
2020-05-26 14:26:25 -07:00
Michael Groover
3cdc8fbdb2 Merge "Address edge cases for signing certificate lineages in sharedUids" into rvc-dev am: 2046776127
Change-Id: If65b24c62ca4ae868d15bbf30aff5f5bbc4b235f
2020-05-26 16:11:10 +00:00
Michael Groover
2046776127 Merge "Address edge cases for signing certificate lineages in sharedUids" into rvc-dev 2020-05-26 16:07:57 +00:00
Michael Groover
f1744af7ed Address edge cases for signing certificate lineages in sharedUids
Currently when a package is installed / updated in a sharedUid the
signatures for the sharedUid are not updated unless the new package
adds a new signer to the lineage; in this case the new lineage is
assigned to the sharedUid without consideration for the existing
lineage. This leads to the following problems:

1. If the current sharedUid lineage is A -> B and the new package has
lineage B -> C then this is used for the sharedUid and A is lost from
the lineage.
2. If the new lineage revokes one or more capabilities from a previous
signer in the lineage these updated capabilities are ignored unless the
lineage added a new signer as well.
3. If the new lineage revokes the sharedUid capability from a previous
signing key in the lineage and another app is installed as part of the
sharedUid and signed with that key the new app's installation is allowed
to proceed.
4. If only a single app is installed as part of a sharedUid, and that
app is updated with a rotated key and a lineage that revokes the
previous signing key's sharedUid capability the update is blocked.
5. If an app is installed as part of the sharedUid and has a diverged
signer in the lineage (ie sharedUid lineage is Y -> A -> B and new app
lineage is Z -> A -> B -> C) the installation is allowed and Y is lost
from the lineage.

Problems 1 and 2 are addressed with the new SigningDetails
mergeLineageWith method that merges common signers between two lineages
and also updates their capabilities to the most restrictive between
the two lineages (capabilities are anded together). Problems 3 is
addressed by checking the signatures of each of the packages in the
sharedUid for any signed with an ancestor for which the sharedUid
capability may have been revoked. Problem 4 is addressed by checking
if the package being updated is the only one in the sharedUid; if so
the update to the new lineage is allowed to proceed. Problem 5 is
addressed by verifying the new app's lineage is the same, a subset, or
a superset of the other.

Bug: 152046935
Test: atest PkgInstallSignatureVerificationTest
Test: atest SigningDetailsTest
Test: atest PackageManagerTests
Test: atest PackageManagerTest
Change-Id: I420c309f522bb47b65ca40ee848024c85cd5804d
2020-05-22 23:50:52 +00:00
Collin Fijalkovich
aa1c667e4f Merge changes from topic "dump-cacheinfo" into rvc-dev am: acb2bba925
Change-Id: Iec363450741936bc3d8ec0f99c597fb5373b5b9c
2020-05-18 23:56:28 +00:00
Darryl Johnson
f7f71df05c Merge "Make sure config change items are executed in the order dispatched." into rvc-dev am: 0d8822c94a
Change-Id: I2317fc9f603255b092f56253f7aaa3e277b69b14
2020-05-18 23:39:03 +00:00
Collin Fijalkovich
acb2bba925 Merge changes from topic "dump-cacheinfo" into rvc-dev
* changes:
  Add cache debugging information to bugreports.
  Maintain global list of caches; purge on low memory
2020-05-18 20:52:43 +00:00
Darryl Johnson
0d8822c94a Merge "Make sure config change items are executed in the order dispatched." into rvc-dev 2020-05-18 17:26:14 +00:00
TreeHugger Robot
37334ce7d4 Merge "De-duplicate with callerTargets(added by using Intent.EXTRA_INITIAL_INTENTS) when adding DisplayResolveInfo." into rvc-dev am: e79c1056b2
Change-Id: I65562306c089dfedc3d06ae147f4f619fdd69ab5
2020-05-15 23:26:16 +00:00
TreeHugger Robot
e79c1056b2 Merge "De-duplicate with callerTargets(added by using Intent.EXTRA_INITIAL_INTENTS) when adding DisplayResolveInfo." into rvc-dev 2020-05-15 23:10:41 +00:00
Joshua Duong
c28d70db77 Merge "Don't attach PendingIntent if settings app is hidden." into rvc-dev am: 8ba3431761
Change-Id: Ib618a2537340cd1e9683387ff6377c282b5ace7a
2020-05-15 21:15:21 +00:00
Joshua Duong
8ba3431761 Merge "Don't attach PendingIntent if settings app is hidden." into rvc-dev 2020-05-15 21:14:39 +00:00
TreeHugger Robot
b06daeb545 Merge "Sharesheet - Fix app stacking" into rvc-dev am: 8714e7d195
Change-Id: I459d1a499ed6301f727623addfc41eb6e9dc6d81
2020-05-15 20:15:23 +00:00
TreeHugger Robot
8714e7d195 Merge "Sharesheet - Fix app stacking" into rvc-dev 2020-05-15 20:13:47 +00:00
Joshua Duong
b381dfaf18 Don't attach PendingIntent if settings app is hidden.
The settings app may not be available. In that case, just show the adb
notification without a PendingIntent.

Bug: 156453114

Test: atest AdbNotificationsTest
Test: With USB debugging enabled, install TestDPC, and use it to hide settings app.
Unplug and replug USB. USB debugging notification shows up and clicking
it does nothing.
Change-Id: Ie29d2c425c05bce9371600d76e4eb2eaba692fd7

Change-Id: Ie5f746cbc7b8a32fc280177bf281a9e973c8df12
2020-05-15 18:58:33 +00:00
Song Hu
276e384e4c De-duplicate with callerTargets(added by using Intent.EXTRA_INITIAL_INTENTS) when adding DisplayResolveInfo.
Bug: 154611479
Test: atest CtsSharesheetTestCases:android.sharesheet.cts.CtsSharesheetDeviceTest
Change-Id: I812c8275fc6f12ad52f56419eedd0c580530704a
2020-05-15 10:01:52 -07:00
Darryl L Johnson
2b9720c694 Make sure config change items are executed in the order dispatched.
In the previous implementation a batch of process/activity config
changes would effectively be executed out of order. When the server
would dispatch changes in config in quick succession the config change
items would update the pending configs first through the preexecute()
calls and then apply the activity config before the process config
is applied even though the process config was dispatched before the activity
config change item. See b/148639784 for more detail.

Fixes: 148639784

Test: ActivityThreadTest#testHandleActivityConfigurationChanged_EnsureUpdatesProcessedInOrder
Test: ActivityThreadTest#testHandleActivityConfigurationChanged_SkipWhenNewerConfigurationPending

Change-Id: I3c926076ac8dba73eb0471c7bc91313df519cf92
2020-05-15 09:40:30 -07:00
Tiger Huang
4f6a9e78cc Merge "Do not dispatch system UI visibility during traversal" into rvc-dev am: 8fd8a538b8
Change-Id: Ief24436d5c61577546d2b99341945d4bdd39ceb9
2020-05-14 17:27:13 +00:00
Tiger Huang
8fd8a538b8 Merge "Do not dispatch system UI visibility during traversal" into rvc-dev 2020-05-14 17:25:56 +00:00
Matt Pietal
c9544a7e92 Sharesheet - Fix app stacking
When there was greater than 2 candidates for app stacking, the prior
targets would get dropped.

Bug: 156220800
Test: atest ChooserActivityTest
Change-Id: Ia8494bb81e95c5415d080148a0c4f98bd243c142
2020-05-13 21:19:40 -04:00
Collin Fijalkovich
ceefcec397 Add cache debugging information to bugreports.
Following the model for dumpsys gfxinfo, this patchset adds a
CacheBinder service that dumps cache state information from each
process.

Bug: 153661880
Test: adb shell dumpsys cacheinfo
Test: adb bugreport

Change-Id: Ie7cce70e56777a200e3e3e92ab895126b6f29032
2020-05-13 11:15:22 -07:00
Tiger Huang
bb7f4caf03 Merge "Remove more dead tests of legacy insets mode" into rvc-dev am: 47936d5e9c
Change-Id: I9e2ddcad004188600ff3c3062dc18f668dd3c9f6
2020-05-13 12:04:51 +00:00
Tiger Huang
47936d5e9c Merge "Remove more dead tests of legacy insets mode" into rvc-dev 2020-05-13 11:52:39 +00:00
Tiger Huang
1da312dcab Remove more dead tests of legacy insets mode
This CL also removes the assumptions about the new insets mode, because
we are always in the new insets mode now.

Fix: 156311082
Test: atest ViewRootImplTest DisplayPolicyLayoutTests WindowStateTests
Change-Id: I9f6f8824ae364b9cd95f6715dd761026d602c095
2020-05-13 16:50:55 +08:00
TreeHugger Robot
1e3fe956cf Merge "Add OWNERS for display, haptics, input and power" into rvc-dev am: f30c225fcb
Change-Id: Iac20c61dfc4d0b79e6773a8d2a10cf7221e95df5
2020-05-12 20:44:05 +00:00
Menghan Li
87c54e0c32 Merge "Refines volume key shortcut confirm dialog strings" into rvc-dev am: 084b2de544
Change-Id: I0a00bf27358ae5b8bbbfbb2101b467121579783b
2020-05-12 20:28:23 +00:00
Riddle Hsu
5cedc6708b Merge changes from topic "b147213487" into rvc-dev am: 8e726a2ef7
Change-Id: Iab5e4ec34dcddc9996ac953e8579e07fef54fc1b
2020-05-12 20:24:34 +00:00
TreeHugger Robot
f30c225fcb Merge "Add OWNERS for display, haptics, input and power" into rvc-dev 2020-05-12 20:17:39 +00:00
TreeHugger Robot
436e2e0c25 Merge "Add tests to verify UsageStats persistence." into rvc-dev am: 564efe2286
Change-Id: I4a7c4d5d5305abfc6c3e6dc7de11db691854f8dd
2020-05-12 20:15:27 +00:00
Antoan Angelov
7cd859b189 Merge "Don't show layout with default if in tabbed view" into rvc-dev am: ff779f6d8e
Change-Id: I13fc4dea8dedce2f5af63094806a7f5d1c966d69
2020-05-12 19:48:19 +00:00
Charles Chen
aa1b447e69 Merge "Add WindowMetricsHelper" into rvc-dev am: 5681f3e796
Change-Id: I6bf39437b330e533008296e503313d1bf7cf03b0
2020-05-12 19:43:58 +00:00
Michael Wright
2e7e81c950 Add OWNERS for display, haptics, input and power
Bug: 156349083
Test: N/A
Change-Id: Ia8afccfc2e470095ae3d52c827c0ac78b7c120ae
2020-05-12 19:11:13 +01:00
Menghan Li
084b2de544 Merge "Refines volume key shortcut confirm dialog strings" into rvc-dev 2020-05-12 16:10:51 +00:00
menghanli
3cba1dc1c5 Refines volume key shortcut confirm dialog strings
- Provide more clear content for single and multiple services are
enabled.
- Avoid non-a11y users accidentally turning shortcut on without
reading this carefully. Hence we put "don't turn on" as the
primary action.

Bug: 155249323
Bug: 138582063
Test: atest AccessibilityShortcutControllerTest
Change-Id: I1c391bb0516bcebfbf6161b94cc0c0b80e0bb72f
2020-05-12 16:05:50 +00:00
Riddle Hsu
8e726a2ef7 Merge changes from topic "b147213487" into rvc-dev
* changes:
  Send fixed rotation adjustments to the associated client
  Add support to override display adjustments by token
  Add fixed rotation display adjustments
2020-05-12 09:05:17 +00:00
Varun Shah
c95e54ef4d Add tests to verify UsageStats persistence.
These new tests verify that all fields defined in UsageStats,
UsageEvents.Event and IntervalStats are known fields. This is to ensure
that when new fields are added to these objects or a refactoring is
done, the fields are accounted for when persisting usage stats.

Bug: 155935953
Test: atest UsageStatsPersistenceTest
Test: atest IntervalStatsTest
Change-Id: Ice65391d0af08b64db4ccaa046e57d9fca299319
2020-05-11 22:12:50 -07:00
Antoan Angelov
ff779f6d8e Merge "Don't show layout with default if in tabbed view" into rvc-dev 2020-05-11 14:49:18 +00:00
Riddle Hsu
d490c57905 Send fixed rotation adjustments to the associated client
So the real information of display can be adjusted according
to the adjustments for the application started with fixed
rotation transform.

The enabling adjustments may be sent in different ways:
- Launch activity
  The information is bundled with LaunchActivityItem.
- Resume activity or update non-activity window
  Send a standalone FixedRotationAdjustmentsItem.

The disabling adjustments (null) are always sent by
FixedRotationAdjustmentsItem.

Bug: 147213487
Test: AppConfigurationTests#testRotatedInfoWithFixedRotationTransform
      TransactionParcelTests#testFixedRotationAdjustments

Change-Id: I5238888a5c8352db83fc12749f4de2bfabf46026
2020-05-11 22:17:03 +08:00
Michael Groover
668dba41b3 Merge "Update PM#checkSignatures by uid to support pre-key rotation behavior" into rvc-dev am: 3369bbd82a
Change-Id: Ief40fa1a56975b79f6bc6bce10cc226cd3b4033c
2020-05-11 12:43:44 +00:00
Charles Chen
5681f3e796 Merge "Add WindowMetricsHelper" into rvc-dev 2020-05-11 10:17:37 +00:00