Commit Graph

29167 Commits

Author SHA1 Message Date
TreeHugger Robot
9014e3c937 Merge "Always use Context.getSystemService() to get IMM in SysUI" 2018-09-20 16:35:26 +00:00
Lucas Dupin
a45a4aecb6 Merge "What a horrible fix" 2018-09-20 16:30:48 +00:00
Lucas Dupin
838337d0d0 Merge "Hide bouncer after unlocking SIM card" 2018-09-20 16:15:52 +00:00
Fabian Kozynski
bf954233c6 Merge "Refactor PagedTileLayout to not overflow screen" 2018-09-20 14:33:55 +00:00
Fabian Kozynski
712ae39210 Refactor PagedTileLayout to not overflow screen
PagedTileLayout respects MeasureSpec mode for height to decide on how many
rows to show. TilePage and PagedTileLayout only show as many rows as
they can up to the height of the screen. TileLayout can calculate the
maximum number of rows given a height limit.

Fixes: 113082314
Test: Visual, atest

Change-Id: I2860d71c9aeb2a8ac62fcdbc71a3041a91605bcb
2018-09-20 09:01:53 -04:00
TreeHugger Robot
eebeb08881 Merge "SecurityControllorImpl: Log whole exception" 2018-09-20 10:51:19 +00:00
Yohei Yukawa
35887743a7 Always use Context.getSystemService() to get IMM in SysUI
This is a mechanical refactoring, which should have no observable
behavior difference at this moment.

We need this refactoring because InputMethodManager#getInstance() does
not work well on multi-display scenarios.

Bug: 115891476
Test: Manually made sure that IME still works on inline-reply
Change-Id: I266c17187c7faab4d436e19a4db7595cab4244ac
2018-09-19 19:12:02 -07:00
Tracy Zhou
8b4bb8664e Update Quickstep Onboarding tips to use theme color so that it works in both light and dark theme.
Test: manual
Change-Id: I027887fe853d41be689431f0e893e661b9a0c6e5
Fixes:115928014
2018-09-19 23:13:48 +00:00
Lucas Dupin
f0a67e378d What a horrible fix
setKeyguardFadingAway will only be called again with false when
the scrim animation is over. This means that if AM takes to long
to start the animation, something else might have already tried
to fade out the scrim because the device woke up or changed state.

Change-Id: I46f87a4e72f8a8408365c2852df9d2c58d53fd9a
Fixes: 115332000
Test: unlock with PIP and breakpoints
2018-09-19 15:23:54 -07:00
Evan Laird
d5180a5ec2 Merge "Fix notifications showing on keyguard" 2018-09-19 20:28:51 +00:00
Tobias Thierer
23957aa974 Move ShadeViewRefactor to right package to fix build breakage.
ShadeViewRefactor's package java.lang.annotation was inconsistent
with its source directory; further, it broke taimen-userdebug-jdk9
because java.lang.annotation is a core library package and it's
no longer supported for framework to have code in such packages.

This CL fixes compilation by moving the annotation to the correct
package which corresponds to its source directory.

Test: make SystemUI-core
Bug: 115604102

Change-Id: I600e57da316f60855d71f69b1aa1939f2081d513
2018-09-19 13:56:38 +01:00
TreeHugger Robot
bc0e47c0c5 Merge "Unregister wallpaper visibility listener when nav bar view is destroyed" 2018-09-19 00:35:23 +00:00
TreeHugger Robot
500420ce55 Merge "Fixes tapping home button on right edge with quickstep layout" 2018-09-18 23:49:32 +00:00
TreeHugger Robot
a01a180991 Merge "Added setprop to go back after gesture end" 2018-09-18 23:19:12 +00:00
TreeHugger Robot
4648bd2527 Merge "Fix broken NSSL tests" 2018-09-18 22:44:27 +00:00
TreeHugger Robot
d71c238a67 Merge "Reload theme before dispatching UiMode event" 2018-09-18 22:37:18 +00:00
Winson Chung
b03d44d9d3 Unregister wallpaper visibility listener when nav bar view is destroyed
- The wallpaper visibility listener is only registered but never
  unregistered, and the RemoteCallbackList isn't enough to manage this
  since all instances belong to the same instance of the SysUI process.

Fixes: 79181718
Test: Change configuration to recreate the nav bar and ensure the old
      nav bar transition wallpaper visibility listener is unregistered
      first

Change-Id: I08e1600a016f1ddff51fc2f67eb4ddced42963b6
2018-09-18 15:29:36 -07:00
Matthew Ng
a099cc8bb1 Fixes tapping home button on right edge with quickstep layout
Reverted ag/4731597 since it was causing issue and instead hides the
menu container when none of its children are visible.

Change-Id: Ie48ef32f8a66392796cb0330faed6dff499bc1b1
Fixes: 114099654
Test: tap around the right edge
2018-09-18 14:54:07 -07:00
Evan Laird
91d0f10a36 Fix notifications showing on keyguard
The root cause here is that some components
(NotificationKeyguardUserManager, NotificationStackScrollLayout,
NotificationShelf) have subtle dependencies about how they update based
on StatusBarState which used to be satisfied. When we migrated to
StatusBarStateController the dependencies were broken sometimes.

The fix here is multifactorial:
    1. Introduce a ranking to StatusBarStateController listeners so that
    we can unwind the dependencies for now. (This should be fixed
    long-term)

    2. Move NSSL's actual notification updating to a new
    onStatePostChange() method of the listeners

    3. Explicitly call updatePublicMode() when hiding the
    keyguard because SbStateController does not give callbacks when
    setting a state to the same value.

Will move updatePublicMode into NotificationKeyguardUserManager in a
later commit to reduce the surface area here.

Bug: 115739177
Change-Id: I97786619a1843922aeedcdb51e067a7c46cacaec
Fixes: 114297820
Test: manual
2018-09-18 17:45:28 -04:00
Evan Laird
fec7766594 Fix broken NSSL tests
I don't see a reason why we would constrain mBarState.addListener to
happen only once, because the whole point is that other classes listen
to those changes as well, and will subscribe unless we mock literally
everything.

Change-Id: Id6aed68c48fbc4f94f78fcd38b9fe0ec83d49c7e
Fixes: 115742174
Test: `atest NotificationStackScrollLayoutTest`
2018-09-18 17:28:08 -04:00
TreeHugger Robot
2c0c642a64 Merge "Removing support for interporcess event from EventBus" 2018-09-18 20:50:24 +00:00
Lucas Dupin
fae63a28c5 Reload theme before dispatching UiMode event
Test: manual
Change-Id: I0f2fc6095f706a5a3af66bf50d41b73cb8c97471
Fixes: 115649718
Fixes: 115394753
Fixes: 115992148
Fixes: 115781667
2018-09-18 18:01:11 +00:00
TreeHugger Robot
d9830db6d1 Merge "Defer theme flags when view isn't attached" 2018-09-18 02:38:01 +00:00
Lucas Dupin
6d48eabe6b Hide bouncer after unlocking SIM card
We don't want to hide the bouncer when the SIM card is READY,
unless we were already at the bouncer because of the SIM PIN/PUK

Test: Insert locked SIM card on lock screen or launcher. Type PIN
Test: Insert unlocked SIM card after pulling up the bouncer
Fixes: 114740965
Change-Id: I4f781b47c1e2a12e5c6f064f303cd457ece01b67
2018-09-17 17:19:36 -07:00
Lucas Dupin
fdbfc545d4 Defer theme flags when view isn't attached
Change-Id: Ie042da18b8c84d9067bb4d951f9dd35fe4ea9d19
Fixes: 113530582
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarWindowControllerTest.java
2018-09-17 16:06:16 -07:00
Yuanjia Hsu
c8c132959a Merge "resolve merge conflicts of 2cb9a70cac to master" 2018-09-17 21:35:22 +00:00
Amin Shaikh
53bc083f27 Fix rare SystemUI QS crash.
Change-Id: I7581bbedbfecebf35f2f9986cae8c16000c9801a
Fixes: 112645457
Test: manual
2018-09-17 15:06:18 -04:00
yuanjiahsu
8eb9d4711b resolve merge conflicts of 2cb9a70cac to master
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: Ic1db72d57f3003bcec0fd8f7fbb2dc4ec7b5dcf3
2018-09-17 23:46:14 +08:00
Yuanjia Hsu
2cb9a70cac Merge "Add feature flag in Settings." am: 55b91f6d93
am: b04fcd5842

Change-Id: I22e073bcbe7c2bacfdce44dd4c05b47fab3059f1
2018-09-17 07:25:33 -07:00
Yuanjia Hsu
b04fcd5842 Merge "Add feature flag in Settings."
am: 55b91f6d93

Change-Id: I27aa24563358fe4467de3aa3660825f1d8bd73d5
2018-09-17 07:09:28 -07:00
Yuanjia Hsu
55b91f6d93 Merge "Add feature flag in Settings." 2018-09-17 13:43:08 +00:00
Shaotang Li
2f5d2a50a8 Merge "Add extra data when starting emergency dialer intent" am: 0b925f85c0
am: e6ce88ca3c

Change-Id: Id27700b585ddafbf20ebdbd14cd92b3f3cf75cd3
2018-09-16 22:35:42 -07:00
Shaotang Li
e6ce88ca3c Merge "Add extra data when starting emergency dialer intent"
am: 0b925f85c0

Change-Id: I9dc0b8711534c1dcdc5715a888a87fb4730f5061
2018-09-16 22:27:03 -07:00
Shaotang Li
0b925f85c0 Merge "Add extra data when starting emergency dialer intent" 2018-09-17 04:14:51 +00:00
Lucas Dupin
7c6ca76793 Allow protected broadcasts in tests
SysUI must send protected broadcasts to avoid system impersonation.
Our tests should also allow these types of broadcasts, otherwise
they will be dropped/skipped on -user builds and functionality
will be broken.

This CL also protects the flashlight broadcast.

Fixes: 110825884
Test: atest com.android.systemui.qs.external.TileServicesTest
Change-Id: I5a3dfc569c1695366e5f0e48cda8a7a32e287e7d
2018-09-14 17:18:54 +00:00
TreeHugger Robot
033f4b9506 Merge "Revert "Revert "Add null check for vrManager""" 2018-09-14 13:37:19 +00:00
TreeHugger Robot
757fc77053 Merge "Reset soft AP state when tethering fails from QS." 2018-09-14 02:18:38 +00:00
Kevin Han
d4092c1897 Merge "Add NotificationGroupManagerTest" 2018-09-14 01:16:36 +00:00
Evan Laird
4418fe2c3d Merge "Leave spaces between Operator name and Clock in StatusBar" am: 375af769e6 am: 3832515acf
am: e06b199457

Change-Id: Ic6fcd200364780b66d29b4d502f0c7c70f2af48a
2018-09-13 13:11:44 -07:00
Evan Laird
e06b199457 Merge "Leave spaces between Operator name and Clock in StatusBar" am: 375af769e6
am: 3832515acf

Change-Id: I80224e5a1cfa6433255d737f8943e4ce35932a53
2018-09-13 12:51:29 -07:00
Evan Laird
3832515acf Merge "Leave spaces between Operator name and Clock in StatusBar"
am: 375af769e6

Change-Id: If2c314f7dc98ffe4d461c90263503e66f72ada48
2018-09-13 12:24:02 -07:00
Amin Shaikh
90eeecc3a1 Reset soft AP state when tethering fails from QS.
Change-Id: I5584178240251eac0d139c3d696cc50f8e9da061
Fixes: 115615686
Test: manual
2018-09-13 11:01:46 -04:00
Shigeki Yokomichi
52a11bbe15 Leave spaces between Operator name and Clock in StatusBar
In StatusBar, there are no spaces between Operator name and Clock,
so leaving spaces to improve design.

Bug: 114133664
Test: Manual, enable operator name in status row
config_showOperatorNameInStatusBar, insert sim card with operator name,
watch status row.

Change-Id: I1a2e33436ed50d429ae4b1769d0a72d501233a22
2018-09-13 11:39:30 +00:00
Lucas Dupin
a354763925 Merge "Pitch black SysUI theme" 2018-09-12 23:05:05 +00:00
TreeHugger Robot
aa9e1bc1c4 Merge "Migrate off deprecated supplemental icon method." 2018-09-12 16:18:40 +00:00
Rick Yiu
483befe0b7 Revert "Revert "Add null check for vrManager""
This reverts commit 122d844516.

Bug: 112064298
Change-Id: Id38ab76ed100358adc03d189373432c03471bcaf
2018-09-12 11:08:19 +00:00
Kevin
96eed64a09 Add NotificationGroupManagerTest
Add some unit tests for NotificationGroupManager testing some basic
functionality and also some of the complex heads up logic.

Bug: 79705024
Test: runtest systemui

Change-Id: I73f01827063d2704a4e1b1d18d479d4e9375447e
2018-09-11 15:49:27 -07:00
Anthony Chen
df94129e3a Migrate off deprecated supplemental icon method.
Bug: 115399985
Test: m -j SystemUI
Change-Id: Ib5da79eb7bb9e5c8573985cc34cbf988bd8aca63
2018-09-11 22:38:37 +00:00
Lucas Dupin
d26faccd0c Pitch black SysUI theme
Test: visual
Bug: 110758454
Change-Id: Id673133763e5624f380facf008ecc4c78092fe13
2018-09-11 15:24:22 -07:00
Ying Zheng
4fd6b783e3 Migrate sysUI and carSysUI to the separated car user lib.
Bug: 113868873
Test: build
Change-Id: I48fb69aab7092d256c6839377c905340f9059165
2018-09-11 13:51:49 -07:00